squakez commented on PR #4797: URL: https://github.com/apache/camel-k/pull/4797#issuecomment-1754849876
> > I am thinking of what side effect it brings now that the Kamelet is not treated as a source anymore. Obviously the code parsing for dependencies is now skipped for Kamelets, but are there any other side effects of this? > > Yes, this is a valid point, thanks. I overlooked this part as we miss any test validating such feature. We need, at least, to parse the inner logic of kamelets in order to discover "capabilities" of any sort beside dependencies. I'll see how we can include this as well and include a test in order to validate the feature. Parsing is now done in #4812 which supersedes this PR. Basically we maintain the generated source in order to perform any parsing as we used to do, but, we do not mount such sources. We instead create a Kamelet bundle configmap which is mounted under ''/etc/camel/kamelets` and let the runtime to use such Kamelets as it normally does in plain Camel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
