jamesnetherton merged PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
JiriOndrusek commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2630138643
> > > Yes, more generally the question is whether all features mentioned in
the camel documentation are covered with tests ;)
> >
> >
> > That is a valid question, I'
aldettinger commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2627545182
> > Yes, more generally the question is whether all features mentioned in
the camel documentation are covered with tests ;)
>
> That is a valid question, I'm currently add
JiriOndrusek commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2627435752
> Yes, more generally the question is whether all features mentioned in the
camel documentation are covered with tests ;)
That is a valid question, I'm currently adding t
aldettinger commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2627263320
> > Maybe there is need for more coverage like auto reload in other prs.
>
> Do you mean a use case with context reload? it is covered by different
test class, which alrea
JiriOndrusek commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2627020565
failure in saga example seems to be unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
JiriOndrusek commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2626910355
> Maybe there is need for more coverage like auto reload in other prs.
Do you mean a use case with context reload? it is covered by different test
class (see
https://git
JiriOndrusek commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1937036797
##
integration-test-groups/aws2/aws-secrets-manager/src/main/java/org/apache/camel/quarkus/component/aws/secrets/manager/it/AwsSecretsManagerResource.java:
#
JiriOndrusek commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1937036484
##
integration-test-groups/aws2/aws-secrets-manager/src/test/java/org/apache/camel/quarkus/component/aws/secrets/manager/it/AwsSecretsManagerTest.java:
##
@@
aldettinger commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1935825083
##
integration-test-groups/aws2/aws-secrets-manager/src/test/java/org/apache/camel/quarkus/component/aws/secrets/manager/it/AwsSecretsManagerTest.java:
##
@@
aldettinger commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1935821966
##
integration-test-groups/aws2/aws-secrets-manager/src/main/java/org/apache/camel/quarkus/component/aws/secrets/manager/it/AwsSecretsManagerResource.java:
##
JiriOndrusek commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2624554893
I missed some hardcoded aws**2**-*. It is fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
JiriOndrusek commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2624362716
That is my fault, I changed something in aws-test-support, let me fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
JiriOndrusek commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2624349157
> Tests failed:
>
> ```
> java.lang.IllegalArgumentException: Error configuring property:
camel.component.aws-cw.secret-key because cannot find component with name
aw
jamesnetherton commented on PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#issuecomment-2624171944
Tests failed:
```
java.lang.IllegalArgumentException: Error configuring property:
camel.component.aws-cw.secret-key because cannot find component with name
aws-cw.
JiriOndrusek commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1935102976
##
integration-test-groups/aws2/aws-secrets-manager/src/main/resources/application.properties:
##
@@ -21,6 +21,6 @@
camel.component.aws-secrets-manager.acce
JiriOndrusek commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1935101396
##
integration-test-groups/aws2/aws-secrets-manager/src/main/resources/application.properties:
##
@@ -21,6 +21,6 @@
camel.component.aws-secrets-manager.acce
jamesnetherton commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1934142147
##
integration-test-groups/aws2/aws-secrets-manager/src/main/resources/application.properties:
##
@@ -21,6 +21,6 @@
camel.component.aws-secrets-manager.ac
JiriOndrusek opened a new pull request, #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953
fixes https://github.com/apache/camel-quarkus/issues/6673,
https://github.com/apache/camel-quarkus/issues/6952
Aws-secret-manager native profile is added.
Tests are moved into `aws
19 matches
Mail list logo
