JiriOndrusek commented on code in PR #6953:
URL: https://github.com/apache/camel-quarkus/pull/6953#discussion_r1937036484
##########
integration-test-groups/aws2/aws-secrets-manager/src/test/java/org/apache/camel/quarkus/component/aws/secrets/manager/it/AwsSecretsManagerTest.java:
##########
@@ -30,76 +30,98 @@
import org.apache.camel.quarkus.test.mock.backend.MockBackendDisabled;
import org.apache.camel.quarkus.test.mock.backend.MockBackendUtils;
import org.apache.camel.quarkus.test.support.aws2.Aws2TestResource;
+import org.apache.camel.quarkus.test.support.aws2.BaseAWs2TestSupport;
import org.junit.jupiter.api.Test;
import org.testcontainers.shaded.org.awaitility.Awaitility;
import static org.hamcrest.CoreMatchers.is;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.*;
@QuarkusTest
@QuarkusTestResource(Aws2TestResource.class)
-public class AwsSecretsManagerTest extends AwsSecretsManagerAbstractTest {
+public class AwsSecretsManagerTest extends BaseAWs2TestSupport {
+
+ public AwsSecretsManagerTest() {
+ super("/aws-secrets-manager");
+ }
@Test
public void testOperations() {
final String secretToCreate = "loadFirst";
final String secret2ToCreate = "changeit2";
final String secretToUpdate = "loadSecond";
- final String nameToCreate = "CQTestSecret" +
System.currentTimeMillis();
- final String name2ToCreate = "CQTestSecret2" +
System.currentTimeMillis();
+ final String nameToCreate = "CQTestSecret-operation-1-" +
System.currentTimeMillis();
+ final String name2ToCreate = "CQTestSecret2-operation-2-" +
System.currentTimeMillis();
+ final String description2ToCreate = "description-" + name2ToCreate;
String createdArn = null;
String createdArn2 = null;
try {
- createdArn = createSecret(nameToCreate, secretToCreate);
+ // >> create secret 1
+ createdArn = AwsSecretsManagerUtil.createSecret(nameToCreate,
secretToCreate);
+ // >> create secret 2 (with description)
assertNotNull(createdArn);
createdArn2 = RestAssured.given()
.contentType(ContentType.JSON)
-
.body(Collections.singletonMap(SecretsManagerConstants.SECRET_NAME,
name2ToCreate))
+ .body(Map.of(SecretsManagerConstants.OPERATION,
SecretsManagerOperations.createSecret,
+ SecretsManagerConstants.SECRET_NAME, name2ToCreate,
+ SecretsManagerConstants.SECRET_DESCRIPTION,
description2ToCreate))
.queryParam("body", secret2ToCreate)
+ .queryParam("useHeaders", true)
.post("/aws-secrets-manager/operation/" +
SecretsManagerOperations.createSecret)
.then()
.statusCode(201)
.extract().asString();
assertNotNull(createdArn);
+ // >> list both secrets
final String finalCreatedArn = createdArn;
final String finalCreatedArn2 = createdArn2;
Awaitility.await().pollInterval(5, TimeUnit.SECONDS).atMost(1,
TimeUnit.MINUTES).untilAsserted(
() -> {
- Map<String, Boolean> secrets = listSecrets();
+ Map<String, Boolean> secrets =
AwsSecretsManagerUtil.listSecrets(null);
// contains both created secrets
assertTrue(secrets.containsKey(finalCreatedArn));
assertTrue(secrets.containsKey(finalCreatedArn2));
});
+ // >> use MAX_RESULTS header
+ Awaitility.await().pollDelay(5, TimeUnit.SECONDS).pollInterval(5,
TimeUnit.SECONDS).atMost(1, TimeUnit.MINUTES)
+ .untilAsserted(
+ () -> {
+ Map<String, Boolean> secrets =
AwsSecretsManagerUtil.listSecrets(1);
+ // contains both created secrets
+ assertTrue(secrets.size() == 1);
+ });
- String secret = RestAssured.given()
+ // >> get secret1 with version_id
+ var secret1recievedMap = RestAssured.given()
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
