Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-22 Thread via GitHub
orpiske commented on PR #12844: URL: https://github.com/apache/camel/pull/12844#issuecomment-1904187555 I tested this manually and it seems OK. Let's merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-22 Thread via GitHub
orpiske merged PR #12844: URL: https://github.com/apache/camel/pull/12844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-20 Thread via GitHub
orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1460299699 ## core/camel-core/src/test/java/org/apache/camel/component/file/strategy/FileChangedReadLockMinAgeTest.java: ## @@ -79,4 +79,4 @@ public void configure() throws Except

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
VaishnaviR18 commented on PR #12844: URL: https://github.com/apache/camel/pull/12844#issuecomment-1900767232 Thanks a lot! @orpiske and @oscerd I have reverted the changes, can you please review it? -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
VaishnaviR18 commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459346299 ## core/camel-core/src/test/java/org/apache/camel/component/file/FileExclusiveReadNoneStrategyTest.java: ## @@ -73,7 +77,7 @@ public void process(Exchange exchange

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
VaishnaviR18 commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459345884 ## core/camel-core/src/test/java/org/apache/camel/component/file/stress/FileAsyncStressReadLockNoneManualManualTest.java: ## @@ -17,15 +17,18 @@ package org.apach

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
VaishnaviR18 commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459345282 ## core/camel-core/src/test/java/org/apache/camel/component/file/stress/FileAsyncStressManuallyManualTest.java: ## @@ -32,6 +31,10 @@ @DisabledOnOs(OS.WINDOWS) p

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
VaishnaviR18 commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459343894 ## core/camel-core/src/test/java/org/apache/camel/component/file/FileBatchConsumerMemoryLeakManualTest.java: ## @@ -64,7 +69,7 @@ public void process(Exchange exch

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
VaishnaviR18 commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459344575 ## core/camel-core/src/test/java/org/apache/camel/component/file/strategy/FileChangedReadLockTest.java: ## @@ -68,7 +72,7 @@ private void writeSlowFile() throws Ex

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459017045 ## core/camel-core/src/test/java/org/apache/camel/component/file/strategy/FileChangedReadLockTest.java: ## @@ -68,7 +72,7 @@ private void writeSlowFile() throws Excepti

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459016044 ## core/camel-core/src/test/java/org/apache/camel/component/file/stress/FileAsyncStressManuallyManualTest.java: ## @@ -32,6 +31,10 @@ @DisabledOnOs(OS.WINDOWS) public

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459015736 ## core/camel-core/src/test/java/org/apache/camel/component/file/stress/FileAsyncStressReadLockLockFileTestManualManualTest.java: ## @@ -17,15 +17,18 @@ package org.ap

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459015408 ## core/camel-core/src/test/java/org/apache/camel/component/file/stress/FileAsyncStressReadLockNoneManualManualTest.java: ## @@ -17,15 +17,18 @@ package org.apache.cam

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459010708 ## core/camel-core/src/test/java/org/apache/camel/component/file/FileBatchConsumerMemoryLeakManualTest.java: ## @@ -64,7 +69,7 @@ public void process(Exchange exchange)

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459014695 ## core/camel-core/src/test/java/org/apache/camel/component/file/stress/FileAsyncStressReadLockRenameManualManualTest.java: ## @@ -17,15 +17,18 @@ package org.apache.c

Re: [PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
github-actions[bot] commented on PR #12844: URL: https://github.com/apache/camel/pull/12844#issuecomment-1900336290 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] CAMEL-19519 - camel-file: replace Thread.sleep in tests. [camel]

2024-01-19 Thread via GitHub
VaishnaviR18 opened a new pull request, #12844: URL: https://github.com/apache/camel/pull/12844 # Description Issue - https://issues.apache.org/jira/browse/CAMEL-19519 # Target - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel