orpiske commented on code in PR #12844: URL: https://github.com/apache/camel/pull/12844#discussion_r1459010708
########## core/camel-core/src/test/java/org/apache/camel/component/file/FileBatchConsumerMemoryLeakManualTest.java: ########## @@ -64,7 +69,7 @@ public void process(Exchange exchange) throws Exception { }); context.start(); - Thread.sleep(30 * 1000L); + latch.await(30, TimeUnit.SECONDS); Review Comment: This is incorrect. There needs to be something to count down the latch. ########## core/camel-core/src/test/java/org/apache/camel/component/file/FileExclusiveReadNoneStrategyTest.java: ########## @@ -73,7 +77,7 @@ public void process(Exchange exchange) throws Exception { try (OutputStream fos = Files.newOutputStream(testFile("slowfile/hello.txt"))) { fos.write("Hello World".getBytes()); for (int i = 0; i < 3; i++) { - Thread.sleep(100); + latch.await(100, TimeUnit.MILLISECONDS); Review Comment: Same note as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org