Re: [PR] [CAMEL-20962] camel-jbang: SpringBoot support in Kubernetes plugin [camel]

2024-07-19 Thread via GitHub
christophd merged PR #14859: URL: https://github.com/apache/camel/pull/14859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.a

Re: [PR] [CAMEL-20962] camel-jbang: SpringBoot support in Kubernetes plugin [camel]

2024-07-18 Thread via GitHub
christophd commented on PR #14859: URL: https://github.com/apache/camel/pull/14859#issuecomment-2235895200 I think `CommandLine.populateCommand()` is fine. I suppose we are using this primarily in tests and it is the way piccoli handles the command arguments so I would prefer to keep it as

Re: [PR] [CAMEL-20962] camel-jbang: SpringBoot support in Kubernetes plugin [camel]

2024-07-17 Thread via GitHub
tdiesler commented on PR #14859: URL: https://github.com/apache/camel/pull/14859#issuecomment-2233667509 Please note, the KubernetesExportTest now uses a combination of cmd line args and direct property access like this ... ``` KubernetesExport command = createCommand(new S

Re: [PR] [CAMEL-20962] camel-jbang: SpringBoot support in Kubernetes plugin [camel]

2024-07-17 Thread via GitHub
tdiesler commented on code in PR #14859: URL: https://github.com/apache/camel/pull/14859#discussion_r1681289660 ## dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesExport.java: ## @@ -195,12 +197,16 @@ publ

Re: [PR] [CAMEL-20962] camel-jbang: SpringBoot support in Kubernetes plugin [camel]

2024-07-17 Thread via GitHub
christophd commented on code in PR #14859: URL: https://github.com/apache/camel/pull/14859#discussion_r1681140543 ## dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesExport.java: ## @@ -195,12 +197,16 @@ pu

[PR] [CAMEL-20962] camel-jbang: SpringBoot support in Kubernetes plugin [camel]

2024-07-17 Thread via GitHub
tdiesler opened a new pull request, #14859: URL: https://github.com/apache/camel/pull/14859 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m