tdiesler commented on PR #14859:
URL: https://github.com/apache/camel/pull/14859#issuecomment-2233667509
Please note, the KubernetesExportTest now uses a combination of cmd line
args and direct property access like this ...
```
KubernetesExport command = createCommand(new String[] {
"classpath:route.yaml" },
"--gav=camel-test:route:1.0.0", "--runtime=" + rt.runtime());
command.traits = new String[] { "container.port=8088",
"container.image-pull-policy=IfNotPresent" };
Assertions.assertEquals(0, command.doCall());
```
these args are then used by ...
```
CommandLine.populateCommand(command, argsLst.toArray(new String[0]));
```
Although I like configuring these cmd objects explicitly, it only works from
subclasses (i.e. a test cannot set properties on ExportBase). There are other
places in the code where these access restrictions (i.e. non public) cause
issues when the k8s plugin calls into csb plugin.
How do you feel about making these cmd properties public? I could get rid of
`CommandLine.populateCommand`, tests could set stuff in the base class and
stuff in the base class could get set before delegating to a cmd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
