[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA added a comment. > --implicit-check-not=vec-extabi maybe better? @jsji had to rename the test file because the filename was tripping the error 😆 but this is better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://review

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76c931ae42cf: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 367525. ZarkoCA retitled this revision from "[PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf" to "[PowerPC] Truncate results for out of range values for vec_cts,vec_ctf". ZarkoCA edited the summary of this revision. ZarkoCA added a commen

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA created this revision. ZarkoCA added reviewers: sfertile, cebowleratibm. ZarkoCA added a project: PowerPC. Herald added subscribers: shchenz, nemanjai. Herald added a reviewer: aaron.ballman. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM but I have a strong preference that `clang/test/Layout/aix-packed-bitfields.c` be committed separately if my understanding is right. Comment at: clang/test/Layout/ai

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358087. ZarkoCA added a comment. - Warning should only apply to members of struct - Re-word warning slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files:

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358261. ZarkoCA added a comment. - Add a warning group for this warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files: clang/include/clang/Basic/DiagnosticG

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358760. ZarkoCA added a comment. - Add more RUN lines to test - change `if` condition to be one line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files: clang/in

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA created this revision. ZarkoCA added reviewers: akyrtzi, rsmith, quinnp. ZarkoCA added a project: clang. Herald added a subscriber: dang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Trying to update some options that don't at least have an inclusive l

[PATCH] D112627: [clang] Inclusive language: change error message to use allowlist

ZarkoCA created this revision. ZarkoCA added reviewers: tuktuk, vitalybuka, MaskRay. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112627 Files: clang/include/cl

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA updated this revision to Diff 382708. ZarkoCA added a comment. - Rename directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112591/new/ https://reviews.llvm.org/D112591 Files: clang/docs/ClangCommandLineReference.rst clang/include/

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA added a comment. In D112591#3090710 , @akyrtzi wrote: > Do you intend to rename `clang/test/ARCMT/whitelisted` directory as a > follow-up? Otherwise LGTM. Missed this initially, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA created this revision. ZarkoCA added reviewers: zaks.anna, jkorous, george.karpenkov, ygribov, Szelethus, quinnp, aaron.ballman. ZarkoCA added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, a.sidorin, baloghadamsoftware. ZarkoCA requested re

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA updated this revision to Diff 383359. ZarkoCA added a comment. - Fix formatting and change variable names to make better grammatical sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112642/new/ https://reviews.llvm.org/D112642 Files:

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA marked 6 inline comments as done. ZarkoCA added a comment. In D112642#3093559 , @aaron.ballman wrote: > Thank you for this! Mostly just bikeshedding on names (allowlist as a verb > sounds weird to me), feel free to take or leave the suggestions.

[PATCH] D112627: [clang] Inclusive language: change error message to use allowlist

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc001775a3afb: [clang] Inclusive language: change error message to use allowlist (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8659b241ae94: [clang][NFC] Inclusive terms: Replace uses of whitelist in… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112642/new/ h

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA created this revision. ZarkoCA added reviewers: rzurob, cebowleratibm, sfertile. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Correct the XLC/C++ version in the warning message to use the information from XL's -qversion

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA updated this revision to Diff 383507. ZarkoCA added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112591/new/ https://reviews.llvm.org/D112591 Files: clang/docs/ClangCommandLineReference.rst clang/include/cl

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383804. ZarkoCA added a comment. - Remove V from version number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files: clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383805. ZarkoCA added a comment. - Remove comma from product name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files: clang/include/clang/Basic/DiagnosticSemaKin

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA created this revision. ZarkoCA added reviewers: thakis, compnerd, rtrieu, gribozavr, kcc. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the error message to use ignorelist, and changed some variable and function n

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

ZarkoCA created this revision. ZarkoCA added reviewers: kcc, samsonov, jkorous, lebedev.ri, pcc, vlad.tsyrklevich. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace filenames, variable names, check prefixes uses of blacklist

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

ZarkoCA added a comment. In D113211#3110171 , @jkorous wrote: > Hi! Thank you for the clean-up :) > > I feel there might be a bit of work still left. While renaming filenames and > function names should be mostly inconsequential renaming command line opt

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

This revision was automatically updated to reflect the committed changes. Closed by commit rGa83a6c22e63a: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path=… (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D112591?vs=383507&id=385099#toc Rep

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7528554f83: [AIX][Clang] Fix XL product name in AIX XL compatibility warning (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA updated this revision to Diff 385478. ZarkoCA retitled this revision from "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist " to "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist". ZarkoCA added a comme

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA updated this revision to Diff 385479. ZarkoCA added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113189/new/ https://reviews.llvm.org/D113189 Files: clang/include/clang/AST/CommentHTMLTags.td clang/include/clang/

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

This revision was automatically updated to reflect the committed changes. Closed by commit rG05f34ffa2169: [clang] Inclusive language: change instances of blacklist/whitelist to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end).

ZarkoCA accepted this revision. ZarkoCA added a comment. It may be better to use `__builtin_va_list` and the like instead of the header inclusion but I don't want to make the test change too onerous if that turns out to be the case. Comment at: clang/test/CodeGen/aix-altivec-

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113433/new/ https://reviews.llvm.org/D113433 _

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, dcoughlin, quinnp. ZarkoCA added a project: clang. Herald added subscribers: dexonsmith, martong. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Rewording of comments to avoid using `sanity t

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

ZarkoCA created this revision. ZarkoCA added reviewers: klimek, akyrtzi, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits. Herald added a project: LLDB. Rename function to more inclusive name. Repository: rG

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

This revision was automatically updated to reflect the committed changes. Closed by commit rG8924ba3bf8c6: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/ (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113

[PATCH] D113505: [NFC][clang] Inclusive language: replace masterPort with mainPort

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113505/new/ https://reviews.llvm.org/D113505 _

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` -> >

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388207. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Reword comments based on suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140192 , @Quuxplusone wrote: > Peanut gallery says: I'd recommend //not// taking this particular patch; it > seems much less "obvious" than the whitelist/inclusionlist type of patch. > Whereas "whitelist" is just a

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388332. ZarkoCA added a comment. - Address review comments - Also rename some variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files: clang/include/clang/A

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 13 inline comments as done. ZarkoCA added a comment. @Quuxplusone Thanks for thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 ___

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. In D114025#3142565 , @aaron.ballman wrote: > In D114025#3141414 , @keryell wrote: > >> In D114025#3140192

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388494. ZarkoCA added a comment. - Add FIXME to comments and fix grammar on one comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files: clang/include/clang/A

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388550. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. - Address latest round of comments - Fix unrelated formatting to stop distracting clang-format linter complaints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but validation

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Thanks @aaron.ballman and @Quuxplusone for the constructive reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e5a0c42bd8: [clang][NFC] Inclusive terms: replace some uses of sanity in clang (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D114025?vs=388550&id=388587#toc Repository: r

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, delesley, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114562 Files: clang/docs/T

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall thanks for having a look, I will clarify the comments with your suggestions. In D114025#3152900 , @tstellar wrote: > @ZarkoCA If you are planning to do a lot of this, it might be good to write a > script (or a clang-t

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA updated this revision to Diff 389737. ZarkoCA added a comment. - Fix description - Remove `three` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114562/new/ https://reviews.llvm.org/D114562 Files: clang/docs/ThreadSafetyAnalysis.rst Ind

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5162b558d8c0: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall These are the proposed changes which address some of your comments. I am planning on waiting for further clarification on some of the others. Comment at: clang/include/clang/Analysis/CFG.h:520 /// to keep receiving compiler warnings when

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5ad6fa279cc: [clang][docs] Inclusive language: remove use of sanity check in option… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3162140 , @rjmccall wrote: > Those all look good, thanks. Committed here Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14742f2a689c: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 252147. ZarkoCA added a comment. Simplified testcases. Added testcases for variadic arguments being passed directly to the stack when all registers are used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 252325. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. Renamed PPC32_SVR4ABIInfo class to PPC32ABIInfo. Fixed test case to use builtins. Changed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 6 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175 namespace { /// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information. class PPC32_SVR4_ABIInfo : public DefaultABIInfo { sf

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 253127. ZarkoCA added a comment. Created PPCAIX32TargetCodeGenInfo class so that initDwarfEHRegSizeTable now returns true on AIX and added a test. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Com

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix32-cc-abi-vaarg.ll:17 +call void @llvm.va_start(i8* nonnull %0) +call void @llvm.va_copy(i8* nonnull %0, i8* nonnull %0) +%argp.cur = load i8*, i8** %arg,

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 253774. ZarkoCA added a comment. Rebased to include byval changes. Fixed name of array. Fixed up test case as per comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 253776. ZarkoCA added a comment. Fixed test cases to use builtins again, set no soft float abi for AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/l

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 4 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( jasonliu

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA planned changes to this revision. ZarkoCA added a comment. Fixing test case issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 ___ cfe-commits mail

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 254193. ZarkoCA added a comment. Fixed test cases that were breaking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: llvm/lib/Target/PowerPC/PPCISelLowering.c

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 4 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10019 + return SetCGInfo( + new PPCAIX32TargetCodeGenInfo(Types, CodeGenOpts.FloatABI == "soft")); return SetCGInfo( jasonliu

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 254214. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Set isSoftFloat to return false for AIX. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/lib/Basic/Targets/PPC.h cl

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 254243. ZarkoCA added a comment. Removed data layout and target triple info from test output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/test/

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile. Herald added subscribers: cfe-commits, kbarton, hiraditya, nemanjai. Herald added a project: clang. This patch adds support for handling of variadic functions for AIX. This includes ensuring that use and consume corr

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

ZarkoCA updated this revision to Diff 250213. ZarkoCA added a comment. Clang formatted the patch and fixed typo in testcase. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: clang/lib/Basic/Targets/P

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

ZarkoCA updated this revision to Diff 250749. ZarkoCA added a comment. - Removed 64BIT support varargs. - Added a fatal error for 64bit varargs on AIX. - Removed 64bit testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://revie

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

ZarkoCA updated this revision to Diff 250772. ZarkoCA added a comment. Removed unrelated changes in aix-cc-abi.ll CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: clang/lib/Basic/Targets/PPC.h clang/lib/CodeGen/TargetInfo.cpp clang/t

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

ZarkoCA planned changes to this revision. ZarkoCA added a comment. I will split this patch up in two. One for changes in clang specific for 32BIT AIX varargs, and a second for changes in llc for 32/64BIT varargs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. ZarkoCA added reviewers: jasonliu, sfertile, cebowleratibm. Herald added a subscriber: wuzish. This patch contains only the FE changes previously found in https://reviews.llvm.o

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 251065. ZarkoCA retitled this revision from "[PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode." to "[PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX". ZarkoCA edited the summary of this revi

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7088 + GPRIndex < NumGPArgRegs; ++GPRIndex) { +unsigned VReg = MF.getRegInfo().getLiveInVirtReg( +IsPPC64 ? GPR_64[GPRInd

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 25. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Fixed testcase breakages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: llvm/lib/T

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 251407. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. Changed comments per suggestions. Added `va_copy` in test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/lib/

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175 namespace { /// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information. class PPC32_SVR4_ABIInfo : public DefaultABIInfo { sf

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 251408. ZarkoCA marked 11 inline comments as done. ZarkoCA added a comment. Addressed code comments, working on adding and fixing tests for further clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/ne

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7076 +static const MCPhysReg GPR_64[] = {PPC::X3, PPC::X4, PPC::X5, PPC::X6, + PPC::X7, PPC::X8, PPC::X9, PPC::X10}; +unsigned const NumGPArgRegs =

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: w2yehia, qiongsiwu1, hubert.reinterpretcast. ZarkoCA added a project: PowerPC. Herald added subscribers: wlei, wenlei. Herald added a project: All. ZarkoCA requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Hera

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a39465d0015: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: qiongsiwu1, w2yehia. Herald added a project: All. ZarkoCA requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D148177 also removed the error for

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG951919e5112c: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHA

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 528492. ZarkoCA marked an inline comment as done. ZarkoCA removed a reviewer: jsji. ZarkoCA added a comment. Rebase and fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/ https://reviews.llvm.o

[PATCH] D118350: [AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, sfertile, cebowleratibm, stevewan, Jake-Egan, aaron.ballman, tmatheson, dnsampaio. ZarkoCA added projects: clang, PowerPC. Herald added subscribers: shchenz, nemanjai. ZarkoCA requested review of this revision. Herald

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 403857. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Fixed formatting - Fixed test case - Check for when Arg is nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404090. ZarkoCA added a comment. Addressing comments: - Change comment before checkArgAlignment() - Add missing RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef ParamName,

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404190. ZarkoCA added a comment. Addressed some of the comments: - Applied code cleanup per suggestions - Used `CharUnits` instead of hard coded values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); +

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404600. ZarkoCA added a comment. - Warning shouldn't apply to functions that have internal linkage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files: clang/incl

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added a comment. In D118350#3282855 , @nemanjai wrote: > Would it make sense (and would it be possible) to check the linkage of the > callee? Presumably calling something like > `static void localfunc(int *)` > with an over-aligned member shouldn

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

ZarkoCA added inline comments. Comment at: clang/test/SemaTemplate/instantiate-attr.cpp:1 // RUN: %clang_cc1 -fsyntax-only -verify %s // expected-no-diagnostics hubert.reinterpretcast wrote: > Add `-Wno-aix-compat` instead? I agree with this, this way AIX still

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 411912. ZarkoCA retitled this revision from "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function" to "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function". Zar

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 412826. ZarkoCA added a comment. - Try to remove deeply nested ifs by using early returns - Fix note so it refers to struct - Add a struct that isn't called byval in test case to make it clearer that warning isn't emitted on every declaration Repository:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 412840. ZarkoCA added a comment. - Remove formatting changes to unrelated code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files: clang/include/clang/Basic/Diag

<    1   2   3   >