ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments.
================ Comment at: llvm/test/CodeGen/PowerPC/aix32-cc-abi-vaarg.ll:17 + call void @llvm.va_start(i8* nonnull %0) + call void @llvm.va_copy(i8* nonnull %0, i8* nonnull %0) + %argp.cur = load i8*, i8** %arg, align 4 ---------------- jasonliu wrote: > I think it would be more clear if we actually have another va_list to copy > instead of just va_copying itself. The same applies to all the places we call > va_copy. > Also it's not very clear to me which part in the check result actually tells > me about the effect of the va_copy though. Those are both good points. I'm rewriting the test and adding comments to the IR/assembly to make it clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
