[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:1 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and Arguemnt order. +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ s/Arguemnt/Argument/ Comment at

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:3 +// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \ +// // RUN: -Wl,-bnocdtors \ +// // RUN: -target powerpc-ibm-aix7.1.0.0 \ formatting, align with the line

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 255321. ZarkoCA added a comment. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/test/CodeG

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 255323. ZarkoCA added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 Files: clang/lib/Basic/Targets/PPC.h clang/lib/CodeGen/TargetInfo.cpp cla

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

ZarkoCA added a comment. @jhibbits is this patch going to be committed soon? I have a patch (https://reviews.llvm.org/D76360) that I will need to rebase once this is in. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73290/new/ https://re

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 + +class PPCAIX32TargetCodeGenInfo : public TargetCodeGenInfo { +public: Xiangling_L wrote: > sfertile wrote: > > Xiangling_L wrote: > > > I

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 256351. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. Rebased on https://reviews.llvm.org/D73290 and this patch now depends on it. Removed PPCAIX32TargetCodegenClass from previous diff. Corrected behaviour `PPC32TargetCodeGenInfo::initDwar

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 256398. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Addressed comments -added error for -msvr4-struct-return on AIX and modified appropriate test case -changed code structure as per comment -renamed test file Repository: rG LLVM G

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/ppc32-struct-return.c:53 + +// AIX-SVR4: fatal error: error in backend: -msvr4-struct-return not supported on AIX + jasonliu wrote: > jasonliu wrote: > > sfe

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 258110. ZarkoCA added a comment. Added a TODO to remove the error for `msvr4-struct-return` on AIX when we verify it works as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 261837. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Rebased patch to include latest changes in trunk. Removed that it depended on https://reviews.llvm.org/D73290 in the summary, as that patch has been landed. Repository: rG LLVM

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4368 + + return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*Indirect*/ false, TypeInfo, + SlotSize, /*AllowHigher*/ true); Is there a reason why Indirect is set to `

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA abandoned this revision. ZarkoCA added a comment. This work is included in https://reviews.llvm.org/D79035. Abandoning this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76360/new/ https://reviews.llvm.org/D76360 _

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:691 AddGlobalDtor(Fn); + CXXGlobalDtors.clear(); } I may be missing something but why do we need this now, as opposed to not needing it before? Why didn't we need to clear the CXXGlo

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4257 + // 64-bit only registers: + // 114: tfhar + // 115: tfiar From what I've seen, the tfhar, tfiar and texasr are used by the Power8 CPU, which means that there is potential for t

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5244 llvm::Value *Address) const { - - return PPC64_initDwarfEHRegSizeTable(CGF, Address); + return PPC_initDwarfEHRegSizeTable(CGF, Address, /* Is64Bit*

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added a comment. I'm ok with this now. I will let @Xiangling_L approve if she's ok with it since she had the last few comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 ___ cfe-commit

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358934. ZarkoCA added a comment. - Fix formatting in test case - Reword warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files: clang/include/clang/B

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL compiler

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66225db98d83: [PowerPC][AIX] Add warning when alignment is incompatible with XL (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile, PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. ZarkoCA requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Remove the previous er

[PATCH] D106409: [PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf

ZarkoCA created this revision. ZarkoCA added reviewers: bmahjour, nemanjai, jsji, PowerPC. Herald added subscribers: shchenz, kbarton. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM (llc) will crash when a user specifies a num

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 360535. ZarkoCA added a comment. - Fix comment to also describe what happens in 32bit mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files: clang/lib/CodeGen/

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4577-4583 + // If we have a complex type and the base type is smaller than 8 bytes, + // the ABI calls for the real and imaginary parts to be right-adjusted + // in separate doublewords. However, Clang

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:262-269 + if (T.isOSAIX()) { +// Pass -b prefix for AIX linker. +A.claim(); +A.render(Args, CmdArgs); +continue; + } else { +TC.getDriver().Diag

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM with small nit, thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:263 + if (!T.isOSAIX()) { +TC.getDriver().Diag(diag::err_drv_unsupported_op

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:263 + if (!T.isOSAIX()) { +TC.getDriver().Diag(diag::err_drv_unsupported_opt) +<< A.getAsString(Args); anjankgk wrote: > ZarkoCA wrote: > > nit, I prefe

[PATCH] D107063: Set TargetCPUName for AIX to default to pwr7.

ZarkoCA added a comment. Thanks @jamieschmeiser this change LGTM but I'll defer to @hubert.reinterpretcast for final approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107063/new/ https://reviews.llvm.org/D107063

[PATCH] D107105: [AIX] Pass the -b option to linker on AIX (with fix to build break)

ZarkoCA added a comment. Thanks for the quick turn around and fix @anjankgk, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107105/new/ https://reviews.llvm.org/D107105 ___ cfe-commits mailing list

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

ZarkoCA accepted this revision. ZarkoCA added a comment. LGTM also. Just a comment typo. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1779 + // On AIX, zero-width bitfields pad out to the natural alignment boundary, + // but dont increase the alignment greater than the M

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406086. ZarkoCA added a comment. - Moved AIX check to its own function to hopefully avoid Arg and ArgTy getting out of sync - Rebased and removed LIT test cases workaround Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef ParamName,

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406620. ZarkoCA added a comment. - Add note for diagnostic pointing to declaration of the struct member - cleaned up use of unneeded variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://re

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA marked 4 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5220-5221 + Context.toCharUnitsFromBits(AA->getAlignment(Context)); + if (Alignment.getQuantity() >= 16) +Diag(Loc, diag::warn_no

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406822. ZarkoCA added a comment. - Warn on declaration of struct member and add note for call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files: clang/include/c

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/test/Sema/aix-attr-align.c:34-35 + baz(s.a); // no-warning + baz(s.b); // expected-warning {{requesting an alignment of 16 bytes or greater for struct members is not binary compatible with IBM XL C/C++ for AIX 16.1.0 and older}

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406843. ZarkoCA added a comment. - Shorten warning message - Add new note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3299-3301 +: Warning<" %0 byte requested alignment for a struct member used as an" + " argument is 16 bytes or greater which is not binary" + " compatible wit

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added a comment. After offline discussion with @sfertile , the warning should occur only when the struct member is passed on the stack. I will be updating the patch shortly. @aaron.ballman Thank you for the thorough reviews comments and sorry for the churn. Repository: rG LLVM Githu

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 443812. ZarkoCA added a comment. - Rebase and add FDecl check before calling checkAIXMemberAlignment() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files: clang/

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

This revision was automatically updated to reflect the committed changes. Closed by commit rGa61b202d4e3b: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/powerpc-c99complex.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-linux -emit-llvm %s -o - | FileCheck %s --check-prefixes=PPC64LNX +// RUN: %clang_cc1 -triple powerpc-unknown-linux -emit-llvm %s -o - | FileCheck

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/powerpc-c99complex.c:7 + return x; +// PPC64LNX-LABEL: define { float, float } @foo1(float %x.{{.*}}, float %x.{{.*}}) #0 { +// PPC64LNX: ret { float, float } Nit: I don't think you

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA accepted this revision. ZarkoCA added a comment. Thanks for doing the formatting changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88105/new/ https://reviews.llvm.org/D88105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

ZarkoCA added a comment. In D88105#2292266 , @nemanjai wrote: > This clearly changes behaviour and should thereby not have the `[NFC]` tag. Looks like it accidentally includes https://reviews.llvm.org/D88130. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex

This revision was automatically updated to reflect the committed changes. Closed by commit rG64b8a633a872: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex (authored by cebowleratibm, committed by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D88105?vs=293917&id=294222#to

[PATCH] D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88130/new/ https://reviews.llvm.org/D88130 __

[PATCH] D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf330d9f163f6: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX (authored by cebowleratibm, committed by ZarkoCA). Changed pr

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 305136. ZarkoCA retitled this revision from "[AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs. " to "[AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. ". ZarkoCA edited the summar

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:532 Options.EmitCallSiteInfo = CodeGenOpts.EmitCallSiteInfo; + Options.AIXExtendedAltivecABI = CodeGenOpts.AIXExtendedAltivecABI; Options.ValueTrackingVar

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 305150. ZarkoCA added a comment. Rebased and addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/lib/Target/PowerPC/PPCCallingConv.td ll

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:184 if (TM.isPPC64()) { -if (Subtarget.hasAltivec()) +if (Subtarget.hasAltivec()) { + if (Subtarget.isAIXABI() && !TM.getAIXExtendedAlt

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR_PPC64_RegMask) sfertile

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 306509. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. Addressed comments: Added and fixed test cases and changed option selection logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 10 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616 + if (Args.hasArg(options::OPT_maltivec) && + (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) { +for (const Arg *A : Args) { -

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 306515. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Rebase and remove regmask altivec change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Fil

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA marked 6 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 306545. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Fixed failing test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/include/llvm/Target/TargetMachine.h llvm/l

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 5 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1443 + if (Arg *A = + Args.getLastArg(OPT_mabi_EQ_vec_default, OPT_mabi_EQ_vec_extabi)) { Xiangling_L wrote: > Should we als

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 306696. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Addressed comments and added a test to check whether the driver passes these options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D8968

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option

ZarkoCA updated this revision to Diff 298409. ZarkoCA retitled this revision from "[PPC][AIX] Add vector callee saved registers for AIX extended vector ABI" to "[PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option". ZarkoCA edited the summary of t

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option

ZarkoCA marked 5 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-csr-vector.ll:4 +; RUN: FileCheck --check-prefix=MIR32 %s + +; RUN: llc -mtriple=powerpc-unknown-aix-xcoff -verify-machineinstrs \ Xiangling_L wro

[PATCH] D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/DeclSpec.cpp:1200 + // It has also been historically deprecated on AIX (as an alias for + // "vector int" in both 32-bit and 64-bi

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 307192. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. Addressed some of the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684 Files: clan

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 307405. ZarkoCA added a comment. Went back to old option selection logic as updated version did not emit an error when selecting 'maltivec` but not `mabi=vec-extabi`. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 7 inline comments as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/altivec.c:7 + +// RUN: %clang -S -emit-llvm -maltivec -mabi=vec-extabi -target powerpc-unknown-aix %s -o - | FileCheck %s +// RUN: not %clang -S -emit-llvm -mabi=vec-default

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 307449. ZarkoCA added a comment. Simplified option logic as per suggestion. Removed stray isXCOFF reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684 Files: cl

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 7 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4624 + + if (Triple.isOSAIX()) { +if (Args.hasArg(options::OPT_maltivec) && Xiangling_L wrote: > line 4624 to line 4635 can be simplifi

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

This revision was automatically updated to reflect the committed changes. ZarkoCA marked 2 inline comments as done. Closed by commit rGc92f29b05e68: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 307499. ZarkoCA added a comment. Seems a few test cases require `mattr=-altivec` to pass with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe7d425edc64: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D92117: [AIX] Enabling vectory types for AIX

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile, jasonliu, Xiangling_L, hubert.reinterpretcast. Herald added a project: clang. Herald added a subscriber: cfe-commits. ZarkoCA requested review of this revision. This patch enables vector types for AIX. Repository:

[PATCH] D92117: [AIX] Enabling vector types for AIX

ZarkoCA updated this revision to Diff 307748. ZarkoCA added a comment. Added regex and variable for function attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92117/new/ https://reviews.llvm.org/D92117 Files: clang/lib/CodeGen/TargetInfo.c

[PATCH] D78903: [Driver] Add option -fproc-stat-report

ZarkoCA added inline comments. Comment at: clang/test/Driver/report-stat.c:1 +// RUN: %clang -c -fproc-stat-report %s | FileCheck %s +// CHECK: clang{{.*}}: output={{.*}}.o, total={{[0-9.]+}} ms, user={{[0-9.]+}} ms, mem={{[0-9]+}} Kb Hi @sepavloff, is it possib

[PATCH] D92117: [AIX] Enabling vector type arguments and return for AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGff8e8c1b14ea: [AIX] Enabling vector type arguments and return for AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92117/new/ https:

[PATCH] D78903: [Driver] Add option -fproc-stat-report

ZarkoCA added inline comments. Comment at: clang/test/Driver/report-stat.c:1 +// RUN: %clang -c -fproc-stat-report %s | FileCheck %s +// CHECK: clang{{.*}}: output={{.*}}.o, total={{[0-9.]+}} ms, user={{[0-9.]+}} ms, mem={{[0-9]+}} Kb ZarkoCA wrote: > Hi @sepavl

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

ZarkoCA created this revision. ZarkoCA added reviewers: Xiangling_L, cebowleratibm, sfertile. Herald added subscribers: llvm-commits, cfe-commits, dang, dmgreen, arphaman, kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. ZarkoCA requested review of this revision. Added support fo

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 298991. ZarkoCA marked 3 inline comments as done. ZarkoCA retitled this revision from "[PPC][AIX] Add vector callee saved registers for AIX extended vector ABI and add clang and llvm option" to "[PPC][AIX] Add vector callee saved registers for AIX extended ve

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 298994. ZarkoCA added a comment. Fixed typo in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/lib/Target/PowerPC/PPCCallingConv.td llvm/lib/

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 344785. ZarkoCA added a comment. - Rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa168fc50ba: Parse vector bool when stdbool.h and altivec.h are included (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-non-type-vector.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-aix-xcoff -target-feature +altivec -fsyntax-only %s + Can you add tests for 64bit BE/LE linux and 32bit AIX/BE linux in this th

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-non-type-vector.c:1-24 +// RUN: %clang_cc1 -target-feature +altivec -fsyntax-only %s -triple powerpc64-ibm-aix +// RUN: %clang_cc1 -target-feature +altivec -fsyntax-only %s -triple powerpc64-ibm-aix-xcoff +//

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 ___ cfe-commits mailing list cf

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA updated this revision to Diff 318971. ZarkoCA marked an inline comment as done. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Emit error message only when option is active - Changed description of patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94986

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

This revision was automatically updated to reflect the committed changes. ZarkoCA marked an inline comment as done. Closed by commit rG028d7a36681f: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D95702: [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, cebowleratibm. ZarkoCA added a project: PowerPC. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Opening this revision to better address comments by @hu

[PATCH] D95702: [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3426a528d5: [AIX] Improve option processing for mabi=vec-extabi and mabi=vec=defaul (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0a71c5fc05: [PowerPC][AIX] Add support for varargs for complex types on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/ https://reviews.llvm.org/D106409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 376630. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Herald added a subscriber: steven.zhang. - Only truncate **b** and not result - Add a proper test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/lib/Headers/altivec.h:3178 + : (__builtin_vsx_xvcvuxdsp((vector unsigned long long)(__a)) * \ + (vector float)(vector unsigned)((0x7f - (__b)) << 23 & 0x1F)),

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353721. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Addressed comments: - Removed redundant `elseif` and CHECK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.l

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4779 CmdArgs.push_back("-mabi=vec-extabi"); +else if (A->getOption().getID() == options::OPT_mabi_EQ_vec_default) + CmdArgs.push_back("-mabi=

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353748. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. - Updated test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/include/

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:3 +// RUN: FileCheck %s --check-prefix=EXTABI // RUN: %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=DFLTABI ---

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353787. ZarkoCA added a comment. Use `--implicit-check-not` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files: clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:12 +/ +// NOEXTABI-NOT: "-mabi=vec-extabi" jsji wrote: > Why not use `--implicit-check-not`? Thank you, I wasn't aware of this option before

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353806. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. check for `vec-extabi` instead of `-mabi=vec-extabi` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org

  1   2   3   >