[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen created this revision. ychen added reviewers: rsmith, aaron.ballman. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128745 Files:

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 440703. ychen added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/CXX/drs/dr6xx.cpp

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen created this revision. ychen added reviewers: hubert.reinterpretcast, erichkeane, rsmith, aaron.ballman, royjacobson. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most of the wordings are impleme

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3616449 , @erichkeane wrote: > Is there any chance you can validate this against > https://reviews.llvm.org/D126907 as well? We touch similar code, and I'm > intending to get that committed in the near future. Otherwi

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3616471 , @ychen wrote: > In D128750#3616449 , @erichkeane > wrote: > >> Is there any chance you can validate this against >> https://reviews.llvm.org/D126907 as well? We touch

[PATCH] D114728: [Coroutine] Remove the prologue data of `-fsanitize=function` for split functions

ychen abandoned this revision. ychen added a comment. Herald added a project: All. D115844 and D116130 supersede this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114728/new/

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 440789. ychen added a comment. - add release notes - update www-status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. In D115844#3625776 , @vitalybuka wrote: > @ychen This patch causes 20% .o size increase (x86_64) Is this expected? No, it is not expected. Do you have a test case? I'll take a look. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5119 - while (--NumParams > 0) { -if (Function->getParamDecl(NumParams - 1)->isParameterPack()) - return false; royjacobson wrote: > Curious, why was this removed? I think

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen added a comment. In D128745#3632850 , @aaron.ballman wrote: > Thank you for working on this! Can you please add more details to the patch > summary about the changes? Thanks for taking a look. This was intended to correctly implement https://ee

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, aaron.ballman wrot

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3627085 , @royjacobson wrote: > Thanks for working on this! I like the approach, but two comments: Thanks for the review. > I would like more tests for the different forms of template argument > deduction. Some sugges

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. Herald added a subscriber: MaskRay. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D122869: [lit] Fix setup of sanitizer environment

ychen added inline comments. Comment at: clang/test/Unit/lit.cfg.py:33 -# Propagate path to symbolizer for ASan/MSan. -for symbolizer in ['ASAN_SYMBOLIZER_PATH', 'MSAN_SYMBOLIZER_PATH']: -if symbolizer in os.environ: -config.environment[symbolizer] = os.environ[symb

[PATCH] D122869: [lit] Fix setup of sanitizer environment

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. I'm looking at relevant code recently. This LGTM. Comment at: clang/test/Unit/lit.cfg.py:33 -# Propagate path to symbolizer for ASan/MSan. -for symbolizer in ['ASAN_SYMBOLIZE

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen updated this revision to Diff 448732. ychen added a comment. - use < 2 - check multiple flag outputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129954/new/ https://reviews.llvm.org/D129954 Files: clang/lib/CodeGen/CGStmt.cpp clang/tes

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen updated this revision to Diff 448733. ychen added a comment. - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129954/new/ https://reviews.llvm.org/D129954 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/inline-asm-x86-f

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen marked 2 inline comments as done. ychen added a comment. In D129954#3686780 , @nikic wrote: > LGTM. After some further consideration, implementing this properly in LLVM > would probably take more effort than is worthwhile (especially as this is >

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rG92c1bc61586c: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen updated this revision to Diff 360514. ychen marked an inline comment as done. ychen added a comment. - fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Sema/S

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added inline comments. Comment at: clang/test/Sema/i-c-e.c:77-78 + // expected-warning {{expression result unused}} +int comma3[(1, 2)]; // expected-warning {{variable length array folded to constant array as an extension}} \ + /

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

ychen added a comment. Herald added a project: All. @aaron.ballman Thanks for taking a look. @probinson Gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118850/new/ https://reviews.llvm.org/D118850 __

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

ychen added a comment. @probinson Thanks. No worries. I should've pinged earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118850/new/ https://reviews.llvm.org/D118850 ___ cfe-commits mailing list c

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e80976fdf3f: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. Herald added a project: All. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes

ychen created this revision. ychen added a reviewer: probinson. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So it matches `__STDCPP_DEFAULT_NEW_ALIGNMENT__`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D11885

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

ychen added a comment. I don't see why the patch is wrong... It uses the target/platform-specific `NewAlign`. If the platform allows customized memory allocation that assumes weak alignment, it should set the `NewAlign` accordingly, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

ychen added a comment. In D118804#3292263 , @jyknight wrote: > In D118804#3292185 , @ychen wrote: > >> I don't see why the patch is wrong... It uses the target/platform-specific >> `NewAlign`. If the platform all

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

ychen accepted this revision. ychen added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118804/new/ https://reviews.llvm.org/D118804 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 405520. ychen added a comment. - Remove a file that is included by accident. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added inline comments. Comment at: llvm/lib/CodeGen/CommandFlags.cpp:462 + static cl::opt EnableJMCInstrument( + "enable-jmc-instrument", + cl::desc("Instrument functions with a call to __CheckForDebuggerJustMyCode"), ychen wrote: > hans wrote:

[PATCH] D112353: [bazel] fixes for windows build

ychen added a comment. In D112353#3291381 , @GMNGeoffrey wrote: > If you'd like to rebase this and see what's still outstanding, I can take > another look :-) Thanks for getting around to this. I rebased the patch and reran the build. It seems the new

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3292918 , @hans wrote: > It seems Phabricator ate my comment, but I meant to say: > > My understanding is still that IR passes generally live in Transforms/ and > that CodeGen/ deals with lower levels such as MachineInst

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3294880 , @rnk wrote: > In D118428#3294411 , @ychen wrote: > >> The passes in `lib/Transforms/Instrumentation` runs with >> `EmitAssemblyHelper::RunOptimizationPipeline`. JMC pas

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

ychen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:223-224 const llvm::Triple &Triple, const ArgList &Args, + llvm::opt::ArgStr

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen marked an inline comment as done. ychen added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:180 + "JMC instrument more than once?"); + FunctionCallee Fn = + M.getOrInsertFunction(CheckFunctionName, getCheckFunctionType(Ctx)); --

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 406927. ychen marked an inline comment as done. ychen added a comment. - address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files: clang/docs/ReleaseNot

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen created this revision. ychen added reviewers: mubashar_, lenary, pbarrio. Herald added a subscriber: kristof.beyls. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407308. ychen added a comment. - add ARM64 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c clang/test/Sema/tes

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen added a comment. In D119301#3309140 , @lenary wrote: > I don't fully understand the reasoning for the patch, and you haven't really > explained it. I think what you are saying is that the `IsAux` argument to > `getTargetFeatures` should be conside

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407313. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/test/Sema/test-wunaligned-access.c clang/test/Sema/test-wunalig

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen added a comment. In D119301#3309253 , @ychen wrote: > In D119301#3309140 , @lenary wrote: > >> I don't fully understand the reasoning for the patch, and you haven't really >> explained it. I think what you

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407314. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp clang/lib/Driver/ToolCha

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407336. ychen added a comment. - Handle ARM - Add driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp c

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

ychen added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:478 + HELP, METAVAR, VALUES) \ + {DriverID::OPT_##ID, DriverID::OPT_##ALIAS, (void *)ALIASARGS}, +#include "clang/Driver/Options.inc" ---

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 407384. ychen marked an inline comment as done. ychen added a comment. - Remove CodeViewDebug.cpp and the associated test. It was needed because the instrumented flag variables were scoped inside the associated method in the CodeView. The current patch puts th

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen marked an inline comment as done. ychen added inline comments. Comment at: llvm/test/CodeGen/X86/jmc-instrument.ll:2 +; Check that the flag symbol is not full-qualified. +; RUN: llc < %s -enable-jmc-instrument | FileCheck %s + hans wrote: > ychen wrote: > >

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen updated this revision to Diff 407571. ychen added a comment. - Remove `CmdArgs` from `arm::getARMTargetFeatures` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119301/new/ https://reviews.llvm.org/D119301 Files: clang/lib/Driver/ToolChains/

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb96106af3f55: [AArch64][ARM] add -Wunaligned-access only for clang (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D118428: [clang-cl] Support the /JMC flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ychen marked an inline comment as done. Closed by commit rGbd3a1de683f8: [clang-cl] Support the /JMC flag (authored by ychen). Changed prior to commit: https://revie

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3312440 , @paulkirth wrote: > Hi, > > We have two failing test cases on Fuchsia's clang canary builder on Windows > x64. > > LLVM :: Instrumentation/JustMyCode/jmc-instrument-x86.ll > LLVM :: Instrumentation/JustMyCode/

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. In D115844#3321190 , @pcc wrote: > On the bug you have: > > define internal fastcc void > @​_Z4callIiE4taskv.resume(%_Z4callIiE4taskv.Frame* noalias nonnull > align 8 dereferenceable(24 > ) %FramePtr) #​1 prologue <{ i32,

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5171 (!TargetDecl || !isa(TargetDecl))) { +assert((CGM.getCodeGenOpts().CodeModel == "default" || +CGM.getCodeGenOpts().CodeModel == "small") && pcc wrote: > What happens

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen updated this revision to Diff 408752. ychen added a comment. Herald added subscribers: jdoerfert, pengfei. - check code model in driver - document `func_sanitizer` in Langref - add a codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen added a comment. In D118428#3312621 , @ychen wrote: > In D118428#3312440 , @paulkirth > wrote: > >> Hi, >> >> We have two failing test cases on Fuchsia's clang canary builder on Windows >> x64. >> >> LLVM

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen created this revision. ychen added reviewers: hans, rnk, aganea, JDevlieghere, labath. Herald added a subscriber: hiraditya. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The motivation is to enable the MSVC-

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. > - how does that work, actually? How does it differentiate between "my" code > and "code that happens to be compiled in the current CU" (e.g. the STL). > What's the significance of the funky `___x@c` symbols? The non-user code is specified by a config file (htt

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. RFC sent: https://discourse.llvm.org/t/rfc-just-my-code-stepping-for-non-msvc-debuggers/60279 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 __

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. gentle ping. @pcc could we please move this forward if the direction looks good to you? It has been sitting for a while... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 443756. ychen added a comment. - handle more cases to implement DR692, DR1395 - tentatively implement DR1432 which DR692 needs, otherwise there would be regressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 443771. ychen marked an inline comment as done. ychen added a comment. - fix a bug - update comments - check-all, check-runtimes pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:2488 +bool XHasMoreArg = X.pack_size() > Y.pack_size(); +if (!(XHasMoreArg && X.pack_elements().back().isPackExpansion()) && +!(!XHasMoreArg && Y.pack_elements().back().i

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, ychen wrote: > aar

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen created this revision. ychen added reviewers: nikic, ChuanqiXu. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. It is illegal to merg

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen added a comment. In D129530#3644074 , @ChuanqiXu wrote: > This looks good to me basically. I would love to see an example to test the > two coro.save wouldn't be merged. Yep, `hoist-skip-token.ll` is testing this. Repository: rG LLVM Github Mo

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen updated this revision to Diff 443818. ychen added a comment. - Address Chuanqi's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129530/new/ https://reviews.llvm.org/D129530 Files: clang/test/CodeGenCoroutines/coro-attributes.cpp

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

ychen added a comment. In D129530#3644094 , @ChuanqiXu wrote: > In D129530#3644091 , @ychen wrote: > >> In D129530#3644074 , @ChuanqiXu >> wrote: >> >>> This looks good t

[PATCH] D129530: [coroutine] add nomerge function attribute to `llvm.coro.save`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcb7d76d65e8: [coroutine] add nomerge function attribute to `llvm.coro.save` (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. Thanks for the review. @aaron.ballman @erichkeane. About the non-trailing pack, I had the impression that DR692 is only about the trailing pack in practice but don't remember the exact wording, so I dig the standardese further. For partial specialization: https://eel.is/

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen updated this revision to Diff 444099. ychen marked 4 inline comments as done. ychen added a comment. - add Clang ABI check - replace one NTTP with a local constexpr variable - style changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5423-5424 +template ::value> +static TemplateLikeDecl * aaron.ballman wrote: > Can't this be a local constexpr variable instead of an NTTP, or are there > reasons you want to allow

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen updated this revision to Diff 444363. ychen added a comment. - add CodeGen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateDed

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5444 + if (Better1 && Better2) { +bool ClangABICompat14 = S.Context.getLangOpts().getClangABICompat() <= +LangOptions::ClangABI::Ver14; aaron.ballma

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ychen added inline comments. Comment at: llvm/docs/LangRef.rst:24541 + + declare ptr @llvm.threadlocal.address(ptr) nounwind readnone willreturn + Like @jyknight already did, any idea what it would take to change the parameter type from pointer to token? Lo

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen created this revision. ychen added reviewers: nikic, efriedma, lebedev.ri. Herald added subscribers: jsji, pengfei, kristof.beyls. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC inline asm docum

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen added a comment. In D129954#3658139 , @nikic wrote: > Hm, might it be better to teach LLVM about this (in some > ConstantRange/KnownBits logic)? This doesn't really seem like something the > frontend should know about and encode, as that means eac

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen marked an inline comment as done. ychen added a comment. In D128750#3627085 , @royjacobson wrote: > I'm also a bit concerned that we're deviating from the standard here w.r.t. > to the 'reordering' checks for reversed candidates. I support this -

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. In D128750#3662898 , @royjacobson wrote: > but in your example with T/U/V we have 3 template parameters that we could > reorder in 6 different ways. But, any reordering of the 6 that does not have consecutive U and V is not val

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1843 + + auto *FTRTTIProxy = new llvm::GlobalVariable( + TheModule, Addr->getType(), pcc wrote: > Are these proxy variables necessary? I think that now that we have custom > code

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

ychen added a comment. Since Charlie has completed his internship before LGTM, I'll commit this on his behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62829/new/ https://reviews.llvm.org/D62829 ___ cfe-commits mailing list cfe-commit

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen created this revision. ychen added reviewers: akhuang, rnk, probinson. Herald added a project: clang. Herald added a subscriber: cfe-commits. This essentially reverts changes from r361400. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67141 Files: clang/lib/CodeGen/CG

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

ychen added a comment. > Would that work for this test also? Yes, that sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527 ___ cfe-commits mailing lis

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

ychen updated this revision to Diff 218588. ychen added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527 Files: clang/test/Driver/verbose-output-quoting.c Index: clang/test/Dr

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen updated this revision to Diff 218769. ychen added a comment. - address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://reviews.llvm.org/D67141 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/enum2.c

[PATCH] D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.

ychen added a comment. In D67141#1658238 , @rnk wrote: > lgtm, thanks! Thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67141/new/ https://reviews.llvm.org/D67141 __

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238028. ychen added a comment. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. - when optnone is not present, add `optsize` for Os and `minsize` for Oz - add Os Oz function attribute test. - add Os Oz pipeline test Repository: rG L

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238034. ychen added a comment. - fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-debug-

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238042. ychen added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-debug-pm.c

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen updated this revision to Diff 238071. ychen added a comment. - rebase & clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thi

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen added a comment. In D72404#1820628 , @tycho wrote: > In D72404#1820461 , > @merge_guards_bot wrote: > > > {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 > > failed and 781 were skipped

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

ychen updated this revision to Diff 238142. ychen edited the summary of this revision. ychen added a comment. - fix test when clang is the host compiler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. Apologies that it takes so long. I'll fix the test and land it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67847/new/ https://reviews.llvm.org/D67847 ___ cfe-commits mai

[PATCH] D44352: [Concepts] Type Constraints

ychen added a comment. I saw a null pointer dereference for the `p3-2a.cpp` file added here. It is not always reproducible for me, I was able to reproduce it once offline. Any idea? Crash stack is here: https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-1220/console-log.txt From D

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

ychen added a comment. Herald added subscribers: wenlei, danielkiss. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85676/new/ https://reviews.llvm.org/D85676 ___ cfe-commits mailing list cfe-commit

[PATCH] D85676: [NewPM] collapsing nested pass mangers of the same type

ychen added a comment. In D85676#2245787 , @asbirlea wrote: > Seems like a good idea. I'm curious if you saw any impact from this change. Yeah, I'm curious too but I didn't measure it yet. What's the recommended ways to measure it? Repository: rG LLV

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen updated this revision to Diff 310079. ychen marked an inline comment as done. ychen added a comment. - `clang/test/Misc/time-passes.c`: add -fno-experimental-new-pass-manager - `llvm/test/Other/time-passes.ll`: makes sure each pass has one entry. Repository: rG LLVM Github Monorepo CHAN

<    1   2   3   4   5   6   7   >