ychen added a comment. In D129530#3644094 <https://reviews.llvm.org/D129530#3644094>, @ChuanqiXu wrote:
> In D129530#3644091 <https://reviews.llvm.org/D129530#3644091>, @ychen wrote: > >> In D129530#3644074 <https://reviews.llvm.org/D129530#3644074>, @ChuanqiXu >> wrote: >> >>> This looks good to me basically. I would love to see an example to test the >>> two coro.save wouldn't be merged. >> >> Yep, `hoist-skip-token.ll` is testing this. > > Oh, sorry. I didn't notice that. The current version should be fine. > > Personally, I would like to move the test to `Transforms/Coroutine` and add a > new test that the two `llvm.coro.suspend` are the same but they couldn't be > merged. This is not required. Sure, sounds good to me. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129530/new/ https://reviews.llvm.org/D129530 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
