[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-08-27 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya created this revision. Herald added a subscriber: fhahn. Clang changes related to Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled https://reviews.llvm.org/D37196 Files: lib/CodeGen/CodeGenAction.cpp Index:

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-08-31 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya updated this revision to Diff 113434. vivekvpandya added a comment. Updated the patch! I don't think now we require to save OldDiagnosticHandler and context as we have ClangDiagnosticHandler class with creation of CreateASTConsumer, but I need some review. https://reviews.llvm.org

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-05 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya updated this revision to Diff 113879. vivekvpandya added a comment. Clang-formated https://reviews.llvm.org/D37196 Files: lib/CodeGen/CodeGenAction.cpp Index: lib/CodeGen/CodeGenAction.cpp === --- lib/CodeGen/CodeG

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-11 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya marked an inline comment as done. vivekvpandya added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:882-883 BEConsumer = Result.get(); - + VMContext->setDiagnosticHandler(llvm::make_unique( + CI.getCodeGenOpts(), Result.get())); // Enable gene

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-11 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya updated this revision to Diff 114645. vivekvpandya added a comment. Update https://reviews.llvm.org/D37196 Files: lib/CodeGen/CodeGenAction.cpp Index: lib/CodeGen/CodeGenAction.cpp === --- lib/CodeGen/CodeGenAction

[PATCH] D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-11 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya updated this revision to Diff 114647. vivekvpandya marked 8 inline comments as done. https://reviews.llvm.org/D33514 Files: include/llvm/Analysis/OptimizationDiagnosticInfo.h include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h include/llvm/IR/DiagnosticHandler.h include/l

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-12 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya added a comment. Why? That was inside BackendConsumer. I was getting incomplete type error. You can just save the old DiagHandler object instead. I don't think now we need to do that as per my understanding CodeGen i.e emitting LLVM IR is last phase in clang which will pass control

[PATCH] D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-12 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya updated this revision to Diff 114869. vivekvpandya marked 3 inline comments as done. vivekvpandya added a comment. Update. https://reviews.llvm.org/D33514 Files: include/llvm/Analysis/OptimizationDiagnosticInfo.h include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h include

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-13 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya updated this revision to Diff 115085. vivekvpandya added a comment. update https://reviews.llvm.org/D37196 Files: lib/CodeGen/CodeGenAction.cpp Index: lib/CodeGen/CodeGenAction.cpp === --- lib/CodeGen/CodeGenAction

[PATCH] D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

2017-09-13 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya updated this revision to Diff 115086. vivekvpandya added a comment. Added method to detach unique_ptr from LLVMContext. https://reviews.llvm.org/D33514 Files: include/llvm/Analysis/OptimizationDiagnosticInfo.h include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h include/ll

[PATCH] D63381: Allow copy/move assignment operator to be coroutine as per N4775

2019-06-18 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63381/new/ https://reviews.llvm.org/D63381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63381: Allow copy/move assignment operator to be coroutine as per N4775

2019-06-19 Thread Vivek Pandya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL363804: Allow copy/move assignment operator to be coroutine as per N4775 (authored by vivekvpandya, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D63381

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

2019-06-23 Thread Vivek Pandya via Phabricator via cfe-commits
vivekvpandya added a comment. Minor suggestion, you may want to update http://clang.llvm.org/cxx_status.html page for "typename optional in more contexts" with in this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://review