vivekvpandya marked an inline comment as done. vivekvpandya added inline comments.
================ Comment at: lib/CodeGen/CodeGenAction.cpp:882-883 BEConsumer = Result.get(); - + VMContext->setDiagnosticHandler(llvm::make_unique<ClangDiagnosticHandler>( + CI.getCodeGenOpts(), Result.get())); // Enable generating macro debug info only when debug info is not disabled and ---------------- anemet wrote: > Any reason you moved where we set this up? # At older place I was not able to define ClangDiagnosticHandler class as it will require definition of BackendComsumer and vice versa. # and this seems to be appropriate place to create and tie DiagnosticHandler to LLVMContext But I am not sure about why old diagnostic handler was tied back to context that is why I wanted someone from clang to look at this. https://reviews.llvm.org/D37196 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
