[clang] 37e1458 - [NFC] Remove reference to file deleted by D100981.

Author: Vitaly Buka Date: 2021-04-22T10:40:18-07:00 New Revision: 37e1458128556ae153313cdb7e085907dff5bb8b URL: https://github.com/llvm/llvm-project/commit/37e1458128556ae153313cdb7e085907dff5bb8b DIFF: https://github.com/llvm/llvm-project/commit/37e1458128556ae153313cdb7e085907dff5bb8b.diff L

[clang] 68ff493 - [NFC] Fixed some D79714 warnings

Author: Vitaly Buka Date: 2021-04-25T12:41:46-07:00 New Revision: 68ff493dfc950c05c102e09e14a16d06253ffa16 URL: https://github.com/llvm/llvm-project/commit/68ff493dfc950c05c102e09e14a16d06253ffa16 DIFF: https://github.com/llvm/llvm-project/commit/68ff493dfc950c05c102e09e14a16d06253ffa16.diff L

[clang] f2a585e - [NFC] Fix "not used" warning

Author: Vitaly Buka Date: 2021-04-26T22:09:23-07:00 New Revision: f2a585e6d392f4c8587c1dac4d776037d4b588c5 URL: https://github.com/llvm/llvm-project/commit/f2a585e6d392f4c8587c1dac4d776037d4b588c5 DIFF: https://github.com/llvm/llvm-project/commit/f2a585e6d392f4c8587c1dac4d776037d4b588c5.diff L

[clang-tools-extra] 669eb60 - Initialize HighlightingsBuilder::Resolver

Author: Vitaly Buka Date: 2022-01-07T15:21:22-08:00 New Revision: 669eb60046706c096d4d7804359670f3ca18ed7a URL: https://github.com/llvm/llvm-project/commit/669eb60046706c096d4d7804359670f3ca18ed7a DIFF: https://github.com/llvm/llvm-project/commit/669eb60046706c096d4d7804359670f3ca18ed7a.diff L

[clang-tools-extra] 244dd29 - Don't pass uninitialized QueryKind

Author: Vitaly Buka Date: 2022-01-07T17:14:08-08:00 New Revision: 244dd2913a43a200f5a6544d424cdc37b771028b URL: https://github.com/llvm/llvm-project/commit/244dd2913a43a200f5a6544d424cdc37b771028b DIFF: https://github.com/llvm/llvm-project/commit/244dd2913a43a200f5a6544d424cdc37b771028b.diff L

[clang] 05d46f6 - [NFC][sanitizer] Remove sanitizer_persistent_allocator.cpp

Author: Vitaly Buka Date: 2021-10-08T13:43:28-07:00 New Revision: 05d46f627c49ca9a576150be910a869034ced764 URL: https://github.com/llvm/llvm-project/commit/05d46f627c49ca9a576150be910a869034ced764 DIFF: https://github.com/llvm/llvm-project/commit/05d46f627c49ca9a576150be910a869034ced764.diff L

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

vitalybuka wrote: > > How i can see the full amount of breakage on different platforms > > proactively? I have created a PR: #104607 to address the big endian issue > > with the test as my // REQUIRES: x86-registered-target turned out not to be > > enough to exclude running test in the big end

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

vitalybuka wrote: > > Can we split `-fsanitize=unsigned-integer-overflow` into > > `-fsanitize=unsigned-integer-overflow-patternA,unsigned-integer-overflow-patternB,unsigned-integer-overflow-patternC...` > > ? > > Then it's quite intuitive to disable them with `no-sanitize`. > > Yikes, no way.

[clang] d257cd8 - [CodeGen][asan] Use `%t` instead of `cd` in test

Author: Vitaly Buka Date: 2024-08-16T23:02:12-07:00 New Revision: d257cd875873666d250e3fa7e95aafcd099f4e2f URL: https://github.com/llvm/llvm-project/commit/d257cd875873666d250e3fa7e95aafcd099f4e2f DIFF: https://github.com/llvm/llvm-project/commit/d257cd875873666d250e3fa7e95aafcd099f4e2f.diff L

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

@@ -995,6 +996,13 @@ void EmitAssemblyHelper::RunOptimizationPipeline( FPM.addPass(BoundsCheckingPass()); }); +if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) + PB.registerScalarOptimizerLateEPCallback( vitalybuka wrote: Thi

[clang] [clang][rtsan] Introduce realtime sanitizer codegen and driver (PR #102622)

https://github.com/vitalybuka approved this pull request. LGTM, but please get approvals from other responded reviewers https://github.com/llvm/llvm-project/pull/102622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -438,6 +438,36 @@ Moved checkers Sanitizers -- +- Added the ``-fsanitize-undefined-ignore-overflow-pattern`` flag which can be + used to disable specific overflow-dependent code patterns. The supported + patterns are: ``add-overflow-test``, ``negated-unsigned-cons

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -367,6 +367,21 @@ class LangOptionsBase { PerThread, }; + /// Exclude certain code patterns from being instrumented by arithmetic + /// overflow sanitizers + enum OverflowPatternExclusionKind { +/// Don't exclude any overflow patterns from sanitizers +None

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -0,0 +1,63 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsanitize=signed-integer-overflow,unsigned-integer-overflow -fsanitize-undefined-ignore-overflow-pattern=all %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsanitize

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -438,6 +438,36 @@ Moved checkers Sanitizers -- +- Added the ``-fsanitize-undefined-ignore-overflow-pattern`` flag which can be + used to disable specific overflow-dependent code patterns. The supported + patterns are: ``add-overflow-test``, ``negated-unsigned-cons

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka deleted https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -367,6 +367,21 @@ class LangOptionsBase { PerThread, }; + /// Exclude certain code patterns from being instrumented by arithmetic + /// overflow sanitizers + enum OverflowPatternExclusionKind { +/// Don't exclude any overflow patterns from sanitizers +None

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-land Overflow Pattern Exclusions (PR #104889)

@@ -293,6 +293,48 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

[clang] [clang] Merge lifetimebound and GSL code paths for lifetime analysis (PR #104906)

vitalybuka wrote: Also https://lab.llvm.org/buildbot/#/builders/164/builds/2291 https://github.com/llvm/llvm-project/pull/104906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang] Merge lifetimebound and GSL code paths for lifetime analysis (#104906)" (PR #105752)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/105752 Revert as it breaks libc++ tests, see #104906. This reverts commit c368a720a0b40bb8fe4aff3971fe9a7009c85aa6. >From 1482dc3f18243d09e7d205b724c76d69c0284b99 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date:

[clang] Revert "[clang] Merge lifetimebound and GSL code paths for lifetime analysis (#104906)" (PR #105752)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/105752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Re-land "[clang] Merge lifetimebound and GSL code paths for li… (PR #105753)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/105753 ... just for visibility >From 04376ece0618912d85a9a52a5f00f3eb3aa63c30 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Thu, 22 Aug 2024 16:38:31 -0700 Subject: [PATCH] =?UTF-8?q?Revert=20"Revert=20"[clang]=

[clang] Re-land "[clang] Merge lifetimebound and GSL code paths for li… (PR #105753)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/105753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

vitalybuka wrote: > Here's a screenshot of the rendered table so you don't have to build the html > docs yourself to inspect the layout: With this table, pattern affect only one sanitizer check, so splitting checks, as I suggested is possible. However I chatted with other folks, seems they ar

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

@@ -314,26 +314,55 @@ Currently, this option supports three overflow-dependent code idioms: unsigned long foo = -1UL; // No longer causes a negation overflow warning unsigned long bar = -2UL; // and so on... -``post-decr-while`` +``unsigned-post-decr-while`` .. cod

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

@@ -4806,6 +4806,34 @@ getOverflowPatternBinOp(const BinaryOperator *E) { return {}; } +/// Compute and set the OverflowPatternExclusion bit based on whether the vitalybuka wrote: Maybe this way? ``` static void computeOverflowPatternExclusion(const ASTCont

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/105709 >From c55507b3d5552d573068140736e8f904640924e9 Mon Sep 17 00:00:00 2001 From: Justin Stitt Date: Wed, 21 Aug 2024 19:29:03 -0700 Subject: [PATCH 1/2] rename some patterns, rewrite docs >From Vitaly's review

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

https://github.com/vitalybuka approved this pull request. I've updated the patch and can land later https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

@@ -314,26 +314,55 @@ Currently, this option supports three overflow-dependent code idioms: unsigned long foo = -1UL; // No longer causes a negation overflow warning unsigned long bar = -2UL; // and so on... -``post-decr-while`` +``unsigned-post-decr-while`` .. cod

[clang] [clang-format] Add option to remove leading blank lines (PR #91221)

vitalybuka wrote: @sstwcw Please don't ignore the presubmit, it detected issue before merging: Some checks were not successful 2 skipped, 65 successful, 48 failing, and 3 pending checks https://github.com/llvm/llvm-project/pull/91221 ___ cfe-commits m

[clang] [llvm] [Instrumentation] Move out to Utils (NFC) (PR #108532)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/108532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Instrumentation] Move out to Utils (NFC) (PR #108532)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/108532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

https://github.com/vitalybuka requested changes to this pull request. I think it change the meaning completly. I read "Coverage Sanitizer" as a tool which finds bugs in Coverage. When "Sanitizer Coverage" as a coverage used by sanitizers. https://github.com/llvm/llvm-project/pull/106505

[clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/106505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/106505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

https://github.com/vitalybuka requested changes to this pull request. Before looking into details, may I ask you to: 1. Re-base 2. address or reply to existing comments 3. click re-request review. Thank you! https://github.com/llvm/llvm-project/pull/105479 __

[clang] [compiler-rt] [llvm] [rtsan][llvm][NFC] Rename sanitize_realtime_unsafe attr to sanitize_realtime_blocking (PR #113155)

vitalybuka wrote: > LGTM - would love some eyes from more established folks to make sure we are > not breaking any bw-compatability foo, and seeing as this spans the tree a > bit. > > Definitely I am for this change, I think the attr is more clear this way, and > we caught it before LLVM 20 w

[clang] [compiler-rt] [llvm] [rtsan][llvm][NFC] Rename sanitize_realtime_unsafe attr to sanitize_realtime_blocking (PR #113155)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/113155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [sanitizer] Document AddressSanitizer security considerations (PR #100937)

https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/100937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

https://github.com/vitalybuka approved this pull request. I can not reproduce linux bot issue with the patch. https://github.com/llvm/llvm-project/pull/80007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

vitalybuka wrote: Can't comment on fuchsia, but buildbot_standard.sh which is mentioned on original review was shutdown for a while. Some steps were moved to buildbot_cmake.sh based bots, I can try those. https://github.com/llvm/llvm-project/pull/80007 __

[clang] [llvm] [SanitizerCoverage] Add gated tracing callbacks support to trace-cmp (PR #113227)

@@ -816,12 +821,30 @@ Value *ModuleSanitizerCoverage::CreateFunctionLocalGateCmp(IRBuilder<> &IRB) { return Cmp; } +Instruction *ModuleSanitizerCoverage::CreateGateBranch(Function &F, vitalybuka wrote: It would be nice to have a separate NFC patch for extr

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

@@ -15,3 +15,5 @@ documentation setup. If you are writing a package for LLVM, see docs/Packaging.rst for our suggestions. + +Test line. vitalybuka wrote: Why thus change? https://github.com/llvm/llvm-project/pull/113160 __

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/113160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SanitizerCoverage] Add gated tracing callbacks support to trace-cmp (PR #113227)

@@ -1013,19 +1051,10 @@ void ModuleSanitizerCoverage::InjectCoverageAtBlock(Function &F, BasicBlock &BB, ConstantInt::get(IntptrTy, Idx * 4)), PtrTy); if (Options.GatedCallbacks) { - if (!FunctionGateCmp) { -// Create this in the

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

vitalybuka wrote: Actually this PR is the case of https://lab.llvm.org/buildbot/#/builders/164/builds/3908, not https://github.com/llvm/llvm-project/pull/113491 https://github.com/llvm/llvm-project/pull/108357 ___ cfe-commits mailing list cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] Revert "[runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler" (PR #113653)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/113653 Reverts llvm/llvm-project#108357 Breaks https://lab.llvm.org/buildbot/#/builders/164/builds/3908 and similar bots >From bcc6c988acdd2e6fba38f373abc3e090b3b70581 Mon Sep 17 00:00:00 2001 From: Vitaly Buka

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

vitalybuka wrote: > I know @kees feels strongly that this should be the other way around: > Instrument _everything_ by default (which would eliminate the need for > filterlist integration entirely) and exclude things from instrumentation with > `wraps`. My intuition is that @kees approach cou

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

vitalybuka wrote: Thanks! https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ubsan] Suppression by type for `-fsanitize=enum` (PR #114754)

https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/114754 Similar to #107332. >From 87b84e1b1bb7115594e10fcea69db76ac5bcc050 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 4 Nov 2024 00:22:52 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

vitalybuka wrote: @JustinStitt Can't assign you as reviewer, but please take a look https://github.com/llvm/llvm-project/pull/114754 https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

@@ -67,9 +67,11 @@ types specified within an ignorelist. int a = 2147483647; // INT_MAX ++a;// Normally, an overflow with -fsanitize=signed-integer-overflow } + vitalybuka wrote: Please do unrelated fixes in separate PRs. https://gi

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

vitalybuka wrote: > @vitalybuka > > > Is "Test documentation build" error related? > > I am noticing this documentation build failing in other [un-related Clang > patchsets](https://github.com/llvm/llvm-project/actions/runs/11598884769/job/32295763452?pr=114281) > (related to `ClangFormattedS

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

vitalybuka wrote: Is "Test documentation build" error related? https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

vitalybuka wrote: > @vitalybuka Can we move forward with this? The most recent commit uses the > `=sanitize` `=no_sanitize` wording that you prefer. yes, we can you should press "re-request review" after update https://github.com/llvm/llvm-project/pull/107332 __

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -48,6 +49,59 @@ Example $ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ; ./a.out # No error report here. +Usage with UndefinedBehaviorSanitizer += + +The arithmetic overflow sanitizers ``unsigned-integer-overfl

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

https://github.com/vitalybuka deleted https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

https://github.com/vitalybuka requested changes to this pull request. Please don't forget to "re-request" after update, fell free to ping me in chat as well. https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lis

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

https://github.com/vitalybuka approved this pull request. Actually LGTM, Request for doc and test is quite straightforward. No need to block on me. https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -48,6 +49,59 @@ Example $ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ; ./a.out # No error report here. +Usage with UndefinedBehaviorSanitizer += + +The arithmetic overflow sanitizers ``unsigned-integer-overfl

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

@@ -48,6 +48,64 @@ Example $ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ; ./a.out # No error report here. +Usage with UndefinedBehaviorSanitizer += + +The arithmetic overflow sanitizers ``unsigned-integer-overfl

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

vitalybuka wrote: > Right, while I want to go full instrumentation, it's just not going to happen > in the Linux kernel. We're going to need both options so that we can slowly > overlap coverage until we've squeezed out all the unexpected wrap-around. That was just my 2c. Linux decision about

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

@@ -8710,3 +8710,103 @@ Declares that a function potentially allocates heap memory, and prevents any pot of ``nonallocating`` by the compiler. }]; } + +def WrapsDocs : Documentation { + let Category = DocCatField; + let Content = [{ +The ``wraps`` attribute can be used wit

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

@@ -433,6 +433,26 @@ Attribute Changes in Clang - Fix a bug where clang doesn't automatically apply the ``[[gsl::Owner]]`` or ``[[gsl::Pointer]]`` to STL explicit template specialization decls. (#GH109442) +- Introduced ``__attribute__((wraps))`` which can be added to type

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

https://github.com/vitalybuka commented: I guess we already discussed that before. My preference is the wrap and sanitize attributes are interdependent. Open to be convinced otherwise. But seems like we want consistency with https://godbolt.org/z/crhdaczx1 * `__attribute__((wraps,no_sanitize("

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/115094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

@@ -8710,3 +8710,103 @@ Declares that a function potentially allocates heap memory, and prevents any pot of ``nonallocating`` by the compiler. }]; } + +def WrapsDocs : Documentation { + let Category = DocCatField; + let Content = [{ +The ``wraps`` attribute can be used wit

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

@@ -8710,3 +8710,103 @@ Declares that a function potentially allocates heap memory, and prevents any pot of ``nonallocating`` by the compiler. }]; } + +def WrapsDocs : Documentation { + let Category = DocCatField; + let Content = [{ +The ``wraps`` attribute can be used wit

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/115094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] add wraps and no_wraps attributes (PR #115094)

vitalybuka wrote: I am comfortable accepting sanitization related stuff, and will be happy to look into implementation details. To me this approach is LGTM, but this patch goes beyond sanitizers into the area of tuning behavior of UB code, so I think we need feedback from maintainers of the rel

<    4   5   6   7   8   9   10   11   12   13   >