[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. In D134410#3817070 , @xbolva00 wrote: > In D134410#3816918 , @vitalybuka > wrote: > >> I tried to hook this patch into MemorySanitizer and it reduces instrumented >> code by ~30% ! >

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. > Also I applied this patch with D134698 and > used on our large test set, expecting significant number of pre-existing > reports. To my surprise I see not many of them. Something wrong with my msan experiment, I'll re-evaluate size

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

vitalybuka added a comment. It may help with some cases, but still does not guarantee that pointer will not survive in paddings or red-zones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135713/new/ https://reviews.llvm.org/D135713 _

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a reviewer: vitalybuka. vitalybuka added a comment. In D134410#3817190 , @vitalybuka wrote: >> Also I applied this patch with D134698 >> and used on our large test set, expecting significant number of

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. In D134410#3860646 , @xbolva00 wrote: >> I assume with this patch landed, many such cases may change code behavior. >> So we will need to update msan to have a tool to detect cases like this >> anyway. > > I believe that upda

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. Comment at: clang/lib/CodeGen/CGExpr.cpp:1746 + if (auto TyPtr = Ty.getTypePtrOrNull()) { +if (!(TyPtr->isSpecificBuiltinType(BuiltinType::UChar) || Taking into account potantial risks from pre-existing UB, I believe we need

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Introduces memory bugs: https://lab.llvm.org/buildbot/#/builders/5/builds/30234 https://lab.llvm.org/buildbot/#/builders/236/builds/1556 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137838: [Support] Move TargetParsers to new component

vitalybuka added a comment. This bot is broken after the patch https://lab.llvm.org/buildbot/#/builders/236/builds/1480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

vitalybuka added subscribers: fmayer, vitalybuka. vitalybuka added a comment. FYI @fmayer Probably this patch https://lab.llvm.org/buildbot/#/builders/237/builds/350/steps/13/logs/stdio -- Testing: 66920 tests, 48 workers -- Testing: 0.. 10.. 20 FAIL: Clang :: SemaCXX/sugar-common-types.c

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:777 // Enable aliases as they should have no downside with ODR indicators. -UsePrivateAlias(UseOdrIndicator || ClUsePrivateAlias), -UseOdrIndicator(UseO

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

vitalybuka added a comment. In D137381#3924698 , @lebedev.ri wrote: > Can someone from @Sanitizers please comment? :) @vitalybuka ? @glider ? > @rsmith ? > > In D137381#3923911 , @MaskRay wrote: > >> I think im

[PATCH] D137992: [asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

vitalybuka added a subscriber: kstoimenov. vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1256 if (AsanOutlineInstrumentation) { CmdArgs.push_back("-mllvm"); CC @kstoimenov it's maybe not the best name for flag, but t

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/GwpAsan.rst:174 ++-++

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka updated this revision to Diff 494999. vitalybuka added a comment. as reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang/AST/ASTContext.h clang/include/clang

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/37/builds/19499 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 ___ cfe-commits mailing lis

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

vitalybuka added a comment. Fails on this bot https://lab.llvm.org/buildbot/#/builders/5/builds/30884/steps/13/logs/stdio https://reviews.llvm.org/D142233 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:34 + +static void expandKernelSanitizerMasks(SanitizerMask *Mask) { + if (*Mask & (SanitizerKind::Address | SanitizerKind::KernelAddress)) Prefer return value to output paramet

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2100 +GlobalVariable *Metadata = CreateMetadataGlobal( +M, Initializer, llvm::demangle(std::string(G->getName(; was this demanded before? ==

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added a comment. The rest is LGTM Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-72 + if (FsanitizeArgument.has(SanitizerKind::Address) && !Meta.NoAddress) { IsDynInit &= !CGM.isInNoSanitizeList(SanitizerKind::Address |

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME: Metadata should be attched directly to the global directly instead - // of being

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. all stuff under llvm/... here needs testing, Bitcode and AsmParser have many tests usable as examples Also probably better to separate from clang changes: Patch 1: extends LL

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

vitalybuka added a comment. In D124699#3549191 , @kstoimenov wrote: > This change is breaking memory sanitizer in some cases. We observed that > when the argument is not actually removed the pass is dropping the noundef > attribute. See the diff snipp

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

vitalybuka added subscribers: browneee, vitalybuka. vitalybuka added a comment. This patch breaks msan bots: https://lab.llvm.org/buildbot/#/builders/5/builds/24307 and https://lab.llvm.org/buildbot/#/builders/74 https://lab.llvm.org/buildbot/#/builders/5/builds/24335 is (last green build http

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:429 + // Extra sanitizer attributes that are used for global variables (GV's). + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, it should be next to other kw_ s

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Can you please rebase this patch onto others two? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.ll

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:181 #define GET_ATTR_NAMES #define ATTRIBUTE_ENUM(ENUM_NAME, DISPLAY_NAME) \ kw_##DISPLAY_NAME, Have you considered in Attributes.inc ? /// Can be used as global attribute.

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added a comment. LGTM, with Asm test and bitcode stuff moved as explained. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 ___ cfe-commits mailing li

[PATCH] D127145: [Driver] add -lresolv for all but Android.

vitalybuka added a comment. yes, however I have no idea if we need !TC.getTriple().isOSFreeBSD() !TC.getTriple().isOSNetBSD() !TC.getTriple().isOSOpenBSD()) etc. I guess if make mistake it will be noticed and fixed. Please update clang/test/Driver/sanitizer-ld.c Repository: rG LLVM Gi

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/GlobalValue.h:329 +} +void deserialize(unsigned V) { + if (V & (1 << 0)) NoSanitize = true; vitalybuka wrote: > serialization should not be in this header, this bit stuff is /Bitcode/

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:397 + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, + // GV's with __attribute__((no_sanitize("address"))). do we need no_sanitize on IR level? We should map i

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka updated this revision to Diff 434947. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/Sanitiz

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka updated this revision to Diff 434955. vitalybuka added a comment. fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/include/llvm/AsmParser/LLParser.h llvm/include/llvm/

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka updated this revision to Diff 434956. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/Sanitiz

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added a comment. I simplified this a little bit, but I guess this is effectively the same. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if (NoSaniti

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

vitalybuka added a comment. Why do we want this as a separate -fsanitize= Maybe better to have some modifier flag like -fsanitize-memtag-globals=1 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 __

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

vitalybuka added a comment. In D127163#3564919 , @hctim wrote: > We already have `-fsanitize=memtag` that implies `-fsanitize=memtag-heap` and > `-fsanitize=memtag-stack`. > > It makes the most sense IMHO in the world where we want heap MTE. > `-fsaniti

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added a comment. In D126929#3567491 , @hctim wrote: > Update. Sorry if it want clear that I some changes. You undone my snapshot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1389 + + if (GV.hasSanitizerMetadata()) +Vals.push_back(serializeSanitizerMetadata(GV.getSaniti

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added a comment. No need to recover my snapshot, I'll just comment here. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:20 +using GlobalVariable = llvm::GlobalVariable; +using GVSanitizerMetadata = GlobalVariable::SanitizerMetadata; Seems inco

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:55 + + bool IsExcluded = CGM.isInNoSanitizeList(GV, Loc, Ty); + IsExcluded |= (NoSanitizeMask == SanitizerKind::All); vitalybuka wrote: > it can be in some weird ubsan check i

[PATCH] D145214: [TSAN] add support for riscv64

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SAN

[PATCH] D148654: Modify BoundsSan to improve debuggability

vitalybuka resigned from this revision. vitalybuka added a comment. I assume we moved to https://github.com/llvm/llvm-project/pull/65972 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. In D159167#4651325 , @lhames wrote: > @vitalybuka If we want to disable this test for now, what's the canonical way > to do it? Should we just wrap the whole `add_clang_unittest` block in the > conditional? > > # export_exe

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. In D153536#4576683 , @aaron.ballman wrote: > In D153536#4571435 , @vitalybuka > wrote: > >>> Thanks! We might need someone from clangd to help here. The logs do not >>> have any info

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); There is a leak here https://lab.llvm.org/buildbot/#/builders/5/builds/3572

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added a comment. Not sure why the similar code above does not leak, so I will revert and leave to author to investigate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); vitalybuka wrote: > There is a leak here https://lab.llvm.org/buildbot/#/bu

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

vitalybuka added a comment. Breaks the bot https://lab.llvm.org/buildbot/#/builders/74/builds/21336/steps/13/logs/stdio Please take a look or revert? Note: msan_track_origins step may have useful details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

vitalybuka added a comment. Reverted with D155568 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing lis

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944 Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4565993 , @jroelofs wrote: > In D157119#4564546 , @vitalybuka > wrote: > >> I suspect one of your recent changes broke >> https://lab.llvm.org/buildbot/#/builders/168/build

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. > How to reproduce locally: > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Does not reproduce on my workstation too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569725 , @jroelofs wrote: > Flaky test? Here's a later build where it succeeds, but the change has > nothing to do with clangd: > https://lab.llvm.org/buildbot/#/builders/168/builds/14997 No, I manually requested

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

vitalybuka added a comment. In D157119#4569967 , @vitalybuka wrote: > In D157119#4569725 , @jroelofs > wrote: > >> Flaky test? Here's a later build where it succeeds, but the change has >> nothing to do with cl

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Not sure what is wrong there, probably the test need to be updated. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. In D153536#4570534 , @aaron.ballman wrote: > In D153536#4570513 , @vitalybuka > wrote: > >> This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997 >> Not sure wha

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. Not a test update The second line of the test triggers: RUN: not --crash clangd -lit-test -sync=0 < %s 2> %t.async.err == Signalled while building preamble Filename: ===

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

vitalybuka added a comment. > Thanks! We might need someone from clangd to help here. The logs do not have > any information explaining what's failing with the test, and looking at the > test code, I struggle to see how these changes would impact that test. We've > had some significant issues w

[PATCH] D148654: Modify BoundsSan to improve debuggability

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:47 #include "llvm/Transforms/Utils/SanitizerStats.h" #include this file and BoundsChecking.cpp belong to different patches Comment at: clang/lib/CodeGen/CGExpr.cpp:

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. This breaks https://lab.llvm.org/buildbot/#/builders/5/builds/36614 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://reviews.llvm.org/D159167 ___ cfe-commits

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. In D159167#4645214 , @vitalybuka wrote: > This breaks https://lab.llvm.org/buildbot/#/builders/5/builds/36614 I landed b4b4d8bd61d8de946e130beff5049a4ab13e155d

[PATCH] D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests

vitalybuka added a comment. Also maybe it's cleaner just disable a particular test (binary or test case) with incompatible sanitizer. Leaving this up to @lkail or @v.g.vassilev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159167/new/ https://revi

[PATCH] D148654: Modify BoundsSan to improve debuggability

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3576-3597 +if (TrapBBs.size() <= CheckHandlerID) + TrapBBs.resize(CheckHandlerID + 1); +llvm::BasicBlock *&TrapBB = TrapBBs[CheckHandlerID]; + +if (!CGM.getCodeGenOpts().OptimizationLevel

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. It's more convenient if you upload new patches into original review and reland that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 __

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Could this be related https://lab.llvm.org/buildbot/#/builders/127/builds/54239 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 _

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Reverted. Please continue on original review: `arc diff HEAD^ --revision D157632` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 _

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

vitalybuka added a comment. Reverted cd591e02d4563d4b90792ed5f441e1cf5b30443e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 ___

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

vitalybuka added a comment. In D74094#4633785 , @alexfh wrote: > This commit caused invalid AddressSanitizer: stack-use-after-scope errors in > our internal setup. Trying to create a standalone repro, but so far we think > that the patch is incorrect. @v

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

vitalybuka accepted this revision. vitalybuka added a comment. Can this be landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list

[PATCH] D77189: Bisect autoinit

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77189 Files: clang/lib/CodeGen/CGDecl.cpp Index: clang/lib/CodeGen/CGDecl.cpp =

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

vitalybuka added a comment. LGTM would it be possible to split into 3 patches 1. Instrumentation 2. clang flags stuff 3. compiler-rt test Btw. is this clang formated? Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:482 +Ctor = CreateInitCallsForSecti

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

vitalybuka added inline comments. Comment at: clang/test/Driver/autocomplete.c:49 +// RUN: %clang --autocomplete=-fno-sanitize-coverage=,f | FileCheck %s +// -check-prefix=FNOSANICOVER FNOSANICOVER: func RUN: %clang +// --autocomplete=-fno-sanitize-coverage= | FileCheck %s --

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ Why not to add RUN: s

[PATCH] D77373: Add more -fsanitize=array-bounds tests

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77373 Files: clang/test/CodeGen/bounds-checking.c clang/test/CodeGen/bounds-checking.cpp Index: clang/test/CodeGen/bounds-

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/bounds-checking.c:116 + // CHECK-NOT: @llvm.trap + return (s->t, s->a)[i]; + // CHECK: } C version works even without patch Repository: rG LLVM Gi

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vitalybuka added a reviewer: rsmith. vitalybuka updated this revision to Diff 254728. vitalybuka added a comment. vitalybuka marked 2 inline comments as done. remove debug dump =

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka updated this revision to Diff 254728. vitalybuka added a comment. remove debug dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/boun

[PATCH] D77373: Add more -fsanitize=array-bounds tests

vitalybuka updated this revision to Diff 254729. vitalybuka added a comment. tmp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77373/new/ https://reviews.llvm.org/D77373 Files: clang/test/CodeGen/bounds-checking.c clang/test/CodeGen/bounds-che

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

vitalybuka added a comment. Looks like several independent patches, could you spit them, with descriptions explaining why existing values are not good enough? Could you also add into description test names which switch from FAIL to PASS with your changes. I assume code as-is fails some tests on

[PATCH] D73513: [memtag] Plug in stack safety analysis.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:670 + if (AllocaRange.contains(AS.Use.Range)) { +AS.AI->setMetadata(M.getMDKindID("stack-safe")

[PATCH] D44798: [libFuzzer] Use OptForFuzzing attribute with -fsanitize=fuzzer.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/test/fuzzer/lit.cfg:88 + +config.substitutions.append(('%no_opt_cpp_compiler', + generate_compiler_cmd(is_cpp=True, fuzzer_enabled=Tr

[PATCH] D39445: [clang-fuzzer] Fix incremental builds of the fuzzer

vitalybuka created this revision. Herald added a subscriber: mgorny. Don't use BUILD_IN_SOURCE keep git checkout clean Don't forward CMAKE_GENERATOR as ExternalProject_Add should do it already Reset UPDATE_COMMAND to avoid git checkout updates on each build https://reviews.llvm.org/D39445 Files

[PATCH] D39445: [clang-fuzzer] Fix incremental builds of the fuzzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL317035: [clang-fuzzer] Fix incremental builds of the fuzzer (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D39445?vs=120926&id=121045#toc Repository: rL LLVM https://rev

[PATCH] D37860: [MSan] Enable use-after-dtor instrumentation by default.

vitalybuka added a comment. What is the status of this patch? https://reviews.llvm.org/D37860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:2539 +def fno_omit_frame_pointer : Flag<["-"], "fno-omit-frame-pointer">, Group, + HelpText<"Help to produce better stack traces during debugging">; defm operator_names : BoolFOption<"operator-

[PATCH] D146603: [docs] Document -fomit-frame-pointer

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:2643 + HelpText<"Omit the frame pointer from functions that don't need it. " + "Some stack unwinding cases lik

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added a comment. Usually freezing signatures is not a big concern, we can agree to preserve existing functions. The stuff like ASanStackFrameLayout is the concern. compiler and runtime must agree on data layout. The same for global. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D145040: Add test for Flags.data_flow_trace

vitalybuka updated this revision to Diff 503231. vitalybuka added a comment. test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145040/new/ https://reviews.llvm.org/D145040 Files: compiler-rt/lib/fuzzer/FuzzerDriver.cpp compiler-rt/test/fuzzer

[PATCH] D145040: Add test for Flags.data_flow_trace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67f5b05cdcdc: Add test for Flags.data_flow_trace (authored by yingcong-wu, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145727: [HWASAN][LSAN] Disable tests which don't pass in HWASAN+LSAN mode

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. non-crash ones are probable worth of investigating later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145727/new/ https://reviews.llvm.

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

vitalybuka added inline comments. Comment at: clang/test/Index/crash-recovery-modules.m:14 // REQUIRES: crash-recovery // UNSUPPORTED: libstdcxx-safe-mode // UNSUPPORTED: libstdcxx-safe-mode, hwasan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

vitalybuka added a comment. what is about detect_leaks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145822/new/ https://reviews.llvm.org/D145822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed a reviewer: alekseyshl. vitalybuka added 1 blocking reviewer(s): eugenis. vitalybuka accepted this revision. vitalybuka added a comment. This revision now requires review to proceed. I don't know why HWASAN may required pie, but @eugenis seems confident on D44745

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed 1 blocking reviewer(s): eugenis. vitalybuka added a comment. This revision is now accepted and ready to land. Feel free to land. It works on my arm linux setup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147121/new/ https://re

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150504/new/ https://reviews.llvm.org/D150504 __

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 __

[PATCH] D148573: Allow -fsanitize=function on all targets

vitalybuka added a comment. These bots are broken after the patch https://lab.llvm.org/buildbot/#/builders/77/builds/26834 https://lab.llvm.org/buildbot/#/builders/18/builds/9073 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148573/new/ https://rev

[PATCH] D150504: [AST] Construct Capture objects before use

This revision was automatically updated to reflect the committed changes. Closed by commit rG8826cd57825d: [AST] Construct Capture objects before use (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150504/new/ https://reviews

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

<    1   2   3   4   5   6   7   8   >