vitalybuka added inline comments.
================
Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:55
+
+ bool IsExcluded = CGM.isInNoSanitizeList(GV, Loc, Ty);
+ IsExcluded |= (NoSanitizeMask == SanitizerKind::All);
----------------
vitalybuka wrote:
> it can be in some weird ubsan check ignore list, and this way it will
> propagate on asan/hwasan
> I don't think you can avoid extending isInNoSanitizeList (in a separate patch)
you you can introduce:
```
bool CodeGenModule::isInNoSanitizeList(SanitizerMask Kind, llvm::GlobalVariable
*GV,
SourceLocation Loc) const {
```
similar to
```
bool CodeGenModule::isInNoSanitizeList(SanitizerMask Kind, llvm::Function *Fn,
SourceLocation Loc) const {
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126929/new/
https://reviews.llvm.org/D126929
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
