[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

vitalybuka added a comment. @python3kgae 0fbafb5a1c4381ded4bc7f59a5a6091c229faed7 is fixing leaks in this tests. Note, the leak was missed because of unrelated issues in gtest and lsan setup which we fixed recently. I incor

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added a comment. I am not sure what to do with this patch. I really prefer to avoid it to minimize the risk of regressions. We probably considered/prototyped to insert starts like in this solution then in 2016. But at the time of the solution was a comment by @rsmith https://reviews

[PATCH] D122869: [lit] Fix setup of sanitizer environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd33c36235df1: [lit] Fix setup of sanitizer environment (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

vitalybuka added a comment. Compilation fails with this patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22936/steps/bootstrap%20clang/logs/stdio [ 8%] Built target LLVMMC /b/sanitizer-x86_64-linux/build/llvm/lib/Support/regcomp.c:541:2: error: unannotated fall-through

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGE

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka updated this revision to Diff 216991. vitalybuka added a comment. return hwasan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66695/new/ https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFu

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka updated this revision to Diff 216992. vitalybuka added a comment. fix compilation error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66695/new/ https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/C

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

vitalybuka updated this revision to Diff 216994. vitalybuka added a comment. update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66695/new/ https://reviews.llvm.org/D66695 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenF

[PATCH] D66697: hwasan, codegen: Keep more lifetime markers used for hwasan

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added a project: clang. Herald added a subscriber: cfe-commits. vitalybuka added a parent revision: D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan. Repository: rG LLVM Github Monorepo h

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

This revision was automatically updated to reflect the committed changes. Closed by commit rL369979: msan, codegen, instcombine: Keep more lifetime markers used for msan (authored by vitalybuka, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.

[PATCH] D66697: hwasan, codegen: Keep more lifetime markers used for hwasan

This revision was automatically updated to reflect the committed changes. Closed by commit rL369980: hwasan, codegen: Keep more lifetime markers used for hwasan (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:13 +-DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} +-DCMAKE_BUILD_TYPE=Debug + BUILD_COMMAND ${CMAKE_MAKE_PROGRAM} Why this is debug? Comment at: clan

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/tools/clang-fuzzer/CMakeLists.txt:12 +# Hack to bypass LLVM's cmake sources check and allow multiple libraries and +# executables from this directory. +set(LLVM_OPTIONAL_SOURCES morehouse wrote: > v

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/tools/clang-fuzzer/ClangFuzzer.cpp:20 extern "C" int LLVMFuzzerTestOneInput(uint8_t *data, size_t size) { std::string s((const char *)data, size); morehouse wrote: > morehouse wrote: > > vitalybuka wrote:

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/tools/clang-fuzzer/cxx_proto.proto:17 +syntax = "proto2"; +//option cc_api_version = 2; + >> //option cc_api_version = 2; Please remove Comment at: clang/tools/clang-fuzzer/proto-to-cxx/CMakeL

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:6 + +ExternalProject_Add(${PBM_PREFIX} + PREFIX ${PBM_PREFIX} Just noticed, for cmake projects shorter syntax can be used. Example: https://github.com/google/libprotobuf-mut

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:559 // trace-pc w/o func/bb/edge implies edge. if ((CoverageFeatures & Extract if (!(CoverageFeatures & InsertionPointTypes)) { } Comment at: clang/l

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D36882: [clang-proto-fuzzer] Allow user-specified compiler arguments.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:33 + for (I = 1; I < *argc; I++) +if (llvm::StringRef((*argv)[I]).equals("-ignore_remaining_

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. In D68115#1819418 , @aaron.ballman wrote: > In D68115#1811091 , @lebedev.ri > wrote: > > > In D68115#1811089 , > > @hubert.reinterpretcast wrot

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. In D68115#1820579 , @aaron.ballman wrote: > In D68115#1820462 , @vitalybuka > wrote: > > > I would be happy to finish this patch if we agree on something. > > > > So if I understand thi

[PATCH] D81703: [Clang] Don't leave Expr::Classification fields uninitialized in default constructor

vitalybuka added a comment. Compiler warning should already catch this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81703/new/ https://reviews.llvm.org/D81703 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e614b0c7ed3: [NFC][MSan] Round up OffsetPtr in PoisonMembers (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added a subscriber: kcc. vitalybuka added a comment. I've chatted about that with @kcc and @eugenis . It seems the problem the patch is trying to solve is less important than regressions. Even with the current state when rare false ODR reports are possible it still useful. It would be

[PATCH] D91061: Move the test compiler setup in a common place. NFCI

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted because of memory leaks: http://lab.llvm.org:8011/#/builders/5/builds/1262 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91061/

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

vitalybuka added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:455-520 +#if SANITIZER_SOLARIS +// dlpi_tls_modid is only available since Solaris 11.4 SRU 10. Use +// dlinfo(RTLD_DI_LINKMAP) instead which works on both Solaris 11.3 and

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

vitalybuka added a comment. Other than file issue, compiler-rt part is LGTM leaving the rest to @MaskRay Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:455-520 +#if SANITIZER_SOLARIS +// dlpi_tls_modid is only available since Solaris 11.4 SRU 10. Use

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added a comment. https://reviews.llvm.org/D55156 So with this patch no code increase but we lose ODR checks. To preserve checks we need -fsanitize-address-use-odr-indicator but then binary size increase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added a comment. alias change is LGTM, we can try to figure-out how to roll out -fsanitize-address-use-odr-indicator Comment at: compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp:5 +// RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared -mllvm -asan-use-priva

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added inline comments. Comment at: compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp:4-5 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared %s -o %dynamiclib1 -// RUN: %clangxx_asan -fno-rtti -DBUILD_SO2 -fPIC -shared %s -o %dynamiclib2 +// RUN: %clangxx_a

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

vitalybuka created this revision. vitalybuka added reviewers: eugenis, morehouse. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Such fields will likely have offset zero making __sanitizer_dtor_callback poisoning wrong regions.

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembersgetFieldOffset(layoutStartOffset) for current calleds is expected topoint to the first trivial field or the one which follows non-trivial

vitalybuka created this revision. vitalybuka added reviewers: morehouse, eugenis. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...withoutassumptions about callers. This patch will avoid the need in suchassumptions. Depends o

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e1cb0db8a79: [CodeGen][MSan] Don't use offsets of zero-sized fields (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers

vitalybuka added a comment. In D92728#2437506 , @eugenis wrote: > Don't you want to similarly align down PoisonEnd? > > But if this is something that should never happen, as your comment rightly > suggests, wouldn't it be better to add an assert()? > The

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but it could be better with a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80488/new/ https://reviews.llvm.org/D80488 _

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO: Use

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO: Use

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1551 +def fexperimental_sanitize_hwaddress_aliasing + : Flag<["-"], "fexperimental-sanitize-hwaddress-aliasing">, +Group, Please switch to fsanitize-hwaddress-experimental-al

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM Comment at: compiler-rt/test/hwasan/lit.site.cfg.py.in:10 +# Whether to use -mlam or not. +config.enable_aliases = lit_config.params.get("ENABLE_ALIASES", "@ENA

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

vitalybuka added a comment. Would you mind to add compiler-rt/test/asan which triggers this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 ___ cfe-commits

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556-2559 + // Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is at +

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added a comment. Would you mind to clang-format entire existing compiler-rt/test/scudo/ and than rebase this patch on top? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 __

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka updated this revision to Diff 345967. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added inline comments. Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) -set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) +set(ALL_SCUDO_STANDALONE_SUPPOR

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka updated this revision to Diff 345975. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC + SCUDO_STANDALONE_TEST_TAR

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556 + uint64_t RZ = 0; + if (SizeInBytes < MinRZ / 2) { +// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is MaskRay wrote: > I wo

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

vitalybuka added a comment. Do you need help with landing thin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. So I will hide it from "Ready to Review" list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757-760 +bool HaveSanitizeCoverage = +CGM.getCodeGenOpts().SanitizeCoverageType || +CGM.getCodeGenOpts().SanitizeCoverageIndirectCalls || +

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:192 + +void HandleTagMismatch(AccessInfo ai, uptr pc, uptr frame, + void *uc, uptr *registers_

[PATCH] D95166: Disable rosegment for old Android versions.

vitalybuka added a comment. Out Android build bot is broken after this patch http://lab.llvm.org:8011/#/builders/77/builds/3234 Run Build Command(s):/usr/bin/ninja cmTC_578f8 && [1/2] Building C object CMakeFiles/cmTC_578f8.dir/testCCompiler.c.o [2/2] Linking C executable cmTC_578f8 FAILE

[PATCH] D110880: [msan] Remove StackTrace::tag

vitalybuka updated this revision to Diff 376351. vitalybuka added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110880/new/ https://reviews.llvm.org/D11

[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

vitalybuka created this revision. Herald added subscribers: steven_wu, hiraditya, inglorion. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Distributed ThinLTO has special case when backend fallback to regular non-ThinLTO versio

[PATCH] D96328: [Clang, NewPM] Add KMSan support

vitalybuka created this revision. vitalybuka added reviewers: glider, eugenis. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D96320 . Repository: rG LLVM Github Monorepo https://

[PATCH] D96328: [Clang, NewPM] Add KMSan support

vitalybuka updated this revision to Diff 322643. vitalybuka added a comment. simplify test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96328/new/ https://reviews.llvm.org/D96328 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Driver/msan

[PATCH] D96406: [Msan, NewPM] Reduce size of msan binaries

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. EarlyCSEPass called after msan redices code size by about 10%. Similar optimization exists for legacy pass ma

[PATCH] D96412: [ThinLTO, NewPM] Call OptimizerLastEPCallbacks after Prelink

vitalybuka created this revision. vitalybuka added reviewers: aeubanks, tejohnson, eugenis. Herald added subscribers: steven_wu, hiraditya, inglorion. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. -O0 ThinLTO

[PATCH] D96328: [Clang, NewPM] Add KMSan support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6051f52acf5: [Clang, NewPM] Add KMSan support (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D96328?vs=322643&id=322

[PATCH] D96456: [ThinLTO] Add Config::OptPassBuilderHook

vitalybuka created this revision. Herald added subscribers: steven_wu, hiraditya, inglorion. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang needs to register sanitizer at OptimizerLastEPCallback. Nowever

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka added a comment. Test will follow if you agree with approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 ___ cfe-commits mailing list cfe-commits@

[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

vitalybuka added a comment. In D96320#2554493 , @aeubanks wrote: > This seems like the wrong fix to me. > ThinLTO only runs the simplification pipeline pre-link, then runs it again > plus the optimization pipeline. The optimization pipeline is the only pl

[PATCH] D96481: [NFC] Extract function which registers sanitizer passes

vitalybuka created this revision. vitalybuka added reviewers: aeubanks, tejohnson. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96481 Files: clang/lib/CodeGen

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 322924. vitalybuka marked an inline comment as done. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/Ba

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 322934. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-di

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1549 + Conf.OptPassBuilderHook = [&](PassBuilder &PB) { +addSanitizers(TargetTriple, CGOpts, LOpts, PB); + }; tejohnson wrote: > I can't find where this is defined. to avoid noi

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 322935. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-

[PATCH] D96481: [NFC] Extract function which registers sanitizer passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2f59d2a0607: [NFC] Extract function which registers sanitizer passes (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96406: [Msan, NewPM] Reduce size of msan binaries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG686b65f85f22: [Msan, NewPM] Reduce size of msan binaries (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D96406?vs=322

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 323202. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/Ba

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1328 +CodeGenOpts.ThinLTOIndexFile.empty()) { + // This is testing distributed ThinLTO PostLink. O0 called optimized in + // PreLink. tejohnson wrote: > I don't unde

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1328 +CodeGenOpts.ThinLTOIndexFile.empty()) { + // This is testing distributed ThinLTO PostLink. O0 called optimized in + // PreLink. vitalybuka wrote: > tejohnson w

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, What is the difference between the

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Po

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added a comment. >> FWIW I would prefer denylist as well. (Also uses of whitelist should be >> allowlist, but also incremental :) I feel like existing and proposed value do match the meaning of this list. maybe ignorelist, skiplist (can be confused with data structure?), or just asan

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka added a comment. This patch is relatively recent. I'd like to revert this for D96203 Can we user just pointo to /dev/null if file is not needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79043/new/

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added a comment. In D96203#2559792 , @mibintc wrote: > In D96203#2559426 , @vitalybuka > wrote: > FWIW I would prefer denylist as well. (Also uses of whitelist should be allowlist, but also in

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reopen to attract attention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79043/new/ https://reviews.llvm.org/D79043 __

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/SanitizerBlacklist.h:20 #include #include This file should go into a separate patch. It touches multiple files with simple changes but unlikely will case rollback. It's unrelated to mo

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, delcypher wrote: > delcypher wrote

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka added a comment. In D79043#2560867 , @aganea wrote: > In D79043#2560710 , @vitalybuka > wrote: > >> This patch is relatively recent. I'd like to revert this for D96203 >>

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324171. vitalybuka marked 4 inline comments as done. vitalybuka added a comment. fix language Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/Code

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324173. vitalybuka added a comment. undo CodeGenOpts.ThinLTOIndexFile.empty() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Po

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka resigned from this revision. vitalybuka added a comment. LGTM, but leaving for others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits m

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Po

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka updated this revision to Diff 324526. vitalybuka edited the summary of this revision. vitalybuka added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. restore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka added a comment. I recovered this patch as PreLink alternative to D96456 . Short term either of them will fix internal google builds. Long term D96320 is going to be easier to maintain, e.g. if other users, without d

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka updated this revision to Diff 324527. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Driver/asan.c cl

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324528. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-di

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka updated this revision to Diff 324529. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-di

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Po

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Basic/Sanit

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Ba

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka updated this revision to Diff 325895. vitalybuka marked an inline comment as done. vitalybuka added a comment. rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320 Files: clang/lib/C

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka abandoned this revision. vitalybuka added a comment. in favor of D96320 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 _

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8560c2d4268c: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from… (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added a comment. Could you please rebase the patch onto D96974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 ___ cf

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

vitalybuka added a comment. In D103845#2804441 , @pcc wrote: > This isn't how the output looks on Android. Are you sure this isn't a > Fuchsia-specific bug in the output formatting? I don't see from the code how android can insert \n if SymbolizePC fail

[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:171 } // namespace __hwasan +#else // #if !SANITIZER_FUCHSIA +namespace __hwasan {

<    1   2   3   4   5   6   7   8   >