[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 +std::optional +firstMatchedProvider(const include_cleaner::Includes &Includes, + llvm::ArrayRef Providers); kadircet wrote: > can you

[PATCH] D151073: [clang] Fix label (de-)serialization in ASM statements.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151073 Files: clang/lib/Serialization/ASTReaderStmt.cpp

[PATCH] D151073: [clang] Fix label (de-)serialization in ASM statements.

VitaNuo updated this revision to Diff 524211. VitaNuo added a comment. Remove template param. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151073/new/ https://reviews.llvm.org/D151073 Files: clang/lib/Serialization/ASTReaderStmt.cpp clang/lib

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 524336. VitaNuo marked 19 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-to

[PATCH] D151073: [clang] Fix label (de-)serialization in ASM statements.

VitaNuo updated this revision to Diff 524342. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151073/new/ https://reviews.llvm.org/D151073 Files: clang/lib/Serial

[PATCH] D151073: [clang] Fix label (de-)serialization in ASM statements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b50e87f21e1: [clang] Fix label (de-)serialization in ASM statements. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo updated this revision to Diff 525477. VitaNuo added a comment. VitaNuo updated this revision to Diff 525560. VitaNuo updated this revision to Diff 525566. VitaNuo updated this revision

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 525581. VitaNuo added a comment. Move the speller out of the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 526064. VitaNuo marked 13 inline comments as done. VitaNuo added a comment. Rework according to the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 F

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Thanks for the comments! I'll re-assign the review to Haojian for now, so that we can hopefully make more progress this week. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:48 +void Inclu

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 526558. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 526610. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-too

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:104 + ApplyFirstIncludeSpeller() { +for (const auto &Strategy : + include_cleaner::IncludeSpellingStrategy::entries()) { --

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 526615. VitaNuo added a comment. Remove extra braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527001. VitaNuo marked 25 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-to

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:86 + llvm::SmallVector MainFileDecls; + for (auto *D : Result.Nodes.getNodeAs("top")->decls()) { +SourceLocation Loc = D->getLocation(); ---

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527314. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Herald added a subscriber: ormris. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.l

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527317. VitaNuo added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt cla

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:88 +class IncludeSpeller { +public: hokein wrote: > hokein wrote: > > I think this is an important API (we will create a subclass for our > >

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527329. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-too

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:88 +SourceLocation Loc = D->getLocation(); +if (!SM->isWrittenInMainFile(SM->getSpellingLoc(Loc))) + continue; hokein wrote: > V

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527330. VitaNuo added a comment. Update test name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527359. VitaNuo added a comment. Try to fix windows test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527369. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove system-independent handling to see behavior on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://review

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527376. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove the regular expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: cla

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527384. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove regex and path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: cl

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527385. VitaNuo added a comment. Remove regex and path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527392. VitaNuo marked an inline comment as done. VitaNuo added a comment. Add debug statements for windows debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527402. VitaNuo added a comment. Remove debug statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527412. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 ___ cfe-commits mail

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527420. VitaNuo added a comment. Remove extra path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527435. VitaNuo added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Includ

[PATCH] D151895: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527438. VitaNuo added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Includ

[PATCH] D151895: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo abandoned this revision. VitaNuo added a comment. Herald added a subscriber: ormris. Created by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151895/new/ https://reviews.llvm.org/D151895 ___

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527446. VitaNuo added a comment. Fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cl

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527447. VitaNuo added a comment. Add newline at file end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527448. VitaNuo added a comment. Add newline at file end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527451. VitaNuo added a comment. Remove extra include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527452. VitaNuo added a comment. Remove newline at file end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527457. VitaNuo added a comment. Re-introduce special path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeL

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527466. VitaNuo added a comment. Fix windows test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527473. VitaNuo added a comment. Try to fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527509. VitaNuo added a comment. Try ignoring verbatim spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527543. VitaNuo added a comment. Fix last test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tool

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527545. VitaNuo added a comment. Undo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/c

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527554. VitaNuo added a comment. Experiment with paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt cl

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527583. VitaNuo added a comment. Undo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/c

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527812. VitaNuo added a comment. Escape the slashes in regex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.tx

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527822. VitaNuo added a comment. Remove path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt cla

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527839. VitaNuo added a comment. Re-introduce path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527872. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-too

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc28506ba4b69: [clang-tidy] Implement an include-cleaner check. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://revi

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 495516. VitaNuo added a comment. Undo turning spellHeader method public. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 495517. VitaNuo added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 495545. VitaNuo added a comment. Add header spelling to fix suggestion. Fix range to only underline the symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files:

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D143635: [clangd] Refactor new include cleaner functionality into a separate class.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D143663: [clangd] Show used symbols on hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 496460. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 496463. VitaNuo added a comment. Expose API for lookup instead of retrieving the whole map. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo added a comment. Thanks for review! Comment at: clang-tools-extra/clangd/Headers.h:164 + llvm::StringMap> + buildMainFileIncludesBySpelling() const { +llvm::StringMap> BySpelling; kadircet wrote: > instead of building this on-demand, what about bu

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 497349. VitaNuo marked 9 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-too

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thank you for the comments! I've addressed (almost) all of them. In some places, I'm not so happy about how the code has become very nested, but I don't have ideas on how to make it better atm. Comment at: clang-tools-extra/clangd/Config.h:91 + enu

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 497602. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-too

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Headers.cpp:76 +Out->MainFileIncludesBySpelling.try_emplace(Inc.Written) +.first->second.push_back(static_cast(*Inc.HeaderID)); } kadircet wrote: > r

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 498401. VitaNuo marked 14 inline comments as done. VitaNuo added a comment. Herald added a subscriber: ChuanqiXu. Address review comments. Make diagnostics symref-centered and attach them to each reference. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the extensive explanations! See the updated version, it should also take the discussions on the document into account. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:512 +include_cleaner::Includes +convertIncludes(const SourceManage

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 498419. VitaNuo added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/cl

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 ___ cfe-commits mail

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 498428. VitaNuo added a comment. Move to source file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extr

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 499436. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-too

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) kadircet wrote: > nit: >

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 499456. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-too

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) kad

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499553. VitaNuo marked 24 inline comments as done. VitaNuo added a comment. Address review comments (apart from testing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D1434

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! I should have addressed everything apart from testing. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:523 +TransformedInc.Angled = WrittenRef.starts_with("<"); +if (auto FE = SM.getFileManager().getFile(Inc.Reso

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499879. VitaNuo marked 18 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-to

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:408 + +bool isFilteredByConfig(const Config &Cfg, llvm::StringRef HeaderSpelling) { + for (auto &Filter : Cfg.Diagnostics.Includes.IgnoreHeader) { kadirce

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499886. VitaNuo added a comment. Upload once again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

This revision was automatically updated to reflect the committed changes. VitaNuo marked an inline comment as done. Closed by commit rGe028c9742897: Move the BySpelling map to IncludeStructure. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499896. VitaNuo added a comment. Merge upstream changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extr

[PATCH] D148793: [WIP][clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 520307. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Herald added a subscriber: arphaman. Move the check from "google" to "misc". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/

[PATCH] D150187: [tidy][IdentifierNaming] Fix crashes on non-identifiers

VitaNuo added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:457 + // Don't keep track for non-identifier names. + if (auto *II = Decl->getIdentifier()) { +return addUsage(RenamerClangTidyCheck::NamingCheckId(Decl->getLocation(), -

[PATCH] D150668: Add doc link to missing include diagnostics.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D150683: [clangd] Tweak "provides" hover card when symbols have the same name

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1539 +Front, [&](llvm::StringRef Sym) { P.appendCode(Sym); }, +[&] { P.appendText(", "); }); if (UsedSymbolNames.size() > Front.size()) { What will this do if `Fron

[PATCH] D150683: [clangd] Tweak "provides" hover card when symbols have the same name

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/clangd/Hover.cpp:1539 +Front, [&](llvm::StringRef Sym) { P.appendCode(Sym); }, +[&] { P.appendText(", "); });

[PATCH] D150668: Add doc link to missing include diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cb2770bd714: Add doc link to missing include diagnostics. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 514901. VitaNuo added a comment. Extract a test for th firstMatchedProvider method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87 +std::optional +firstMatchedProvider(const include_cleaner::Includes &Includes, + llvm::ArrayRef Providers); kadi

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 515227. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e9b1effac34: [clangd] Implement cross reference request for #include lines. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo created this revision. Herald added subscribers: PiotrZSL, ChuanqiXu, kadircet, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-com

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 515322. VitaNuo added a comment. Add a pragma example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-to

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 515323. VitaNuo added a comment. Remove comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-e

[PATCH] D149165: [clangd] Deduplicate missing-include findings

VitaNuo added a comment. Thank you! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:419 }); + // Put possibly equal diagnostics together for deduplication. + // The duplicates might be from macro arguments that get expanded multiple Could you m

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 528315. VitaNuo marked 11 inline comments as done. VitaNuo added a comment. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

<    1   2   3   4   5   >