[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:650-652 +if (S.getLangOpts().CPlusPlus2b) { + if (BlockStart.isInvalid()) +diagExportedUnnamedDecl(S, *UDK, D, BlockStart); Chuanqi

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

tbaeder added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2217 + /// The gloabl module fragment of the current tranlation unit. + clang::Module *GlobalModuleFragmentCache = nullptr; Typos in "gloabl" and "tranlation" in the comment. Any reaso

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

tbaeder added a comment. I just noticed this as well. @arichardson, has there been any work towards a working solution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109611/new/ https://reviews.llvm.org/D109611 ___

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; sbc100 wrote: > Where does `11` come from here? Do o

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 404849. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/lib/Driver/ToolChains/WebAssembly.h clang/test/Driver/wasm-toolchain.cpp Index: clang/t

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; sbc100 wrote: > tbaeder wrote: > > sbc100 wrote: > >

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:445 addSystemInclude(DriverArgs, CC1Args, - getDriver().SysRoot + "/include/c++/v1"); + getDriver().SysRoo

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

tbaeder added a comment. @thakis After re-applying this patch locally, I can't see the breakage you described with the reproducer provided. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109611/new/ https://reviews.llvm.org/D109611 ___

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 404935. tbaeder marked an inline comment as done. tbaeder added a comment. Stop hardcoding `v1` or `11` and make the tests work like that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:544 + + if (Version.empty()) { +// FIXME: Fallback correct? sbc100 wrote: > tbaeder wrote: > > sbc100 wrote: > > > Just early ret

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder updated this revision to Diff 405156. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/lib/Driver/ToolChains/WebAssembly.h clang/test

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 410233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/S

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an arr

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder updated this revision to Diff 410236. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119221/new/ https://reviews.llvm.org/D119221 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Lexer/utf8-char-literal.cpp clang/www/c_sta

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:24 +char g = u8'\x80'; // expected-warning {{implicit conversion from 'int' to 'char' changes value from 128 to -128}} #endif ta

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements N2393. I am a bit confused by the proposal only taking about adding "true" and "fal

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder added inline comments. Comment at: clang/test/Sema/c2x-bool.c:10 +_Static_assert(_Generic(true, bool : true, default: false)); +_Static_assert(_Generic(false, bool : true, default: false)); + Not that clang-format wanted me to format these two lines, but

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

tbaeder created this revision. tbaeder added a reviewer: sbc100. Herald added subscribers: sunfish, jgravelle-google, dschuff. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. As an alternative to https://reviews.llvm.org/D11

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

tbaeder added a comment. @sbc100 Do you think we should add `/backward` as well? `Gnu.cpp` does that it seems: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Gnu.cpp#L2959-L2960 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D120313: [clang][www] Port make_cxx_dr_status script to Python3

tbaeder created this revision. tbaeder added reviewers: rsmith, aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And run it to re-generate the cxx_dr_status.html Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D120313: [clang][www] Port make_cxx_dr_status script to Python3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02571f86bb01: [clang][www] Port make_cxx_dr_status script to Python3 (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D120

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rGf8cedc642d9b: [clang] Never wrap a nullptr in CXXNewExpr::getArraySize() (authored by tbaeder). Repository

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

tbaeder updated this revision to Diff 410544. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120251/new/ https://reviews.llvm.org/D120251 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wasm-toolchain.cpp Index: clang/test/Driv

[PATCH] D120251: [clang][driver][wasm] Fix libstdc++ target-dependent include dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f300d34decb: [clang][driver][wasm] Fix libstdc++ target-dependent include dir (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

tbaeder created this revision. tbaeder added reviewers: kaz7, simoll, aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise, the `// DEF-SAME: "[[RESOURCE_DIR]]/lib/linux/libclang_rt.builtins-ve.a" "-lc"` line e

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

tbaeder added a comment. The failing tests seem all omp related and not about this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120644/new/ https://reviews.llvm.org/D120644 ___ cfe-commits maili

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12d3679256c9: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I noticed that this is basically always unused. And if it is needed, the end of th

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 412714. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder marked an inline comment as done. tbaeder added a comment. In D120888#3359798 , @aaron.ballman wrote: > Thank you for working on this! We've (very) slowly been working towards all > of the attribute parsing functions taking a `ParsedAttributesWi

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 412994. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

tbaeder updated this revision to Diff 413276. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 413279. tbaeder marked 3 inline comments as done. tbaeder added a comment. Thanks for the links to the papers. What's the best way of updating https://clang.llvm.org/c_status.html#c2x with the new papers? I added the changes to `stdbool.h`, but I haven't bee

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113 - Implemented `WG14 N2674 The noreturn attribute `_. - Implemented `WG14 N2418 Adding the u8 character prefix

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b969b0bb53e: [clang][parser] Stop dragging an EndLoc around when parsing attributes (authored by tbaeder). Repository: rG LLVM Github Monorepo C

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I wasn't 100% whether to add the range

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 413744. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/ParsedAttr.h clang/include/clang/Sema/Se

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder added inline comments. Comment at: clang/test/SemaOpenCL/address-spaces.cl:261 typedef __private int private_int_t; - __private __attribute__((opencl_global)) int var1; // expected-error {{multiple address spaces specified for type}} \ + __attribute__((opencl_glob

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

tbaeder added a comment. Herald added a project: All. Hi @qiucf, I'm running into a problem with the testsuite that's caused by this patch. I think the comment from @jsji about newer glibc was never addressed. When running the testsuite on ppc64le with a glibc newer than 2.34, the the warning

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

tbaeder created this revision. tbaeder added reviewers: qiucf, jsji, kbarton. Herald added a subscriber: nemanjai. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As explained in https://reviews.llvm.org

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 413782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Headers/stdbool.h:16 /* Don't define bool, true, and false in C++, except as a GNU extension. */ #ifndef __cplusplus #define bool _Bool aaron.ballman wrote: > We're

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b7941ad7c89: [clang][driver] Fix float128 diagnostics with glibc >= 2.32 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121209/new/ h

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

tbaeder created this revision. tbaeder added a reviewer: rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test case otherwise fails an assertion in Diagnostic::getArgKind(): clang++: /home/tbaeder/code/llvm-project/cl

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

tbaeder updated this revision to Diff 399925. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116595/new/ https://reviews.llvm.org/D116595 Files: clang/lib/Sema/SemaModule.cpp clang/test/Modules/cxx20-export-import.cpp Index: clang/test/Modules/cxx20-export-import.cpp ===

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

tbaeder added inline comments. Comment at: clang/test/Modules/cxx20-export-import.cpp:1-2 + +// RUN: %clang_cc1 -std=c++20 -fmodules -fmodules-cache-path=%t -fimplicit-module-maps -I%S/Inputs -stdlib=libc++ -verify %s +export import dummy; // expected-error {{export declaration

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder created this revision. tbaeder added reviewers: rsmith, aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As part of P1766R1 , allow unname

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder added a comment. Reading this again, it sounds like this is not expected to happen for C++20; I was using https://clang.llvm.org/cxx_status.html#cxx20 as guidance here. Repository: rG LLVM Github Mon

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder updated this revision to Diff 330954. tbaeder added a comment. Dropped the `FORCE` stuff since we can just set the variable directly and that shouldn't make a difference as far was I know. And the warning now only appears if either LTO or LLD are enabled. CHANGES SINCE LAST ACTION ht

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder added a comment. In D89942#2629146 , @beanz wrote: > If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the > configuration and logging a message seems like the wrong move when the only > way to get into that state is to specifically

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder added a comment. Including `CMakeDetermineSystem` gives me: loading initial cache file ../clang/cmake/caches/3-stage.cmake CMake Error: Could not open file for write in copy operation /CMakeSystem.cmake.tmp CMake Error: : System Error: Permission denied CMake Error at /usr/share/

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder updated this revision to Diff 331246. tbaeder added a comment. Here's a version that shells out to `uname -m` to get the arch. Setting both the `_LLD` and `_LTO` variable that often looks a bit odd but I didn't want to use other variables. Can change that of course. CHANGES SINCE LAST

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9ef6bc42643: [clang] Disable LTO and LLD on SystemZ for stage3 builds (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D8

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. John, do you have any more comments on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Thank you. I'm not looking at this test case: void opaque(void); void opaque2(void); void opaque3(void); @class C; int main(int argc, const char * argv[]) { __attribute__((nomerge)) @try { opaque(); } @catch(C *c) { opaque2(); } @f

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder updated this revision to Diff 331817. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 Files: clang/lib/Parse/ParseStmt.cpp clang/test/CodeGenObjC/attr-nomerge.m Index: clang/test/CodeGenObjC/attr-nomerge.m ===

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder updated this revision to Diff 332213. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 Files: clang/lib/Parse/ParseStmt.cpp clang/test/CodeGenObjC/attr-nomerge.m Index: clang/test/CodeGenObjC/attr-nomerge.m ===

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Hmm, the new test seems to cause an assertion failure in llvm code generation in Windows. Is anything known about that? Is the test case wrong in some way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder updated this revision to Diff 332283. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 Files: clang/lib/Parse/ParseStmt.cpp clang/test/CodeGenObjC/attr-nomerge.m Index: clang/test/CodeGenObjC/attr-nomerge.m ===

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder updated this revision to Diff 332539. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 Files: clang/lib/Parse/ParseStmt.cpp clang/test/CodeGenObjC/attr-nomerge.m Index: clang/test/CodeGenObjC/attr-nomerge.m ===

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added a comment. Hey Aaron, do you have any more comments on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc6b139392f6: [clang][parser] Don't prohibit attributes on objc @try/@throw (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Thanks everyone! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added a comment. I'm gonna continue the conversation here if that's ok, the inline comments are rather cramped and confusing. So, I just double-checked this and `Attrs.Range.getBegin()` returns the location of the first `[`, which is correct and not a problem. `Lexer::getRawToken(Attrs

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 332886. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/test/Parser/cxx0x-attributes.cpp

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 332964. tbaeder added a comment. Alright, thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 332966. tbaeder marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith, rjmccall. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sorry for the title, I'm not 100% sure that's even correct here. This call to `ProhibitAttribu

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder updated this revision to Diff 333226. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278 Files: clang/lib/Parse/ParseDeclCXX.cpp Index: clang/lib/Parse/ParseDeclCXX.cpp === -

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are parsing both C++11 and GNU-style attributes here, but the previous `ProhibitAttributes()` call wa

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 333510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/test/Parser/cxx0x-attributes.cpp

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

tbaeder updated this revision to Diff 333511. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99338/new/ https://reviews.llvm.org/D99338 Files: clang/lib/Parse/ParseDecl.cpp Index: clang/lib/Parse/ParseDecl.cpp === --- cla

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder added a comment. This (and https://reviews.llvm.org/D99338) are both NFC changes once https://reviews.llvm.org/D97362 lands (they need the three-parameter version of `ProhibitCXX11Attributes()`). I can merge the three into one patch if you prefer. CHANGES SINCE LAST ACTION https://r

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder added a comment. All the attribute patches are just preparations so I can finally enable the source locations in GNU attributes in https://reviews.llvm.org/D75844. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 334179. tbaeder added a comment. Added the changes from https://reviews.llvm.org/D99338 and https://reviews.llvm.org/D99278 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder abandoned this revision. tbaeder added a comment. Abandoning in favor of https://reviews.llvm.org/D97362 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278 ___ cfe-commits mailing list cfe-commits

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

tbaeder abandoned this revision. tbaeder added a comment. Abandoning in favor of https://reviews.llvm.org/D97362 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99338/new/ https://reviews.llvm.org/D99338 ___ cfe-commits mailing list cfe-commits

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4656-4657 !getLangOpts().ObjC) { -ProhibitAttributes(attrs); +ProhibitCXX11Attributes(attrs, diag::err_attributes_not_allowed, +/*DiagnoseEmptyAttrs=*/true); i

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5018e15fdfda: [clang][parser] Allow GNU-style attributes in explicit template... (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/n

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334604. tbaeder added a comment. I know it's been a while, but here's an update on that patch. Now that I've got https://reviews.llvm.org/D97362 and https://reviews.llvm.org/D97371 pushed, this is a much simpler change and does not break any of the existin

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334605. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/ParsedAttr.h clang/lib/Parse/ParseDecl.cpp clang/test/AST/sourceranges.cpp c

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334668. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/ParsedAttr.h clang/lib/Parse/ParseDecl.cpp clang/test/AST/sourceranges.cpp c

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ea9fa8c507e: [clang][parser] Set source ranges for GNU-style attributes (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. Damn. Reverted again for the time being. The libc++ build seems to fail and I won't have time to look into that this week. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 __

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. Yep. I'll try to come up with a test and a fix next week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list cf

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 334954. tbaeder added a comment. Herald added a subscriber: jdoerfert. A little earlier than expected. Happy Easter :P CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Pars

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder updated this revision to Diff 335016. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/ParsedAttr.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. I compiled libc++ with a clang that has this patch applied and didn't run into more problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75844/new/ https://reviews.llvm.org/D75844 ___ cfe-commits mailing list cfe-

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I randomly noticed this comment (introduced in a3e01cf822f7415337e5424af3c6f4c94a12c1b9 from @rsmith),

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this since it's probably not worth it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

tbaeder added a comment. Hey Aaron, it's been a while. Do you have a suggestion on how to proceed if @rsmith has no opinion on it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99936/new/ https://reviews.llvm.org/D99936 __

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

tbaeder updated this revision to Diff 338459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99936/new/ https://reviews.llvm.org/D99936 Files: clang/lib/Parse/ParseStmt.cpp clang/test/SemaCXX/warn-unused-label-error.cpp Index: clang/test/SemaCXX/warn-unused-label-error.cpp =

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG320311a01b49: [clang][parser] Unify rejecting (non) decl stmts with gnu attributes (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99936

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 313872. tbaeder added reviewers: jansvoboda11, thakis, Bigcheese. tbaeder added a comment. Rebased on lastest main branch and added a few more reviewers from git blame'ing the Options.td file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. I guess I could add a test for the example I posted, but I'm not sure of how much value that is. Or do you mean a test case that -ansi and -std=c89 behave the same in every situation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llv

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. That sounds good but it's different to what this patch is trying to accomplish, isn't it? -ansi already doesn't get passed to the linker. E.g. with clang 10.0.1 without this patch: ~ ❯ clang test.o -o test -ansi -### clang version 10.0.1 (Fedora 10.0.1-3.fc32) Targ

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 316115. tbaeder added a comment. Okay, I've added a test and made sure it fails before and succeeds after this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 Files: clang/include/clang/Driver/Opti

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 316118. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 Files: clang/include/clang/Driver/Options.td clang/test/Driver/ansi.c Index: clang/test/Driver/ansi.c =

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. And thank you for reviewing my patches :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. Yes, I was gonna ask somebody else but if you have time, committing this one and https://reviews.llvm.org/D94478 would be nice CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375

<    16   17   18   19   20   21   22   >