[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan created this revision. Herald added subscribers: cfe-commits, jsji, jfb, kbarton, mgorny, nemanjai. Herald added a project: clang. This patch adds AIX toolchain infrastructure into driver, and enables AIX system linker invocation with some basic functionality support Repository: rG LL

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225521. stevewan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.c

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225631. stevewan marked 25 inline comments as done. stevewan added reviewers: jasonliu, Xiangling_L. stevewan added a comment. Fix periods at the end of comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68

[PATCH] D69271: Add AIX toolchain and basic linker functionality

stevewan created this revision. Herald added subscribers: cfe-commits, jsji, jfb, kbarton, mgorny, nemanjai. Herald added a project: clang. stevewan abandoned this revision. Herald added subscribers: wuzish, ormris. This patch adds AIX toolchain infrastructure into driver, and enables AIX system l

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225925. stevewan marked 8 inline comments as done. stevewan added a comment. Tidy code with lambda expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); jasonliu wrote: > Xiangling_L wrote: > > Is there any re

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/CMakeLists.txt:33 ToolChains/Arch/X86.cpp + ToolChains/AIX.cpp ToolChains/Ananas.cpp jasonliu wrote: > Looks like this list is following alphabetical or

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226170. stevewan added a comment. Avoid blank else block when assertion is off Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226304. stevewan added a comment. Capture local variable IsArch32Bit by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59 + + auto getCrt0Basename = [&IsArch32Bit, &Args] { +// Enable gprofiling when "-pg" is specified. jasonliu wrote: > nit: There is no

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D69356 ___

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added a comment. In D68340#1720362 , @Yi-Hong.Lyu wrote: > Seems this commit broke the buildbot > http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 @daltenty's patch rG201ed14aea8c

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: hubert.reinterpretcast, Xiangling_L, ZarkoCA, daltenty. On AIX, add '-bcdtors:all:0:s' to linker implicitly through driver, so that we can collect all static construct

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265765. stevewan added a comment. Address comments and fix windows compatibility issues with the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: cl

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265781. stevewan added a comment. Address furthur comments on the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: clang/lib/Driver/ToolChains/AIX.c

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:2 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and argument order. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN: -Wl,-bnocdtors \

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265813. stevewan added a comment. Incorporate the test case into 'aix-ld.c'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: clang/lib/Driver/ToolChains/AIX.c

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan added a comment. I'm planning to post an NFC patch after this to fix the formatting for existing cases in 'aix-ld.c' so that everything is consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D8041

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265818. stevewan added a comment. Update check prefix based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bf2409a4e4d: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: ZarkoCA, hubert.reinterpretcast, daltenty. stevewan edited the summary of this revision. Based on comments received in D80415 pertinen

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan updated this revision to Diff 266070. stevewan added a comment. Fix misalignment caused by tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Driver/aix-ld.c Index: clang/tes

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan updated this revision to Diff 266081. stevewan added a comment. Pass 'clang-format' checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Driver/aix-ld.c Index: clang/test/

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan updated this revision to Diff 266263. stevewan added a comment. Add the two-space indent before continuations on a pipeine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Drive

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa924dac44f31: [NFC] Fix formatting for the 'aix-ld.c' test case. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://re

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: hubert.reinterpretcast, cebowleratibm, daltenty. This patch changes the AIX default target CPU to power4 since this is the the lowest arch for the lowest OS level suppo

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4afe6f7a84: [AIX] Change the default target CPU to power4 for AIX on Power (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80835/new/

[PATCH] D81115: [PowerPC] Do not check for non-Darwin in PowerPC target cpu handling

stevewan created this revision. Herald added subscribers: cfe-commits, steven.zhang, shchenz, nemanjai. Herald added a project: clang. stevewan added reviewers: hubert.reinterpretcast, daltenty. Herald added a subscriber: wuzish. Since Darwin on PowerPC is no longer supported, we'll take the Darwi

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:301 +TargetCPUName = "pwr4"; + else if (!T.isOSDarwin()) { +if (T.getArch() == llvm::Triple::ppc64) hubert.reint

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

stevewan updated this revision to Diff 268588. stevewan added a comment. Reduce the nested 'if' and reorder it to prefer the more likely case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81115/new/ https://reviews.llvm.org/D81115 Files: clang/

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

stevewan added a comment. The unit test failure (`instrprof-gcov-multithread_fork.test`) in pre merge checks is caused by another commit. See http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

stevewan added a comment. Looks like this has broken the build bot? (see http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG61cd264068ee: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan accepted this revision. stevewan added a comment. LGTM with minor nit. I took a look at the failed tests in premerge checks, they didn't seem to be related, but please double check before you commit. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return if

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. The test was failing on Linux if I set LLVM_DEFAULT_TARGET_TRIPLE. For example if I set it to`powerpc64le-linux-gnu` clang actually uses "powerpc64le-unknown-linux-gnu". Would you be able to provide a fix to this? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. Yes, this issue was hit with the reland applied. When given a `--` format LLVM_DEFAULT_TARGET_TRIPLE, Clang would expand the target triple to `---`, and therefore causes the name mismatch between what the driver searches for and what the test case creates as the dummy

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. In D79842#2138857 , @DavidSpickett wrote: > Right, I see the issue. > > The code that gets the default triple name > (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you > have in cmake, not the actual

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true -

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true -

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. This LGTM, but since I'm not most familiar with the type 1 failure in description, let's see if other reviewers have further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList &DriverArgs, +ArgStringList &CC1Args) const { I don't think this is the revision you inten

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList &DriverArgs, +ArgStringList &CC1Args) const { s

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM with some nits. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1781 - // pragma align(packed). - if (isAIXLayout(Context) && !MaxFieldAlignment.isZero() && !Fie

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

stevewan added a comment. I don't think the redirect files portion of this patch is well-described in the description, could you please add it? Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) { + for (size_

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM other than some nits. Comment at: clang/lib/Driver/Job.cpp:361 + + if (!RedirectFiles.empty()) { +std::vector> RedirectFilesOptional; ==

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

stevewan added inline comments. Comment at: clang/test/Driver/aix-ld.c:675-676 +// CHECK-LD32-SHARED-EXPORTS-NOT: "{{.*}}llvm-nm" +// CHECK-LD32-SHARED-EXPORTS-NOT: "-X" +// CHECK-LD32-SHARED-EXPORTS-NOT: "32" +// CHECK-LD32-SHARED-EXPORTS: "{{.*}}ld{{(.exe)?}}" -

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

stevewan added a comment. Might be a dumb question, but I see this is a revert to rGb116ded , do we also want to revert the changes added to `llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp`? Comment at: clang/li

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc644aeca8f: Revert "[AIX] Avoid structor alias; die before bad alias codegen" (authored by Jake-Egan, committed by stevewan). Repository: rG LLV

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1781 - // pragma align(packed). - if (isAIXLayout(Context) && !MaxFieldAlignment.isZero() && !FieldSize) -FieldAlign = std::min(FieldAlign, MaxFieldAlignmentInBits); sfertile

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1783 +if (FieldPacked) { + FieldAlign = UnpackedFieldAlign = 1; +} else if (!MaxFieldAlignment.isZero()) { `UnpackedFieldAlign` is used to check if the packed attribute

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "aligned" attribute can only increase the alignment of a struct, or struct member, unless it's used together with the "packed" attribute, or used a

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 363860. stevewan added a comment. Attr 'packed' is already taken into account in ABIAlign/PreferredAlign Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: cla

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 363870. stevewan added a comment. Fix incomplete diff, please discard last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan accepted this revision. stevewan added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106900/new/ https://reviews.llvm.org/D106900 ___ cfe-commits mailing list cfe-commit

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 364186. stevewan added a comment. Merge tests into one file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp clang/test/Layout

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/test/Layout/aix-alignof-align-and-pack-attr.cpp:11 + +// CHECK: @c = global %struct.C zeroinitializer, align 2 sfertile wrote: > Minor nit: I think the other test can liv

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 364350. stevewan marked an inline comment as done. stevewan added a comment. Fix the same problem in field layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Fi

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 364359. stevewan added a comment. Add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/RecordLayoutBu

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "__alignof__()" operator, when used on a type, always returns the `ABIAlign` if the type is marked `__attribute__((aligned()))`. However, the "al

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan added a comment. This is a split of the query portion from https://reviews.llvm.org/D107394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107598/new/ https://reviews.llvm.org/D107598 ___ cfe-co

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan updated this revision to Diff 364630. stevewan added a comment. Add third test case as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107598/new/ https://reviews.llvm.org/D107598 Files: clang/lib/AST/ASTContext.cpp clang/tes

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa91916500d67: [AIX] "aligned" attribute should not decrease type alignment returned by… (authored by stevewan). Repository: rG LLVM Github Monorep

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan planned changes to this revision. stevewan added a comment. The query portion has been split out as https://reviews.llvm.org/D107598, which needs to be cleaned out from this patch. The record layout part also needs update as we uncover more problems with the current implementation. Re

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 366051. stevewan added a comment. Rebase to latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp clang/test/L

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367312. stevewan added a comment. Fields marked attribute "aligned" and "packed" don't need to go through alignment upgrade Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. I'm not familiar with `getCanonicalType()`, can you confirm whether it sees through nested typedef's? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 ___

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 __

[PATCH] D105185: [AIX] Add _AIX73 version macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52f34673ead3: [AIX] Add _AIX73 version macro (authored by Jake-Egan, committed by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9964b0ef828b: [clang] Add -fdump-record-layouts-canonical option (authored by daltenty, committed by stevewan). Repository: rG LLVM Github Monorep

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. In D105112#2858702 , @thakis wrote: > Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's > VERSION_MAJOR after adding a LangOption, else builds with > LLVM_APPEND_VC_REV=NO won't invalidate their module cach

[PATCH] D103587: [AIX] Define __TOS_AIX__ predefined macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG045872f42203: [AIX] Define __TOS_AIX__ predefined macro (authored by Jake-Egan, committed by stevewan). Changed prior to commit: https://reviews.llvm.org/D103587?vs=349913&id=356783#toc Repository: r

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

This revision was automatically updated to reflect the committed changes. Closed by commit rG798fe3c774a1: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105635/new/

[PATCH] D113614: Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following interpreter tests failed on AIX because 64-bit XCOFF object files are currently not supported on AIX. This patch disables the tests on A

[PATCH] D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG42102bce98e5: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D97823: Update default arch on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, the default arch level should match the minimum supported arch level of the OS version Repository: rG LLVM Github Monorepo https://review

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji wro

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327798. stevewan added a comment. Address comments with regard to handling older AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Drive

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327803. stevewan added a comment. Improve handling different AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Driver/ToolChains/CommonA

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); jsji wrote: > `micro` unsed. Sorry I missed this comment. I agree t

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327825. stevewan added a comment. Reflect varible is unused in its name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Driver/ToolChains/CommonArg

[PATCH] D97823: [AIX] Update default arch on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b274ed49960: [AIX] Update default arch on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D104550: [analyzer] Implement getType for SVal

stevewan added a comment. In D104550#2849582 , @vsavchenko wrote: > In D104550#2849561 , @DavidSpickett > wrote: > >> @vsavchenko One of the added tests is failing on our 32 bit Armv7 Thumb bot: >> https://lab.

[PATCH] D104550: [analyzer] Implement getType for SVal

stevewan added a comment. In D104550#3139684 , @martong wrote: > In D104550#3139239 , @stevewan > wrote: > >> In D104550#2849582 , @vsavchenko >> wrote: >> >>> In D10455

[PATCH] D114381: [AIX] Disable unsupported offloading gpu tests

stevewan added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114381/new/ https://reviews.llvm.org/D114381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSA uses bitwidth to infer the integer value type. In the ILP32 model, for example 32-bit AIX, any 32-bit integer type will be considerred as `int`, w

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The PCH reader looks for `__clangast` section in the precompiled module file, which is not present in the file on AIX, and we don't support writing th

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

stevewan created this revision. Herald added a subscriber: yaxunl. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX doesn't support GPU. There is no point testing HIP on it. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan updated this revision to Diff 389535. stevewan added a comment. Explain the rationale Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 Files: clang/test/ClangScanDeps/modules-pch-common-submodul

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06d4a76309cd: [NFC][AIX]Disable precompiled module file tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D114615: Increase the number of driver diagnostics

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're close to hitting the limited number of driver diagnostics, increase `DIAG_SIZE_DRIVER` to accommodate more. Repository: rG LLVM Github Monor

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG23dc88622630: [NFC][AIX]Disable unsupported hip test on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114484/new/ https://review

[PATCH] D114615: [NFC][clang]Increase the number of driver diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c32c568844c: [NFC][clang]Increase the number of driver diagnostics (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 390795. stevewan added a comment. Herald added a subscriber: mgorny. Pin target triple before analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454 Files: clang

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. Finally had some time to get back to this. Thanks @steakhal for your suggestion, the sample code in `ASTMatchersNodeTest.cpp` was helpful. I was actually looking for a good way of querying the target triple as I do agree that it is an better way of fixing this. Hopeful

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 391120. stevewan added a comment. Herald added subscribers: luke957, s.egerton, simoncook, fedor.sergeev, aheejin. Add targets we are interested in testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/n

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. > but we could pick a couple of esoteric targets where integrals differ > significantly from what we have on x86_64 Turns out `wasm` and `darwin` also have a similar problem, I added them to the skip list for now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114454: [analyzer]Skip unstable CSA tests failing on several platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4d194f44c4: [analyzer]Skip unstable CSA tests failing on several platforms (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new

[PATCH] D69620: Add AIX assembler support

stevewan created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. This is a follow on patch to D68340 . Given the AIX toolchain skeleton and system linker support introduced in D68340 , thi

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:26 + + bool hasIntegratedCPP() const override { return false; } + Xiangling_L wrote: > I saw a lot of other target also set `hasIntegratedCPP

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:45 + // Acccept any mixture of instructions. + CmdArgs.push_back("-many"); + Xiangling_L wrote: > GCC invokes system assembler also with o

  1   2   >