stevewan added inline comments.
================
Comment at: clang/test/Driver/aix-ld.c:675-676
+// CHECK-LD32-SHARED-EXPORTS-NOT: "{{.*}}llvm-nm"
+// CHECK-LD32-SHARED-EXPORTS-NOT: "-X"
+// CHECK-LD32-SHARED-EXPORTS-NOT: "32"
+// CHECK-LD32-SHARED-EXPORTS: "{{.*}}ld{{(.exe)?}}"
----------------
DiggerLin wrote:
> stevewan wrote:
> > And please keep this consistent across the tests.
> using:
> // CHECK-LD32-SHARED-EXPORTS-NOT: "-X"
> // CHECK-LD32-SHARED-EXPORTS-NOT: "32"
>
> will be fail on the -X 64 too.
>
> using // CHECK-LD32-SHARED-EXPORTS-NOT: "-X" "32"
> will be success on the -X 64.
> So I am prefer use the
> CHECK-LD32-SHARED-EXPORTS-NOT: "-X"
> CHECK-LD32-SHARED-EXPORTS-NOT: "32"
>
If this is meant to check also for `-X 64`. I suggest using proper regex
instead of relying solely on the `-X` check.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119147/new/
https://reviews.llvm.org/D119147
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
