[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

steveire added inline comments. Comment at: clang-tidy/ClangTidy.h:11 +// +// It should remain as stable as possible, as many out-of-tree checks exist. +//===--===// alexfh wrote: > sammccall wro

[PATCH] D54061: [clang-tidy] run() doesn't update the SourceManager.

steveire added a comment. After this change, it seems that `ClangTidyCheck::check` is not needed and all callers should be ported to call `run()` instead (and the private `run()` declaration should be removed from `ClangTidyCheck`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

steveire added a comment. This feature seems like a good idea. I started writing it too some months ago, but then I changed tactic and worked on distributing the refactor over the network instead. As far as I know, your deduplication would not work with a distributed environment. However, it s

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

steveire added a comment. In https://reviews.llvm.org/D54141#1288818, @JonasToth wrote: > Thank you for the comment! > > In https://reviews.llvm.org/D54141#1288809, @steveire wrote: > > > This feature seems like a good idea. I started writing it too some months > > ago, but then I changed tactic

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

steveire added a comment. In https://reviews.llvm.org/D54141#1288851, @JonasToth wrote: > > So, running `clang-apply-replacements --issue-diags the_new_file.yaml` > > would issue the warnings/fixit hints by processing the yaml and issuing the > > diagnostics the way clang-tidy would have done (

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

steveire added a comment. In https://reviews.llvm.org/D54141#1288930, @JonasToth wrote: > > Do you understand the proposal now? > > Yes better, I was under the impression that `clang-apply-replaments` is run > on the end and the YAMLs are kept until then. Now its clear. > I assume `--issue-diag

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

steveire added a comment. In https://reviews.llvm.org/D54141#1289326, @JonasToth wrote: > > That said, would you agree to have the parser-based deduplication as an > developer-only optin solution for now? :) If you're suggesting proceeding with this regex based solution, I don't think that

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

steveire added a comment. @hokein you and I seem to be making the same proposal :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D54169: [clang-tidy] Zircon ->

steveire added a comment. This is https://bugs.llvm.org//show_bug.cgi?id=32739 . I think checks not relevant to a general audience (ie including the boost directory) should be in external plugins. It's not really clear to me what has to happen for that, but it seems increasingly relevant. htt

[PATCH] D54402: Extract method to allow re-use

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. The list of matchers which can be used with a top matcher can be used in other contexts than code completion. It can be output as data in clang-tidy. Repository: rC Clang https://

[PATCH] D54403: Add new API for returning matching matchers

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. The MatchingMatcher struct currently contains only a string, but it will be expanded in the future. Repository: rC Clang https://reviews.llvm.org/D54403 Files: include/clang/AS

[PATCH] D54404: Exclude matchers which can have multiple results

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D54404 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/D

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. These matchers are bindable. Recording this information will make it possible to introspect the matchers which can be used inside another matcher. Repository: rC Clang https://rev

[PATCH] D54406: Add matchDynamic convenience functions

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. These correspond to the existing match() free functions. Repository: rC Clang https://reviews.llvm.org/D54406 Files: include/clang/ASTMatchers/ASTMatchFinder.h unittests/ASTM

[PATCH] D54407: Record the matcher type when storing a binding

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This is necessary so that when we wish to print the matchers for a binding of type `CXXMeethodDecl`, but which was matched with a base matcher such as `functionDecl()` we can inform th

[PATCH] D54408: Add matchers available through casting to derived

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dy

[PATCH] D54408: Add matchers available through casting to derived

steveire added a comment. These commits are available on github if it's convenient to see it all together there: https://github.com/steveire/clang/commits/matcher-output Here is context for the changes I'm making in case it is useful: https://steveire.wordpress.com/2018/11/11/future-developmen

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. I think this commit is fine without tests. The new method remains internal to the file but follow-up commits add public interface and tests. I'll push the commits separately. I'll not be squashing them. Repository: rC Clang https://reviews.llvm.org/D54402 __

[PATCH] D54404: Exclude matchers which can have multiple results

steveire added a comment. I acknowledge and share the future-proofing concern. We could possibly use something trait-based instead and put the trait beside the matcher definition in ASTMatchers.h, but that doesn't really solve the problem. It only moves the problem. Repository: rC Clang ht

[PATCH] D54407: Record the matcher type when storing a binding

steveire added a comment. In https://reviews.llvm.org/D54407#129, @sbenza wrote: > In https://reviews.llvm.org/D54407#1294934, @aaron.ballman wrote: > > > Adding @sbenza in case he has opinions on this approach. I think it's > > reasonable, but I also know that changes to the the AST matcher

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfM

[PATCH] D54402: Extract method to allow re-use

steveire updated this revision to Diff 173764. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54402 Files: lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp ===

[PATCH] D54403: Add new API for returning matching matchers

steveire updated this revision to Diff 173765. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54403 Files: include/clang/ASTMatchers/Dynamic/Registry.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittest

[PATCH] D54404: Exclude matchers which can have multiple results

steveire updated this revision to Diff 173766. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54404 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dynamic/RegistryTest.cpp

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire updated this revision to Diff 173767. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54405 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp =

[PATCH] D54407: Record the matcher type when storing a binding

steveire updated this revision to Diff 173769. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54407 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/ASTMatchersInternal.cpp lib/Tooling/RefactoringCallbacks.cpp unittests/ASTMatche

[PATCH] D54406: Add matchDynamic convenience functions

steveire updated this revision to Diff 173768. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54406 Files: include/clang/ASTMatchers/ASTMatchFinder.h unittests/ASTMatchers/ASTMatchersNodeTest.cpp Index: unittests/ASTMatchers/ASTMatchersNodeTest.cpp

[PATCH] D54408: Add matchers available through casting to derived

steveire updated this revision to Diff 173770. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dynamic/RegistryTest.cpp =

[PATCH] D54407: Record the matcher type when storing a binding

steveire updated this revision to Diff 173774. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54407 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/ASTMatchersInternal.cpp lib/Tooling/RefactoringCallbacks.cpp unittests/ASTMatche

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. This is just a NFC change, which is normal to appear without tests. The consensus on IRC is that this is fine. Repository: rC Clang https://reviews.llvm.org/D54402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54407: Record the matcher type when storing a binding

steveire added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:154 +bool operator<(const NodeEntry &other) const { + return DynNode < other.DynNode && NodeKind < other.NodeKind; +} aaron.ballman wrote: > This doesn't prov

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfM

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfM

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire updated this revision to Diff 173819. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54405 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp =

[PATCH] D54402: Extract method to allow re-use

steveire updated this revision to Diff 173820. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54402 Files: lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp ===

[PATCH] D54404: Exclude matchers which can have multiple results

steveire added a comment. Let's discuss it on IRC at some point and see if we can come up with wording. Repository: rC Clang https://reviews.llvm.org/D54404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfM

[PATCH] D54404: Exclude matchers which can have multiple results

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", sbenza wrote: > I'm not sure what goes in this list. > `hasAnyName` is here but not `hasName`. > What i

[PATCH] D54404: Exclude matchers which can have multiple results

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624 + "hasAnyDeclaration", + "hasAnyName", + "hasAnyParameter", aaron.ballman wrote: > steveire wrote: > > sbenza wrote: > > > I'm not sure what goes in this list. > >

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire updated this revision to Diff 175429. steveire added a comment. Refactor Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54405/new/ https://reviews.llvm.org/D54405 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Registry

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:85 +using DerivedT = typename ast_matchers::internal::VariadicAllOfMatcher::Type; +registerIfNodeMatcher(ASTNodeKind::getFromNodeKind(), Descripto

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55068 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp =

[PATCH] D55070: Replace FullComment member being visited with parameter

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55070 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp ==

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This has precedent in the StmtVisitor. This change will make it possible to clean up the comment handling in ASTDumper. Repository: rC Clang https://reviews.llvm.org/D55069 File

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire updated this revision to Diff 175956. steveire added a comment. Use isa instead of dyn_cast Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55068/new/ https://reviews.llvm.org/D55068 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp ==

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:1987 +ConstStmtVisitor::Visit(S); + aaron.ballman wrote: > Was there something special about calling the Visit methods directly and > bailing out?

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire updated this revision to Diff 175960. steveire added a comment. Add && Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 Files: include/clang/AST/CommentVisitor.h Index: include/clang/AST/CommentVisitor.h =

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. I'm not aware of existing test coverage for any of this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire updated this revision to Diff 175967. steveire added a comment. Remove && Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 Files: include/clang/AST/CommentVisitor.h Index: include/clang/AST/CommentVisitor.h ==

[PATCH] D55070: Replace FullComment member being visited with parameter

steveire updated this revision to Diff 175968. steveire added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55070/new/ https://reviews.llvm.org/D55070 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire updated this revision to Diff 175962. steveire added a comment. Add && Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 Files: include/clang/AST/CommentVisitor.h Index: include/clang/AST/CommentVisitor.h =

[PATCH] D55070: Replace FullComment member being visited with parameter

steveire updated this revision to Diff 175963. steveire added a comment. Remove param Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55070/new/ https://reviews.llvm.org/D55070 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp ==

[PATCH] D55070: Replace FullComment member being visited with parameter

steveire updated this revision to Diff 175966. steveire added a comment. Remove && Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55070/new/ https://reviews.llvm.org/D55070 Files: include/clang/AST/CommentVisitor.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDum

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. The follow-up patch didn't build anymore with the `&&`. ../tools/clang/lib/AST/ASTDumper.cpp:2672:75: error: cannot bind rvalue reference of type ‘const clang::comments::FullComment*&&’ to lvalue of type ‘const clang::comments::FullComment* const’ ConstComment

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. Ah, `test/Misc/ast-dump-comment.cpp` is existing test coverage for this indeed, great. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55069/new/ https://reviews.llvm.org/D55069 ___ cfe-commi

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Output all content which is local to the FunctionDecl before traversing to child AST nodes. Repository: rC Clang https://reviews.llvm.org/D55083 Files: lib/AST/ASTDumper.cpp

[PATCH] D55069: Extend the CommentVisitor with parameter types

steveire added a comment. > Huh, that's surprising. It's a perfect forwarding reference It's not a forwarding reference because the template parameter is from the record, not the function. See https://godbolt.org/z/L4N2aS > One of the reasons I think this may be important is with the JSON dump

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:1987 +ConstStmtVisitor::Visit(S); + aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > > Was there something special about calling

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire added a comment. Yes, please commit your new tests for FunctionDecl dumping before this patch can go in. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55083/new/ https://reviews.llvm.org/D55083 ___ cfe-comm

[PATCH] D55068: NFC: Simplify dumpStmt child handling

steveire added a comment. Aaron, you added tests for the existing behavior which pass after this patch. Is there anything holding it up? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55068/new/ https://reviews.llvm.org/D55068 _

[PATCH] D55070: Replace FullComment member being visited with parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL348101: Replace FullComment member being visited with parameter (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D55069: Extend the CommentVisitor with parameter types

This revision was automatically updated to reflect the committed changes. Closed by commit rL348100: Extend the CommentVisitor with parameter types (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D55189: Extract TextNodeDumper class

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Start by moving some utilities to it. It will eventually house dumping of individual nodes (after indentation etc has already been accounted for). Repository: rC Clang https://rev

[PATCH] D55188: Extract TextChildDumper class

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp =

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55190 Files: include/clang/AST/ASTTextNodeDumper.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp ==

[PATCH] D55188: Extract TextChildDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump aaron.ballman wrote: > I'm not certain this namespace is usefu

[PATCH] D55188: Extract TextChildDumper class

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote

[PATCH] D55188: Extract TextChildDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:96 + +struct TextChildDumper { + raw_ostream &OS; steveire wrote: > aaron.ballman wrote: > > I'm not sold on the name for this class. It's a

[PATCH] D55068: NFC: Simplify dumpStmt child handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL348189: NFC: Simplify dumpStmt child handling (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176466. steveire added a comment. Rename class. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST/AS

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176467. steveire added a comment. Remove namespace Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST

[PATCH] D55189: Extract TextNodeDumper class

steveire updated this revision to Diff 176478. steveire added a comment. Herald added a subscriber: mgorny. Move implementation to cpp file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55189/new/ https://reviews.llvm.org/D55189 Files: include/clang/AST/TextNo

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

steveire updated this revision to Diff 176481. steveire added a comment. Move to implementation Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://reviews.llvm.org/D55190 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST

[PATCH] D55257: Inline handling of DependentSizedArrayType

steveire created this revision. Herald added a subscriber: cfe-commits. Re-order handling of getElementType and getBracketsRange. It is necessary to perform all printing before any traversal to child nodes. This causes no change in the output of ast-dump-array.cpp due to the way child nodes are p

[PATCH] D55257: Inline handling of DependentSizedArrayType

steveire added a comment. In D55257#1318328 , @aaron.ballman wrote: > > It is necessary to perform all printing before any traversal to child nodes. > > This piqued my interest -- is `VisitFunctionDecl()` then incorrect because it > streams output, then

[PATCH] D55257: Inline handling of DependentSizedArrayType

steveire added a comment. In D55257#1318769 , @aaron.ballman wrote: > In D55257#1318376 , @steveire wrote: > > > In D55257#1318328 , @aaron.ballman > > wrote: > > > > > > I

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

steveire added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; aaron.ballman wrote: > lebedev.ri wrote: > > Can you please also add one function with out-of-line definition? > Gladly! Is

[PATCH] D55189: Extract TextNodeDumper class

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:90 // Utilities -void dumpPointer(const void *Ptr); -void dumpSourceRange(SourceRange R); -void dumpLocation(SourceLocation Loc); -void dumpBareType(Q

[PATCH] D55257: Inline handling of DependentSizedArrayType

This revision was automatically updated to reflect the committed changes. Closed by commit rL348409: NFC: Inline handling of DependentSizedArrayType (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D55188: Extract TextChildDumper class

This revision was automatically updated to reflect the committed changes. Closed by commit rL348410: NFC: Extract TextTreeStructure class (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55188?vs=176467&id=176867#

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55337 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper

[PATCH] D55338: NFC: Move VisitStmt code to dumpStmt

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This call is duplicated in Visits of all direct subclasses of Stmt. Repository: rC Clang https://reviews.llvm.org/D55338 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.

[PATCH] D55339: NFC: Move VisitExpr code to dumpStmt

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. The call is duplicated in the handlers of all Expr subclasses. This change makes it easy to split statement handling out to TextNodeDumper. Repository: rC Clang https://reviews.l

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55340 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper

[PATCH] D55189: Extract TextNodeDumper class

This revision was automatically updated to reflect the committed changes. Closed by commit rC348412: NFC: Extract TextNodeDumper class (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55189?vs=176478&id=176872#toc Repository: rC Clang CHANGES SINCE L

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; aaro

[PATCH] D55393: Re-order content of template parameter dumps

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55393 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-decl.cpp Index: test/AST/ast-dump-decl.cpp ===

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire updated this revision to Diff 177069. steveire added a comment. Adjust tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55083/new/ https://reviews.llvm.org/D55083 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-decl.cpp test/AST/ast-dump-funcs.c

[PATCH] D55394: Re-order type param children of ObjC nodes

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55394 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-decl.m Index: test/AST/ast-dump-decl.m ===

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55395 Files: lib/AST/ASTDumper.cpp test/AST/dump.cpp Index: test/AST/dump.cpp =

[PATCH] D55338: NFC: Move VisitStmt code to dumpStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC348545: NFC: Move VisitStmt code to dumpStmt (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55338?vs=176869&id=177073#toc Repository: rC Clang CHANGES SINC

[PATCH] D55339: NFC: Move VisitExpr code to dumpStmt

This revision was automatically updated to reflect the committed changes. Closed by commit rC348546: NFC: Move VisitExpr code to dumpStmt (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55339?vs=176870&id=177074#toc Repository: rC Clang CHANGES SINC

[PATCH] D55398: Re-order content from InitListExpr

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This causes no change in the output of ast-dump-stmt.cpp due to the way child nodes are printed with a delay. Repository: rC Clang https://reviews.llvm.org/D55398 Files: lib/AS

[PATCH] D55393: Re-order content of template parameter dumps

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-decl.cpp:330-331 // CHECK-NEXT: TemplateTypeParmDecl -// CHECK-NEXT: TemplateArgument type 'int' // CHECK-NEXT: inherited from TemplateTypeParm 0x{{[^ ]*}} 'T' +//

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

steveire added a comment. Would it make sense to make this a generic non-abseil check? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55410/new/ https://reviews.llvm.org/D55410 ___ cfe-commits mailing li

[PATCH] D55398: Re-order content from InitListExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL348714: Re-order content from InitListExpr (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5539

[PATCH] D55393: Re-order content of template parameter dumps

steveire updated this revision to Diff 177412. steveire added a comment. New approach Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55393/new/ https://reviews.llvm.org/D55393 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-decl.cpp Index: test/AST/ast-dump-d

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Use it to add optional label nodes to Stmt dumps. This preserves behavior of InitExprList dump: // CHECK-NEXT: `-InitListExpr {{.+}} 'U [3]' // CHECK-NEXT: |-array filler // CHECK

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL348719: NFC: Move dump of individual comment nodes to NodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55190?

[PATCH] D55489: Implement dumpFunctionDeclParameters in NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D55489 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

<    1   2   3   4   5   6   7   8   9   10   >