steveire added inline comments.
================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:154
+ bool operator<(const NodeEntry &other) const {
+ return DynNode < other.DynNode && NodeKind < other.NodeKind;
+ }
----------------
aaron.ballman wrote:
> This doesn't provide the right ordering guarantees. Use `std::tie()` instead:
> `return std::tie(DynNode, NodeKind) < std::tie(Other.DynNode,
> Other.NodeKind);`
Thanks, I forgot about `tie` :).
Repository:
rC Clang
https://reviews.llvm.org/D54407
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
