[PATCH] D151480: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::​GetConstantArrayFromStringLiteral()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds an assert. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151480 Files: clang/lib/CodeGen/Cod

[PATCH] D151480: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::​GetConstantArrayFromStringLiteral()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151480/new/ https://reviews.llvm.org/D151480 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match i

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. DeduceTemplateArgumentsByTypeMatch() returns null value which is dereferenced without checking since getAsIncompleteArrayType() r

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3e7c6e9e080: [NFC][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/ https://reviews.

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: mattd, gchakrabarti, asavonic, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a projec

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Manna updated this revision to Diff 526259. Manna added a comment. I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151606/new/ https://reviews.llvm.org/D151606 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp Index: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp ==

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

Manna updated this revision to Diff 526264. Manna added a comment. Fix clang-format error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/ https://reviews.llvm.org/D151469 Files: clang/lib/AST/ExprConstant.cpp Index: clang/lib/AST/ExprConstant.cpp =

[PATCH] D151480: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule::​GetConstantArrayFromStringLiteral()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf59795b2b703: [NFC][CLANG] Fix nullptr dereference issue in CodeGenModule… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151480/new/ ht

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a5aeadb558: [NFC][CLANG] Fix issue with dereference null return value in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/ h

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151525/new/ https://reviews.llvm.org/D151525 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf64f760e2d20: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151525/n

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in clang::​Type::​getRVVEltType(clang::​ASTCont

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

Manna updated this revision to Diff 526647. Manna added a comment. Thank you @erichkeane for reviews! I have updated assert message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151529/new/ https://reviews.llvm.org/D151529 Files: clang/lib/Sema/SemaTemplateDeduction.cpp Index: cl

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151721/new/ https://reviews.llvm.org/D151721 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151721: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType()

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c05128aeaf8: [NFC][CLANG] Fix nullptr dereference issue in Type::getRVVEltType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151721/n

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf236a037fd8: [NFC][CLANG] Fix nullptr dereference issue in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151529/new/ https://reviews.

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Manna requested review of this revisi

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in SetValueDataBasedOnQualType(clang::​Value &,

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

Manna abandoned this revision. Manna added a comment. Closing this PR. Codes give an assert for unknown type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151770/new/ https://reviews.llvm.org/D151770 ___

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

Manna updated this revision to Diff 526877. Manna added a comment. Rebase the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 Files: clang/lib/Sema/SemaType.cpp Index: clang/lib/Sema/SemaType.cpp =

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

Manna updated this revision to Diff 526882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 Files: clang/lib/Sema/SemaType.cpp Index: clang/lib/Sema/SemaType.cpp === --- clang/l

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

Manna added a comment. Thank you @erichkeane for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151769/new/ https://reviews.llvm.org/D151769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151770/new/ https://reviews.llvm.org/D151770 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151769: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr()

This revision was automatically updated to reflect the committed changes. Closed by commit rG071d4ab377d3: [NFC][CLANG] Fix nullptr dereference issue in HandleRISCVRVVVectorBitsTypeAttr() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb069246573: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match in ConvertQualTypeToKind(clang::​ASTContext con

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concern with nullptr dereference issue

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castA

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match In clang::​CodeGen::​CodeGenTypes::​GetFunctio

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castA

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151928/new/ https://reviews.llvm.org/D151928 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concerns

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151947/new/ https://reviews.llvm.org/D151947 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151957/new/ https://reviews.llvm.org/D151957 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

Manna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:956 // Determine whether the type argument is substitutable for the bound. if (typeArgObjC->isObjCIdType()) { // When the type argument is 'id', the only acceptable type e

[PATCH] D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable()

This revision was automatically updated to reflect the committed changes. Closed by commit rG02ce49afb9a0: [NFC][CLANG] Fix bug with dereference null return value in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151957/new/ htt

[PATCH] D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs()

This revision was automatically updated to reflect the committed changes. Closed by commit rG82659941ccb8: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D151947: [NFC][CLANG] Fix Static Code Analyzer Concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7550310738b: [NFC][CLANG] Fix Static Code Analyzer Concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151947/new/ https://reviews.

[PATCH] D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind()

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0525f66988e: [NFC][CLANG] [NFC][CLANG] Fix nullptr dereference issue in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151928/new/ htt

[PATCH] D151010: [NFC][CLANG] Fix bug with dereference null return value found by static analyzer tool

Manna abandoned this revision. Manna added a comment. This is False Positive. Closing the PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 ___ cfe-commits ma

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match i

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Coverity: In clang::​ASTContext::​hasUniqueObjectRepresentations(clang::​QualType, bool): Return value of function w

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna added a comment. In D149922#4321972 , @erichkeane wrote: > Looks like both ABIs that use this assume the parameter passed to > `getMemberPointerInfo` is non-null. While we DO check the type (in reality, > we probably should be doing a `if (const

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna updated this revision to Diff 519859. Manna added a comment. I have updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149922/new/ https://reviews.llvm.org/D149922 Files: clang/lib/AST/ASTContext.cpp Index: clang/lib/AST/ASTContext.cpp ===

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna updated this revision to Diff 519868. Manna marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149922/new/ https://reviews.llvm.org/D149922 Files: clang/lib/AST/ASTContext.cpp Index: clang/lib/AST/ASTContext.cpp =

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2862 - if (Ty->isMemberPointerType()) { -const auto *MPT = Ty->getAs(); + if (const auto *MPT = Ty->getAs()) { return !ABI->getMemberPointerInfo(MPT).HasPadding; erichkeane wrote:

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

Manna added a comment. Thanks @erichkeane for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149922/new/ https://reviews.llvm.org/D149922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e0c44174823: [NFC][CLANG] Fix nullptr dereference found by Coverity static analysis tool (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added a comment. In D149461#4323175 , @tahonermann wrote: > These changes look good to me and I agree with not making a change for the > `KnownHeaders` case. >> I agree with not making a change for the `KnownHeaders` case. Yup. I closed them a

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG07996804a0c0: [NFC] ][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://review

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

Manna added a comment. Thank you everyone for reviews and comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

Manna added a comment. >> Thanks again for catching our oops @HazardyKnusperkeks! Yup, Thank you @HazardyKnusperkeks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

This revision was automatically updated to reflect the committed changes. Closed by commit rGbabe8629d73f: [NFC][Clang] Fix static analyzer tool remarks about large copies by values in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 520384. Manna added a comment. Thanks @tahonermann for reviews. I have addressed review comments and updated patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/Bo

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna marked 6 inline comments as done. Manna added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:704 /// Move the given pool's allocations to this pool. AttributePool(AttributePool &&pool) = default; tahonermann wrote: > This class h

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna created this revision. Manna added reviewers: erichkeane, tahonermann. Herald added a subscriber: ctetreau. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static Analyzer Tool, Coverity: Bad bit shift operation The operat

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 520681. Manna edited the summary of this revision. Manna added a comment. Thank you for reviews and comments @erichkeane and @sdesmalen! I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked 4 inline comments as done. Manna added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; --

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 520693. Manna marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/utils/TableGen/SveEmitter.cpp ===

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 521073. Manna marked 2 inline comments as done. Manna added a comment. I have updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/BodyFarm.h clang/include/cl

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &&D); +SemaDiagnosticBuilder &operator=(SemaDiagnosticBuilder &&D); SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default;

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 521089. Manna added a comment. Fix Coverity complain about shift overflow issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 Files: clang/utils/TableGen/SveEmitter.cpp Index: clang/utils/TableGen/SveE

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; --

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added a comment. In D149718#4333563 , @tahonermann wrote: > Looks good. Thanks @Manna! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 _

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added a comment. In D150140#4333552 , @tahonermann wrote: > Looks good to me! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org

[PATCH] D150411: [NFC][Clang] Fix Static Code Analysis Concerns

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: steakhal, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds missing assignment operator to the clas

[PATCH] D150411: [NFC][Clang] Fix Static Code Analysis Concerns

Manna abandoned this revision. Manna added a comment. Wrong patch. Closing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 ___ cfe-commits mailing list cfe-comm

[PATCH] D150411: [NFC][Clang] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 521529. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1789-1791 +SemaDiagnosticBuilder &operator=(SemaDiagnosticBuilder &&D) = delete; SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +SemaDiagnosticBuilder &operator=(const SemaDiagn

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ebff1ac1b98: [NFC][Clang] Fix Coverity issues of copy without assign (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https:/

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna added a comment. Thank you everyone for comments and reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG245549c57517: [NFC][CLANG] Fix Static Code Analysis Concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added a comment. In D149718#4341384 , @uabelho wrote: > In D149718#4341052 , @uabelho wrote: > >> Compiling with clang 15.0.5 I get the following warning/error with this >> patch: >> >> ../../clang/includ

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 522608. Manna added a comment. Thank you @aaronpuchert for reviews and the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analys

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 522821. Manna marked 3 inline comments as done. Manna added a comment. Thanks @tahonermann for your reviews and feedbacks. I have addressed your review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D1504

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1789-1791 +SemaDiagnosticBuilder &operator=(SemaDiagnosticBuilder &&D) = delete; SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +SemaDiagnosticBuilder &operator=(const SemaDiagn

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 522826. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna created this revision. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 522877. Herald added subscribers: steakhal, martong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/A

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 523025. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGOpe

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 523030. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGOpe

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna updated this revision to Diff 523071. Manna added a comment. Thank you @steakhal for reviews. I have addressed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h cl

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added a comment. In D150744#4350048 , @steakhal wrote: > > In our case, we initialized that field from the registration function, like > this: > > void ento::registerMoveChecker(CheckerManager &mgr) { > MoveChecker *chk = mgr.registerChec

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added a comment. In D150744#4350198 , @erichkeane wrote: > CFE changes look fine to me! Thank you @erichkeane for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 _

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:187 - AggressivenessKind Aggressiveness; + AggressivenessKind Aggressiveness = AK_Invalid; steakhal wrote: > By looking at the

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna marked an inline comment as done. Manna added a comment. @steakhal, do you have any more concerns with StaticAnalyzer changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits ma

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523376. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1790 SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +SemaDiagnosticBuilder &operator=(const SemaDiagnosticBuilder &) = delete; ~SemaDiagnosticBuilder(); tahone

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523396. Manna added a comment. Fix clang-format issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, luismarques, s.egerton, dkrupp, donat.nagy, Szelethus, PkmX, a.sidorin, simoncook, baloghadamsoftware, arichardson. Herald added a project: All. Manna requested review of this revision

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna updated this revision to Diff 523468. Manna edited the summary of this revision. Manna added a comment. I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150895/new/ https://reviews.llvm.org/D150895 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Par

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna updated this revision to Diff 523481. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150895/new/ https://reviews.llvm.org/D150895 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Parse/ParsePragma.cpp === ---

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:4058 + PP.Lex(Tok); + II = Tok.getIdentifierInfo(); erichkeane wrote: > I'm having trouble figuring out why this isn't a breaking change. > `PP.Lex(Tok)` moves the current 'token' to b

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna updated this revision to Diff 523502. Manna added a comment. Herald added a subscriber: asb. I have removed `IntrinsicClass` and updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150895/new/ https://reviews.llvm.org/D150895 Files: clang/lib/Parse/ParsePragma.cpp I

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna updated this revision to Diff 523509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150895/new/ https://reviews.llvm.org/D150895 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Parse/ParsePragma.cpp === ---

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:4051 + if (II->isStr("vector")) +Actions.DeclareRISCVVBuiltins = true; erichkeane wrote: > So I'd say leave this where it was. Once line 4043

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. In D150411#4354135 , @NoQ wrote: > Static Analyzer changes look great, thanks! Thank you @NoQ for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 _

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523540. Manna marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang/include/

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:705-707 + // The move assignment operator is defined as deleted pending further + // motivation. + AttributePool &operator=(AttributePool &&pool) = delete; tahonermann wrote: > Let'

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. Thank you @tahonermann, @NoQ, @aaronpuchert for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4fbc4bdbf58: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

<    1   2   3   >