Manna added inline comments.
================
Comment at: clang/lib/Sema/SemaType.cpp:956
// Determine whether the type argument is substitutable for the bound.
if (typeArgObjC->isObjCIdType()) {
// When the type argument is 'id', the only acceptable type
----------------
erichkeane wrote:
> Note for future reviewers: This 'if' on both branches dereferences the
> `boundObjC` pointer. The true path is just below here, on 959. Second is in
> the condition inside of the `else if` on 961, `canAssignObjCInterfaces`
> immediately dereferences the parameters.
>>This 'if' on both branches dereferences the boundObjC pointer. The true path
>>is just below here, on 959. Second is in the condition inside of the else if
>>on 961, canAssignObjCInterfaces immediately dereferences the parameters.
Yes.
Thank you @erichkeane for reviews!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151964/new/
https://reviews.llvm.org/D151964
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
