Might be because the constructed AST for a @finally on Windows will contain a
CapturedStmt: https://reviews.llvm.org/D47564. You probably want to explicitly
specify a non windows-msvc triple in the test.
From: cfe-commits on behalf of Raphael
Isemann via cfe-commits
Reply-To: Raphael Isemann
Author: smeenai
Date: Fri May 18 14:59:29 2018
New Revision: 332777
URL: http://llvm.org/viewvc/llvm-project?rev=332777&view=rev
Log:
[test] Fix run line to use correct triple
objc_begin_catch/objc_end_catch are specific to the Itanium ABI, so we
should be using an Itanium triple for this test.
Author: smeenai
Date: Wed Oct 4 16:17:12 2017
New Revision: 314946
URL: http://llvm.org/viewvc/llvm-project?rev=314946&view=rev
Log:
[libc++] Add site config option for ABI macros
Some ABI macros affect headers, so it's nice to have a site config
option for them. Add a LIBCXX_ABI_DEFINES cmake m
Author: smeenai
Date: Wed Oct 4 16:44:38 2017
New Revision: 314949
URL: http://llvm.org/viewvc/llvm-project?rev=314949&view=rev
Log:
[libc++] Allow users to explicitly specify ABI
libc++'s current heuristic for detecting Itanium vs. Microsoft ABI falls
short in some cases. For example, it will d
Author: smeenai
Date: Wed Oct 4 16:51:57 2017
New Revision: 314950
URL: http://llvm.org/viewvc/llvm-project?rev=314950&view=rev
Log:
[libc++] Move cache variable definition. NFC
Move it to where the other ABI cache variables/options are defined.
Modified:
libcxx/trunk/CMakeLists.txt
Modifi
Author: smeenai
Date: Wed Oct 4 19:18:08 2017
New Revision: 314965
URL: http://llvm.org/viewvc/llvm-project?rev=314965&view=rev
Log:
[libc++] Clarify names of ABI forcing macros
Make it clear that these are intended only to force a specific ABI when
the autodetection would give the wrong result
, Shoaib Meenai via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: smeenai
Date: Wed Oct 4 16:44:38 2017
New Revision: 314949
URL:
http://llvm.org/viewvc/llvm-project?rev=314949&view=rev<https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2D
Author: smeenai
Date: Mon Oct 9 12:25:17 2017
New Revision: 315234
URL: http://llvm.org/viewvc/llvm-project?rev=315234&view=rev
Log:
[libc++] Support Microsoft ABI without vcruntime headers
The vcruntime headers are hairy and clash with both libc++ headers
themselves and other libraries. libc++
Author: smeenai
Date: Mon Jun 5 21:06:28 2017
New Revision: 304761
URL: http://llvm.org/viewvc/llvm-project?rev=304761&view=rev
Log:
[Driver] Don't force .exe suffix for lld
When cross-compiling to Windows using lld, we want the driver to invoke
it as lld-link rather than lld-link.exe. On Window
Isn't PRIuPTR (from inttypes.h) the portable way to print a uintptr_t?
On 12/27/17, 10:47 AM, "cfe-commits on behalf of Chandler Carruth via
cfe-commits" wrote:
Author: chandlerc
Date: Tue Dec 26 21:46:53 2017
New Revision: 321469
URL:
https://urldefense.proofpoint.com
Hah, we all missed this during review.
From: cfe-commits on behalf of Saleem
Abdulrasool via cfe-commits
Reply-To: Saleem Abdulrasool
Date: Saturday, January 6, 2018 at 10:48 AM
To: "cfe-commits@lists.llvm.org"
Subject: [libcxx] r321937 - Correct mistake in pragma usage for Windows
Author: c
This seems bogus to me. CodeView can be generated on any build platform; it
just needs the correct triple, which Reid added in r326144.
From: cfe-commits on behalf of Adam Nemet
via cfe-commits
Reply-To: Adam Nemet
Date: Monday, February 26, 2018 at 8:51 PM
To: "cfe-commits@lists.llvm.org"
S
Could you point me to the specific bot that was failing? I've dealt with that
problem before, and it shouldn't be hard to fix, but I wanna monitor the bot
after the fix to make sure it stays green.
From: on behalf of Adam Nemet
Date: Monday, February 26, 2018 at 9:30 PM
To: Shoaib Meenai
Cc:
Thanks. I'm building on macOS locally to confirm the original problem and my
fix.
From: on behalf of Adam Nemet
Date: Monday, February 26, 2018 at 9:42 PM
To: Shoaib Meenai
Cc: "cfe-commits@lists.llvm.org" , Reid Kleckner
, Zachary Turner
Subject: Re: r326168 - Attempt to fix greendragon bot
Reid re-committed r326141 this morning (and followed up with r326144), and I
don't think either of those have been reverted?
From: Zachary Turner
Date: Monday, February 26, 2018 at 9:47 PM
To: Adam Nemet
Cc: Shoaib Meenai , "cfe-commits@lists.llvm.org"
, Reid Kleckner
Subject: Re: r326168 - A
Author: smeenai
Date: Mon Feb 26 22:04:23 2018
New Revision: 326171
URL: http://llvm.org/viewvc/llvm-project?rev=326171&view=rev
Log:
[Driver] Fix codeview-column-info on macOS
macOS home directory paths begin with /Users, and clang-cl interprets
the /U portion as a macro undefine rather than a p
r326171 works locally. I'll keep an eye on the bots.
From: on behalf of Adam Nemet
Date: Monday, February 26, 2018 at 9:51 PM
To: Shoaib Meenai
Cc: Zachary Turner , "cfe-commits@lists.llvm.org"
, Reid Kleckner
Subject: Re: r326168 - Attempt to fix greendragon bot after r326141
Yep.
On Feb
Hmm. Reid had included a fix for compiler-rt in r326141, but that doesn't seem
particularly relevant to this failure. In any case, I expect I'll receive
emails when that bot is up and running again, and I can take a look then. (It
didn't repro locally on Linux for me.)
From: Zachary Turner
Dat
Author: smeenai
Date: Mon Mar 19 12:34:39 2018
New Revision: 327892
URL: http://llvm.org/viewvc/llvm-project?rev=327892&view=rev
Log:
[CodeGen] Add funclet token to ARC marker
The inline assembly generated for the ARC autorelease elision marker
must have a funclet token if it's emitted inside a f
Author: smeenai
Date: Fri Jun 1 17:49:54 2018
New Revision: 333808
URL: http://llvm.org/viewvc/llvm-project?rev=333808&view=rev
Log:
[cmake] Use LLVM's check_linker_flag
LLVM already defines this function, so make use of it instead of rolling
our own.
Modified:
cfe/trunk/tools/driver/CMakeL
Author: smeenai
Date: Fri Jun 1 18:22:39 2018
New Revision: 333810
URL: http://llvm.org/viewvc/llvm-project?rev=333810&view=rev
Log:
[cmake] Support LLD for CLANG_ORDER_FILE
LLD also supports order files using the `--symbol-ordering-file` option.
As the name would suggest, the order file format
Author: smeenai
Date: Wed Jun 6 16:09:02 2018
New Revision: 334145
URL: http://llvm.org/viewvc/llvm-project?rev=334145&view=rev
Log:
[Driver] Stop passing -fseh-exceptions for x86_64-windows-msvc
-fseh-exceptions is only meaningful for MinGW targets, and that driver
already has logic to pass eit
Author: smeenai
Date: Thu Jun 7 13:07:52 2018
New Revision: 334224
URL: http://llvm.org/viewvc/llvm-project?rev=334224&view=rev
Log:
[Parse] Use CapturedStmt for @finally on MSVC
The body of a `@finally` needs to be executed on both exceptional and
non-exceptional paths. On landingpad platforms,
Author: smeenai
Date: Thu Jun 7 15:24:20 2018
New Revision: 334240
URL: http://llvm.org/viewvc/llvm-project?rev=334240&view=rev
Log:
Revert "[Parse] Use CapturedStmt for @finally on MSVC"
This reverts commit r334224.
This is causing buildbot failures on Windows, presumably because some
tests do
Author: smeenai
Date: Thu Jun 7 15:54:54 2018
New Revision: 334243
URL: http://llvm.org/viewvc/llvm-project?rev=334243&view=rev
Log:
[Frontend] Disallow non-MSVC exception models for windows-msvc targets
The windows-msvc target is used for MSVC ABI compatibility, including
the exceptions model.
Author: smeenai
Date: Thu Jun 7 17:30:00 2018
New Revision: 334251
URL: http://llvm.org/viewvc/llvm-project?rev=334251&view=rev
Log:
Reapply "[Parse] Use CapturedStmt for @finally on MSVC"
This reapplies r334224 and adds explicit triples to some tests to fix
them on Windows (where otherwise they
Author: smeenai
Date: Thu Jun 7 17:41:01 2018
New Revision: 334253
URL: http://llvm.org/viewvc/llvm-project?rev=334253&view=rev
Log:
[CodeGen] Always use MSVC personality for windows-msvc targets
The windows-msvc target is meant to be ABI compatible with MSVC,
including the exception handling. E
Author: smeenai
Date: Thu Jun 14 16:26:33 2018
New Revision: 334780
URL: http://llvm.org/viewvc/llvm-project?rev=334780&view=rev
Log:
[cmake] Add linker detection for Apple platforms
LLVM currently assumes that Apple platforms will always use ld64. In the
future, LLD Mach-O might also be supporte
Comment inline (Outlook handles quoting terribly, so I'm not sure how much
it'll end up standing out, but I believe you typo'd "preprocessor" as "
prepreocssor").
From: cfe-commits on behalf of Richard
Smith via cfe-commits
Reply-To: Richard Smith
Date: Wednesday, October 31, 2018 at 5:49 PM
Author: smeenai
Date: Wed Nov 7 16:29:33 2018
New Revision: 346378
URL: http://llvm.org/viewvc/llvm-project?rev=346378&view=rev
Log:
[clang] Set CMP0075 to new
Make the check_include_file* macros honor CMAKE_REQUIRED_LIBRARIES. This
shouldn't cause any of the configuration checks to give differe
Author: smeenai
Date: Wed Nov 14 11:16:22 2018
New Revision: 346882
URL: http://llvm.org/viewvc/llvm-project?rev=346882&view=rev
Log:
[AST] Fix typo in MicrosoftMangle
Correct the spelling from Artifical to Artificial.
Differential Revision: https://reviews.llvm.org/D54536
Modified:
cfe/tru
Could we merge this into 7.0.1? It's a trivial typo fix, and the error message
could otherwise be confusing to users (someone brought this up in IRC a few
hours ago).
From: cfe-commits on behalf of Alex Lorenz
via cfe-commits
Reply-To: Alex Lorenz
Date: Friday, September 7, 2018 at 12:01 PM
If it's not too late, could we have this as part of 7.0.1? (You'll also
need to cherry-pick the initial reversion in r338602.) 7.0 hits assertion
failures for pretty basic memcpy cases on windows-msvc targets, and this
patch fixes that.
% cat /tmp/reduced.c
void *memcpy(void *, const void *, __SIZ
: Shoaib Meenai
Cc: cfe-commits , Tom Stellard
Subject: Re: r338941 - [constexpr] Support for constant evaluation of
__builtin_memcpy and
On Mon, 26 Nov 2018, 11:50 Richard Smith
mailto:rich...@metafoo.co.uk> wrote:
On Wed, 21 Nov 2018, 15:32 Shoaib Meenai via cfe-commits
mailto:cfe-comm
Author: smeenai
Date: Mon Mar 4 13:19:53 2019
New Revision: 355340
URL: http://llvm.org/viewvc/llvm-project?rev=355340&view=rev
Log:
[build] Rename clang-headers to clang-resource-headers
Summary:
The current install-clang-headers target installs clang's resource
directory headers. This is diffe
Author: smeenai
Date: Mon Mar 4 13:19:53 2019
New Revision: 355340
URL: http://llvm.org/viewvc/llvm-project?rev=355340&view=rev
Log:
[build] Rename clang-headers to clang-resource-headers
Summary:
The current install-clang-headers target installs clang's resource
directory headers. This is diffe
Author: smeenai
Date: Mon Mar 4 16:38:32 2019
New Revision: 355354
URL: http://llvm.org/viewvc/llvm-project?rev=355354&view=rev
Log:
[cmake] Create exports for umbrella library targets
When using the umbrella llvm-libraries and clang-libraries targets, we
should export all library targets, other
Author: smeenai
Date: Mon Mar 11 11:53:57 2019
New Revision: 355853
URL: http://llvm.org/viewvc/llvm-project?rev=355853&view=rev
Log:
[clang] Add install targets for API headers
Add an install target for clang's API headers, which allows them to be
included in distributions. The install rules alr
Author: smeenai
Date: Tue Mar 26 15:16:53 2019
New Revision: 357036
URL: http://llvm.org/viewvc/llvm-project?rev=357036&view=rev
Log:
[cmake] Reset variable before using it
A bunch of macros use the same variable name, and since CMake macros
don't get their own scope, the value persists across ma
Author: smeenai
Date: Thu Mar 28 10:01:20 2019
New Revision: 357184
URL: http://llvm.org/viewvc/llvm-project?rev=357184&view=rev
Log:
[CodeGen] Add additional mangling for struct members of non trivial structs
In https://bugs.llvm.org/show_bug.cgi?id=41206 we observe bad codegen
when embedding a
Author: smeenai
Date: Thu Oct 4 12:50:14 2018
New Revision: 343808
URL: http://llvm.org/viewvc/llvm-project?rev=343808&view=rev
Log:
[AST] Revert mangling changes from r339428
As discussed in https://reviews.llvm.org/D50144, we want Obj-C classes
to have the same mangling as C++ structs, to supp
Just wanted to point out that r350920 is on the 8.0 release branch as well. I
don't know if there are any additional considerations there.
On 1/31/19, 2:20 PM, "cfe-commits on behalf of John McCall via cfe-commits"
wrote:
On 31 Jan 2019, at 16:57, Akira Hatanaka wrote:
> all copy/move constructors are deleted seems reasonable to me.
>
> On Thu, 31 Jan 2019 at 14:31, Shoaib Meenai via cfe-commits
> wrote:
>>
>> Just wanted to point out that r350920 is on the 8.0 release branch as
well. I don't know if there a
I was gonna point to the directions for using llvm/utils/git-svn/git-svnrevert,
but it looks like that script only works with git svn and not with the git
monorepo. James, was updating the revert script something on your roadmap? If
not, I'd be happy to take a stab at it (and I'm wondering if it
Should this be considered for 8.0? It's late in the branch and I don't know how
prevalent the issue being fixed is, but it caught my eye.
From: cfe-commits on behalf of Erik
Pilkington via cfe-commits
Reply-To: Erik Pilkington
Date: Wednesday, February 13, 2019 at 12:32 PM
To: "cfe-commits@li
I don't think Hans ended up getting added to the recipients? (Unless Outlook is
being silly or it was a BCC, in which case I apologize for the spam.)
On 2/14/19, 3:16 PM, "cfe-commits on behalf of Erik Pilkington via
cfe-commits" wrote:
Hans, can you merge this diagnostic regression fix i
Author: smeenai
Date: Fri Feb 15 07:59:02 2019
New Revision: 354140
URL: http://llvm.org/viewvc/llvm-project?rev=354140&view=rev
Log:
[clang] Create install targets for non-shared libraries
I don't see a reason for these to not have install targets created,
which in turn allows them to be bundled
Author: smeenai
Date: Fri Feb 15 07:59:04 2019
New Revision: 354141
URL: http://llvm.org/viewvc/llvm-project?rev=354141&view=rev
Log:
[clang] Add build and install targets for clang libraries
This is modeled after the existing llvm-libraries target. It's a
convenient way to include all clang libr
Author: smeenai
Date: Wed Feb 20 15:08:43 2019
New Revision: 354525
URL: http://llvm.org/viewvc/llvm-project?rev=354525&view=rev
Log:
[clang] Switch to LLVM_ENABLE_IDE
r344555 switched LLVM to guarding install targets with LLVM_ENABLE_IDE
instead of CMAKE_CONFIGURATION_TYPES, which expresses the
Author: smeenai
Date: Wed Feb 20 15:16:15 2019
New Revision: 354527
URL: http://llvm.org/viewvc/llvm-project?rev=354527&view=rev
Log:
[clang] Add CMake target for installing clang's CMake exports
This mirrors LLVM's install-cmake-exports target.
Differential Revision: https://reviews.llvm.org/D5
Note that Reid restored the old behavior in r312043.
Configuring with -DLLVM_APPEND_VC_REV=OFF should also restore the old
behavior, I believe.
On 9/9/17, 1:55 PM, "cfe-commits on behalf of Dimitry Andric via cfe-commits"
wrote:
On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits
wr
Author: smeenai
Date: Thu Sep 14 11:23:43 2017
New Revision: 313284
URL: http://llvm.org/viewvc/llvm-project?rev=313284&view=rev
Log:
[libc++] Prevent stale site configuration headers
If we define cmake macros that require a site config, and then undefine
all such macros, a stale site config head
Author: smeenai
Date: Thu Sep 14 23:19:31 2017
New Revision: 313345
URL: http://llvm.org/viewvc/llvm-project?rev=313345&view=rev
Log:
[libc++] Remove unnecessary struct tag
It causes warnings about mismatched tags, and it's not needed.
Modified:
libcxx/trunk/include/typeinfo
Modified: libcx
Author: smeenai
Date: Fri Sep 15 11:49:34 2017
New Revision: 313377
URL: http://llvm.org/viewvc/llvm-project?rev=313377&view=rev
Log:
[libc++] Account for Microsoft CRT const overloads
Microsoft's CRT already provides the const overloads, and it defines the
`_CRT_CONST_CORRECT_OVERLOADS` macro to
Author: smeenai
Date: Thu Jul 11 14:20:38 2019
New Revision: 365825
URL: http://llvm.org/viewvc/llvm-project?rev=365825&view=rev
Log:
[clang-shlib] Fix clang-shlib for PRIVATE dependencies
Any static library with a PRIVATE dependency ends up with a
$ generator expression in its INTERFACE_LINK_LIB
clang-shlib] Fix clang-shlib for PRIVATE dependencies
On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: smeenai
Date: Thu Jul 11 14:20:38 2019
New Revision: 365825
URL:
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_
To: Shoaib Meenai mailto:smee...@fb.com>>
Cc: cfe-commits mailto:cfe-commits@lists.llvm.org>>
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author
sable building the latter if the former is set?
From: Alex Bradbury mailto:a...@lowrisc.org>>
Date: Friday, July 12, 2019 at 2:02 AM
To: Shoaib Meenai mailto:smee...@fb.com>>
Cc: cfe-commits mailto:cfe-commits@lists.llvm.org>>
Subject: Re: r365825 - [clang-shlib] Fix clang-
cfe-commits mailto:cfe-commits@lists.llvm.org>>
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: smeenai
Date: Thu Jul 11 14:20:38 2019
New Revis
Author: smeenai
Date: Fri Jul 12 10:23:35 2019
New Revision: 365922
URL: http://llvm.org/viewvc/llvm-project?rev=365922&view=rev
Log:
Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies
This reverts r365825 (git commit 3173c60f96c3ccfc17d403a192ae58e720153c23)
This is breaking BUILD_SH
Sorry about the breakage. I reverted it in r365922.
On 7/12/19, 9:12 AM, "Brian Rzycki via Phabricator"
wrote:
brzycki added a comment.
Hello @smeenai , this commit causes LLVM to fail to build when set set `-D
BUILD_SHARED_LIBS=ON`. Here is the failing CMake and Ninja invocation
>>
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: smeenai
Date: Thu Jul 11 14:20:38 2019
New Revision: 365825
URL:
https://urldefense.proofpoin
ARED_LIBS and the combined Clang dylib incompatible?
Should we disable building the latter if the former is set?
From: Alex Bradbury mailto:a...@lowrisc.org>>
Date: Friday, July 12, 2019 at 2:02 AM
To: Shoaib Meenai mailto:smee...@fb.com>>
Cc: cfe-commits mailto:cfe-commits@lists.
Author: smeenai
Date: Mon Aug 5 23:48:43 2019
New Revision: 367982
URL: http://llvm.org/viewvc/llvm-project?rev=367982&view=rev
Log:
[Driver] Introduce -stdlib++-isystem
There are times when we wish to explicitly control the C++ standard
library search paths used by the driver. For example, when
Author: smeenai
Date: Tue Aug 6 00:13:53 2019
New Revision: 367984
URL: http://llvm.org/viewvc/llvm-project?rev=367984&view=rev
Log:
[DirectoryWatcher] Fix asserts Mac builds
Add a missing semicolon after an assert. Remove the period from the
assert message while I'm here, because we don't usual
You missed a semicolon after an assert, which broke asserts Mac builds. I fixed
it in r367984.
From: cfe-commits on behalf of Puyan Lotfi
via cfe-commits
Reply-To: Puyan Lotfi
Date: Monday, August 5, 2019 at 10:11 PM
To: "cfe-commits@lists.llvm.org"
Subject: r367979 - [clang][DirectoryWatche
Why does this check for isKnownWindowsMSVCEnvironment specifically? Wouldn't
any COFF target (windows-cygnus, windows-gnu, windows-itanium, etc.) have the
same limitation, since it's an object file format issue and not an ABI issue?
From: cfe-commits on behalf of Erich Keane
via cfe-commits
R
Ah, looks like you were originally checking for COFF, and then David suggested
checking for MSVC instead? I'm curious about why, although I'm sure the
suggestion is legit :)
From: cfe-commits on behalf of Shoaib
Meenai via cfe-commits
Reply-To: Shoaib Meenai
Date: Tuesday, Janua
ke you were originally checking for COFF, and then David suggested
checking for MSVC instead? I'm curious about why, although I'm sure the
suggestion is legit :)
From: cfe-commits
mailto:cfe-commits-boun...@lists.llvm.org>>
on behalf of Shoaib Meenai via cfe-commits
mailto:cf
- Limit COFF 'common' emission to <=32 alignment types.
Ah, looks like you were originally checking for COFF, and then David suggested
checking for MSVC instead? I'm curious about why, although I'm sure the
suggestion is legit :)
From: cfe-commits
mailto:cfe-commits
Author: smeenai
Date: Wed Jan 9 12:05:16 2019
New Revision: 350754
URL: http://llvm.org/viewvc/llvm-project?rev=350754&view=rev
Log:
[CodeGen] Clarify comment about COFF common symbol alignment
After a discussion on the commit thread, it seems the 32 byte alignment
limitation is an MSVC toolchai
This is missing an attribution of changes, right?
From: cfe-commits on behalf of David
Chisnall via cfe-commits
Reply-To: David Chisnall
Date: Wednesday, April 11, 2018 at 11:49 PM
To: "cfe-commits@lists.llvm.org"
Subject: r329882 - ObjCGNU: Fix empty v3 protocols being emitted two fields
sh
AFAIK you need to add the "Patch by …" line manually. I don't know if arc is
supposed to preserve the original commit author information, though I would
suspect the version control system itself plays a role there.
From: David Chisnall on behalf of David Chisnall
Date: Thursday, April 12, 201
Author: smeenai
Date: Tue May 1 13:38:05 2018
New Revision: 331305
URL: http://llvm.org/viewvc/llvm-project?rev=331305&view=rev
Log:
[ARM] Remove redundant #if in test. NFC
Both sides of this #if #include the same file. Drop the #if, leaving only the
#include.
Patch by Matt Glazar.
Differenti
Author: smeenai
Date: Tue May 1 13:45:25 2018
New Revision: 331306
URL: http://llvm.org/viewvc/llvm-project?rev=331306&view=rev
Log:
[libclang] Fix the type of 'int (Foo);'
libclang exposes the type of 'int (Foo);' (a global variable of type int
called Foo) as CXType_Unexposed. This is because C
The check lines added here are failing for me on CentOS 7.
https://reviews.llvm.org/P8091 has the lit output and the actual output being
produced by one of the added RUN lines. My llvm and clang repositories are in
sync. Any idea what might be going on here?
From: cfe-commits on behalf of Tere
Author: smeenai
Date: Tue Jun 26 16:18:59 2018
New Revision: 335686
URL: http://llvm.org/viewvc/llvm-project?rev=335686&view=rev
Log:
[clang] Add test dependency on llvm-as
r335618 added tests that invoke llvm-as, so we should also ensure that
running clang tests rebuilds llvm-as.
Modified:
Ah, my llvm-as was indeed out of date. I made check-clang depend on llvm-as in
r335686 to avoid this issue in the future.
From: Teresa Johnson
Date: Tuesday, June 26, 2018 at 4:11 PM
To: Shoaib Meenai
Cc: "cfe-commits@lists.llvm.org"
Subject: Re: r335618 - [ThinLTO] Add testing of summary inde
Author: smeenai
Date: Fri Jun 29 18:04:50 2018
New Revision: 336032
URL: http://llvm.org/viewvc/llvm-project?rev=336032&view=rev
Log:
[libc++abi] Limit libc++ header search to specified paths
Right now, when libc++abi is locating libc++ headers, it specifies
several search locations, but it also
Author: smeenai
Date: Fri Jun 29 18:25:47 2018
New Revision: 336034
URL: http://llvm.org/viewvc/llvm-project?rev=336034&view=rev
Log:
[libc++abi] Look for __config instead of vector
vector is a generic C++ header, whereas __config is libc++-specific, so
we can look for it instead to guarantee we'
Author: Han Zhu
Date: 2020-04-27T13:37:07-07:00
New Revision: f8990feb125a0f8d3f2892a589bc6fad3c430858
URL:
https://github.com/llvm/llvm-project/commit/f8990feb125a0f8d3f2892a589bc6fad3c430858
DIFF:
https://github.com/llvm/llvm-project/commit/f8990feb125a0f8d3f2892a589bc6fad3c430858.diff
LOG:
Author: Han Zhu
Date: 2020-05-06T19:33:58-07:00
New Revision: 0c9230dad1692bc3d8f1ce2dddae413a115f2532
URL:
https://github.com/llvm/llvm-project/commit/0c9230dad1692bc3d8f1ce2dddae413a115f2532
DIFF:
https://github.com/llvm/llvm-project/commit/0c9230dad1692bc3d8f1ce2dddae413a115f2532.diff
LOG:
smeenai added inline comments.
Comment at: include/__config:559
@@ -554,1 +558,3 @@
+# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS
+# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS
#endif
compnerd wrote:
> Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION
Author: smeenai
Date: Mon Sep 19 13:29:07 2016
New Revision: 281925
URL: http://llvm.org/viewvc/llvm-project?rev=281925&view=rev
Log:
[libc++] Fix extern template visibility for Windows
On Windows, marking an `extern template class` declaration as exported
actually forces an instantiation, which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281925: [libc++] Fix extern template visibility for Windows
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24679?vs=71685&id=71861#toc
Repository:
rL LLVM
https://reviews.
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
On Windows builds, we currently require `_LIBCPP_DLL` to be specified in
order for dllexport/dllimport annotations to be generated. I believe
it's better to do the opposi
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Visual Studio 2013 and onward have all the required functions in their
CRT headers, and we don't support older versions anymore.
https://reviews.llvm.org/D24879
Files:
smeenai added a comment.
It's worth noting that the entirety of the deleted file was guarded by a `#if
((_VC_CRT_MAJOR_VERSION-0) < 12)` anyway (i.e. it would only be included on
Visual Studio 2012 and below), so the code was already dead :)
https://reviews.llvm.org/D24879
_
Author: smeenai
Date: Sat Sep 24 01:27:28 2016
New Revision: 282328
URL: http://llvm.org/viewvc/llvm-project?rev=282328&view=rev
Log:
[libc++] Remove math_win32.h
Visual Studio 2013 and onward have all the required functions in their
CRT headers, and we don't support older versions anymore.
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282328: [libc++] Remove math_win32.h (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24879?vs=72330&id=72389#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24879
Files:
smeenai abandoned this revision.
smeenai added a comment.
Your patch looks good to me and is a nicer way of accomplishing this. Thanks
for taking care of it!
https://reviews.llvm.org/D24877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
`__declspec(dllexport)` and `__declspec(dllimport)` should only be used
when building libc++abi as a DLL, but that's the more com
smeenai updated this revision to Diff 72598.
smeenai added a comment.
Addressing @EricWF's comment
https://reviews.llvm.org/D24945
Files:
CMakeLists.txt
include/__cxxabi_config.h
Index: include/__cxxabi_config.h
===
--- includ
smeenai marked an inline comment as done.
smeenai added a comment.
https://reviews.llvm.org/D24945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: smeenai
Date: Mon Sep 26 22:44:09 2016
New Revision: 282470
URL: http://llvm.org/viewvc/llvm-project?rev=282470&view=rev
Log:
[libc++abi] Default to DLL annotations on Windows
`__declspec(dllexport)` and `__declspec(dllimport)` should only be used
when building libc++abi as a DLL, but tha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282470: [libc++abi] Default to DLL annotations on Windows
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24945?vs=72598&id=72599#toc
Repository:
rL LLVM
https://reviews.ll
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Replace a stale reference to cxx_EXPORTS with _LIBCPP_BUILDING_LIBRARY,
and clarify why the operator new and delete family of functions are
marked dllexport when building
smeenai updated this revision to Diff 72891.
smeenai added a comment.
Clarifying code comment
https://reviews.llvm.org/D25042
Files:
include/new
Index: include/new
===
--- include/new
+++ include/new
@@ -125,8 +125,18 @@
} /
smeenai updated this revision to Diff 72911.
smeenai added a comment.
Moving documentation to documentation file, per @EricWF's comment
https://reviews.llvm.org/D25042
Files:
docs/DesignDocs/VisibilityMacros.rst
include/new
Index: include/new
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282644: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D25042?vs=72911&id=72915#toc
Repository:
rL LLVM
https://reviews.
1 - 100 of 385 matches
Mail list logo
