[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously for nowait target, CG emitted a function call to `__tgt_target_nowait`, etc. However, in OpenMP RTL, these functions just dir

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 added a comment. In D78075#1980746 , @jdoerfert wrote: > You need to update the tests too. Yeah, I will do that. Basically I would like to do that if this direction is not wrong... :-) Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd7e4188a09: Replace separator in OpenMP variant name mangling. (authored by LukasSommerTu, committed by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 274223. tianshilei1992 added a comment. Herald added a subscriber: sstefan1. Will update failed tests later CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/CGOpenMPRuntime.c

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a comment. In D129008#3640233 , @jdoerfert wrote: > In D129008#3640194 , > @tianshilei1992 wrote: > >> `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. > > Don't w

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

tianshilei1992 added a comment. Is it a good idea to define variables starting with `CMAKE`? That might be confusing for later maintenance by other developers because chances are that they will think those variables are CMake provided variables, try to look up into CMake document to see what th

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 updated this revision to Diff 441742. tianshilei1992 added a comment. fix unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 updated this revision to Diff 441908. tianshilei1992 added a comment. rebase and fix test error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008 Files: clang/lib/CodeGen/CGDecl.cpp clang

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

tianshilei1992 updated this revision to Diff 442585. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127042/new/ https://reviews.llvm.org/D127042 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema/Sem

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

tianshilei1992 updated this revision to Diff 442588. tianshilei1992 added a comment. remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127042/new/ https://reviews.llvm.org/D127042 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D129211: [Clang][Doc] Update the release note for clang

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Add the support for `atomic compare` and `atomic

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83837a61981c: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series (authored by tianshilei1992). Changed prior to commit: h

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008

[PATCH] D129211: [Clang][Doc] Update the release note for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG114df244ec50: [Clang][Doc] Update the release note for clang (authored by tianshilei1992). Changed prior to commit: https://reviews.llvm.org/D1292

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: pengfei, guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clan

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; ABataev wrote: > Better to make it a property of MappedVars. Also, are there any iss

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 updated this revision to Diff 450469. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131272/new/ https://reviews.llvm.org/D131272 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp c

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; tianshilei1992 wrote: > ABataev wro

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21202dac18e: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

tianshilei1992 added a comment. `bool` is used by a function declaration `__ockl_fdot2` in `clang/lib/Headers/__clang_hip_libdevice_declares.h`, which is included by `clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

tianshilei1992 added a comment. This patch causes wrong arguments in nested parallel regions. `openmp/libomptarget/test/offloading/bug49779.cpp` fails and after reverting this patch, it passed. You can easily find out the wrong pointer with a tiny change of the test case: void work(int *C) {

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 updated this revision to Diff 361387. tianshilei1992 added a comment. rebase and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/tes

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 added a comment. @ABataev I updated the description. If you agree with my understanding, I'll land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 _

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3274cdc83ecd: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1 (authored by tianshilei1992). Repository: rG LLVM Github Monor

[PATCH] D100582: [WIP][OpenMP][Offloading] New device runtime library - Not for review

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. Herald added a subscriber: ormris. We're moving to D106803 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100582/new/ https://reviews.llvm.or

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0276db14167b: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit`… (authored by Jose M Monsalve Diaz ,

[PATCH] D106033: [OpenMP] Folding threadLimit and numThreads when single value in kernels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ab6aedda9d9: [OpenMP] Folding threadLimit and numThreads when single value in kernels (authored by Jose M Monsalve Diaz , co

[PATCH] D106674: Runtime for Interop directive

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:13 +static omp_interop_rc_t +__kmpc_interop_get_property_err_type(omp_interop_property_t property) { + switch (property) { tianshilei1992 wrote: > There are some conventions in

[PATCH] D106674: Runtime for Interop directive

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:1150-1156 + CUresult Err = cuDeviceGet(&Dev, DeviceId); + if (Err == CUDA_SUCCESS) { +DeviceInfo->Device = reinterpret_cast(Dev); + } else { +cuGetErrorSt

[PATCH] D121466: [OpenMP] Replace math headers with OpenMP wrapper calls

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM. Support the header file is actually generated automatically. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121466/new/

[PATCH] D122133: [LTO] Add configuartion option to use default optimization pipeline

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I tested it locally, and it fixes the performance regression. Since it is internal flag, it will not break any existing code. I'm okay with the change. Not sure if we want to a

[PATCH] D123460: [OpenMP] Make generating offloading entries more generic

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. If we'd like it to be used by CUDA or other programming models, `llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp` is not a good place. Other than that, the patch looks good to me.

[PATCH] D123235: atomic compare fail : Parser & AST support

tianshilei1992 added a comment. In D123235#3444644 , @koops wrote: > Can I please have the detailed log for the build failures? I do not have the > necessary setup to test those builds. You can find it https://buildkite.com/llvm-project/premerge-checks

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

tianshilei1992 created this revision. tianshilei1992 added reviewers: ABataev, jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repos

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 423132. tianshilei1992 added a comment. Herald added a project: All. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/include/clang/AST/St

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2835-2847 bool IsXLHSInRHSPart = false; /// Used for 'atomic update' or 'atomic capture' constructs. They may /// have atomic expressio

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

tianshilei1992 added a comment. In D123862#3454380 , @ABataev wrote: > What about ASTStmtWriter? It's using accessor function `isXLHSInRHSPart()` and so on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8760b51ee0f: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective` (authored by tianshilei1992). Repository: rG LLVM Github Monorepo C

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 423198. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11663 X = BO->getLHS(); - D = BO->getRHS(); + D = BO->getRHS()->IgnoreImpCasts(); ABataev wrote: > Why do we need to use `IgnoreImpCasts()` here and in other places? Clang usua

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405645. tianshilei1992 added a comment. Fix template instantiation and add one test. More tests are on the way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

tianshilei1992 added a comment. Not sure if it's good to merge such a large patch. We could potentially split the patch to three independent patches: tool chain, device runtime, and the OpenMPOpt pass to support expansion of shared variable (which for some reason is not included in this patch.

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405703. tianshilei1992 added a comment. refine the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. @ABataev @jdoerfert I got a question about writing the test. `atomic compare` is supported from 5.1. Basically we have three ways to guard those `atomic compare` code: 1. Use macro `_OPENMP`. This pretty much works with one exception: we don't set the macro for

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:35 } +// omp50-error@+4 {{unexpected OpenMP clause 'compare' in directive '#pragma omp atomic'}} +// omp50-note@+4 {{expected an expression statement}} ABataev wrote: > a

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3294390 , @ABataev wrote: > In D116637#3294361 , > @tianshilei1992 wrote: > >> @ABataev @jdoerfert I got a question about writing the test. `atomic >> compare` is suppo

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3294474 , @ABataev wrote: > In D116637#3294466 , > @tianshilei1992 wrote: > >> In D116637#3294390 , @ABataev >> wrote: >> >>>

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3294498 , @ABataev wrote: > In D116637#3294490 , > @tianshilei1992 wrote: > >> In D116637#3294474 , @ABataev >> wrote: >> >>>

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405725. tianshilei1992 added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:10 +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s + +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp-si

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:964 + // CHECK-51-NEXT: } + // omp51-note@+1 {{in instantiation of function template specialization 'foo' requested here}} return foo(a); I cannot figure out why I have

[PATCH] D118934: [OpenMP] Completely remove old device runtime

tianshilei1992 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2470 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -defm openmp_target_new_runtime: BoolFOption<"openmp-target-new-runtime", - LangOpts<"OpenMPTargetNewRuntime">, DefaultTrue, -

[PATCH] D118934: [OpenMP] Completely remove old device runtime

tianshilei1992 added a comment. If this patch can be back ported to 14, then it's totally fine to remove the argument. Otherwise keeping it sounds more reasonable. If we keep it, we'd better to emit a warning and then we could remove it in 15 or other version w/o any concern that we don't tell

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:964 + // CHECK-51-NEXT: } + // omp51-note@+1 {{in instantiation of function template specialization 'foo' requested here}} return foo(a)

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8163 +CmdArgs.push_back(Args.MakeArgString( +"-cuda-path=" + CudaInstallation.getInstallPath())); + break; Would be better to keep aligned with `clang

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118944/new/ https://reviews.llvm.org/D118944 _

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405827. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files:

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11206 +if (!E->isInstantiationDependent()) { + auto Type = E->getType(); + if (!Type->isScalarType()) { ABataev wrote: >

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405837. tianshilei1992 added a comment. add final test and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/Diag

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:10 +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s + +//

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405967. tianshilei1992 added a comment. add TODO for PCH test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:40 +#ifdef OMP51 +// omp51-error@+1 2 {{atomic compare is not supported for now}} +#pragma omp atomic compare ABataev wrote:

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_ast_print.cpp:40 +#ifdef OMP51 +// omp51-error@+1 2 {{atomic compare is not supported for now}} +#pragma omp atomic compare ABataev wrote:

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 405985. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. move error to code gen and add missing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://rev

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb35be6fe98e3: [Clang][Sema][OpenMP] Sema support for `atomic compare` (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406008. tianshilei1992 added a comment. rebase and make preparation for codegen in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files: clang/include

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406012. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. remove leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297387 , @cmtice wrote: > This commit is causing some of our builds to fail with these errors: > > clang/lib/Sema/SemaOpenMP.cpp:11372:9: error: unused variable 'D' > [-Werror,-Wunused-variable] > > Expr *D =

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297785 , @kda wrote: > This still seems to be breaking sanitizers fast: > https://lab.llvm.org/buildbot/#/builders/5/builds/18563 > > To reproduce these results: > https://github.com/google/sanitizers/wiki/Sani

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297833 , @jdoerfert wrote: > In D116637#3297790 , > @tianshilei1992 wrote: > >> In D116637#3297785 , @kda wrote: >> >>> This s

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3298635 , @cmtice wrote: > When building/running > third_party/llvm/llvm-project/clang/test/OpenMP/atomic_messages.c and > third_party/llvm/llvm-project/clang/test/OpenMP/atomic_ast_print.cpp, we get > use-of-

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406310. tianshilei1992 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files: clang/include/clang/AST/StmtOpenMP.h clang/lib/AST

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --include-generated-funcs --replace-value-regex "__omp_offloading_[0-9a

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406546. tianshilei1992 added a comment. fix clang crash and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files: clang/include/clang/AST/StmtOpenMP.

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEXT:[[TMP1:%.*]] = atomicrmw umin i8* [[CX]], i

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr; + Using `D->IgnoreImpCasts()` c

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 406867. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/include/clang/AST/OpenMPClause.h clang/include/

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev w

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407307. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. rebase and mark related functions as unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https:/

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev w

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407309. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. use `LLVM_FALLTHROUGH` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407312. tianshilei1992 added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/include/clang/AST/OpenMPClause.h clang/include

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This is a follow-up patch of D1193

[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

tianshilei1992 added inline comments. Comment at: README.md:71 + mlir, openmp, polly, or pstl. ``LLVM_ENABLE_RUNTIMES`` can include any of + libcxx, libcxxabi, libunwind, or compiler-rt. FWIW, OpenMP can be put into either of them. In OpenMP

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 updated this revision to Diff 407387. tianshilei1992 added a comment. recover test cases removed by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 Files: clang/lib/Sema/SemaOpenM

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +//

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +//

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407701. tianshilei1992 added a comment. remove the dummy node Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp cla

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +//

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407868. tianshilei1992 added a comment. fix errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11790-11797 +if (IsCompareCapture) { + // TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore + // code gen. + un

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 408226. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: cla

  1   2   3   4   5   6   >