tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments.
================ Comment at: clang/test/OpenMP/atomic_ast_print.cpp:10 +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s + +// RUN: %clang_cc1 -DOMP51 -verify=omp51 -fopenmp-simd -fopenmp-version=51 -ast-print %s | FileCheck --check-prefixes=CHECK,CHECK-51 %s ---------------- ABataev wrote: > tianshilei1992 wrote: > > @ABataev But still in this path, we cannot test `-emit-pch` because we will > > emit `atomic compare is not supported for now` anyway, and it cannot be > > worked around. I'll add it in the codegen patch or in a following patch of > > codegen. > Why? It should be tested. > ``` > // RUN: %clang_cc1 -fopenmp -DOMP51 -fopenmp-version=51 -x c++ -std=c++11 > -emit-pch -o %t %s > // RUN: %clang_cc1 -fopenmp -DOMP51 -fopenmp-version=51 -std=c++11 > -include-pch %t -fsyntax-only -verify %s -ast-print | FileCheck %s > ``` > Could you try this? I did, but since the first command can emit errors, the test fails. It should be tested. I'll add it back when we don't emit error in Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
