[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec446ddcee3: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr… (authored by shafik). Herald added a project: clang. Changed p

[PATCH] D129951: adds `__disable_adl` attribute

shafik added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:542 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the statement wi

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, hubert.reinterpretcast. Herald added a project: All. shafik requested review of this revision. Currently the implementation of `__VA_OPT__` will treat the concatenation of a non-placemaker token and placemaker token

[PATCH] D142316: [clang] Add test for CWG2396

shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } While gcc accep

[PATCH] D142639: [clang] Warn by default that implicit capture of 'this' is deprecated in C++20 and later.

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142639/new/ https://reviews.llvm.org/D142639 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492560. shafik added a comment. - Update line ending in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p1042r1.cpp Index:

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492562. shafik added a comment. - I think I correctly updated line endings this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vao

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added inline comments. Comment at: clang/test/Preprocessor/macro_vaopt_p1042r1.cpp:1 - RUN: %clang_cc1 -E %s -pedantic -std=c++2a | FileCheck -strict-whitespace %s - I removed Windows lines ending from this test, I don't think they matter but if someone c

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492589. shafik added a comment. - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p1042r1.cpp Index: clang/te

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added a comment. It looks like the modules test failures are unrelated and are failing all the recent modules builds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 ___ cfe-commits mailing l

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. In `TransformAttributedType(...)` when checking if `_Nullable` can be applied to a type it dereferences `TL.getAttr()` unconditionally which we c

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman. Herald added a project: All. shafik requested review of this revision. We provide several diagnostics for various undefined behaviors due to signed integer overflow outside of a constant expression context. We were m

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

shafik added subscribers: clang-language-wg, shafik. shafik added a comment. Adding `clang-language-wg` for more visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142692/new/ https://reviews.llvm.org/D142692 ___

[PATCH] D142316: [clang] Add test for CWG2396

shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:202 + // void g2(A a) { a.operator B decltype(B())::*(); } + // void h(A a) { a.operator identity::type B::*(); } + // void h2(A a) { a.operator B identity::type::*(); } Endill wrote: >

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik updated this revision to Diff 493351. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTransform.h clang/test/SemaCXX/nullability.cpp

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik updated this revision to Diff 493389. shafik marked an inline comment as done. shafik added a comment. - Fix up release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/TreeTran

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

shafik added a comment. The build failures look unrelated to this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142799/new/ https://reviews.llvm.org/D142799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D142799: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is applicable to a type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2bd8aeea7e7d: [Clang] Fix unconditional access to Attr pointer when checking if _Nullable is… (authored by shafik). Herald added a project: clang. R

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

shafik updated this revision to Diff 493641. shafik marked an inline comment as done. shafik added a comment. - Add release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142867/new/ https://reviews.llvm.org/D142867 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67ee18cc7a30: [Clang] Add machinery to catch overflow in unary minus outside of a constant… (authored by shafik). Herald added a project: clang. Rep

[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

shafik added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1415 +// +// FIXME: It looks not easy to balance PushExpressionEvaluationContext() +// and PopExpressionEvaluationContext(). It does seem a bit ad-hoc Repository: rG LLVM Github

[PATCH] D140614: [C++20] Mark lambdas in lambda specifiers as dependent if necessary

shafik added inline comments. Comment at: clang/test/SemaCXX/lambda-unevaluated.cpp:127 +auto foo(int t) { + int(*f)(int) = [](auto t) -> decltype([=] { return t; } ()) { return t; }; + return f; cor3ntin wrote: > I thought unevaluated lambdas could not have ca

[PATCH] D138453: [clang] Add serialization for loop hint annotation tokens

shafik added a comment. It looks like https://github.com/llvm/llvm-project/issues/60543 is hitting your added `llvm_unreachable("missing serialization code for annotation token");` is this expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D140455: [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

shafik updated this revision to Diff 488383. shafik marked 3 inline comments as done. shafik added a comment. - Move HandleOverflowResult closer to where it is used. - move int after constexpr in function rem - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140455/new/ h

[PATCH] D140455: [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

shafik updated this revision to Diff 488441. shafik added a comment. - Moving back HandleOverflowResult to before the switch statement to avoid "jump bypasses variable initialization" error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140455/new/ https://reviews.llvm.org/D140455 Fil

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:291 /// Returns whether we should create a global variable for the /// given VarDecl. + bool isGlobalDecl(const ValueDecl *VD) const { Comment at: clang/te

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1315 + if (InterpretBuiltin(S, PC, Func->getBuiltinID())) { +NewFrame.release(); +return true; We don't have to update `S.Current`? Comment at: clang/lib/AST/Inter

[PATCH] D140455: [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0138390dd2a: [Clang] Diagnose undefined behavior in a constant expression while evaluating a… (authored by shafik). Herald added a project: clang.

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

shafik added subscribers: aaron.ballman, shafik. shafik added a comment. I wonder if `ActionResult` needs a overload that takes `std::nullptr_t` the current interface seems easy to use wrong like we have seen here. @aaron.ballman wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138851: [Clang] Permit static constexpr variables in constexpr functions

shafik added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:246 + +constexpr double evaluate_static_constexpr() { + struct Constexpr{ Can we also add the test from the proposal as well for completeness sake: ``` constexpr char tes

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:10277-10281 + AddTemplateOverloadCandidate(TD, FoundDecl, /*ExplicitArgs*/ nullptr, + TmpInits, Candidates, + SuppressUserConversions, +

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:761 if (std::optional LocalIndex = allocateLocalPrimitive(SubExpr, *SubExprT, true, true)) { if (!this->visitInitializer(SubExpr)) Comm

[PATCH] D140724: [clang][Interp] Add back Run() call

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false; Why did you add these checks calling `checkingPotentialConstantExpressio

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

shafik added a comment. Is this PR still workable or does it need a major rework and should be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92733/new/ https://reviews.llvm.org/D92733 ___ cfe

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

shafik added a comment. In D92733#4051123 , @faisalv wrote: > I'll try and look into it this weekend and have some sort of updated news > for you by monday? > Faisal Vali Awesome, feel free to add me as a reviewer. If we can get this fixed that would awe

[PATCH] D140724: [clang][Interp] Add back Run() call

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/Interp.h:1301 assert(S.Current->getFunction()->hasRVO()); + if (S.checkingPotentialConstantExpression()) +return false;

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

shafik added inline comments. Comment at: clang/test/AST/Interp/cxx17.cpp:7 + +struct F { int a; int b;}; +constexpr F getF() { tbaeder wrote: > shafik wrote: > > It would also be good to test references, bit-fields, volatile and > > tuple-like types if possible

[PATCH] D140668: [clang][Interp] Implement remaining bits for MaterializeTemporaryExprs

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140668/new/ https://reviews.llvm.org/D140668 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM @aaron.ballman are you happy with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 _

[PATCH] D141681: [clang][Interp] Fix parameter map when re-visiting function

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:57 +ParamDescriptors.insert({ParamOffset, {Ty, Desc}}); +Params.insert({PD, ParamOffset}); +ParamOffset

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

shafik added a comment. Makes sense to me as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140838/new/ https://reviews.llvm.org/D140838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D141775: [Clang] Export CanPassInRegisters as a type trait

shafik added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5387 + return RD->canPassInRegisters(); +return true; } erichkeane wrote: > Is there good reason to return true for all non-record types? Should we > instead be limiting the ty

[PATCH] D141784: [clang][Interp] Fix binary comma operators

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141784/new/ https://reviews.llvm.org/D141784 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

shafik added a comment. Interesting it looks like neither gcc nor MSVC diagnose this either but it looks correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141803/new/ https://reviews.llvm.org/D141803 ___

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

shafik added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:379 + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), nullptr, + VK_PRValue, FPOptionsOverride());

[PATCH] D142315: [clang] Add test for CWG1111

shafik added inline comments. Comment at: clang/www/cxx_dr_status.html:6476 Remove dual-scope lookup of member template names -Unknown +Clang 6 aaron.ballman wrote: > erichkeane wrote: > > Were you able to track down which patch fixed this in cla

[PATCH] D142316: [clang] Add test for CWG2396

shafik added a comment. You mention CWG2385 as na but you don't explain how it was resolved, was it superceded by p1787 . Also nitpick you mentioned `P1787` in the description but it links to a ph

[PATCH] D142381: [clang] Add test for CWG1960

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142381/new/ https://reviews.llvm.org/D142381 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D142388: [clang] Add builtin_nondet

shafik added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:658 BUILTIN(__builtin_call_with_static_chain, "v.", "nt") +BUILTIN(__builtin_nondet, "v.", "nt") erichkeane wrote: > Not a fan of the name in general, it doesn't really explain wh

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

shafik added a comment. I could not find any tests that test for this warning. Comment at: clang/lib/Sema/SemaExpr.cpp:5914 + runWithSufficientStackSpace(CallLoc, [&] { +MarkDeclarationsReferencedInExpr(Init, /*SkipLocalVariables*/ true); + }); Reposit

[PATCH] D140598: [Clang] Add sanity check in Sema::getDestructorName to prevent nullptr dereference

shafik updated this revision to Diff 491554. shafik marked 2 inline comments as done. shafik added a comment. - Switched to isValid() over isSet() - Added release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140598/new/ https://reviews.llvm.org/D140598 Files: clang/docs/Release

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

shafik added a comment. This looks good to me but I am wondering how "interpretation is interrupted" can happen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138275/new/ https://reviews.llvm.org/D138275 ___ cfe-commits mailing list cfe-comm

[PATCH] D140845: [clang][Interp] Fix left-/right-shifting more than sizeof(unsigned)

shafik added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:149 + constexpr signed int R = 62; + constexpr decltype(L) M = L << R; }; Can we add a test for left shift as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

shafik added a comment. Herald added subscribers: ChuanqiXu, arphaman. Herald added a project: All. Is this PR still relevant or should it just be closed? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24439/new/ https://reviews.llvm.org/D24439 ___

[PATCH] D11235: clang-format: Fix breaking before nested 'operator' in function declarations

shafik added a comment. Herald added a project: All. @Eugene.Zelenko it this still relevant or should this be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11235/new/ https://reviews.llvm.org/D11235 ___ cfe-commits mailing list cfe-co

[PATCH] D23602: Port tools/clang-format/git-clang-format to work Python beyond 2.7

shafik added a comment. Herald added a project: All. Should we close this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23602/new/ https://reviews.llvm.org/D23602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19385: [scan-build] fix warnings emitted on Clang Format code base

shafik added a comment. Herald added a project: All. Is this relevant anymore or should it be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19385/new/ https://reviews.llvm.org/D19385 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D25171: clang-format: Add two new formatting options

shafik added a comment. Herald added a project: All. Is this still relevant or should this be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D25171/new/ https://reviews.llvm.org/D25171 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D22334: Fix for Bug 28172 : clang crashes on invalid code (with too few arguments to __builtin_signbit) without any proper diagnostics.

shafik added a comment. Herald added a project: All. It looks like the examples no longer crash: https://godbolt.org/z/Yn8qK3fnT So likely we should just close this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22334/new/ https://reviews.llvm.org/D22334 __

[PATCH] D28144: clang support for Mageia 6 distro

shafik added a comment. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. @bkramer is this still relevant or should it be closed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28144/new/ https://reviews.llvm.org/D28144 __

[PATCH] D18478: python bindings: expose the clang version string

shafik added a comment. Herald added a subscriber: arphaman. Herald added a project: All. @compnerd is this still relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18478/new/ https://reviews.llvm.org/D18478 ___ cfe-commits mailing list

[PATCH] D22189: llvm.noalias - Clang CodeGen - check restrict variable map only for restrict-qualified lvalues

shafik added a comment. Herald added subscribers: mattd, gchakrabarti, asavonic, jeroen.dobbelaere, bollu. Herald added a project: All. @rjmccall is this still relevant or can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22189/new/ https://reviews.llvm.org/D22189 ___

[PATCH] D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr

shafik added a comment. Herald added a project: All. Is this relevant anymore or should we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37004/new/ https://reviews.llvm.org/D37004 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D37192: [clang-format] Add support for generic Obj-C categories

shafik added subscribers: Eugene.Zelenko, rjmccall, shafik. shafik added a comment. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. @rjmccall @Eugene.Zelenko this looks like it might still be relevant. CHANGES SINCE LA

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

shafik closed this revision. shafik added a comment. Herald added a project: All. It looks like these changes are already landed so closing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37196/new/ https://reviews.llvm.org/D37196 ___ cfe-commi

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

shafik added a comment. Herald added a project: All. Is this PR still relevant or can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19201/new/ https://reviews.llvm.org/D19201 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D41130: git-clang-format: cleanup: Use run() when possible.

shafik added a comment. Herald added a project: All. Is this still relevant or can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41130/new/ https://reviews.llvm.org/D41130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D41145: git-clang-format: refactor to support upcoming --staged flag

shafik added a comment. Herald added a subscriber: wangpc. Herald added a project: All. Is this still relevant or can we close this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41145/new/ https://reviews.llvm.org/D41145 ___ cfe-commits mail

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

shafik added a comment. Herald added a subscriber: wangpc. Herald added a project: All. Is this still relevant? It looks like some of these changes made it in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23130/new/ https://reviews.llvm.org/D23130 _

[PATCH] D156711: [clang][ExprConstant] Fix assertion failure in constant expression folding

shafik added a comment. It looks like I fixed this in: https://reviews.llvm.org/D158557 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156711/new/ https://reviews.llvm.org/D156711 ___ cfe-commits mailing

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

shafik added a comment. Herald added a project: All. Is this change still relevant of can we close this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45234/new/ https://reviews.llvm.org/D45234 ___ cfe-commits mailing

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

shafik added a comment. Herald added a subscriber: steven.zhang. Herald added a project: All. @hubert.reinterpretcast is this still relevant? It looks like portions of this have landed, can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18360/new/ https://reviews.llvm.org/D

[PATCH] D61309: [clang] Add no-warn support for Wa

shafik closed this revision. shafik added a comment. Herald added subscribers: ormris, MaskRay. Herald added a project: All. Closing since these changes looks like they have landed already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61309/new/ h

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

shafik closed this revision. shafik added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. Closing as it look like this is now `modernize-make-unique` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044

[PATCH] D7842: Make clang-format-diff compatible with Python 3.4

shafik closed this revision. shafik added a comment. Herald added a project: All. Closing this does not look relevant anymore CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7842/new/ https://reviews.llvm.org/D7842 ___ cfe-commits mailing list

[PATCH] D61663: [clang-format] Fix a JavaScript import order bug.

shafik added a comment. Herald added a project: All. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. @MyDeveloperDay this looks like it still could be relevant. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61663/new/ https://reviews.

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

shafik added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @rnk can we close this PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69766/new/ https://reviews.llvm.org/D69766 __

[PATCH] D75047: Add Control Flow Guard in Clang release notes.

shafik closed this revision. shafik added a comment. Herald added a project: All. Closing since this was landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75047/new/ https://reviews.llvm.org/D75047 __

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

shafik added a comment. Herald added a project: All. It looks like this is almost there, can we get it over the line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113838/new/ https://reviews.llvm.org/D113838 __

[PATCH] D99466: Fix PR48889: assertion failure for void() in flattened ternary expression

shafik added a comment. Herald added a project: All. This is accepted but it looks like we need the previous `void{}` fix in order to land this. It would be nice to get both in before phab is not usable anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

shafik added a comment. Note we have a second crash linked to this PR: https://github.com/llvm/llvm-project/issues/67173#issuecomment-1733647699 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 __

[PATCH] D117773: [clang-tidy] added JSON output to clang-tidy-diff.py

shafik added a comment. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. Is this change still relevant of can we close this PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117773/new/ https://re

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

shafik added a comment. Herald added a subscriber: PiotrZSL. Herald added a project: All. Is this change still relevant or can we close the PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

shafik added a comment. Herald added a project: All. Herald added a reviewer: rymiel. Is this change still relevant or can we close this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117197/new/ https://reviews.llvm.org/D117197 ___ cfe-commi

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

shafik added a comment. Herald added a project: All. It looks like some of these changes made it through different PRs but a lot of this is not in. It would be nice to get a updated version of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. @dim the crash should be fixed by landing: https://github.com/llvm/llvm-project/pull/67373 I need to rebase and test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-c

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik updated this revision to Diff 557569. shafik added a comment. - Integrate fix from https://github.com/llvm/llvm-project/pull/67373 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/Sem

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

shafik added a comment. I think we at least need some tests for this, looks like we have the AST tests in `clang/test/AST/ast-dump*` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383 __

[PATCH] D155270: [clang][Interp] Basic support for bit fields

shafik added inline comments. Comment at: clang/test/AST/Interp/bitfields.cpp:36 + // TODO: +=, -=, etc. operators. +} This is an interesting test case: ``` struct A {int c:3;}; constexpr int f() { A a1{3}; return a1.c++; } void g() { constexpr int x

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/include/clang/Sema/Lookup.h:197-200 +DiagnoseAccess(std::move(Other.DiagnoseAccess)), +DiagnoseAmbiguous(std::move(Other.DiagnoseAmbiguous)), AllowHidden(std::move(Ot

[PATCH] D155523: [clang] Fix a crash when casting to an array type

shafik added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:458 + case InitializationSequence::FK_ParenthesizedListInitFailed: +// In C++20, if the underlying destination type is a RecordType, then we +// attempt to perform parentesized aggregate initialization

[PATCH] D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate

shafik added a reviewer: aaron.ballman. shafik added a comment. Adding Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155475/new/ https://reviews.llvm.org/D155475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

shafik added a comment. I think this looks fine, I just wonder if we should be adding more tests to make sure we cover the a fuller set of types and non-type template parameters. I feel like this is always what bites us when bugs come up, if we had just test more carefully we would have caught

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:15191 OverloadCandidateSet::iterator Best; switch (CandidateSet.BestViableFunction(*this, OpLoc, Best)) { case OR_Success: @rsmith if `R.isAmbiguous()` should we even check the ove

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

shafik added a comment. Thank you for the fix! Can you explain why the fix fixes the bug? It is not a lot of change but I am not familiar enough to see what the underlying issue actually is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155705/new

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

shafik added a comment. Your explanation makes sense, I wish we had some documentation someplace that covered how it is expected to work with some examples with expected results. Maybe we should think about tests that might exercise this code a bit more. The definition of `MultiLevelTemplateArg

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

shafik added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:507 + // C++ [basic.scope.hiding]p2: + // A class name or enumeration name can be hidden by the name of john.brawn wrote: > shafik wrote: > > This section does not exist anymore, it was

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

shafik added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:669 +if (JumpScope != TargetScope) + DiagnoseIndirectOrAsmJump(G, JumpScope, LD, TargetScope); + } Do we have a test that checks this diagnostic? Repository: rG

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

shafik added a reviewer: clang-language-wg. shafik added a comment. I am not sure about this change but I think we at least need a test and this does not seem non-functional if it prevents a crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1558

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

shafik added a comment. Did you evaluate trying to use `StepsLeft` at all to limit the allocation? Should the limit be setable via the command line like what we do with steps via `-fconstexpr-steps`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

<    1   2   3   4   5   6   7   8   9   10   >