shafik added inline comments.

================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:291
   /// Returns whether we should create a global variable for the
   /// given VarDecl.
+  bool isGlobalDecl(const ValueDecl *VD) const {
----------------



================
Comment at: clang/test/AST/Interp/cxx17.cpp:7
+
+struct F { int a; int b;};
+constexpr F getF() {
----------------
It would also be good to test references, bit-fields, volatile and tuple-like 
types if possible, if not then leave a FIXME.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138802/new/

https://reviews.llvm.org/D138802

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to