@@ -179,6 +179,13 @@ void sparc::getSparcTargetFeatures(const Driver &D, const
ArgList &Args,
Features.push_back("-hard-quad-float");
}
+ if (Arg *A = Args.getLastArg(options::OPT_mv8plus, options::OPT_mno_v8plus))
{
+if (A->getOption().matches(options::OPT_mv8p
s-barannikov wrote:
> > > > This looks wrong. Preferred and ABI alignments should be set in
> > > > ~Triple~. ADD: Sorry, I meant DataLayout, of course.
> > >
> > >
> > > Thanks for pointing this out. How does data layout affect the alignment
> > > of constant string global variable symbols?
@@ -6077,6 +6077,10 @@ def mvis3 : Flag<["-"], "mvis3">,
Group;
def mno_vis3 : Flag<["-"], "mno-vis3">, Group;
def mhard_quad_float : Flag<["-"], "mhard-quad-float">,
Group;
def msoft_quad_float : Flag<["-"], "msoft-quad-float">,
Group;
+def mv8plus : Flag<["-"], "mv8plus">,
@@ -21,6 +21,12 @@ char f_int_4(char x) { return x; }
// CHECK-LABEL: define{{.*}} fp128 @f_ld(fp128 noundef %x)
long double f_ld(long double x) { return x; }
+// Empty struct is lowered as a placeholder word parameter.
+struct empty {};
+
+// CHECK-LABEL: define{{.*}} i64 @f_
@@ -263,7 +263,10 @@ SparcV9ABIInfo::classifyType(QualType Ty, unsigned
SizeLimit) const {
CoerceBuilder CB(getVMContext(), getDataLayout());
CB.addStruct(0, StrTy);
- CB.pad(llvm::alignTo(CB.DL.getTypeSizeInBits(StrTy), 64));
+ // All structs, even empty ones, should t
s-barannikov wrote:
IIRC there is a clang-tidy check that diagnoses uninitialized PODs, but
probably making the constructor non-trivial is simpler.
https://github.com/llvm/llvm-project/pull/98307
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/98307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -21,6 +21,12 @@ char f_int_4(char x) { return x; }
// CHECK-LABEL: define{{.*}} fp128 @f_ld(fp128 noundef %x)
long double f_ld(long double x) { return x; }
+// Empty struct is lowered as a placeholder word parameter.
+struct empty {};
+
+// CHECK-LABEL: define{{.*}} i64 @f_
@@ -21,6 +21,12 @@ char f_int_4(char x) { return x; }
// CHECK-LABEL: define{{.*}} fp128 @f_ld(fp128 noundef %x)
long double f_ld(long double x) { return x; }
+// Empty struct is lowered as a placeholder word parameter.
+struct empty {};
+
+// CHECK-LABEL: define{{.*}} i64 @f_
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/90338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,7 +11,7 @@
//
s-barannikov wrote:
I guess this file should've been removed.
https://github.com/llvm/llvm-project/pull/93388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -6077,6 +6077,10 @@ def mvis3 : Flag<["-"], "mvis3">,
Group;
def mno_vis3 : Flag<["-"], "mno-vis3">, Group;
def mhard_quad_float : Flag<["-"], "mhard-quad-float">,
Group;
def msoft_quad_float : Flag<["-"], "msoft-quad-float">,
Group;
+def mv8plus : Flag<["-"], "mv8plus">,
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/101650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15567,12 +15567,13 @@ bool ComplexExprEvaluator::VisitBinaryOperator(const
BinaryOperator *E) {
HandleComplexComplexDiv(A, B, C, D, ResR, ResI);
}
} else {
- if (RHS.getComplexIntReal() == 0 && RHS.getComplexIntImag() == 0)
-return Error(E, d
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/104666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s-barannikov wrote:
May it make sense to add tests with the argument passed in memory / by
reference?
https://github.com/llvm/llvm-project/pull/104816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
s-barannikov wrote:
I think the issue could be handled a different (more generic) way, by pulling
`useFirstFieldIfTransparentUnion` to the caller and taking transparent unions
into account when emitting LLVM IR for the formal / actual parameters somewhere
in `CGCall.cpp`, so that ABIInfo imple
@@ -13,10 +13,12 @@
#ifndef LLVM_SUPPORT_COMPRESSION_H
#define LLVM_SUPPORT_COMPRESSION_H
-#include "llvm/ADT/ArrayRef.h"
-#include "llvm/Support/DataTypes.h"
+#include "llvm/Support/ErrorHandling.h"
+#include
+#include
s-barannikov wrote:
Here and elsewher
@@ -1,4 +1,4 @@
-//===- MachineCFGPrinter.cpp - DOT Printer for Machine Functions
--===//
+//===- - DOT Printer for Machine Functions --===//
s-barannikov wrote:
Looks unintended.
https://github.com/llvm/llvm-project/pull/104825
_
@@ -39,7 +39,6 @@
#ifndef LLVM_SUPPORT_BALANCED_PARTITIONING_H
#define LLVM_SUPPORT_BALANCED_PARTITIONING_H
-#include "raw_ostream.h"
#include "llvm/ADT/ArrayRef.h"
#include
s-barannikov wrote:
(nit)
```suggestion
#include "llvm/ADT/ArrayRef.h"
#include
@@ -10,6 +10,7 @@
#include "InputFiles.h"
#include "InputSection.h"
#include "OutputSegment.h"
+#include "llvm/ADT/StringSwitch.h"
#include
s-barannikov wrote:
(nit)
```suggestion
#include "llvm/ADT/StringSwitch.h"
#include
```
https://github.com/llvm/ll
@@ -19,6 +19,7 @@
#include "llvm/IR/InstVisitor.h"
#include "llvm/IR/ValueHandle.h"
#include "llvm/Pass.h"
+#include "llvm/Support/Debug.h"
using namespace llvm;
s-barannikov wrote:
```suggestion
using namespace llvm;
```
https://github.com/llvm/llvm-projec
@@ -12,10 +12,8 @@
#include "Unix.h"
#include "llvm/ADT/Hashing.h"
-#include "llvm/ADT/StringRef.h"
+#include "llvm/ADT/StringSwitch.h"
#include "llvm/Config/config.h"
-#include
-#include
s-barannikov wrote:
`` is used in this file
https://github.com/llv
@@ -9,17 +9,14 @@
#ifndef LLVM_SUPPORT_CHRONO_H
#define LLVM_SUPPORT_CHRONO_H
-#include "llvm/Support/Compiler.h"
-#include "llvm/Support/FormatProviders.h"
+#include "llvm/Support/FormatVariadicDetails.h"
#include
s-barannikov wrote:
(nit) extra newline
@@ -17,7 +17,7 @@
#ifndef LLVM_SUPPORT_ATOMIC_H
#define LLVM_SUPPORT_ATOMIC_H
-#include "llvm/Support/DataTypes.h"
+#include
s-barannikov wrote:
```suggestion
#include
```
https://github.com/llvm/llvm-project/pull/104825
___
@@ -13,7 +13,7 @@
#ifndef LLVM_SUPPORT_CRC_H
#define LLVM_SUPPORT_CRC_H
-#include "llvm/Support/DataTypes.h"
+#include
s-barannikov wrote:
```suggestion
#include
```
https://github.com/llvm/llvm-project/pull/104825
_
s-barannikov wrote:
> However I feel like it is out of scope for what I am trying to do right now.
> Would this be better as a separate PR to change how this is handled?
Sure
https://github.com/llvm/llvm-project/pull/104816
___
cfe-commits mailing l
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/105544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/105824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/106951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov edited
https://github.com/llvm/llvm-project/pull/116642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s-barannikov wrote:
Stray change?
https://github.com/llvm/llvm-project/pull/116181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov created
https://github.com/llvm/llvm-project/pull/118856
None
>From 8af8a8c51955802a58341f32b2990859ee89038b Mon Sep 17 00:00:00 2001
From: Sergei Barannikov
Date: Thu, 5 Dec 2024 21:41:36 +0300
Subject: [PATCH] [libunwind] Fix a typo in debug print
---
libunw
s-barannikov wrote:
Spent quite a time tracking a non-existent address >_<
https://github.com/llvm/llvm-project/pull/118856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov closed
https://github.com/llvm/llvm-project/pull/118856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov edited
https://github.com/llvm/llvm-project/pull/119246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov commented:
May it be possible that the wrapper function's return type is invalid and the
cast isn't needed?
https://github.com/llvm/llvm-project/pull/119246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
@@ -3302,6 +3302,9 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs(
CharUnits Align = CGM.getContext().getDeclAlign(VD);
Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align);
}
+if (Val->getType() != Wrapper->getReturnType()) {
+ Val = Build
s-barannikov wrote:
> Updating the wrapper function's return type as below also fixes the error:
I mean, why do we have to watch for type mismatches and fix them instead of
creating the correct type in the first place?
There is `getPointerType(RetQT)` just above, shouldn't it be something like
s-barannikov wrote:
> I'm unfamiliar with Clang Qualtypes
I see. Well, neither am I :) I brought this up in case someone else could
suggest the preferred way to fix the issue.
I don't have objections against the current approach, but I'm not qualified to
review it either.
https://github.com/
s-barannikov wrote:
> * the `strlen` is NOT constant-evaluated on MSVC, even the latest version.
The godbolt link shows otherwise?
https://github.com/llvm/llvm-project/pull/122366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
s-barannikov wrote:
> @s-barannikov
>
> > > * the `strlen` is NOT constant-evaluated on MSVC, even the latest version.
> >
> >
> > The godbolt link shows otherwise?
>
> This is what I see in godbolt - to me this loop looks like strlen:
>
>  const { return Assertions; }
ArrayRef getDumps() const { return Dumps; }
- ArrayRef> getSuperClasses() const {
-return SuperClasses;
+ /// Append all superclasses in post-order to \p Classes.
+ void get
@@ -0,0 +1,102 @@
+//===-- CGBuiltin.h - LLVM CodeGen wrappers for llvm::Value* --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,102 @@
+//===-- CGBuiltin.h - LLVM CodeGen wrappers for llvm::Value* --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,102 @@
+//===-- CGBuiltin.h - LLVM CodeGen wrappers for llvm::Value* --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,102 @@
+//===-- CGBuiltin.h - LLVM CodeGen wrappers for llvm::Value* --*- C++
-*-===//
s-barannikov wrote:
Copy&paste bug?
Note that per updated coding standard this line may be the same as line 7.
https://github.com/llvm/llvm-project/pull/13225
https://github.com/s-barannikov edited
https://github.com/llvm/llvm-project/pull/132252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,105 @@
+//===-- CGBuiltin.h - Emit LLVM Code for builtins
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,105 @@
+//===-- CGBuiltin.h - Emit LLVM Code for builtins
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/132252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,105 @@
+//===-- CGBuiltin.h - Emit LLVM Code for builtins
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -61,6 +61,16 @@ add_clang_library(clangCodeGen
CGAtomic.cpp
CGBlocks.cpp
CGBuiltin.cpp
+ TargetBuiltins/AArch64.cpp
s-barannikov wrote:
(nit) Move these filenames down the list to keep it sorted?
https://github.com/llvm/llvm-project/pull/132252
@@ -0,0 +1,107 @@
+//===-- CGBuiltin.h - Emit LLVM Code for builtins
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/s-barannikov approved this pull request.
https://github.com/llvm/llvm-project/pull/130108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-barannikov commented:
Apparently my English is really not that good, sorry :smile:
Please see the two inline suggestions
https://github.com/llvm/llvm-project/pull/132252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
101 - 161 of 161 matches
Mail list logo
