s-barannikov wrote:

> > > > This looks wrong. Preferred and ABI alignments should be set in 
> > > > ~Triple~. ADD: Sorry, I meant DataLayout, of course.
> > > 
> > > 
> > > Thanks for pointing this out. How does data layout affect the alignment 
> > > of constant string global variable symbols?
> > 
> > 
> > They will be aligned to the preferred alignment specified as Y in the 
> > "-a:X:Y" part of the data layout, IIRC.
> 
> Thanks for the explanation. I understand that data layout can set default and 
> preferred alignment for all globals. This patch chooses alignment based on 
> the size of global objects. Can data layout do that?

You can specify ABI and preferred alignments for "first class" types, and 
separately for aggregates. It is all documented 
[here](https://llvm.org/docs/LangRef.html#data-layout).


https://github.com/llvm/llvm-project/pull/101309
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to