[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. Kindly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D130689: [LLVM] Update C++ standard to 17

barannikov88 added a comment. There are a few places (primarily in ADT and Support) that check __cplusplus > 201402. Do they need to be cleaned up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 ___

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a reviewer: aaron.ballman. barannikov88 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list cf

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.h:63 + /// Returns Swift ABI info helper for the target. + const SwiftABIInfo &getSwiftABIInfo() const { return *SwiftInfo; } + aaron.ballman wrote: > `SwiftInfo` isn't always initiali

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 updated this revision to Diff 450298. barannikov88 added a comment. Assert that Swift ABI info is initialized before accessing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 Files: cla

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 updated this revision to Diff 450294. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/SwiftCallin

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. In D130394#3705047 , @inclyc wrote: > (Not a serious review) It seems like that your patch has already been > accepted, so that I can commit this patch for you. It was very nice of you, thanks! Repository: rG LLVM Githu

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. In D131225#3706207 , @abidh wrote: > I think this patch is moving the things in the right direction. But please > wait for some other reviewers to chime in. It seems quite opposite to me. Comment at: cla

[PATCH] D130689: [LLVM] Update C++ standard to 17

barannikov88 added a comment. In D130689#3706263 , @aaron.ballman wrote: > The failures I am getting are the same as what's shown by the sanitizer bot > for Windows: > https://lab.llvm.org/buildbot/#/builders/127/builds/33980/steps/4/logs/stdio > (I'm

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:388 + /// IsRISCVBareMetal - Does this tool chain is a riscv baremetal target. + static bool IsRISCVBareMetal(const llvm::Triple &); + manojgupta wrote: > barannikov88 wrote:

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:388 + /// IsRISCVBareMetal - Does this tool chain is a riscv baremetal target. + static bool IsRISCVBareMetal(const llvm::Triple &); + barannikov88 wrote: > manojgupta wrote:

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:916 + /// Tests if the target is {arm,thumb}-none-none-{eabi,eabihf}. + bool isARMBareMetal() const { +if (getArch() != Triple::arm && getArch() != Triple::thumb) Any future chan

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM with the style issues fixed, but I'd like someone else to take a look. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228-237 + case ToolChain::RLT_C

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added inline comments. Comment at: llvm/lib/Support/Triple.cpp:1936 +bool Triple::isARMBareMetal() const { + if (getArch() != llvm::Triple::arm && getArch() != Triple::thumb) +return false; (nit) at least `llvm::` qualification is redundant, `Tr

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. In D131225#3707735 , @manojgupta wrote: > Address style nits. Neat, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 __

[PATCH] D131416: [Clang][BinaryOperator] memoize ICEKind for BinaryOperator Exprs

barannikov88 added inline comments. Comment at: clang/include/clang/AST/Expr.h:3832 + llvm::Optional getICEKind() const { return IK; } + Does it need to be Optional? It seems that it is never checked that it does not hold a value except for the setter method.

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. Still LGTM Comment at: clang/lib/Driver/ToolChains/BareMetal.h:2 +//===--- BareMetal.h - Bare Metal Tool and ToolChain -*- C++ +//-*-===// // Line overflowed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131563: [WIP] [clang] Fix clang multiarch isssue with musl

barannikov88 added a comment. The diff seems to be restricted to few lines. It should include the full context. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49 + std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu"; + * `!isMusl()` does not mea

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

barannikov88 added a comment. @ckissane I took fresh sources of LLVM and when I run cmake I get the following warning: -- Looking for compress2 -- Looking for compress2 - found CMake Warning at cmake/config-ix.cmake:149 (find_package): By not providing "Findzstd.cmake" in CMAKE_MODULE_

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[PATCH] D130268: [WIP] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required

barannikov88 created this revision. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130322 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGCall.h:26 -// FIXME: Restructure so we don't have to expose so much stuff. -#include "ABIInfo.h" - This is the main change. The included file was not used here at all. Repository: rG LLVM Git

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.h:49 public: - TargetCodeGenInfo(std::unique_ptr Info) : Info(std::move(Info)) {} + TargetCodeGenInfo(std::unique_ptr Info); virtual ~TargetCodeGenInfo(); Had to do this due to "in

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. To reviewers: if you are OK with the patch, could you please merge it? I don't have permission yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 _

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 updated this revision to Diff 446685. barannikov88 added a comment. Removed forward declaration of non-existent class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 Files: clang/lib/CodeG

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/ABIInfo.h:39 -namespace swiftcall { - class SwiftAggLowering; -} Not used in this file. (This class does not seem to be used anywhere.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:504 llvm::StructType *STy = llvm::ConstantStruct::getTypeForElements( - CGM.getLLVMContext(), Packed ? PackedElems : UnpackedElems, Packed); + CGM.getLLVMContext(), Packed ? PackedEl

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

barannikov88 added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:35 +template class ArrayRef; + Should be `typename T`. `class T` is archaic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1302

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. @MaskRay Would you please merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. In D130322#3672362 , @MaskRay wrote: > Testing and will push in one minute Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks

barannikov88 created this revision. Herald added a subscriber: dschuff. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Swift calling conventions stands out in the way that they are lowered

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks

barannikov88 updated this revision to Diff 446953. barannikov88 added a comment. Reword commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/Cod

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. Just thoughts. llvm::any_isa is usually paired with llvm::any_cast; replacing them with llvm::any_cast and nullptr check seems fine. However, - std::any uses RTTI, so it is unlikely to ever replace llvm::Any. - llvm::any_isa<> is kind of convenient and is aligned w

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added inline comments. Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91 assert(parser.has_value()); -assert(llvm::any_isa(parser)); +assert(llvm::any_cast(&parser)); return llvm::any_cast(parser); } This is not intu

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. In D139973#4004408 , @jsilvanus wrote: > I just checked on Godbolt that gcc 12.2 with libstdc++, clang 15.0 with both > libstd++ and libc++ and MSVC 19.33 support `std::any` without RTTI. > But gcc and clang do not provide

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added inline comments. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:193 - if (any_isa(IR)) { -const Function *F = any_cast(IR); -return F->getName().str(); + if (const auto **F = any_cast(&IR)) { +return (*F)->getName().str();

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. Related: https://reviews.llvm.org/D139974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ cfe-commits mailing list cfe-commits

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 accepted this revision. barannikov88 added a comment. In D139973#4005120 , @sebastian-ne wrote: > the question gets wether we want to keep llvm::Any around as a wrapper of > std::any once we can use it (in this case this patch would be obso

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; Nit: C-style casts are generally discouraged (there ar

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: llvm/lib/CodeGen/RegAllocGreedy.h:83 public: -ExtraRegInfo() = default; +ExtraRegInfo() {} ExtraRegInfo(const ExtraRegInfo &) = delete; bkramer wrote: > baranniko

[PATCH] D137838: [Support] Move TargetParsers to new component

barannikov88 added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:11 +/// This header is deprecated in favour of +/// `llvm/TargetParser/AArch64TargetParser.h`. /// Invalid comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" The prefix must remain LLVM_* In other comp

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" barannikov88 wrote: > The prefix must remai

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14742 Builder.getFastMathFlags().setAllowReassoc(); -return Builder.CreateCall(F, {Ops[0], Ops[1]}); +Value *FAdd = Builder.CreateCall(F, {Ops[0], Ops[1]}); +Builder.getFastMathFlags(

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14742 Builder.getFastMathFlags().setAllowReassoc(); -return Builder.CreateCall(F, {Ops[0], Ops[1]}); +Value *FAdd = Builder.CreateCall(F, {Ops[0], Ops[1]}); +Builder.getFastMathFlags(

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/lib/TargetParser/CMakeLists.txt:29 +# LLVMTargetParser. See https://stackoverflow.com/a/25681179 +target_include_directories(LLVMTargetParser PUBLIC $) Will it work if RISC-V target is not compiled-in? This do

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:16 +#include +namespace llvm { + fpetrogalli wrote: > barannikov88 wrote: > > This [[ > > https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implem

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

barannikov88 added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:52 + for (auto &Def : Map) { +const auto &Record = Def.second; +if (Record->isSubClassOf("RISCVProcessorModelTUNE_PROC")) fpetrogalli wrote: > barannikov88 wrot

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valu

[PATCH] D142459: [clang] Deprecate uses of GlobalObject::getAlignment

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:491 new llvm::LoadInst(Var->getType(), ManagedVar, "ld.managed", false, - llvm::Align(Var->getAlignment()), I); + Var->getAlign().valu

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

barannikov88 created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. barannikov88 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

barannikov88 added a comment. I intent to make make InstAlias with "complex" operands (non-empty MIOperandInfo) more robust (stricter syntax). The change will clobber most of the code here, and I thought it is a good time to move the class to a dedicated file. Another weak point is that this cla

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fbca40805c: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 created this revision. Herald added subscribers: s.egerton, simoncook, fedor.sergeev. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead. Herald added projects: clang, LLVM. Repository: rG LL

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 updated this revision to Diff 489341. barannikov88 added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141788/new/ https://reviews.llvm.org/D141788 Files: clang/docs/tools/clang-formatted-files.txt llvm

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

barannikov88 added a comment. It would be nice to have comments reflecting the new behavior in the case of 0 / max value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/ https://reviews.llvm.org/D141798 _

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 added a comment. In D141788#4055263 , @MaskRay wrote: > non-reference `auto` shall work better in these cases. Not sure why? Won't Data be copied every iteration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 updated this revision to Diff 489499. barannikov88 added a comment. Use `auto` instead of `const auto &` Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141788/new/ https://reviews.llvm.org/D141788 Files: clang/docs/tools/clang

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a0e0c226018: [NFC] Use `llvm::enumerate` in llvm/unittests/Object (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056503 , @fpetrogalli wrote: > This is because the sources of clangBasic and clangDriver might be compiled > before LLVMTargetParser is ready. ... > Therefore, if we say that clangDriver and clangBasic depend

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. In D141581#4056671 , @fpetrogalli wrote: > @barannikov88 - I am stuck with an incomplete explanation: Ah, I see. The key point is that standalone build that depends on //installed// LLVM. RISCVTargetParser is a custom tar

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

barannikov88 added a comment. clangBasic and clangDriver already have a dependency on TargetParser (see LLVM_LINK_COMPONENTS at the beginning of corresponding files). Is that not enough? Will it build if you just remove the additional dependency? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141918: WIP: [Clang] Emit 'unwindabort' when applicable.

barannikov88 added a comment. I couldn't find an example of creating "resume unwindabort" in the patch series. Is it yet to be done? Could you show a source code example where such an instruction should be generated? (By the frontend or an IR pass.) I couldn't get it from the RFC. Repository:

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 arsenm wrote: > scott.linder wrote: > > This is ABI breaking, so maybe we don't

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:67 + inline std::optional getLevel(IDType ID) { +if (ID < 0 || ID > 3) + return std::nullopt; As I can see, clients do not check for nullopt. Either add checks or replac

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 scott.linder wrote: > barannikov88 wrote: > > arsenm wrote: > > > scott.linder

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/Support/MathExtras.h:212 /// Only unsigned integral types are allowed. -/// -/// \param ZB the behavior on an input of 0. Only

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 557642. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/test/Preprocessor/has_attribute.c clang/test/Prepro

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 557643. barannikov88 added a comment. Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/docs/ReleaseNotes.rst clang/test/Prepro

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 added a comment. @aaron.ballman I added a release note as requested. Please see if it looks the way it should. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 ___

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 557644. barannikov88 added a comment. Add a hyphen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/docs/ReleaseNotes.rst clang/test/Preprocessor

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f87be6888d: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc (authored by barannikov88). Changed prior to commit: https://reviews.llvm.org/D159393?vs=557644&id=557657#toc Reposito

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

barannikov88 added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2349 + if (isVariadicStringLiteralArgument(Args[N])) { +for (; N < sizeof(uint32_t); N++) + Bits |= (1 << N); maskTrailingZeros might also be useful

[PATCH] D154285: [clang] Deprecate CGBuilderTy::CreateElementBitCast

barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3954 Function *F = CGM.getIntrinsic(Intrinsic::eh_sjlj_setjmp); -Buf = Builder.CreateElementBitCast(Buf, Int8Ty); return RValue::get(Builder.CreateCa

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/Targets/AMDGPU.cpp:520 +static llvm::StructType *getAMDGPUKernelDescriptorType(llvm::LLVMContext &C) { + llvm::Type *Int8 = llvm::IntegerType::getInt8Ty(C); + llvm::Type *Int16 = llvm::IntegerType::getInt16Ty(C);

[PATCH] D105759: Implement P2361 Unevaluated string literals

barannikov88 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:138 - Implemented `P2738R1: constexpr cast from void* `_. +- Partially implemented `P2361R6: constexpr cast from void* `_. + The changes to attrib

[PATCH] D105759: Implement P2361 Unevaluated string literals

barannikov88 added a comment. @cor3ntin I've been working on pretty much the same functionality in our downstream fork. I was not aware of the paper, nor of the ongoing work in this direction, and so I unfortunately missed the review. Thanks for this patch, it significantly reduces the number o

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3883 + ///< message. +CCEK_StaticAssertMessageData, ///< Call to data() in a static assert + ///< message. Appear

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added a comment. According to the current wording, the static_assert-message is either unevaluated string or an expression evaluated at compile time. Unevaluated strings don't allow certain escape sequences, but if I wrap the string in a string_view-like class, I'm allowed to use an

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

barannikov88 created this revision. barannikov88 added a reviewer: cor3ntin. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The width of the APSInt values should be the width of an element. getChar

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added a comment. In D154290#4483055 , @cor3ntin wrote: > In D154290#4482975 , @barannikov88 > wrote: > >> According to the current wording, the static_assert-message is either >> unevaluated string

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

barannikov88 added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:16413 +APSInt C = Char.getInt(); +Result.push_back(static_cast(C.getExtValue())); +if (!HandleLValueArrayAdjustment(Info, PtrExpression, String, CharTy, 1)) aaron.ballman w

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 created this revision. barannikov88 added reviewers: cor3ntin, aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a complementa

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 updated this revision to Diff 554497. barannikov88 added a comment. Update the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7eaaba69906: [Parser] Parse string literal arguments of 'availability'… (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 created this revision. Herald added subscribers: s.egerton, PkmX, simoncook, kristof.beyls, krytarowski, arichardson, dylanmckay. Herald added a reviewer: aaron.ballman. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 updated this revision to Diff 51. barannikov88 added a comment. Update one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/test/Preprocessor/has_attribute.c cla

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:35 +CXX11(clang::warn_unused_result) + // CHECK: __gnu__::__const__: 1 For the context, the attribute is defined with the following spellings: ``` let Spellings = [CXX11<

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18a628ec4ef7: [AST] Use correct APSInt width when evaluating string literals (authored by barannikov88). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

barannikov88 added a comment. Should I create a github PR instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG44e63ffe2bf7: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added a comment. - I'd prefer Lex() over equivalent getParser().Lex() because it is shorter. - Ideally, every change should be tested. - The tests should be minimal. That is, they should be assembly files passed to llvm-mc rather than ll files passed to llc. I'm not very familiar wi

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. Is SmallVector.h still required in Error.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 ___ cfe-commits mailing list cfe-commi

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1474 Address AtomicInfo::emitCastToAtomicIntPointer(Address addr) const { llvm::IntegerType *ty = as it no longer emits anything. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1610 +} + } while (NonComments < 2 and ReadCount > 0); + return NextNextToken; This is much more common. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. In D153229#134 , @IncludeGuardian wrote: > @barannikov88 no it's not. I was going to commit separately to keep the > change small, but it turns out that if I move this to the source file there > are no additional chang

  1   2   3   >