barannikov88 added a comment.

The diff seems to be restricted to few lines. It should include the full 
context.



================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49
 
+  std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu";
+
----------------
* `!isMusl()` does not mean it is "gnu".
* Why don't just use `Triple::getEnvironmentTypeName`?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131563/new/

https://reviews.llvm.org/D131563

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to