Author: spatel
Date: Sun Aug 19 06:12:40 2018
New Revision: 340135
URL: http://llvm.org/viewvc/llvm-project?rev=340135&view=rev
Log:
[CodeGen] add rotate builtins
This exposes the LLVM funnel shift intrinsics as more familiar bit rotation
functions in clang
(when both halves of a funnel shift a
Author: spatel
Date: Sun Aug 19 06:48:06 2018
New Revision: 340136
URL: http://llvm.org/viewvc/llvm-project?rev=340136&view=rev
Log:
revert r340135: [CodeGen] add rotate builtins
At least a couple of bots (PPC only?) are showing the compiler dying while
trying to compile:
http://lab.llvm.org:801
Author: spatel
Date: Sun Aug 19 07:44:47 2018
New Revision: 340137
URL: http://llvm.org/viewvc/llvm-project?rev=340137&view=rev
Log:
[CodeGen] add/fix rotate builtins that map to LLVM funnel shift (retry)
This is a retry of rL340135 (reverted at rL340136 because of gcc host compiler
crashing)
wi
Author: spatel
Date: Sun Aug 19 08:31:42 2018
New Revision: 340138
URL: http://llvm.org/viewvc/llvm-project?rev=340138&view=rev
Log:
revert r340137: [CodeGen] add rotate builtins
At least a couple of bots (gcc host compiler on PPC only?) are showing the
compiler dying while trying to compile.
R
Author: spatel
Date: Sun Aug 19 09:50:30 2018
New Revision: 340141
URL: http://llvm.org/viewvc/llvm-project?rev=340141&view=rev
Log:
[CodeGen] add rotate builtins that map to LLVM funnel shift
This is a partial retry of rL340137 (reverted at rL340138 because of gcc host
compiler crashing)
with 1
Author: spatel
Date: Sun Aug 19 10:32:56 2018
New Revision: 340142
URL: http://llvm.org/viewvc/llvm-project?rev=340142&view=rev
Log:
[CodeGen] add test file that should have been included with r340141
Added:
cfe/trunk/test/CodeGen/builtin-rotate.c
Added: cfe/trunk/test/CodeGen/builtin-rotat
Author: spatel
Date: Wed May 16 07:38:07 2018
New Revision: 332473
URL: http://llvm.org/viewvc/llvm-project?rev=332473&view=rev
Log:
[OpenCL] make test independent of optimizer
There shouldn't be any tests that run the entire optimizer here,
but the last test in this file is definitely going to b
Author: spatel
Date: Tue May 22 08:11:59 2018
New Revision: 332988
URL: http://llvm.org/viewvc/llvm-project?rev=332988&view=rev
Log:
[CodeGen] add tests for abs builtins; NFC
Added:
cfe/trunk/test/CodeGen/builtin-abs.c
Added: cfe/trunk/test/CodeGen/builtin-abs.c
URL:
http://llvm.org/viewvc/
Author: spatel
Date: Tue May 22 08:36:50 2018
New Revision: 332989
URL: http://llvm.org/viewvc/llvm-project?rev=332989&view=rev
Log:
[CodeGen] produce the LLVM canonical form of abs
We chose the 'slt' form as canonical in IR with:
rL332819
...so we should generate that form directly for efficienc
Author: spatel
Date: Tue May 22 16:02:13 2018
New Revision: 333038
URL: http://llvm.org/viewvc/llvm-project?rev=333038&view=rev
Log:
[CodeGen] use nsw negation for builtin abs
The clang builtins have the same semantics as the stdlib functions.
The stdlib functions are defined in section 7.20.6.1
Author: spatel
Date: Mon Sep 25 14:27:37 2017
New Revision: 314158
URL: http://llvm.org/viewvc/llvm-project?rev=314158&view=rev
Log:
[x86] make assertions less strict in avx512f test file
I'm not sure why yet, but there may be differences depending on the host?
Modified:
cfe/trunk/test/CodeG
Author: spatel
Date: Mon Sep 25 14:31:08 2017
New Revision: 314159
URL: http://llvm.org/viewvc/llvm-project?rev=314159&view=rev
Log:
[x86] make assertions less strict in avx512f test file
Missed a line in r314158.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: cfe/trunk/test/
Author: spatel
Date: Fri Oct 20 16:32:41 2017
New Revision: 316250
URL: http://llvm.org/viewvc/llvm-project?rev=316250&view=rev
Log:
[CodeGen] add tests for __builtin_sqrt*; NFC
I don't know if this is correct, but this is what we currently do.
More discussion in PR27108 and PR27435 and D27618.
Author: spatel
Date: Sat Dec 16 08:11:17 2017
New Revision: 320920
URL: http://llvm.org/viewvc/llvm-project?rev=320920&view=rev
Log:
[Driver, CodeGen] pass through and apply -fassociative-math
There are 2 parts to getting the -fassociative-math command-line flag
translated to LLVM FMF:
1. In th
Author: spatel
Date: Wed Jun 13 10:54:52 2018
New Revision: 334628
URL: http://llvm.org/viewvc/llvm-project?rev=334628&view=rev
Log:
[CodeGen] make nan builtins pure rather than const (PR37778)
https://bugs.llvm.org/show_bug.cgi?id=37778
...shows a miscompile resulting from marking nan builtins a
Author: spatel
Date: Sun Nov 25 09:53:16 2018
New Revision: 347527
URL: http://llvm.org/viewvc/llvm-project?rev=347527&view=rev
Log:
[CodeGen] translate MS rotate builtins to LLVM funnel-shift intrinsics
This was originally part of:
D50924
and should resolve PR37387:
https://bugs.llvm.org/show_b
Author: spatel
Date: Sun Mar 31 08:01:30 2019
New Revision: 357366
URL: http://llvm.org/viewvc/llvm-project?rev=357366&view=rev
Log:
[InstCombine] canonicalize select shuffles by commuting
In PR41304:
https://bugs.llvm.org/show_bug.cgi?id=41304
...we have a case where we want to fold a binop of s
Author: spatel
Date: Fri Jul 26 13:36:57 2019
New Revision: 367149
URL: http://llvm.org/viewvc/llvm-project?rev=367149&view=rev
Log:
[CodeGen] fix test that broke with rL367146
This should be fixed properly to not depend on LLVM (so much).
Modified:
cfe/trunk/test/CodeGen/complex-math.c
Mod
Author: spatel
Date: Wed Jul 31 09:53:22 2019
New Revision: 367447
URL: http://llvm.org/viewvc/llvm-project?rev=367447&view=rev
Log:
[InstCombine] canonicalize fneg before fmul/fdiv
Reverse the canonicalization of fneg relative to fmul/fdiv. That makes it
easier to implement the transforms (and p
Author: spatel
Date: Fri Apr 27 07:22:48 2018
New Revision: 331041
URL: http://llvm.org/viewvc/llvm-project?rev=331041&view=rev
Log:
[Driver, CodeGen] add options to enable/disable an FP cast optimization
As discussed in the post-commit thread for:
rL330437 (
http://lists.llvm.org/pipermail/llvm
Author: spatel
Date: Fri Apr 27 09:21:22 2018
New Revision: 331056
URL: http://llvm.org/viewvc/llvm-project?rev=331056&view=rev
Log:
[docs] add -ffp-cast-overflow-workaround to the release notes
This option was added with:
D46135
rL331041
...copying the text from UsersManual.rst for more exposure
Author: spatel
Date: Fri Apr 27 09:24:39 2018
New Revision: 331057
URL: http://llvm.org/viewvc/llvm-project?rev=331057&view=rev
Log:
[docs] more dashes
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs
n't have a strong opinion here, but on 2nd reading, it does seem like a
'strict' flag fits better with existing options.
On Fri, Apr 27, 2018 at 4:41 PM, Richard Smith
wrote:
> On 27 April 2018 at 09:21, Sanjay Patel via cfe-commits <
> cfe-commits@lists.llvm.org> wr
>> On 27 April 2018 at 17:09, Chandler Carruth via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>>>
>>>> On 27 April
Author: spatel
Date: Mon Apr 30 11:19:03 2018
New Revision: 331209
URL: http://llvm.org/viewvc/llvm-project?rev=331209&view=rev
Log:
[Driver, CodeGen] rename options to disable an FP cast optimization
As suggested in the post-commit thread for rL331056, we should match these
clang options with t
Author: spatel
Date: Sun Oct 6 06:08:08 2019
New Revision: 373847
URL: http://llvm.org/viewvc/llvm-project?rev=373847&view=rev
Log:
[InstCombine] don't assume 'inbounds' for bitcast pointer to GEP transform
(PR43501)
https://bugs.llvm.org/show_bug.cgi?id=43501
We can't declare a GEP 'inbounds'
Author: Sanjay Patel
Date: 2020-05-31T11:07:22-04:00
New Revision: dfbfdc96f9e15be40c938cde9b159afd028bf4a2
URL:
https://github.com/llvm/llvm-project/commit/dfbfdc96f9e15be40c938cde9b159afd028bf4a2
DIFF:
https://github.com/llvm/llvm-project/commit/dfbfdc96f9e15be40c938cde9b159afd028bf4a2.diff
Author: Sanjay Patel
Date: 2020-06-01T06:54:45-04:00
New Revision: e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6
URL:
https://github.com/llvm/llvm-project/commit/e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6
DIFF:
https://github.com/llvm/llvm-project/commit/e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6.diff
Author: Sanjay Patel
Date: 2020-06-01T10:21:17-04:00
New Revision: c0303e5391f65dbad3a6f1dbfa5ac9c9a83fa6c0
URL:
https://github.com/llvm/llvm-project/commit/c0303e5391f65dbad3a6f1dbfa5ac9c9a83fa6c0
DIFF:
https://github.com/llvm/llvm-project/commit/c0303e5391f65dbad3a6f1dbfa5ac9c9a83fa6c0.diff
Author: Sanjay Patel
Date: 2020-05-10T11:19:43-04:00
New Revision: bcc5ed7b24e921c8902d0d0db614576bd249f128
URL:
https://github.com/llvm/llvm-project/commit/bcc5ed7b24e921c8902d0d0db614576bd249f128
DIFF:
https://github.com/llvm/llvm-project/commit/bcc5ed7b24e921c8902d0d0db614576bd249f128.diff
Author: Sanjay Patel
Date: 2020-05-10T11:25:37-04:00
New Revision: d02b3aba37d9a18691669392ff26ec28b51741f5
URL:
https://github.com/llvm/llvm-project/commit/d02b3aba37d9a18691669392ff26ec28b51741f5
DIFF:
https://github.com/llvm/llvm-project/commit/d02b3aba37d9a18691669392ff26ec28b51741f5.diff
spatel created this revision.
spatel added reviewers: echristo, evandro, hfinkel.
spatel added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, mcrosier.
Technically, I suppose this patch is independent of the upcoming llvm sibling
patch because we can still pass 'check-all' with
spatel added a subscriber: spatel.
spatel added a comment.
Having a clang regression/unit test that depends on optimizer behavior is
generally viewed as wrong. Can the tests be split into front-end (clang) tests
and separate tests for the IR optimizer? Both x86 and AArch64 have done
something l
spatel added a comment.
In https://reviews.llvm.org/D24397#52, @nemanjai wrote:
> In https://reviews.llvm.org/D24397#555470, @spatel wrote:
>
> > Having a clang regression/unit test that depends on optimizer behavior is
> > generally viewed as wrong. Can the tests be split into front-end (cl
spatel added a comment.
Should also mention:
https://reviews.llvm.org/D17999
has scripts attached that could make this kind of test generation a lot easier.
:)
Repository:
rL LLVM
https://reviews.llvm.org/D24397
___
cfe-commits mailing list
cfe-
spatel added a comment.
Ping.
https://reviews.llvm.org/D24815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spatel marked 2 inline comments as done.
spatel added a comment.
Thanks, Eric. I actually drafted this with the name "recip-estimates", but
thought there might be value in reusing the programmer-visible flag name. I'm
good with "reciprocal-estimates" too.
https://reviews.llvm.org/D24815
___
spatel added inline comments.
> echristo wrote in CGCall.cpp:1735
> Would be nice to get these pulled into a single fast-math string that's set
> and then used all over for sure. :)
I'm probably not imagining some use case, but I was hoping that we can just
delete the 4 (fast/inf/nan/nsz) that
spatel updated this revision to Diff 73364.
spatel added a comment.
Patch updated as suggested by Eric:
1. The attribute is named "reciprocal-estimates".
2. Remove unnecessary -disable-llvm-optzns flag from test file.
Quick fixes, but this will not go in until the LLVM side
(https://reviews.llv
spatel added inline comments.
> mehdi_amini wrote in CGCall.cpp:1735
> I agree with getting on a path to remove these function attributes that have
> an equivalent on per-instruction flag.
>
> I wonder what is the status of these flags in SelectionDAG though? We still
> have a variant of the f
spatel added inline comments.
> mehdi_amini wrote in CGCall.cpp:1735
> I wonder if we couldn’t have this part of the bitcode/IR auto-upgrade: when
> we load a function with this attribute, we automatically add the individual
> flag on every instruction.
Auto-upgrading is part of the solution.
spatel added inline comments.
> mehdi_amini wrote in CGCall.cpp:1735
> I think I remember folks being against FMF on calls (Chris Lattner?), I'll
> try to find the relevant discussion.
> Otherwise your plan seems fine to me!
Yes - Chris was opposed to FMF on intrinsics (preferring parameters/me
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283251: [clang] make reciprocal estimate codegen a function
attribute (authored by spatel).
Changed prior to commit:
https://reviews.llvm.org/D24815?vs=73364&id=73548#toc
Repository:
rL LLVM
https:/
Author: spatel
Date: Tue Oct 4 15:44:05 2016
New Revision: 283251
URL: http://llvm.org/viewvc/llvm-project?rev=283251&view=rev
Log:
[clang] make reciprocal estimate codegen a function attribute
The motivation for the change is that we can't have pseudo-global settings
for codegen living in Targe
spatel added a comment.
In https://reviews.llvm.org/D24397#562469, @bjope wrote:
> (I'm still hesitating about commiting https://reviews.llvm.org/D24955 in llvm
> since that would make these clang tests fail...)
You can't do that. Bots will send you fail mail all day as they choke on the
clan
You should not need to account for any nsw/nuw flags if the clang test does
not enable the optimizer.
Ie, D24955 should not be running at -O0.
On Wed, Oct 5, 2016 at 1:09 PM, Nemanja Ivanovic
wrote:
> OK, I get testing that I'm fine with if I remove the -O2 and the checks
> for 'select i1'.
>
>
Author: spatel
Date: Fri Dec 1 15:15:52 2017
New Revision: 319593
URL: http://llvm.org/viewvc/llvm-project?rev=319593&view=rev
Log:
[CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics
There are 20 LLVM math intrinsics that correspond to mathlib calls according to
the LangRef:
Author: spatel
Date: Sat Dec 2 08:29:34 2017
New Revision: 319618
URL: http://llvm.org/viewvc/llvm-project?rev=319618&view=rev
Log:
[CodeGen] remove stale comment; NFC
The libm functions with LLVM intrinsic twins were moved above this blob with:
https://reviews.llvm.org/rL319593
Modified:
Author: spatel
Date: Sat Dec 2 09:52:00 2017
New Revision: 319619
URL: http://llvm.org/viewvc/llvm-project?rev=319619&view=rev
Log:
[CodeGen] fix mapping from fmod calls to frem instruction
Similar to D40044 and discussed in D40594.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trun
Author: Sanjay Patel
Date: 2022-08-31T15:11:48-04:00
New Revision: cdf3de45d282694290011a2949bdcc61cabb47ef
URL:
https://github.com/llvm/llvm-project/commit/cdf3de45d282694290011a2949bdcc61cabb47ef
DIFF:
https://github.com/llvm/llvm-project/commit/cdf3de45d282694290011a2949bdcc61cabb47ef.diff
Author: Sanjay Patel
Date: 2022-03-17T08:22:30-04:00
New Revision: ab982eace6e4951a2986567d29f4d6be002c1ba7
URL:
https://github.com/llvm/llvm-project/commit/ab982eace6e4951a2986567d29f4d6be002c1ba7
DIFF:
https://github.com/llvm/llvm-project/commit/ab982eace6e4951a2986567d29f4d6be002c1ba7.diff
Author: Sanjay Patel
Date: 2020-09-30T13:22:12-04:00
New Revision: 187686bea3878c0bf2b150d784e7eab223434e25
URL:
https://github.com/llvm/llvm-project/commit/187686bea3878c0bf2b150d784e7eab223434e25
DIFF:
https://github.com/llvm/llvm-project/commit/187686bea3878c0bf2b150d784e7eab223434e25.diff
Author: Sanjay Patel
Date: 2020-09-30T15:10:25-04:00
New Revision: 81921ebc430536ae5718da70a54328c790c8ae19
URL:
https://github.com/llvm/llvm-project/commit/81921ebc430536ae5718da70a54328c790c8ae19
DIFF:
https://github.com/llvm/llvm-project/commit/81921ebc430536ae5718da70a54328c790c8ae19.diff
Author: Sanjay Patel
Date: 2020-10-01T13:46:45-04:00
New Revision: 686eb0d8ded9159b090c3ef7b33a422e1f05166e
URL:
https://github.com/llvm/llvm-project/commit/686eb0d8ded9159b090c3ef7b33a422e1f05166e
DIFF:
https://github.com/llvm/llvm-project/commit/686eb0d8ded9159b090c3ef7b33a422e1f05166e.diff
Author: Sanjay Patel
Date: 2020-10-01T14:37:38-04:00
New Revision: 149f5b573c79eac0c519ada4d2f7c50e17796cdf
URL:
https://github.com/llvm/llvm-project/commit/149f5b573c79eac0c519ada4d2f7c50e17796cdf
DIFF:
https://github.com/llvm/llvm-project/commit/149f5b573c79eac0c519ada4d2f7c50e17796cdf.diff
Author: Venkataramanan Kumar
Date: 2020-10-22T16:01:39-04:00
New Revision: 57cdc52c4df0a8a6835ddeede787b23c0ce9e358
URL:
https://github.com/llvm/llvm-project/commit/57cdc52c4df0a8a6835ddeede787b23c0ce9e358
DIFF:
https://github.com/llvm/llvm-project/commit/57cdc52c4df0a8a6835ddeede787b23c0ce9e35
Author: Sanjay Patel
Date: 2021-05-25T09:17:10-04:00
New Revision: 16e78ec0b43c33c818525ea9b5d39731022f1cbb
URL:
https://github.com/llvm/llvm-project/commit/16e78ec0b43c33c818525ea9b5d39731022f1cbb
DIFF:
https://github.com/llvm/llvm-project/commit/16e78ec0b43c33c818525ea9b5d39731022f1cbb.diff
Author: Sanjay Patel
Date: 2021-09-21T16:53:41-04:00
New Revision: 52832cd917af00e2b9c6a9d1476ba79754dcabff
URL:
https://github.com/llvm/llvm-project/commit/52832cd917af00e2b9c6a9d1476ba79754dcabff
DIFF:
https://github.com/llvm/llvm-project/commit/52832cd917af00e2b9c6a9d1476ba79754dcabff.diff
Author: Sanjay Patel
Date: 2021-09-22T07:45:21-04:00
New Revision: 1ee851c5859fdb36eca57a46347a1e7b8e1ff236
URL:
https://github.com/llvm/llvm-project/commit/1ee851c5859fdb36eca57a46347a1e7b8e1ff236
DIFF:
https://github.com/llvm/llvm-project/commit/1ee851c5859fdb36eca57a46347a1e7b8e1ff236.diff
Author: Sanjay Patel
Date: 2021-06-10T08:50:06-04:00
New Revision: cc86b87a57000ba673edaf95f65913412928f003
URL:
https://github.com/llvm/llvm-project/commit/cc86b87a57000ba673edaf95f65913412928f003
DIFF:
https://github.com/llvm/llvm-project/commit/cc86b87a57000ba673edaf95f65913412928f003.diff
Author: Sanjay Patel
Date: 2022-11-30T14:52:20-05:00
New Revision: e71b81cab09bf33e3b08ed600418b72cc4117461
URL:
https://github.com/llvm/llvm-project/commit/e71b81cab09bf33e3b08ed600418b72cc4117461
DIFF:
https://github.com/llvm/llvm-project/commit/e71b81cab09bf33e3b08ed600418b72cc4117461.diff
Author: Sanjay Patel
Date: 2020-02-25T09:13:49-05:00
New Revision: 83f4372f3a708ceaa800feff8b1bd92ae2c3be5f
URL:
https://github.com/llvm/llvm-project/commit/83f4372f3a708ceaa800feff8b1bd92ae2c3be5f
DIFF:
https://github.com/llvm/llvm-project/commit/83f4372f3a708ceaa800feff8b1bd92ae2c3be5f.diff
move again with
https://reviews.llvm.org/D75130
On Tue, Feb 25, 2020 at 1:15 PM Eric Christopher wrote:
> Is there any way to pull this test out of clang and as an opt test? What's
> it trying to test?
>
> -eric
>
> On Tue, Feb 25, 2020 at 6:15 AM Sanjay Patel via cfe-commi
re any way to pull this test out of clang and as an opt test?
>>> What's it trying to test?
>>>
>>> -eric
>>>
>>> On Tue, Feb 25, 2020 at 6:15 AM Sanjay Patel via cfe-commits <
>>> cfe-commits@lists.llvm.org> wro
Author: Sanjay Patel
Date: 2020-03-02T09:12:53-05:00
New Revision: 8cdcbcaa02e7055a6745f2c1bde003c47c91f79e
URL:
https://github.com/llvm/llvm-project/commit/8cdcbcaa02e7055a6745f2c1bde003c47c91f79e
DIFF:
https://github.com/llvm/llvm-project/commit/8cdcbcaa02e7055a6745f2c1bde003c47c91f79e.diff
Author: Sanjay Patel
Date: 2020-03-02T09:47:32-05:00
New Revision: 1e308452bf68b9576a76004de28307f0318ef9eb
URL:
https://github.com/llvm/llvm-project/commit/1e308452bf68b9576a76004de28307f0318ef9eb
DIFF:
https://github.com/llvm/llvm-project/commit/1e308452bf68b9576a76004de28307f0318ef9eb.diff
going to move again
>>>> with https://reviews.llvm.org/D75130
>>>>
>>>> On Tue, Feb 25, 2020 at 1:15 PM Eric Christopher
>>>> wrote:
>>>>
>>>>> Is there any way to pull this test out of clang and as an opt test?
>>>>> Wha
Author: spatel
Date: Tue Oct 31 13:19:39 2017
New Revision: 317031
URL: http://llvm.org/viewvc/llvm-project?rev=317031&view=rev
Log:
[CodeGen] map sqrt libcalls to llvm.sqrt when errno is not set
The LLVM sqrt intrinsic definition changed with:
D28797
...so we don't have to use any relaxed FP set
Author: spatel
Date: Thu Nov 2 10:06:05 2017
New Revision: 317220
URL: http://llvm.org/viewvc/llvm-project?rev=317220&view=rev
Log:
[CodeGen] add builtin attr tests to show errno-related diffs; NFC
Added:
cfe/trunk/test/CodeGen/builtin-errno.c
Added: cfe/trunk/test/CodeGen/builtin-errno.c
U
Author: spatel
Date: Thu Nov 2 13:39:26 2017
New Revision: 317265
URL: http://llvm.org/viewvc/llvm-project?rev=317265&view=rev
Log:
[CodeGen] fix const-ness of builtin equivalents of and
functions that might set errno
This just makes const-ness of the builtins match const-ness of their lib
f
Author: spatel
Date: Fri Nov 3 09:27:27 2017
New Revision: 317336
URL: http://llvm.org/viewvc/llvm-project?rev=317336&view=rev
Log:
[CodeGen] add libcall attr tests to show errno-related diffs; NFC
See rL317220 for the builtin siblings.
Added:
cfe/trunk/test/CodeGen/libcalls-errno.c
Added:
Author: spatel
Date: Sat Nov 4 08:03:11 2017
New Revision: 317407
URL: http://llvm.org/viewvc/llvm-project?rev=317407&view=rev
Log:
[CodeGen] add remquo to list of recognized library calls
This is just an oversight because we already do recognize __builtin_remquo()
with the same signature.
http
Author: spatel
Date: Mon Nov 6 08:27:36 2017
New Revision: 317489
URL: http://llvm.org/viewvc/llvm-project?rev=317489&view=rev
Log:
[CodeGen] match new fast-math-flag method: isFast()
This corresponds to LLVM commiti r317488:
If that commit is reverted, this commit will also need to be reverted
Author: spatel
Date: Mon Nov 13 14:11:49 2017
New Revision: 318093
URL: http://llvm.org/viewvc/llvm-project?rev=318093&view=rev
Log:
[CodeGen] fix const-ness of cbrt and fma
cbrt() is always constant because it can't overflow or underflow. Therefore, it
can't set errno.
fma() is not always cons
Author: spatel
Date: Sat Nov 18 11:31:57 2017
New Revision: 318598
URL: http://llvm.org/viewvc/llvm-project?rev=318598&view=rev
Log:
[CodeGen] change const-ness of complex calls
After clarification about the C standard, POSIX, and implementations:
The C standard allows errno-setting, and it's (un
Author: Sanjay Patel
Date: 2022-12-08T14:16:46-05:00
New Revision: 05dbdb0088a3f5541d9e91c61a564d0aa4704f4f
URL:
https://github.com/llvm/llvm-project/commit/05dbdb0088a3f5541d9e91c61a564d0aa4704f4f
DIFF:
https://github.com/llvm/llvm-project/commit/05dbdb0088a3f5541d9e91c61a564d0aa4704f4f.diff
Author: spatel
Date: Wed Apr 12 10:19:08 2017
New Revision: 300068
URL: http://llvm.org/viewvc/llvm-project?rev=300068&view=rev
Log:
[x86] fix AVX FP cmp intrinsic documentation (PR28110)
This copies the text used in the #define statements to the code comments.
The conflicting text comes from AM
Author: spatel
Date: Fri Feb 3 16:03:47 2017
New Revision: 294058
URL: http://llvm.org/viewvc/llvm-project?rev=294058&view=rev
Log:
[x86] fix tests with wrong dependency to pass because they broke with r294049
Modified:
cfe/trunk/test/CodeGen/avx512-reduceMinMaxIntrin.c
Modified: cfe/trunk/
Author: spatel
Date: Tue Jun 27 10:39:46 2017
New Revision: 306433
URL: http://llvm.org/viewvc/llvm-project?rev=306433&view=rev
Log:
[x86] weaken test checks that shouldn't be here in the first place
This test would fail after the proposed change in:
https://reviews.llvm.org/D34242
Modified:
Author: spatel
Date: Fri Jan 19 07:14:51 2018
New Revision: 322950
URL: http://llvm.org/viewvc/llvm-project?rev=322950&view=rev
Log:
[CodeGenCXX] annotate a GEP to a derived class with 'inbounds' (PR35909)
The standard says:
[expr.static.cast] p11: "If the prvalue of type “pointer to cv1 B” point
Author: spatel
Date: Sun Mar 12 14:15:10 2017
New Revision: 297588
URL: http://llvm.org/viewvc/llvm-project?rev=297588&view=rev
Log:
[x86] these aren't the undefs you're looking for (PR32176)
x86 has undef SSE/AVX intrinsics that should represent a bogus register
operand.
This is not the same a
Author: spatel
Date: Tue May 2 10:20:18 2017
New Revision: 301928
URL: http://llvm.org/viewvc/llvm-project?rev=301928&view=rev
Log:
[CodeGen] remove/fix checks that will fail when r301923 is recommitted
Don't test the optimizer as part of front-end verification.
Modified:
cfe/trunk/test/Cod
Author: spatel
Date: Wed Sep 9 17:39:06 2015
New Revision: 247203
URL: http://llvm.org/viewvc/llvm-project?rev=247203&view=rev
Log:
convert builtin_unpredictable on a switch into metadata for LLVM
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
cfe/trunk/test/CodeGen/builtin-unpredictable.c
Author: spatel
Date: Thu Sep 24 16:11:52 2015
New Revision: 248537
URL: http://llvm.org/viewvc/llvm-project?rev=248537&view=rev
Log:
fix typos; NFC
Modified:
cfe/trunk/include/clang/Lex/PPCallbacks.h
Modified: cfe/trunk/include/clang/Lex/PPCallbacks.h
URL:
http://llvm.org/viewvc/llvm-projec
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM.
See discussion in http://reviews.llvm.org/D10555.
http://reviews.llvm.org/D10556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: spatel
Date: Fri Aug 28 09:42:54 2015
New Revision: 246303
URL: http://llvm.org/viewvc/llvm-project?rev=246303&view=rev
Log:
fix typo; NFC
Modified:
cfe/trunk/lib/Sema/SemaStmt.cpp
Modified: cfe/trunk/lib/Sema/SemaStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/
spatel created this revision.
spatel added reviewers: hfinkel, kbsmith1, kparzysz, reames, silvas.
spatel added a subscriber: cfe-commits.
spatel added a dependency: D12341: add unpredictable metadata type for control
flow.
This patch depends on D12341 ('unpredictable' metadata type for LLVM).
spatel added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1238
@@ -1217,3 +1237,3 @@
}
- Builder.CreateCondBr(CondV, TrueBlock, FalseBlock, Weights);
+ Builder.CreateCondBr(CondV, TrueBlock, FalseBlock, Weights, Unpredictable);
}
spatel wrote
Author: spatel
Date: Wed Sep 2 15:01:30 2015
New Revision: 246699
URL: http://llvm.org/viewvc/llvm-project?rev=246699&view=rev
Log:
add __builtin_unpredictable and convert to metadata
This patch depends on r246688 (D12341).
The goal is to make LLVM generate different code for these functions fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246699: add __builtin_unpredictable and convert to metadata
(authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D12458?vs=33491&id=33850#toc
Repository:
rL LLVM
http://reviews.llv
spatel added a subscriber: davide.
spatel added a comment.
In https://reviews.llvm.org/D19544#488589, @mmasten wrote:
> In the process of writing test cases, I noticed that a loop with a call to
> llvm.log.f32 was not getting vectorized due to cost modeling. When forcing
> vectorization on the
spatel abandoned this revision.
spatel added a comment.
Abandoning.
The feedback on the dev list was that handling the builtin_expect() in clang is
ugly, so it's better to pay a small cost in LLVM to do it.
Note that the current llvm.expect lowering pass doesn't actually work for
anything but
spatel created this revision.
spatel added reviewers: hfinkel, scanon, chandlerc.
spatel added a subscriber: cfe-commits.
Herald added a subscriber: mcrosier.
isinf (infinite) and isfinite should be implemented with the same function
except we change the comparison operator.
See PR27145 for more
Author: spatel
Date: Thu Apr 7 09:29:05 2016
New Revision: 265675
URL: http://llvm.org/viewvc/llvm-project?rev=265675&view=rev
Log:
make __builtin_isfinite more efficient (PR27145)
isinf (is infinite) and isfinite should be implemented with the same function
except we change the comparison opera
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265675: make __builtin_isfinite more efficient (PR27145)
(authored by spatel).
Changed prior to commit:
http://reviews.llvm.org/D18648?vs=52214&id=52917#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: spatel
Date: Tue Apr 19 12:13:14 2016
New Revision: 266765
URL: http://llvm.org/viewvc/llvm-project?rev=266765&view=rev
Log:
reduce indentation; NFCI
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: spatel
Date: Tue Apr 19 13:06:33 2016
New Revision: 266787
URL: http://llvm.org/viewvc/llvm-project?rev=266787&view=rev
Log:
reduce indentation; NFCI
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
URL:
http://llvm.org/viewvc/l
Author: spatel
Date: Tue Apr 19 13:17:34 2016
New Revision: 266788
URL: http://llvm.org/viewvc/llvm-project?rev=266788&view=rev
Log:
[builtin_expect] tighten checks, add test, add comments
Modified:
cfe/trunk/test/CodeGen/builtin-expect.c
Modified: cfe/trunk/test/CodeGen/builtin-expect.c
URL
spatel created this revision.
spatel added reviewers: hfinkel, davidxl, bkramer.
spatel added a subscriber: cfe-commits.
Herald added subscribers: mcrosier, aemerson.
__builtin_expect() is a GCC-derived builtin that's used as a hint for branch
prediction:
https://gcc.gnu.org/onlinedocs/gcc/Other-
spatel added a comment.
[reposting this as a general comment because the inline comment did not seem to
make it to the mailing list]
Yes, I want to merge the handling of builtin_expect and builtin_unpredictable.
Currently, the 'unpredictable' metadata has no parameters; it is an empty
string l
1 - 100 of 139 matches
Mail list logo
