[PATCH] D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

sdesmalen accepted this revision. sdesmalen added a comment. It gives me great joy to see this code removed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146146/new/ https://reviews.llvm.org/D146146 _

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

sdesmalen updated this revision to Diff 502649. sdesmalen added a comment. - Added assert to check that NumVectors=1 for svcount_t. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136864/new/ https://reviews.llvm.org/D136864 Files: clang/include/c

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07158c54add9: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137556: [POC] Clang implementation for AArch64 SME and SME2 builtins

sdesmalen updated this revision to Diff 535645. sdesmalen retitled this revision from "[POC] Clang implementation for AArch64 SME and some SME2 builtins" to "[POC] Clang implementation for AArch64 SME and SME2 builtins". sdesmalen edited the summary of this revision. sdesmalen added a comment. He

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 536260. sdesmalen marked 11 inline comments as done. sdesmalen added a comment. Updated patch: - Addressed review comments (clarified documentation, minor refactoring) - Added new tests (codegen + sema tests to make sure attributes are propagated to types

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > sdesmalen wrote: > > erichkeane wrote: > > > sdesmalen wrote: > > > > er

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. Thanks @bryanpkc this patch looks good to me now. I'll make some time to review the other patches in the series as well after you update them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:42 // q -> Scalable vector, followed by the number of elements and the base type. +// Q -> AArch64 svcount_t builtin type. // E -> ext_vector, followed by the number of elements and the base

[PATCH] D151081: [Clang][SVE2.1] Add svpext builtins

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:64 +// 2,3,4: array of vectors +// .: indicator for multi-vector modifier that will follow(eg.:2.x) // v: void `s/follow(eg.:2.x)/follow (e.g. 2.x)/` Comment at:

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:42 // q -> Scalable vector, followed by the number of elements and the base type. +// Q -> AArch64 svcount_t builtin type. // E -> ext_vector, followed by the number of elements and the base

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:56 // P: boolean +// Qa: svcount // U: unsigned The typespec modifier in this file can remain `Q` rather than `Qa`. Can you change it back? Repository: rG LLVM Github Monorep

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h The ACLE specification is still in a draft (ALP) state, which mea

[PATCH] D136864: [Clang] Create opaque type for AArch64 SVE2p1/SME2 svcount_t.

sdesmalen updated this revision to Diff 496103. sdesmalen added a comment. Rebased patch to use target("aarch64.svcount") Changed debug info for svcount to only print the first 2 bytes (rather than vscale x 2 bytes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h bryanpkc wrote: > bryanpkc wrote: > > sdesmalen wrote: > > > The

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; erichkeane wrote: > Shouldn't

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; erichkeane wrote: > sdesmalen

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:726 -if (Feature == "+sme") { - HasSME = true; Why did you remove this? Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_ld1.c:16 +// +__a

[PATCH] D150863: [CLANG][AArch64][SVE2.1] Add UCLAMP/SCLAMP/FCLAMP function prototypes

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM with nit addressed Comment at: clang/include/clang/Basic/arm_sve.td:2113 +let TargetGuard = "sve2p1" in { + def SVSCLAMP : SInst<"svclamp[_{d}]", "", "csil",

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. I agree it makes sense to remove the typedef if they are also defined in `arm_bf16.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14882

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen created this revision. sdesmalen added reviewers: erichkeane, aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In https://reviews.llvm.org/D127762#4102578 @erichkeane suggested

[PATCH] D152141: [Clang] Make __arm_streaming apply only to prototyped functions.

sdesmalen created this revision. sdesmalen added a reviewer: rsandifo-arm. Herald added subscribers: jdoerfert, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D152142: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen created this revision. Herald added subscribers: jdoerfert, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds all the lang

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 528366. sdesmalen retitled this revision from "[Clang][AArch64] Add ACLE attributes for SME." to "[Clang][AArch64] Add/implement ACLE keywords for SME.". sdesmalen edited the summary of this revision. sdesmalen added a comment. - Rebased patch after patch t

[PATCH] D152142: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen abandoned this revision. sdesmalen added a comment. Accidentally created a duplicate, I was meant to update D127762 , so abandoning this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152142/new/ h

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 528376. sdesmalen marked 15 inline comments as done. sdesmalen added a comment. - Use only 6 bits for AArch64SMEAttributes to reduce the size of ExtProtoInfo. - Added test for implicit instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen marked 4 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > sdesmalen wrote: > > erichke

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen marked an inline comment as done. sdesmalen added a comment. In D127762#4395509 , @erichkeane wrote: > We ended up getting the regular-attribute-like-keywords patch in a different > form. Do we still want to do this as is? Does it need rebas

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3956 /// [implimits] 8 bits would be enough here. -unsigned NumExceptionType = 0; +unsigned NumExceptionType : 16; + erichkeane wrote: > tbaeder wrote: > > Isn't using a `uin

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen updated this revision to Diff 528431. sdesmalen added a comment. Use uint16_t instead of unsigned bitfield. Also removed accessor methods in favour of assert at point of writing NumExceptionType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3956 /// [implimits] 8 bits would be enough here. -unsigned NumExceptionType = 0; +unsigned NumExceptionType : 16; + erichkeane wrote: > sdesmalen wrote: > > erichkeane wrote

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen updated this revision to Diff 528433. sdesmalen added a comment. Use size_t instead of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152140/new/ https://reviews.llvm.org/D152140 Files: clang/include/clang/AST/Type.h clang/lib/A

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen added inline comments. Comment at: clang/lib/AST/Type.cpp:3374 auto &ExtraBits = *getTrailingObjects(); -ExtraBits.NumExceptionType = epi.ExceptionSpec.Exceptions.size(); +auto NumExceptions = epi.ExceptionSpec.Exceptions.size(); +assert(NumExceptions <

[PATCH] D152197: [NFC][CLANG] Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

sdesmalen added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9 if ((OperationKind == ACK_Arithmetic) && ((LHSBuiltinTy && LHSBuiltinTy->isSVEBool()) || (RHSBuiltinTy && RHSBuiltinTy->isSVEBool( { This doesn't seem like a non-

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

sdesmalen added a comment. Other than the two nits, the patch looks good. Thanks. Comment at: clang/include/clang/Basic/arm_sme.td:82 +def NAME # _H : SInst<"svread_hor_" # n_suffix # "[_{d}]", "ddPimi", t, MergeOp1, + "aarch64_sme_read" # !cond(!e

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9921-9922 return EmitSMEReadWrite(TypeFlags, Ops, Builtin->LLVMIntrinsic); + else if (TypeFlags.isZero()) +return EmitSMEZero(TypeFlags, Ops, Builtin->LLVMIntrinsic); Given t

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7013a751f170: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 482440. sdesmalen added a comment. Changed arm_new_za to be a declaration attribute instead of a type attribute (this was something that @rsandifo-arm pointed out to me recently) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen updated this revision to Diff 129943. sdesmalen added a comment. Refactoring based on @aprantl's suggestions. https://reviews.llvm.org/D41698 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeG

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen marked 3 inline comments as done. sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2358 +if (auto *SizeNode = getVLASizeExpressionForType(EltTy)) + Subscripts.push_back(DBuilder.getOrCreateSubrange(0, SizeNode)); +else --

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen added a comment. Just a gentle reminder that this patch still needs to be accepted (the LLVM support for it has been merged). https://reviews.llvm.org/D41698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.h:474 + CGBuilderTy &Builder, + llvm::Metadata **MetadataDecl = nullptr); aprantl wrote: > same here. Why not just use a return value? Initially I thought i

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen updated this revision to Diff 131990. sdesmalen marked 4 inline comments as done. sdesmalen added a comment. Herald added a subscriber: jholewinski. - Changed return type of getVLASize() to a struct with named members. - EmitDeclare and EmitDeclareOfAutoVariable now return a DILocalVaria

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:990 + D.getLocation(), D.getLocation(), &NameIdent, QT, + getContext().CreateTypeSourceInfo(QT), SC_Auto); + aprantl wrote: > sdesmalen wrote: > > aprantl wrote: > > > I think i

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen updated this revision to Diff 132275. sdesmalen added a comment. - Now always emit an alloca for a VLA dimension expression (regardless of whether -g is passed). - Fixed up some more tests since it now also triggers for all tests with variable length arrays that don't pass -g. - Refact

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen marked an inline comment as done. sdesmalen added a comment. Thanks for your review @aprantl! https://reviews.llvm.org/D41698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

sdesmalen added a comment. In D105169#3254757 , @nlopes wrote: > In D105169#3254692 , @DavidSpickett > wrote: > >> Hi, this patch has caused a gcc test suite failure on our SVE bots: >> https://lab.llvm.org/buil

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing! I'm curious, how did you find this case? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98852/new/ https://rev

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls, mgorny. sdesmalen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In order to bring up scalable vector support in LLVM increm

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen updated this revision to Diff 331820. sdesmalen added a comment. Rebased after D98736 already fixed one of the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98856/new/ https://reviews.llvm.org/D98

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen updated this revision to Diff 333010. sdesmalen added a comment. Moved error reporting to llvm::reportInvalidSizeRequest in TypeSize.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98856/new/ https://reviews.llvm.org/D98856 Files: c

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5052-5055 + if (isa(JA)) { +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } paulwalker-arm wrote: > Are there any concerns

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen updated this revision to Diff 333018. sdesmalen marked 5 inline comments as done. sdesmalen added a comment. Moved implementation of EVT::getVectorNumElements back to header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98856/new/ https:

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: llvm/lib/CodeGen/ValueTypes.cpp:17 +unsigned EVT::getVectorNumElements() const { + auto Error = []() { ctetreau wrote: > Out of curiosity, what is the eventual plan for this function? Does it go > away, or will it

[PATCH] D99592: [PoC][Clang] Use TypeSize instead of uint64_t for getTypeAllocSize().

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2856 Address AddrToStoreInto = Address::invalid(); -if (SrcSize <= DstSize) { +if (llvm::TypeSize::isKnownLE(SrcSize, DstSize)) { AddrToStoreInto = Builder.CreateElementB

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f7bbbc481e2: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag… (authored by sdesmalen). Changed prior to commit: h

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5066 +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } MaskRay wrote: > Does this introduce an option in the CC1 command line

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen created this revision. Herald added subscribers: danielkiss, kristof.beyls. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes an issue with the SVE prefetch and qinc/qdec intrinsics that take an `enum` arg

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen added a comment. The fact that Clang chooses to (explicitly) forget about a builtin in SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't fully understand how the builtin mechanism is supposed to work. @rsmith and @tambre, git history showed me you have more expe

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen updated this revision to Diff 336760. sdesmalen added a comment. Removed `forgetBuiltin` and the code using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new/ https://reviews.llvm.org/D100046 Files: clang/include/clang/Basic

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen added a comment. Thanks for taking time from your weekend to look into this @tambre, much appreciated! Comment at: clang/lib/Sema/SemaDecl.cpp:10953-10967 if (unsigned BuiltinID = NewFD->getBuiltinID()) { ASTContext::GetBuiltinTypeError Error; Look

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf806b3e2fd: [AArch64] ACLE: Fix issue for mismatching enum types with builtins. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1000

[PATCH] D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++.

sdesmalen created this revision. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the builtin prototype to use 'b' (bo

[PATCH] D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro.

sdesmalen created this revision. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a subtle issue where: svprf(pg, ptr, SV_A

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

sdesmalen added a comment. After reading the summary/intent of the patch, I thought the same thing as @rjmccall. Simply returning an i32 for the above example and removing the rounding-up seems right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa936b610fd0: [AArch64][SVE] Fix dup/dupq intrinsics for C++. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100294/new/ https://rev

[PATCH] D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG204aaf879548: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro. (authored by sdesmalen). Changed prior to commit: https:

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

sdesmalen added inline comments. Comment at: llvm/test/Transforms/InstCombine/debuginfo-scalable-typesize.ll:13 + +; ERR-NOT: TypeSize is not scalable + After your changes, what line causes this warning to be emitted? Does this test also pass with asserts enable

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 ___

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3034 +integer and the type of vectorization can be specified with an optional +second parameter. In this case 'fixed' is the default and refers to fixed width +vectorization, whereas 'scalable' indicat

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks for all the changes @david-arm! Comment at: clang/lib/AST/AttrImpl.cpp:46 + else if (state == FixedWidth || state == ScalableWidth) { +if (value) { +

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

sdesmalen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:185-188 +architectural features. For example, we can compile code with +"-mcpu=generic -mtune=cortex-a57" where the architectural features are +defined according to a "generic" CPU, but we use the scheduling

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks @david-arm, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 ___ cfe-commits m

<    1   2   3   4   5