Author: Kai Stierand
Date: 2022-10-11T15:01:31+02:00
New Revision: 5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b
URL:
https://github.com/llvm/llvm-project/commit/5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b
DIFF:
https://github.com/llvm/llvm-project/commit/5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b.diff
Author: Sam McCall
Date: 2022-10-12T19:54:51+02:00
New Revision: 2eaf6f973cacd7f24691b72a9c6a3ee2a3d1a60b
URL:
https://github.com/llvm/llvm-project/commit/2eaf6f973cacd7f24691b72a9c6a3ee2a3d1a60b
DIFF:
https://github.com/llvm/llvm-project/commit/2eaf6f973cacd7f24691b72a9c6a3ee2a3d1a60b.diff
LO
Author: Sam McCall
Date: 2022-10-13T12:07:31+02:00
New Revision: e78165f0ba1e2fbf72b36a36c8560645b69a168a
URL:
https://github.com/llvm/llvm-project/commit/e78165f0ba1e2fbf72b36a36c8560645b69a168a
DIFF:
https://github.com/llvm/llvm-project/commit/e78165f0ba1e2fbf72b36a36c8560645b69a168a.diff
LO
Author: Sam McCall
Date: 2022-10-13T13:05:24+02:00
New Revision: b13f7f9c06604110709a968a2fece4b8d5192708
URL:
https://github.com/llvm/llvm-project/commit/b13f7f9c06604110709a968a2fece4b8d5192708
DIFF:
https://github.com/llvm/llvm-project/commit/b13f7f9c06604110709a968a2fece4b8d5192708.diff
LO
Author: Sam McCall
Date: 2022-12-21T23:35:48+01:00
New Revision: b494f67f67968c50289148fb423a108607be83e9
URL:
https://github.com/llvm/llvm-project/commit/b494f67f67968c50289148fb423a108607be83e9
DIFF:
https://github.com/llvm/llvm-project/commit/b494f67f67968c50289148fb423a108607be83e9.diff
LO
Author: Sam McCall
Date: 2023-01-10T13:59:58+01:00
New Revision: 98ae3616cd1536643a78beeddff119c028f71df6
URL:
https://github.com/llvm/llvm-project/commit/98ae3616cd1536643a78beeddff119c028f71df6
DIFF:
https://github.com/llvm/llvm-project/commit/98ae3616cd1536643a78beeddff119c028f71df6.diff
LO
Author: Sam McCall
Date: 2023-01-11T14:44:22+01:00
New Revision: d7bba07526a7298c9331de031dec15daecff3503
URL:
https://github.com/llvm/llvm-project/commit/d7bba07526a7298c9331de031dec15daecff3503
DIFF:
https://github.com/llvm/llvm-project/commit/d7bba07526a7298c9331de031dec15daecff3503.diff
LO
Author: Sam McCall
Date: 2023-01-11T16:11:25+01:00
New Revision: f0e60f99aefff66ca6223eb3c3a36615f36454ec
URL:
https://github.com/llvm/llvm-project/commit/f0e60f99aefff66ca6223eb3c3a36615f36454ec
DIFF:
https://github.com/llvm/llvm-project/commit/f0e60f99aefff66ca6223eb3c3a36615f36454ec.diff
LO
Author: Sam McCall
Date: 2023-01-11T18:04:42+01:00
New Revision: 9b16c624edde50e2a460f9bd0d2e9ac3cb1af695
URL:
https://github.com/llvm/llvm-project/commit/9b16c624edde50e2a460f9bd0d2e9ac3cb1af695
DIFF:
https://github.com/llvm/llvm-project/commit/9b16c624edde50e2a460f9bd0d2e9ac3cb1af695.diff
LO
Author: Sam McCall
Date: 2022-11-08T12:19:23+01:00
New Revision: 5426a1e51d20a13f575ae03c10b274430b4a3539
URL:
https://github.com/llvm/llvm-project/commit/5426a1e51d20a13f575ae03c10b274430b4a3539
DIFF:
https://github.com/llvm/llvm-project/commit/5426a1e51d20a13f575ae03c10b274430b4a3539.diff
LO
Author: Sam McCall
Date: 2022-11-08T15:20:40+01:00
New Revision: 8249dc21046af57ad3b2c72414aa8a7f16b67687
URL:
https://github.com/llvm/llvm-project/commit/8249dc21046af57ad3b2c72414aa8a7f16b67687
DIFF:
https://github.com/llvm/llvm-project/commit/8249dc21046af57ad3b2c72414aa8a7f16b67687.diff
LO
Author: Sam McCall
Date: 2022-11-08T20:10:39+01:00
New Revision: 38cccb90660347939dd7bfdd57ba66760cba39c2
URL:
https://github.com/llvm/llvm-project/commit/38cccb90660347939dd7bfdd57ba66760cba39c2
DIFF:
https://github.com/llvm/llvm-project/commit/38cccb90660347939dd7bfdd57ba66760cba39c2.diff
LO
Author: Sam McCall
Date: 2022-11-08T20:18:10+01:00
New Revision: c333b92b72b40d1f39d89ab94f764baeb8bb0cab
URL:
https://github.com/llvm/llvm-project/commit/c333b92b72b40d1f39d89ab94f764baeb8bb0cab
DIFF:
https://github.com/llvm/llvm-project/commit/c333b92b72b40d1f39d89ab94f764baeb8bb0cab.diff
LO
Author: Sam McCall
Date: 2022-11-11T12:10:12+01:00
New Revision: 61c2276cb231f5cc5698c0bdd2e92d9ecfdefa16
URL:
https://github.com/llvm/llvm-project/commit/61c2276cb231f5cc5698c0bdd2e92d9ecfdefa16
DIFF:
https://github.com/llvm/llvm-project/commit/61c2276cb231f5cc5698c0bdd2e92d9ecfdefa16.diff
LO
Author: Sam McCall
Date: 2022-11-11T13:25:22+01:00
New Revision: 8dfaf9940abe029e4fd35c63e3d7f2df66306a06
URL:
https://github.com/llvm/llvm-project/commit/8dfaf9940abe029e4fd35c63e3d7f2df66306a06
DIFF:
https://github.com/llvm/llvm-project/commit/8dfaf9940abe029e4fd35c63e3d7f2df66306a06.diff
LO
Author: Sam McCall
Date: 2022-11-11T13:41:54+01:00
New Revision: 7943169273b22f61a0322cb2d38ff75845e52628
URL:
https://github.com/llvm/llvm-project/commit/7943169273b22f61a0322cb2d38ff75845e52628
DIFF:
https://github.com/llvm/llvm-project/commit/7943169273b22f61a0322cb2d38ff75845e52628.diff
LO
Author: Sam McCall
Date: 2022-11-17T17:29:41+01:00
New Revision: 267577325876d7e3e2b96c0a577b1b8ce076dfbb
URL:
https://github.com/llvm/llvm-project/commit/267577325876d7e3e2b96c0a577b1b8ce076dfbb
DIFF:
https://github.com/llvm/llvm-project/commit/267577325876d7e3e2b96c0a577b1b8ce076dfbb.diff
LO
Author: Sam McCall
Date: 2023-02-03T13:22:26+01:00
New Revision: e1aaa314a46cd303019da117bfd330611d5b7a84
URL:
https://github.com/llvm/llvm-project/commit/e1aaa314a46cd303019da117bfd330611d5b7a84
DIFF:
https://github.com/llvm/llvm-project/commit/e1aaa314a46cd303019da117bfd330611d5b7a84.diff
LO
Author: Sam McCall
Date: 2023-02-03T13:47:13+01:00
New Revision: 506e55b041b94808c80099d61cef5539390ab215
URL:
https://github.com/llvm/llvm-project/commit/506e55b041b94808c80099d61cef5539390ab215
DIFF:
https://github.com/llvm/llvm-project/commit/506e55b041b94808c80099d61cef5539390ab215.diff
LO
Author: Sam McCall
Date: 2023-01-12T13:22:21+01:00
New Revision: bb1b0e61cda66cb9f06bc4f1dc21e03bb1744d22
URL:
https://github.com/llvm/llvm-project/commit/bb1b0e61cda66cb9f06bc4f1dc21e03bb1744d22
DIFF:
https://github.com/llvm/llvm-project/commit/bb1b0e61cda66cb9f06bc4f1dc21e03bb1744d22.diff
LO
Author: v1nh1shungry
Date: 2023-01-13T03:26:33+01:00
New Revision: 1feb7af046889728233e67e3163ab30020207bb2
URL:
https://github.com/llvm/llvm-project/commit/1feb7af046889728233e67e3163ab30020207bb2
DIFF:
https://github.com/llvm/llvm-project/commit/1feb7af046889728233e67e3163ab30020207bb2.diff
Author: Sam McCall
Date: 2022-06-23T15:52:22+02:00
New Revision: 6b187fdf3bb409061b6a235487517f478b09afed
URL:
https://github.com/llvm/llvm-project/commit/6b187fdf3bb409061b6a235487517f478b09afed
DIFF:
https://github.com/llvm/llvm-project/commit/6b187fdf3bb409061b6a235487517f478b09afed.diff
LO
Author: Sam McCall
Date: 2022-06-23T17:26:42+02:00
New Revision: e3ec054dfdf48f19cb6726cb3f4965b9ab320ed9
URL:
https://github.com/llvm/llvm-project/commit/e3ec054dfdf48f19cb6726cb3f4965b9ab320ed9
DIFF:
https://github.com/llvm/llvm-project/commit/e3ec054dfdf48f19cb6726cb3f4965b9ab320ed9.diff
LO
Author: Sam McCall
Date: 2022-06-23T18:16:38+02:00
New Revision: 2c80b5319870b57fbdbb6c9cef9c86c26c65371d
URL:
https://github.com/llvm/llvm-project/commit/2c80b5319870b57fbdbb6c9cef9c86c26c65371d
DIFF:
https://github.com/llvm/llvm-project/commit/2c80b5319870b57fbdbb6c9cef9c86c26c65371d.diff
LO
Author: Sam McCall
Date: 2022-06-23T18:21:44+02:00
New Revision: b70ee9d984e71675b030697765988ac6adc2bb4e
URL:
https://github.com/llvm/llvm-project/commit/b70ee9d984e71675b030697765988ac6adc2bb4e
DIFF:
https://github.com/llvm/llvm-project/commit/b70ee9d984e71675b030697765988ac6adc2bb4e.diff
LO
Author: Sam McCall
Date: 2022-06-23T18:21:59+02:00
New Revision: f9710d190886024ba938819722eb23cba8da2c06
URL:
https://github.com/llvm/llvm-project/commit/f9710d190886024ba938819722eb23cba8da2c06
DIFF:
https://github.com/llvm/llvm-project/commit/f9710d190886024ba938819722eb23cba8da2c06.diff
LO
Author: Sam McCall
Date: 2022-06-23T19:27:47+02:00
New Revision: 3e610f2cdc1e156c82f5b59c287165e769b24f40
URL:
https://github.com/llvm/llvm-project/commit/3e610f2cdc1e156c82f5b59c287165e769b24f40
DIFF:
https://github.com/llvm/llvm-project/commit/3e610f2cdc1e156c82f5b59c287165e769b24f40.diff
LO
Author: Sam McCall
Date: 2022-06-23T19:41:11+02:00
New Revision: 7aff663b2a04f6bea0732ed3b11e10466affb2ac
URL:
https://github.com/llvm/llvm-project/commit/7aff663b2a04f6bea0732ed3b11e10466affb2ac
DIFF:
https://github.com/llvm/llvm-project/commit/7aff663b2a04f6bea0732ed3b11e10466affb2ac.diff
LO
Author: Sam McCall
Date: 2022-06-23T20:10:20+02:00
New Revision: 466eae6aa3574aea6604d42666f099025718ffa4
URL:
https://github.com/llvm/llvm-project/commit/466eae6aa3574aea6604d42666f099025718ffa4
DIFF:
https://github.com/llvm/llvm-project/commit/466eae6aa3574aea6604d42666f099025718ffa4.diff
LO
Author: Sam McCall
Date: 2022-06-23T20:34:11+02:00
New Revision: 768216cac0242db609fef55ea98283f57801fd18
URL:
https://github.com/llvm/llvm-project/commit/768216cac0242db609fef55ea98283f57801fd18
DIFF:
https://github.com/llvm/llvm-project/commit/768216cac0242db609fef55ea98283f57801fd18.diff
LO
Author: Sam McCall
Date: 2022-05-31T20:47:57+02:00
New Revision: 9d991da60df492a191b34aa3e75484ddd27e8930
URL:
https://github.com/llvm/llvm-project/commit/9d991da60df492a191b34aa3e75484ddd27e8930
DIFF:
https://github.com/llvm/llvm-project/commit/9d991da60df492a191b34aa3e75484ddd27e8930.diff
LO
Author: Georg Kotheimer
Date: 2022-05-31T22:05:23+02:00
New Revision: ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d
URL:
https://github.com/llvm/llvm-project/commit/ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d
DIFF:
https://github.com/llvm/llvm-project/commit/ce5ebf0b9113df8ccaec1bcfd6804fb16cdef69d.dif
Author: Sam McCall
Date: 2022-05-31T22:30:20+02:00
New Revision: 218393f44ec903341125b70ce3fbb6dc731a9399
URL:
https://github.com/llvm/llvm-project/commit/218393f44ec903341125b70ce3fbb6dc731a9399
DIFF:
https://github.com/llvm/llvm-project/commit/218393f44ec903341125b70ce3fbb6dc731a9399.diff
LO
Author: Sam McCall
Date: 2022-06-03T20:42:38+02:00
New Revision: dc63ad8878de6d0b5dc1268691f48035e9234763
URL:
https://github.com/llvm/llvm-project/commit/dc63ad8878de6d0b5dc1268691f48035e9234763
DIFF:
https://github.com/llvm/llvm-project/commit/dc63ad8878de6d0b5dc1268691f48035e9234763.diff
LO
Author: Sam McCall
Date: 2022-06-03T20:45:48+02:00
New Revision: a43fef05d4fae32f02365c7b8fef2aa631d23628
URL:
https://github.com/llvm/llvm-project/commit/a43fef05d4fae32f02365c7b8fef2aa631d23628
DIFF:
https://github.com/llvm/llvm-project/commit/a43fef05d4fae32f02365c7b8fef2aa631d23628.diff
LO
Author: Sam McCall
Date: 2022-06-03T20:48:55+02:00
New Revision: 830d158d2b7d2fa45f39fe12aa0b2ffc70c7e771
URL:
https://github.com/llvm/llvm-project/commit/830d158d2b7d2fa45f39fe12aa0b2ffc70c7e771
DIFF:
https://github.com/llvm/llvm-project/commit/830d158d2b7d2fa45f39fe12aa0b2ffc70c7e771.diff
LO
Author: Sam McCall
Date: 2022-06-08T23:35:14+02:00
New Revision: 93bcff8aa85512f2b24e822d857b426c31b6d051
URL:
https://github.com/llvm/llvm-project/commit/93bcff8aa85512f2b24e822d857b426c31b6d051
DIFF:
https://github.com/llvm/llvm-project/commit/93bcff8aa85512f2b24e822d857b426c31b6d051.diff
LO
Author: Sam McCall
Date: 2022-06-08T23:39:34+02:00
New Revision: bbc58c5e9ba39b234b6f526b313bbc35cbc2ba0f
URL:
https://github.com/llvm/llvm-project/commit/bbc58c5e9ba39b234b6f526b313bbc35cbc2ba0f
DIFF:
https://github.com/llvm/llvm-project/commit/bbc58c5e9ba39b234b6f526b313bbc35cbc2ba0f.diff
LO
Author: Sam McCall
Date: 2022-06-08T23:39:59+02:00
New Revision: 94b2ca18c10bfb4107a850d63148fc51e65d9512
URL:
https://github.com/llvm/llvm-project/commit/94b2ca18c10bfb4107a850d63148fc51e65d9512
DIFF:
https://github.com/llvm/llvm-project/commit/94b2ca18c10bfb4107a850d63148fc51e65d9512.diff
LO
Author: Sam McCall
Date: 2022-06-09T14:18:30+02:00
New Revision: 18f0b7092db5b8554415e872d02c4628a5ae7296
URL:
https://github.com/llvm/llvm-project/commit/18f0b7092db5b8554415e872d02c4628a5ae7296
DIFF:
https://github.com/llvm/llvm-project/commit/18f0b7092db5b8554415e872d02c4628a5ae7296.diff
LO
https://github.com/sam-mccall approved this pull request.
https://github.com/llvm/llvm-project/pull/66742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -87,6 +87,9 @@ class alignas(const Formula *) Formula {
ArrayRef Operands,
unsigned Value = 0);
+ // Parse Formulas using Arena rather than caling this function directly.
+ static Formula *parse(llvm::BumpPtrAllocator &All
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -95,4 +98,94 @@ BoolValue &Arena::makeBoolValue(const Formula &F) {
return *It->second;
}
+namespace {
+const Formula *parse(Arena &A, llvm::StringRef &In) {
+ auto EatWhitespace = [&] { In = In.ltrim(' '); };
sam-mccall wrote:
Renamed, hard to know if
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -258,114 +276,71 @@ TEST(SolverTest, IffWithUnits) {
}
TEST(SolverTest, IffWithUnitsConflict) {
- ConstraintContext Ctx;
- auto X = Ctx.atom();
- auto Y = Ctx.atom();
- auto XEqY = Ctx.iff(X, Y);
- auto NotY = Ctx.neg(Y);
-
- // (X <=> Y) ^ X !Y
- EXPECT_THAT(solve(
@@ -95,4 +98,94 @@ BoolValue &Arena::makeBoolValue(const Formula &F) {
return *It->second;
}
+namespace {
+const Formula *parse(Arena &A, llvm::StringRef &In) {
+ auto EatWhitespace = [&] { In = In.ltrim(' '); };
+ EatWhitespace();
+
+ if (In.consume_front("!")) {
+if
@@ -95,4 +98,94 @@ BoolValue &Arena::makeBoolValue(const Formula &F) {
return *It->second;
}
+namespace {
+const Formula *parse(Arena &A, llvm::StringRef &In) {
+ auto EatWhitespace = [&] { In = In.ltrim(' '); };
+ EatWhitespace();
+
+ if (In.consume_front("!")) {
+if
https://github.com/sam-mccall updated
https://github.com/llvm/llvm-project/pull/66424
>From 35b33561af918fc2e13af9de18af6b181535ce49 Mon Sep 17 00:00:00 2001
From: Sam McCall
Date: Thu, 14 Sep 2023 21:36:50 +0200
Subject: [PATCH 1/2] [dataflow] Parse formulas from text
My immediate use for thi
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall updated
https://github.com/llvm/llvm-project/pull/66424
>From 35b33561af918fc2e13af9de18af6b181535ce49 Mon Sep 17 00:00:00 2001
From: Sam McCall
Date: Thu, 14 Sep 2023 21:36:50 +0200
Subject: [PATCH 1/3] [dataflow] Parse formulas from text
My immediate use for thi
https://github.com/sam-mccall created
https://github.com/llvm/llvm-project/pull/66757
(In addition to the un-normalized form, so this is back-compatible)
>From 1923a5142f9cbd3556bba599b611ae8a1bbec776 Mon Sep 17 00:00:00 2001
From: Sam McCall
Date: Tue, 19 Sep 2023 12:16:54 +0200
Subject: [PA
sam-mccall wrote:
@kadircet this is internal b/294113850
https://github.com/llvm/llvm-project/pull/66757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sam-mccall wrote:
I didn't add a test here because it seems fairly fiddly and fragile (would be a
lit test) and unlikely to actually regress in practice. But I'm just making
excuses, happy to add one if you think it's worthwhile.
https://github.com/llvm/llvm-project/pull/66757
https://github.com/sam-mccall updated
https://github.com/llvm/llvm-project/pull/66757
>From 1923a5142f9cbd3556bba599b611ae8a1bbec776 Mon Sep 17 00:00:00 2001
From: Sam McCall
Date: Tue, 19 Sep 2023 12:16:54 +0200
Subject: [PATCH 1/2] [clangd] Allow --query-driver to match a dot-normalized
form
https://github.com/sam-mccall approved this pull request.
Thanks, this looks nice!
https://github.com/llvm/llvm-project/pull/66746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall created
https://github.com/llvm/llvm-project/pull/66933
We're traversing the same chains of module ancestors and include
locations repeatedly, despite already populating sets that can detect it!
This is a problem because translateFile() is expensive. I think we can
https://github.com/sam-mccall created
https://github.com/llvm/llvm-project/pull/66947
b1e3cd1d79443603dc003441e07cdd8d30bb7f26 dropped the leading slash here,
presumably unintentionally.
(I don't understand Driver well enough to know how/where this is supposed
to be tested, but it broke clangd
sam-mccall wrote:
Thanks for the quick response!
> The `sys::path::append` behavior here is surprising. I think it'd be better
> to change the computation of `SysRoot` in the function above (line 3102,
> which I can't comment because of GitHub, sigh) to default to
> `llvm::sys::path::get_sepa
@@ -88,10 +88,12 @@ class ModelDumper {
void dump(Value &V) {
JOS.attribute("value_id", llvm::to_string(&V));
-if (!Visited.insert(&V).second)
- return;
-
JOS.attribute("kind", debugString(V.getKind()));
+if (!Visited.insert(&V).second) {
+ JOS.att
@@ -123,13 +125,16 @@ class ModelDumper {
}
void dump(const StorageLocation &L) {
JOS.attribute("location", llvm::to_string(&L));
-if (!Visited.insert(&L).second)
- return;
-
JOS.attribute("type", L.getType().getAsString());
if (auto *V = Env.getValue
@@ -88,10 +88,12 @@ class ModelDumper {
void dump(Value &V) {
JOS.attribute("value_id", llvm::to_string(&V));
-if (!Visited.insert(&V).second)
- return;
-
JOS.attribute("kind", debugString(V.getKind()));
+if (!Visited.insert(&V).second) {
--
sam-mccall wrote:
Thanks! This will fix the double-slash issue (despite the name, `add_dots`
normalizes those).
symlinks and progra~1 mean normalization based on actual filesystem access, and
choosing between multiple forms that are in some sense equally valid.
I don't think I'm opposed if so
https://github.com/sam-mccall closed
https://github.com/llvm/llvm-project/pull/66757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall closed
https://github.com/llvm/llvm-project/pull/66933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall closed
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall updated
https://github.com/llvm/llvm-project/pull/66947
>From 00ef242c40dd453157ee3b31e367fd6240d68a5a Mon Sep 17 00:00:00 2001
From: Sam McCall
Date: Wed, 20 Sep 2023 21:19:03 +0200
Subject: [PATCH 1/2] [Driver] Fix detection of libc++ with empty sysroot.
b1e3cd1
sam-mccall wrote:
> I just meant to change [...] It's a local fix, but all the code here is
> pretty inconsistent anyway, so I don't feel too bad about it.
Oops, of course. Done & I worked out the testing.
https://github.com/llvm/llvm-project/pull/66947
https://github.com/sam-mccall updated
https://github.com/llvm/llvm-project/pull/66947
>From 00ef242c40dd453157ee3b31e367fd6240d68a5a Mon Sep 17 00:00:00 2001
From: Sam McCall
Date: Wed, 20 Sep 2023 21:19:03 +0200
Subject: [PATCH 1/3] [Driver] Fix detection of libc++ with empty sysroot.
b1e3cd1
Author: Sam McCall
Date: 2023-09-22T17:12:20+02:00
New Revision: 36bd5bd888f193b70abf43a09bb4fc04cd2a2ff1
URL:
https://github.com/llvm/llvm-project/commit/36bd5bd888f193b70abf43a09bb4fc04cd2a2ff1
DIFF:
https://github.com/llvm/llvm-project/commit/36bd5bd888f193b70abf43a09bb4fc04cd2a2ff1.diff
LO
@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) {
}
}
+MATCHER_P(jobHasArgs, Substr, "") {
+ const driver::Command &C = arg;
+ std::string Args = "";
+ llvm::ListSeparator Sep(" ");
+ for (const char *Arg : C.getArguments()) {
+Args += Sep;
+
https://github.com/sam-mccall closed
https://github.com/llvm/llvm-project/pull/66947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall created
https://github.com/llvm/llvm-project/pull/67228
Loosely, the "associated header" of `foo.cpp` is `foo.h`.
It should be included, many styles include it first.
So far we haven't special cased it in any way, and require this include
to be justified. e.g. if f
https://github.com/sam-mccall approved this pull request.
https://github.com/llvm/llvm-project/pull/67307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sam-mccall wrote:
@Caslyn that failure doesn't look plausible for this commit, there's no
dependency on AST matchers
I'm not familiar with this buildbot, but it looks like there was an infra
problem (failing install step) for a while that recently got fixed, and this
test failure existed befo
Author: Sam McCall
Date: 2023-09-27T10:59:04+02:00
New Revision: 0afbcb20fd908f8bf9073697423da097be7db592
URL:
https://github.com/llvm/llvm-project/commit/0afbcb20fd908f8bf9073697423da097be7db592
DIFF:
https://github.com/llvm/llvm-project/commit/0afbcb20fd908f8bf9073697423da097be7db592.diff
LO
@@ -10,6 +10,7 @@
//
//===--===//
+#include "../Basic/Targets/NVPTX.h"
sam-mccall wrote:
This header is not part of `clangBasic`'s interface, but rather its
implementation (`lib/Basic` rath
Author: Sam McCall
Date: 2023-09-27T18:58:01+02:00
New Revision: 880fa7faa97bad63e403c924263b01fb81783227
URL:
https://github.com/llvm/llvm-project/commit/880fa7faa97bad63e403c924263b01fb81783227
DIFF:
https://github.com/llvm/llvm-project/commit/880fa7faa97bad63e403c924263b01fb81783227.diff
LO
sam-mccall wrote:
Sorry, there were no notifications, I guess the bot was already red.
I'm not really sure what to do other than disable the test on these bots - I
don't know why it would fail on win/arm (it seems to pass on win/x86), and I
don't have access to such a machine.
This behavior is
sam-mccall wrote:
... and as soon as I said that, I found something: looks like these are maybe
building with `DEFAULT_SYSROOT=C:/buildbot/.arm-ubuntu`, which breaks the
no-sysroot behavior we're testing here.
I'll see if I can override with `--sysroot=`
https://github.com/llvm/llvm-project/p
Author: Sam McCall
Date: 2023-09-27T19:31:57+02:00
New Revision: 5aa3338930d15a59dd6ddbd36fc09ffa6610ca72
URL:
https://github.com/llvm/llvm-project/commit/5aa3338930d15a59dd6ddbd36fc09ffa6610ca72
DIFF:
https://github.com/llvm/llvm-project/commit/5aa3338930d15a59dd6ddbd36fc09ffa6610ca72.diff
LO
https://github.com/sam-mccall resolved
https://github.com/llvm/llvm-project/pull/67431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall edited
https://github.com/llvm/llvm-project/pull/67431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -122,10 +122,22 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
-.value summary {
+.value > summary {
background-color: #ace;
display: flex;
justify-content: space-between;
+ cursor: pointer;
+}
+.value > summary::before {
+ content:
@@ -122,10 +122,22 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
-.value summary {
+.value > summary {
background-color: #ace;
display: flex;
justify-content: space-between;
+ cursor: pointer;
+}
+.value > summary::before {
+ content:
@@ -122,10 +122,22 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
-.value summary {
+.value > summary {
background-color: #ace;
display: flex;
justify-content: space-between;
sam-mccall wrote:
if space-between stays, don
https://github.com/sam-mccall approved this pull request.
https://github.com/llvm/llvm-project/pull/67431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/67637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -122,10 +122,22 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
-.value summary {
+.value > summary {
background-color: #ace;
display: flex;
- justify-content: space-between;
+ justify-content: start;
sam-mccall wrote:
@@ -10,6 +10,7 @@
//
//===--===//
+#include "../Basic/Targets/NVPTX.h"
sam-mccall wrote:
@jchlanda ah, that's simpler than I expected! Wish I'd found that before
reverting...
That looks go
@@ -123,10 +123,21 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
-.value summary {
+.value > summary {
background-color: #ace;
display: flex;
- justify-content: space-between;
+ cursor: pointer;
+}
+.value > summary::before {
+ content:
https://github.com/sam-mccall edited
https://github.com/llvm/llvm-project/pull/67655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall approved this pull request.
https://github.com/llvm/llvm-project/pull/67655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sam-mccall approved this pull request.
https://github.com/llvm/llvm-project/pull/67667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sam-mccall wrote:
(gentle ping)
https://github.com/llvm/llvm-project/pull/65484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1101 - 1200 of 1737 matches
Mail list logo