================ @@ -88,10 +88,12 @@ class ModelDumper { void dump(Value &V) { JOS.attribute("value_id", llvm::to_string(&V)); - if (!Visited.insert(&V).second) - return; - JOS.attribute("kind", debugString(V.getKind())); + if (!Visited.insert(&V).second) { ---------------- sam-mccall wrote:
the reordering here looks good, including `kind` is safe & useful https://github.com/llvm/llvm-project/pull/66887 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits