rogfer01 added inline comments.
Comment at:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp:171-173
+#else
+ios1.copyfmt(ios2);
+#endif
This is a bit unexpected. It looks like if the copyfmt, even if it throws, were
able to copy
rogfer01 added a comment.
I'd rather not to go the way of `TEST_TRY` and `TEST_CASE` macros.
As suggested by @rmaprath, I've been playing with grouping the tests in three
categories: no exceptions (at all), should not throw, must throw. No changes
are required for the first group. The third gro
Author: rogfer01
Date: Mon Nov 14 02:53:27 2016
New Revision: 286798
URL: http://llvm.org/viewvc/llvm-project?rev=286798&view=rev
Log:
Remove some false positives when taking the address of packed members
Differential Revision: https://reviews.llvm.org/D23657
Modified:
cfe/trunk/include/cl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286798: Remove some false positives when taking the address
of packed members (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D23657?vs=77498&id=3#toc
Repository:
rL LLV
rogfer01 added a comment.
Ping? :)
https://reviews.llvm.org/D26457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286809: Protect smart-pointer tests under no exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26457?vs=77361&id=8#toc
Repository:
rL LLVM
https://reviews.llv
Author: rogfer01
Date: Mon Nov 14 04:27:56 2016
New Revision: 286809
URL: http://llvm.org/viewvc/llvm-project?rev=286809&view=rev
Log:
Protect smart-pointer tests under no exceptions
Skip tests that expect an exception be thrown under no-exceptions.
Differential Revision: https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286812: Update tests for strings conversions under
libcpp-no-exceptions (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26139?vs=76373&id=9#toc
Repository:
rL LLVM
htt
Author: rogfer01
Date: Mon Nov 14 04:44:26 2016
New Revision: 286812
URL: http://llvm.org/viewvc/llvm-project?rev=286812&view=rev
Log:
Update tests for strings conversions under libcpp-no-exceptions
Differential Revision: https://reviews.llvm.org/D26139
Modified:
libcxx/trunk/test/std/strin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286813: Protect nested-exceptions tests under no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26458?vs=77363&id=77782#toc
Repository:
rL LLVM
https://reviews
Author: rogfer01
Date: Mon Nov 14 05:00:28 2016
New Revision: 286813
URL: http://llvm.org/viewvc/llvm-project?rev=286813&view=rev
Log:
Protect nested-exceptions tests under no-exceptions
Differential Revision: https://reviews.llvm.org/D26458
Modified:
libcxx/trunk/test/std/language.support
rogfer01 updated this revision to Diff 77789.
rogfer01 added a comment.
Add missing asserts as pointed out by @EricWF
https://reviews.llvm.org/D26512
Files:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp
test/std/input.output/iostreams.base/ios/basic.ios.members
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286823: Protect std::ios tests under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26512?vs=77789&id=77797#toc
Repository:
rL LLVM
https://reviews.l
Author: rogfer01
Date: Mon Nov 14 07:44:50 2016
New Revision: 286823
URL: http://llvm.org/viewvc/llvm-project?rev=286823&view=rev
Log:
Protect std::ios tests under libcpp-no-exceptions
Skip tests that expect an exception be thrown. Also add
some missing asserts in the original test.
Differential
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown.
https://reviews.llvm.org/D26606
Files:
test/std/utilities/memory/specialized.algorithms/uninitialized.copy/uniniti
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown and/or disable
unreachable catch handlers.
https://reviews.llvm.org/D26608
Files:
test/std/strings/basic.string/stri
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown and/or disable
unreachable catch handlers.
https://reviews.llvm.org/D26612
Files:
test/std/strings/basic.string/stri
rogfer01 added a comment.
Hi, friendly ping.
@rsmith any further comment on this?
Thank you very much.
https://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rogfer01 created this revision.
rogfer01 added reviewers: aaron.ballman, rsmith.
rogfer01 added subscribers: cfe-commits, rsmith.
This is a WIP for PR28571.
As suggested by @rsmith it introduces a new ObjectKind for PackedField's
modeled similarly in spirit to BitField's. If the reference is con
rogfer01 added inline comments.
Comment at: lib/Sema/SemaInit.cpp:4202-4204
@@ +4201,5 @@
+
+ It is not possible to bind w to a temporary of a.x because this
+ would require (recursively) invoking the copy constructor of
+ std::vector to obtain first a (properly
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278483: This patch implements PR#22821. (authored by
rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D20561?vs=64114&id=67807#toc
Repository:
rL LLVM
https://reviews.llvm.org/D20561
Fi
Author: rogfer01
Date: Fri Aug 12 03:04:13 2016
New Revision: 278483
URL: http://llvm.org/viewvc/llvm-project?rev=278483&view=rev
Log:
This patch implements PR#22821.
Taking the address of a packed member is dangerous since the reduced
alignment of the pointee is lost. This can lead to memory ali
rogfer01 created this revision.
rogfer01 added a reviewer: rsmith.
rogfer01 added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
RAS extensions are part of ARMv8.2.
This patch enables +ras +noras to AArch64 in clang.
http://reviews.llvm.org/D20283
Files:
lib/Driver/Tools.cpp
rogfer01 updated this revision to Diff 57451.
rogfer01 added a comment.
Update test from mrasext to mras
http://reviews.llvm.org/D20283
Files:
lib/Driver/Tools.cpp
test/Driver/aarch64-ras.c
test/Driver/arm-ras.c
Index: test/Driver/arm-ras.c
===
rogfer01 created this revision.
rogfer01 added a reviewer: rsmith.
rogfer01 added a subscriber: cfe-commits.
This patch implements PR#22821.
Taking the address of a packed member is dangerous since the reduced
alignment of the pointee is lost. This can lead to memory alignment
faults in some arch
rogfer01 added a comment.
I think this has become obsolete as of
http://llvm.org/viewvc/llvm-project?view=revision&revision=270688
http://reviews.llvm.org/D20283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
rogfer01 marked 4 inline comments as done.
Comment at: lib/Sema/SemaExpr.cpp:10527
@@ +10526,3 @@
+ME->getMemberDecl()->hasAttr()) {
+ Diag(OpLoc, diag::warn_taking_address_of_packed_member)
+ << ME->getMemberDecl() << RD;
aaron.ballman wrote
rogfer01 added a comment.
Firefox build has ended and exposes 62 diagnostics, 44 unique ocurrences and 10
different diagnostics (shown below) in networking code.
taking address of packed member 'address' of class or structure
'sctp_state_cookie' may result in an unaligned pointer value
taki
rogfer01 added a comment.
Forget my wrong comment about packed fields that might actually be aligned. It
does not make sense.
Regarding the way to selectively disable this, there is little syntax available
at this point that we can leverage, so I propose to use parentheses as a way to
disable
rogfer01 updated this revision to Diff 58760.
rogfer01 added a comment.
Only warn if the expression is of the form &a.x this way &(a.x) can be used to
silence the warning.
http://reviews.llvm.org/D20561
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/add
rogfer01 reclaimed this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
Well, seems that Renato reverted the changes, so this still holds.
http://reviews.llvm.org/D20283
___
cfe-commits mailing list
cfe-commits@l
rogfer01 added a comment.
Ping?
Thank you very much
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 marked 3 inline comments as done.
Comment at: lib/Sema/SemaExpr.cpp:10527
@@ +10526,3 @@
+if (RD->hasAttr() ||
+ME->getMemberDecl()->hasAttr()) {
+ Diag(OpLoc, diag::warn_taking_address_of_packed_member)
aaron.ballman wrote:
> Ah, I forgo
rogfer01 updated this revision to Diff 59178.
rogfer01 marked an inline comment as done.
rogfer01 added a comment.
Do not warn if the alignment of the type of the field is already 1 as packed
does not have any effect on those fields.
http://reviews.llvm.org/D20561
Files:
include/clang/Basic/
rogfer01 marked an inline comment as done.
rogfer01 added a comment.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
It came to my mind that might be good idea adding one of those "fix-it"
suggestions so the user knows it can silence the warning by using parentheses.
What do you think?
http://reviews.llvm.org/D20561
___
cfe-commits mail
rogfer01 marked 2 inline comments as done.
rogfer01 added a comment.
Well, the assignment-vs-comparison warning does emit a fix-it in
`Sema::DiagnoseAssignmentAsCondition(Expr *E)`
Diag(Loc, diag::note_condition_assign_silence)
<< FixItHint::CreateInsertion(Open, "(")
<< FixItH
rogfer01 added a comment.
I think I wasn't clear with the purpose of the fix-it: there are a few cases
where getting the address of an unaligned pointer is safe (i.e. false
positives).
For instance, when I checked Firefox and Chromium there are cases where getting
the address of an unaligned p
rogfer01 marked 5 inline comments as done.
rogfer01 added a comment.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 updated this revision to Diff 59241.
rogfer01 added a comment.
This change adds a fix-it suggesting parentheses to silence the warning.
http://reviews.llvm.org/D20561
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/address-packed.c
test/SemaCXX
rogfer01 marked 3 inline comments as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5392
@@ -5388,1 +5391,3 @@
+def note_address_of_packed_member_silence : Note<
+ "place parentheses around the '%0' expression to silence this warning">;
aaron.ball
rogfer01 updated this revision to Diff 59342.
rogfer01 marked 3 inline comments as done.
rogfer01 added a comment.
Remove fix-it as it is not suitable for this diagnostic.
http://reviews.llvm.org/D20561
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/addr
rogfer01 marked an inline comment as done.
rogfer01 added a comment.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Ping?
Thanks a lot.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Thank you Aaron. I will commit ASAP.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rogfer01
Date: Mon Jun 13 10:41:40 2016
New Revision: 272552
URL: http://llvm.org/viewvc/llvm-project?rev=272552&view=rev
Log:
Warn when taking address of a packed member
This patch implements PR#22821.
Taking the address of a packed member is dangerous since the reduced
alignment of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272552: Warn when taking address of a packed member
(authored by rogfer01).
Changed prior to commit:
http://reviews.llvm.org/D20561?vs=59342&id=60537#toc
Repository:
rL LLVM
http://reviews.llvm.org/
rogfer01 created this revision.
rogfer01 added a reviewer: rsmith.
rogfer01 added a subscriber: cfe-commits.
This commit extends tbaa.cpp to just make sure that tbaa markers are not
emitted when they should not.
http://reviews.llvm.org/D21295
Files:
test/CodeGen/tbaa.cpp
Index: test/CodeGen/t
rogfer01 added inline comments.
Comment at: test/CodeGen/tbaa.cpp:57
@@ +56,3 @@
+// NO-TBAA-LABEL: define i32 @_Z1g
+// NO-TBAA: store i32 1, i32* %{{.*}}, align 4{{ *$}}
+// NO-TBAA: store i32 4, i32* %{{.*}}, align 4{{ *$}}
jmolloy wrote:
> Would it just be sim
Hi Aaron, Euvgeni,
I'll try to whitelist these functions.
Kind regards,
Roger
-Original Message-
From: Aaron Ballman [mailto:aaron.ball...@gmail.com]
Sent: 14 June 2016 00:30
To: Evgenii Stepanov
Cc: reviews+d20561+public+af1fea8a731d8...@reviews.llvm.org; Roger Ferrer
Ibanez; Richard
Author: rogfer01
Date: Tue Jun 14 06:20:07 2016
New Revision: 272653
URL: http://llvm.org/viewvc/llvm-project?rev=272653&view=rev
Log:
Reverting "Warn when taking address of a packed member"
This new diagnostic is causing some false positives that have to be addressed.
This reverts commit 272552
rogfer01 reopened this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
I've reverted the commit.
During implementation of the white list I felt the changes were too much for a
follow up commit, so I prefer some feedback first.
Repository:
rL LLVM
http://
rogfer01 removed rL LLVM as the repository for this revision.
rogfer01 updated this revision to Diff 60664.
rogfer01 added a comment.
This new patch adds a whitelist for memcpy, memmove, memset and memcmp.
I'm not entirely happy with the strategy that I'm using, where Parser
communicates to Sema
rogfer01 updated this revision to Diff 60667.
rogfer01 added a comment.
Much simpler version thanks to @jmolloy comment.
http://reviews.llvm.org/D21295
Files:
test/CodeGen/tbaa.cpp
Index: test/CodeGen/tbaa.cpp
===
--- test/CodeG
rogfer01 added a comment.
A build of Firefox does not show any false positive now.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 updated the summary for this revision.
rogfer01 updated this revision to Diff 60951.
rogfer01 added a comment.
Thanks @rsmith for the suggestions. I removed the whitelisting totally and
changed the strategy. This patch implements your second suggestion which seemed
more obvious to me. S
rogfer01 added a comment.
Firefox build shows a couple of warnings in the sctp library that already gave
warnings with the earlier patches.
That code has the following structure.
#define SCTP_PACKED __attribute__((packed))
#define SCTP_IDENTIFICATION_SIZE 16
// ...
/* state cookie heade
rogfer01 marked an inline comment as done.
rogfer01 added a comment.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 updated this revision to Diff 61089.
rogfer01 added a comment.
Following @rsmith suggestion, the diagnostic is silenced if the address is
converted to a pointer with lower or equal alignment requirements.
http://reviews.llvm.org/D20561
Files:
include/clang/Basic/DiagnosticSemaKinds.
rogfer01 added a comment.
Ping? Thank you.
http://reviews.llvm.org/D21295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Ping?
Thank you very much.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Ping? Any further comments, thoughts?
Thank you very much.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Ping?
Thank you very much!
http://reviews.llvm.org/D21295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Ping?
Any comment on this?
Thank you very much.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rogfer01
Date: Wed Jul 6 02:13:49 2016
New Revision: 274610
URL: http://llvm.org/viewvc/llvm-project?rev=274610&view=rev
Log:
Add negative test for TBAA
Revision r178818 added tests for TBAA but was missing negative tests to ensure
that TBAA markers are not emitted when TBAA is off.
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274610: Add negative test for TBAA (authored by rogfer01).
Changed prior to commit:
http://reviews.llvm.org/D21295?vs=60667&id=62827#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21295
Files:
c
rogfer01 added a comment.
Ping?
Looking forward any further comments before committing.
Thank you very much.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
rogfer01 added a comment.
If there are not any objections I will commit this tomorrow.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275417: Diagnose taking address and reference binding of
packed members (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D20561?vs=61089&id=63970#toc
Repository:
rL LLVM
htt
Author: rogfer01
Date: Thu Jul 14 09:10:43 2016
New Revision: 275417
URL: http://llvm.org/viewvc/llvm-project?rev=275417&view=rev
Log:
Diagnose taking address and reference binding of packed members
This patch implements PR#22821.
Taking the address of a packed member is dangerous since the redu
Yes I will revert this ASAP.
Sorry for the fuss.
From: Aaron Ballman
Sent: 14 July 2016 19:30:58
To: reviews+d20561+public+af1fea8a731d8...@reviews.llvm.org
Cc: Roger Ferrer Ibanez; Richard Smith; James Y Knight; Evgenii Stepanov;
cfe-commits
Subject: Re: [PATC
Author: rogfer01
Date: Thu Jul 14 15:05:30 2016
New Revision: 275462
URL: http://llvm.org/viewvc/llvm-project?rev=275462&view=rev
Log:
Reverting 275417
This change has triggered unexpected failures.
Removed:
cfe/trunk/test/Sema/address-packed-member-memops.c
cfe/trunk/test/Sema/address-
rogfer01 added a comment.
Reverted.
Repository:
rL LLVM
https://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
builds/5748/steps/compile/logs/stdio
2:
https://cs.chromium.org/chromium/src/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_header.h?sq=package:chromium&dr=C&rcl=1468495044&l=190
On Thu, Jul 14, 2016 at 10:10 AM, Roger Ferrer Ibanez via cfe-commits
mailto:cfe-commits@lists.ll
text could be more explicit
about this.
Should the warning really fire here?
1:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/5748/steps/compile/logs/stdio
2:
https://cs.chromium.org/chromium/src/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_header.h?sq=packag
its@lists.llvm.org>> wrote:
Why did we upgrade the unaligned reference binding from a warning to an error?
That will make it hard to roll this change out across many codebases.
GCC has given an error on this since version 4.7. If there are cases that GCC
accepts and we reject, that sounds li
rogfer01 reopened this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
I suggest that we handle the reference binding diagnostic in another change and
leave this one only for the address taking diagnostic.
Repository:
rL LLVM
https://reviews.llvm.org/D205
rogfer01 added a comment.
In https://reviews.llvm.org/D20561#484421, @jyknight wrote:
> This seems to trigger even for the implicitly generated copier of a packed
> struct. E.g.
>
> #include
>
> void copyit(epoll_event&out, const epoll_event &in) {
> out = in;
> }
>
>
>
> Is that
rogfer01 added a comment.
I've opened https://llvm.org/bugs/show_bug.cgi?id=28571 to track the reference
binding issue.
Repository:
rL LLVM
https://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rogfer01 updated the summary for this revision.
rogfer01 removed rL LLVM as the repository for this revision.
rogfer01 updated this revision to Diff 64114.
rogfer01 added a comment.
Remove the diagnostic for the binding of references.
https://reviews.llvm.org/D20561
Files:
include/clang/Basic
rogfer01 added a comment.
I plan to commit this today. It only diagnoses address-taking of packed fields.
Reference binding to packed fields will be addressed in another change as
proper support may involve codegen changes which are out of the scope of this
work.
Any further comments are welco
rogfer01 added a comment.
> Please wait until someone has had the chance to review before committing (the
> fix does not appear trivial and the original code broke code). I'm on
> vacation today (in theory), but perhaps @rsmith will have a chance to review.
Sure. Thanks.
https://reviews.llvm
101 - 182 of 182 matches
Mail list logo
