[PATCH] D126743: [RISCV][Clang] Add tests for all supported policy functions. (NFC)

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. This is a huge number of test changes so I have checked a subset of files but the changes seems reasonable, as I imagine they're generated mechanically. We seem to be internally consistent

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 added inline comments. Comment at: clang/lib/CodeGen/Targets/RISCV.cpp:178 return false; -if (isEmptyRecord(getContext(), Ty, true)) +if (isEmptyRecord(getContext(), Ty, true, true)) return true; I've observed (based on manually add

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 added a comment. I didn't have libcxx handy but @SixWeining testcase also failed with libstdcxx so I made a slightly smaller standalone testcase based on what libstdcxx does and I manually replaced all the template stuff. typedef decltype((int *)2 - (int *)1) my_ptrdiff_t; struc

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 added a comment. I didn't have libcxx handy but @SixWeining testcase also fails with libstdcxx so I expanded what C++ does and removed the templates. With the new patch this does not fail anymore. typedef decltype((int *)2 - (int *)1) my_ptrdiff_t; struct my_lambda { bool op

[PATCH] D156438: [Docs] Fix code-blocks missing colon

rogfer01 created this revision. Herald added a reviewer: aaron.ballman. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. rogfer01 requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added

[PATCH] D156438: [Docs] Fix code-blocks missing colon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31747668: [Docs] Fix code-blocks missing a colon and a newline (authored by rogfer01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Thanks for the update @asb. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142327/new/ https://reviews.llvm.org/D142327 ___ cfe-c

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added a comment. Hi @jdoerfert, thanks a lot for putting this up this initial skeleton and providing an example with `barrier`. I made a small experiment lowering a `taskwait` (which is even simpler than `barrier` in "lowering" complexity). It was pretty straightforward after all. I h

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added a comment. In D69785#1733233 , @jdoerfert wrote: > In D69785#1732951 , @rogfer01 wrote: > > > I made a small experiment lowering a `taskwait` (which is even simpler than > > `barrier` in "lowering" c

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMPKinds.def:165 + +__OMP_RTL(__kmpc_barrier, false, Void, IdentPtr, Int32) +__OMP_RTL(__kmpc_cancel_barrier, false, Int32, IdentPtr, Int32) As we migrate, we will end with a significant nu

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

rogfer01 created this revision. rogfer01 added reviewers: jdoerfert, kiranchandramohan. Herald added subscribers: llvm-commits, cfe-commits, guansong, hiraditya. Herald added projects: clang, LLVM. rogfer01 added a parent revision: D69922: [OpenMP] Use the OpenMP-IR-Builder. This is similar to D69

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

rogfer01 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMPKinds.def:165 + +__OMP_RTL(__kmpc_barrier, false, Void, IdentPtr, Int32) +__OMP_RTL(__kmpc_cancel_barrier, false, Int32, IdentPtr, Int32) jdoerfert wrote: > rogfer01 wrote: > > As we mig

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

rogfer01 updated this revision to Diff 233524. rogfer01 added a comment. ChangeLog: - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://reviews.llvm.org/D70799 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/taskyield_codegen.cpp llvm/include

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:50 +static bool isExperimentalExtension(StringRef Ext) { + // Currently 'b' is the only supported experimental extension Suggestion: I think we can avoid these two functions

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

rogfer01 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:114 + +// Add some known attributes to the outlined function. +Function *OutlinedFn = Extractor.extractCodeRegion(CEAC); This comment seems misplaced now.

[PATCH] D69828: [OpenMP] Lower taskwait using OpenMP IR Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82f35e17621: [OpenMP] Lower taskwait using OpenMP IR Builder (authored by rogfer01). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

rogfer01 updated this revision to Diff 244611. rogfer01 added a comment. ChangeLog: - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://reviews.llvm.org/D70799 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/taskyield_codegen.cpp llvm/include

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bef1c0e5645: [OpenMP] Lower taskyield using OpenMP IR Builder (authored by rogfer01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://revi

[PATCH] D38362: Mark tests as unsupported in C++98 as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL317210: Mark tests as unsupported in C++98 as well (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D38362?vs=118005&id=121310#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D38362: Mark tests as unsupported in C++98 as well

rogfer01 added a comment. Thank you @mclow.lists ! Repository: rL LLVM https://reviews.llvm.org/D38362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 added a comment. Thanks @eopXD. Not sure why you didn't observe the failure. I understand your build has `-DLLVM_ENABLE_ASSERTIONS=ON`. I investigated a bit the libcxx errors flagged by the precommit CI. I can get similar (but not exactly the same errors) if the build before this chang

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 updated this revision to Diff 532546. rogfer01 added a comment. ChangeLog: - Update clang tests that now, on RISC-V only, observe a larger precompiled module file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 Files: clang/includ

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa45f81ff7ea: [clang][Serialization][RISCV] Increase the number of reserved predefined type… (authored by rogfer01). Repository: rG LLVM Github Mo

[PATCH] D152134: [1/6][Clang][RISCV] Replace unit-stride (fault-first) segment load with tuple type interfaces

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152134/new/ https://reviews.llvm.org/D152134

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152135/new/ https://reviews.llvm.org/D152135

[PATCH] D152136: [3/6][Clang][RISCV] Replace strided segment load with tuple type interfaces

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152136/new/ https://reviews.llvm.org/D152136

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

rogfer01 added a comment. Just to confirm, though: seeing those `COERCE`, I assume the underlying calling convention (which unfortunately it not 100% transparent to `clang` at this point) is the same as passing in order the components of the tuple, right? (Apologies if this was already discusse

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

rogfer01 added a comment. Hi @abel-bernabeu, I did a quick experiment replacing all the calls to `getLexer().Lex()` with `getParser().Lex()` and now your testcase is accepted and looks like this in the output f2: addisp, sp, -32 sd ra, 24(sp) sd s0, 16(sp

[PATCH] D152138: [5/6][Clang][RISCV] Replace indexed segment load with tuple type interfaces

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wangpc. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152138/new/ https://reviews.llvm.org/D1

[PATCH] D152139: [6/6][Clang][RISCV] Replace indexed segment store with tuple type interfaces

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wangpc. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152139/new/ https://reviews.llvm.org/D1

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. Herald added a subscriber: wangpc. In D152070#4421004 , @DavidSpickett wrote: > FYI after this change: > > Building CXX object > tools/lldb/sou...luginTypeSystemClang.dir/TypeSystemClang.cpp.o > > /home/david.spickett/llvm

[PATCH] D152137: [4/6][Clang][RISCV] Replace strided segment store with tuple type interfaces

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wangpc. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152137/new/ https://reviews.llvm.org/D1

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. In D152070#4425358 , @eopXD wrote: > In D152070#4425318 , @rogfer01 > wrote: > >> In D152070#4421004 , >> @DavidSpickett wrote: >> >>> FYI afte

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. >> Can you check if clang crashes for you? > > I am seeing messages related to builtin type, but they do not seem related to > RVV builtin types. > > $ touch t.c > $ clang -cc1 -triple riscv64 -w -emit-pch -o test.pch t.c > $ clang -cc1 -triple riscv64 -w -x c -inc

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 created this revision. rogfer01 added reviewers: eopXD, Eugene.Zelenko, craig.topper. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. rogfe

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. It looks like we need to increase `NUM_PREDEF_TYPE_IDS`. Let's continue the discussion on D153111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152070/new/ https://reviews.llvm.org/D1520

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 added a comment. Let me check if I can add a `static_assert` to get a compile-time failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 ___ cfe-com

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 updated this revision to Diff 532061. rogfer01 added a comment. ChangeLog: - Add a sentinel and a `static_assert` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/lib/Se

[PATCH] D23325: [WIP] Binding of references to packed fields

rogfer01 updated this revision to Diff 81955. rogfer01 added a comment. Rebase to current trunk https://reviews.llvm.org/D23325 Files: include/clang/AST/Decl.h include/clang/AST/Expr.h include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/Specifiers.h

[PATCH] D23325: [WIP] Binding of references to packed fields

rogfer01 updated this revision to Diff 82114. rogfer01 added a comment. Minor issues addressed https://reviews.llvm.org/D23325 Files: include/clang/AST/Decl.h include/clang/AST/Expr.h include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/Specifiers.h

[PATCH] D27614: Mark tests as unsupported under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL291550: Mark tests as unsupported under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27614?vs=80877&id=83782#toc Repository: rL LLVM https://review

[PATCH] D31496: Make -defsym a driver option

rogfer01 added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1882 +TakeNextArg = true; } } else { I wonder if you should `break;` here if validation fails like the original code did? https://reviews.llvm.org/D31496

[PATCH] D31496: Make -defsym a driver option

rogfer01 added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1882 +TakeNextArg = true; } } else { salari01 wrote: > rogfer01 wrote: > > I wonder if you should `break;` here if validation fails like the original > > co

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

rogfer01 created this revision. Under `-fms-extensions` `__unaligned` is a type-qualifier that can be applied to a non-static member function declaration. This causes an assertion when mangling the name under Itanium, where that qualifier is not mangled. This patch justs makes the minimal chan

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

rogfer01 added a comment. `clang::Sema::IsOverload` explicitly forbids the `__restrict` case for the qualifier of non-static member functions. I assume `__unaligned` is not forbidden because the MSVC ABI does encode this qualifier while the Itanium ABI currently does not. This patch just makes

[PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. In https://reviews.llvm.org/D20561#662922, @royger wrote: > Hi, some targets do not support unaligned accesses so this warning is valuable in terms of portability. In platforms where unaligned accesses are allowed, it may happen that such accesses incur in a perform

[PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. In https://reviews.llvm.org/D20561#662963, @royger wrote: > In https://reviews.llvm.org/D20561#662959, @rogfer01 wrote: > > > We fixed all identified false positives in later patches to this one. So > > maybe you want to check against trunk clang. If trunk still diagnos

[PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. In https://reviews.llvm.org/D20561#663069, @joerg wrote: > It is not true that all false positives have been fixed, some of the more > complex cases involving nested data structures are still open. I could not find any in bugzilla after a quick search. So please feel

[PATCH] D34686: [AArch64] Add hasFP16VectorArithmetic helper function. NFCI

rogfer01 added a comment. I agree with the spirit of the change but I think you want to use `AArch64::` enumerators instead of those in `ARM::` Comment at: lib/Basic/Targets.cpp:6190 unsigned HasFullFP16; + unsigned ArchKind; There is an `AArch64::ArchKi

[PATCH] D34686: [AArch64] ARMV8-A archkind and target defines helper functions

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. This LGTM. Thanks for the refactoring and the fix. https://reviews.llvm.org/D34686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D35108: Fix crash parsing invalid code

rogfer01 added a comment. Hi @ogoffart thanks for fixing this. I suggest some minor change for the check, other than that this looks good to me. Comment at: lib/Sema/SemaChecking.cpp:12099 BaseType = BaseType->getPointeeType(); RecordDecl *RD = BaseType->getAs()->

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

rogfer01 created this revision. This patch fixes an assertion that is hit when a redeclaration with differing types only differs in the unaligned type-qualifier. https://reviews.llvm.org/D29986 Files: lib/AST/ASTContext.cpp test/Sema/unaligned-qualifier.c Index: test/Sema/unaligned-quali

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

rogfer01 created this revision. See related proposal in http://lists.llvm.org/pipermail/cfe-dev/2017-February/052739.html This patch honors the unaligned type qualifier (currently available through he keyword __unaligned and -fms-extensions) in CodeGen. In the current form the patch affects de

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

rogfer01 updated this revision to Diff 89172. rogfer01 marked 2 inline comments as done. rogfer01 added a comment. Updated patch. Use TargetInfo::getCharWidth and remove unnecessary else. https://reviews.llvm.org/D30166 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/AST/

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

rogfer01 added a comment. Ping? https://reviews.llvm.org/D29986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

rogfer01 added a comment. Sorry for the noise. I was expecting some more formal approval in the usual form of "Ready to land" but if you think it is OK I will commit it shortly. Regards. https://reviews.llvm.org/D29986 ___ cfe-commits mailing list

[PATCH] D29986: Fix crash when an incorrect redeclaration only differs in __unaligned type-qualifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL296099: Fix crash when an incorrect redeclaration only differs in __unaligned type… (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D29986?vs=88514&id=89617#toc Repository:

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

rogfer01 added inline comments. Comment at: lib/Driver/Tools.cpp:5940 + options::OPT_fno_always_use_bss, false)) +CmdArgs.push_back("-always-use-bss"); + I think you mean `"-falways-use-bss"`. Please add a test that checks that the driver i

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

rogfer01 added a comment. Ping? :-) Kind regards https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

rogfer01 updated this revision to Diff 89989. rogfer01 added a comment. Avoid altering results of TypeInfo due to the __unaligned qualifier. Instead override the natural alignment to 1 if the type is __unaligned-qualified. https://reviews.llvm.org/D30166 Files: lib/AST/ASTContext.cpp lib/A

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

rogfer01 added a comment. Thanks @javed.absar This LGTM now. https://reviews.llvm.org/D30326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

rogfer01 added a comment. Ping? :-) Kind regards https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL297276: Honor __unaligned in codegen for declarations and expressions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D30166?vs=89989&id=91005#toc Repository: rL LLVM https

[PATCH] D30884: When diagnosing taking address of packed members skip __unaligned-qualified expressions

rogfer01 created this revision. Given that we have already explicitly stated in the qualifier that the expression is `__unaligned`, it makes little sense to diagnose that the address of the packed member may not be aligned. https://reviews.llvm.org/D30884 Files: lib/Sema/SemaChecking.cpp

[PATCH] D30884: When diagnosing taking address of packed members skip __unaligned-qualified expressions

rogfer01 added a comment. Thanks for the review @aaron.ballman! https://reviews.llvm.org/D30884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30884: When diagnosing taking address of packed members skip __unaligned-qualified expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rL297620: When diagnosing taking address of packed members skip __unaligned-qualified… (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D30884?vs=91531&id=91548#toc Repository:

[PATCH] D30898: Add new -fverbose-asm that enables source interleaving

rogfer01 created this revision. This is the clang side of the RFC in http://lists.llvm.org/pipermail/cfe-dev/2017-February/052549.html Note that in contrast to the original suggestion `-fsource-asm` here we use the preferred `-fverbose-asm`. Basically explicitly saying `-fverbose-asm` in the c

[PATCH] D30898: Add new -fverbose-asm that enables source interleaving

rogfer01 added a comment. > A somewhat obvious comment: no chance for this to be accepted without LIT > tests. I understand you have your doubts on the best approach to testing -- > and it's OK to ask either here or on llvm-dev -- but tests should be added > nevertheless. Sure. I wasn't planni

[PATCH] D26611: Protect test for dynarray under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288155: Protect test for dynarray under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D26611?vs=77809&id=79580#toc Repository: rL LLVM https://review

[PATCH] D27093: Protect std::{, unordered_}map tests under noexceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288157: Protect std::{,unordered_}map tests under noexceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27093?vs=79212&id=79582#toc Repository: rL LLVM https://revi

[PATCH] D27096: Protect locale tests under noexceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288156: Protect locale tests under noexceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27096?vs=79219&id=79581#toc Repository: rL LLVM https://reviews.llvm.org/D2

[PATCH] D26612: Protect std::string tests under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288158: Protect std::string tests under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D26612?vs=78012&id=79583#toc Repository: rL LLVM https://review

[PATCH] D27095: Protect std::array tests under noexceptions

rogfer01 updated this revision to Diff 79589. rogfer01 added a comment. Add missing assertions in the original test. https://reviews.llvm.org/D27095 Files: test/std/containers/sequences/array/at.pass.cpp Index: test/std/containers/sequences/array/at.pass.cpp

[PATCH] D27095: Protect std::array tests under noexceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288165: Protect std::array tests under noexceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27095?vs=79589&id=79591#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D27252: Protect sequences test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Replace throw with TEST_THROW and protect tests that do throw. Also add missing assert(false). https://reviews.llvm.org/D27252 Files: test/std/containers/sequen

[PATCH] D27253: Protect futures test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip tests that expect an exception be thrown. https://reviews.llvm.org/D27253 Files: test/std/thread/futures/futures.promise/move_assign.pass.cpp Index: test/s

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Replace throw with TEST_THROW and skip tests that throw exceptions https://reviews.llvm.org/D27254 Files: test/std/experimental/optional/optional.specalg/swap.pas

[PATCH] D27255: Protect std::ostream::sentry test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip test that throws an exception. https://reviews.llvm.org/D27255 Files: test/std/input.output/iostream.format/output.streams/ostream_sentry/destruct.pass.cpp

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

rogfer01 added inline comments. Comment at: test/std/experimental/optional/optional.specalg/swap.pass.cpp:225 } +#ifndef TEST_HAS_NO_EXCEPTIONS { mclow.lists wrote: > Why is this here, and not before line L#236? Yep, I'm wrong here. Probably a fallout o

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

rogfer01 updated this revision to Diff 79765. rogfer01 added a comment. Protect the right set of tests. https://reviews.llvm.org/D27254 Files: test/std/experimental/optional/optional.specalg/swap.pass.cpp Index: test/std/experimental/optional/optional.specalg/swap.pass.cpp =

[PATCH] D27255: Protect std::ostream::sentry test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288378: Protect std::ostream::sentry test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27255?vs=79720&id=79931#toc Repository: rL LLVM https:

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288379: Protect optional test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27254?vs=79765&id=79932#toc Repository: rL LLVM https://reviews.ll

[PATCH] D27253: Protect futures test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288382: Protect futures test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27253?vs=79718&id=79933#toc Repository: rL LLVM https://reviews.llv

[PATCH] D27252: Protect sequences test under libcpp-no-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL288383: Protect sequences test under libcpp-no-exceptions (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27252?vs=79717&id=79934#toc Repository: rL LLVM https://reviews.l

[PATCH] D27310: Handle tests for noexcept that expect a false value

rogfer01 created this revision. rogfer01 added reviewers: EricWF, mclow.lists, rmaprath. rogfer01 added a subscriber: cfe-commits. Under libcpp-no-exceptions, noexcept is trivially true. Some tests expect in the usual setting to return false. Wrap these tests in a convenience macro. https://rev

[PATCH] D23325: [WIP] Binding of references to packed fields

rogfer01 updated this revision to Diff 80081. rogfer01 added a comment. Drop attribute packed of a class when one of its fields is a non-packed non-pod for compatibility with GCC. https://reviews.llvm.org/D23325 Files: include/clang/AST/Decl.h include/clang/AST/Expr.h include/clang/AST/S

[PATCH] D27310: Handle tests for noexcept that expect a false value

rogfer01 updated this revision to Diff 80235. rogfer01 added a comment. - Rewrite the adjusted tests in the way suggested by @EricWF - Also check that this test works in a GCC-built libcxx https://reviews.llvm.org/D27310 Files: test/libcxx/strings/iterators.exceptions.pass.cpp Index: test/l

[PATCH] D27310: Handle tests for noexcept that expect a false value

rogfer01 added inline comments. Comment at: test/libcxx/strings/iterators.exceptions.pass.cpp:29 +#ifndef TEST_HAS_NO_EXCEPTIONS +constexpr bool expected = false; +#else EricWF wrote: > We can't use constexpr because these tests run in C++03. However `const bool

[PATCH] D27310: Handle tests for noexcept that expect a false value

rogfer01 updated this revision to Diff 80238. rogfer01 added a comment. Do not use constexpr. https://reviews.llvm.org/D27310 Files: test/libcxx/strings/iterators.exceptions.pass.cpp Index: test/libcxx/strings/iterators.exceptions.pass.cpp ===

[PATCH] D27310: Handle tests for noexcept that expect a false value

This revision was automatically updated to reflect the committed changes. Closed by commit rL288660: Handle tests for noexcept that expect a false value (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D27310?vs=80238&id=80242#toc Repository: rL LLVM https://reviews

[PATCH] D27614: Mark tests as unsupported under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: EricWF, mclow.lists, rmaprath. rogfer01 added a subscriber: cfe-commits. The destructor of std::promise needs to construct a std::future_error exception so it calls std::make_exception_ptr. But under libcpp-no-exceptions this will trigger a

[PATCH] D27614: Mark tests as unsupported under libcpp-no-exceptions

rogfer01 added a comment. Ping? :) https://reviews.llvm.org/D27614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

This revision was automatically updated to reflect the committed changes. Closed by commit rL300686: Avoid assert when a non-static member function is qualified with __unaligned (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D31976?vs=94962&id=95723#toc Repository:

[PATCH] D31814: Add option to add command-line options and version info to output file

rogfer01 added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:4222 + std::string line; + while (std::getline(iss, s, ';')) { +if ((s.length() + line.length()) < 80) { I wonder if this also works if the original compiler invokation included a ";"

[PATCH] D33398: Remove __unaligned preventively when mangling types in Itanium ABI

rogfer01 created this revision. `__unaligned` is not currently mangled in any way and as such is not a relevant qualifier for substitutions. This may cause that, when it is the only qualifier, the substitution is added twice which triggers an assertion. The simplest thing to do is to remove the

[PATCH] D33398: Remove __unaligned preventively when mangling types in Itanium ABI

rogfer01 added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2329-2333 + // __unaligned is not currently mangled in any way. This implies that it is + // not a relevant qualifier for substitutions (while CVR and maybe others + // are). This triggers an assertion when

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 updated this revision to Diff 99876. rogfer01 retitled this revision from "Remove __unaligned preventively when mangling types in Itanium ABI" to "Mangle __unaligned in Itanium ABI". rogfer01 edited the summary of this revision. rogfer01 added a reviewer: majnemer. rogfer01 added a commen

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Thans @khchen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117989/new/ https://reviews.llvm.org/D117989 _

[PATCH] D120227: [RISCV] Add policy operand for masked vid and viota IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120227/new/ https://reviews.llvm.org/D120227 _

[PATCH] D120228: [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120228/new/ https://reviews.llvm.org/D120228 _

<    1   2   3   >