[PATCH] D38362: Mark test as unsupported in C++98 as well

rogfer01 created this revision. https://reviews.llvm.org/D38362 Files: test/std/re/re.alg/re.alg.match/exponential.pass.cpp Index: test/std/re/re.alg/re.alg.match/exponential.pass.cpp === --- test/std/re/re.alg/re.alg.match/expon

[PATCH] D38452: Mark test as a long-test

rogfer01 created this revision. This test creates a string of 2GiB which may make it too slow to run in a simulator. https://reviews.llvm.org/D38452 Files: test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump2gig.pass.cpp Index: test/std/input.outpu

[PATCH] D38628: Remove unneeded typename from test

rogfer01 created this revision. https://reviews.llvm.org/D38628 Files: test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp Index: test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp === --- test/

[PATCH] D38362: Mark tests as unsupported in C++98 as well

rogfer01 updated this revision to Diff 118005. rogfer01 retitled this revision from "Mark test as unsupported in C++98 as well" to "Mark tests as unsupported in C++98 as well". rogfer01 added a comment. ChangeLog: - I wanted to mark two tests but forgot to add one in the previous change https:

[PATCH] D38628: Remove unneeded typename from test

rogfer01 updated this revision to Diff 118183. rogfer01 added a comment. - Remove another instance of this issue https://reviews.llvm.org/D38628 Files: test/std/utilities/utility/pairs/pair.astuple/tuple_element.fail.cpp test/std/utilities/variant/variant.helpers/variant_alternative.fail.cp

[PATCH] D38628: Remove unneeded typename from test

rogfer01 added a comment. Thanks @chill , @mclow.lists and @EricWF ! https://reviews.llvm.org/D38628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38628: Remove unneeded typename from test

This revision was automatically updated to reflect the committed changes. Closed by commit rL315278: Remove unneeded typename from test (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D38628?vs=118183&id=118321#toc Repository: rL LLVM https://reviews.llvm.org/D3862

[PATCH] D38452: Mark test as a long-test

rogfer01 added a comment. Friendly ping :) https://reviews.llvm.org/D38452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38452: Mark test as a long-test

This revision was automatically updated to reflect the committed changes. Closed by commit rL315570: Mark test as a long-test (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D38452?vs=117317&id=118753#toc Repository: rL LLVM https://reviews.llvm.org/D38452 Files:

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

rogfer01 added a comment. Thanks for reopening this @kristina. I suggest passing `--sysroot=` to make sure we see the expected behaviour when the sysroot is actually empty. Note that this would not really test the scenario where `DEFAULT_SYSROOT` is empty **and** no `--sysroot` appears in the

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

rogfer01 added a comment. Hi @kristina . Sure, I didn't mean to do that broader change here. Apologies if it read that way. Would it be acceptable to add an empty `--sysroot=` to the test? I can post the change for review in another diff. Thanks a lot. Repository: rC Clang https://review

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 created this revision. rogfer01 added reviewers: lewis-revill, asb, simoncook, kristina. Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, apazos, johnrusso, rbar. In https://reviews

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 added a comment. Thanks for the review! https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 added a comment. I can commit it. https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

rogfer01 added a comment. Thanks I will do it shortly. https://reviews.llvm.org/D51972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51972: [RISCV] Explicitly set an empty --sysroot in the test

This revision was automatically updated to reflect the committed changes. Closed by commit rC342060: [RISCV] Explicitly set an empty --sysroot in the test (authored by rogfer01, committed by ). Herald added a subscriber: jrtc27. Repository: rC Clang https://reviews.llvm.org/D51972 Files: te

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

rogfer01 added a comment. I understand you're fixing the narrowing check from "unscoped enum/integer type" → float. But you have also extended some tests which are "unscoped enum" → integer type (lines 153, 170 and 173). So I presume they were already handled correctly before your patch. Can t

[PATCH] D42969: [Sema] Fix decltype of static data members

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. This LGTM. Thanks for fixing this. Wait a couple of days before committing in case there are other comments. https://reviews.llvm.org/D42969 ___

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Looks good to me now. Wait a couple of days before submitting it just in case the other reviewers have more comments. Do you plan to submit (in another change) the unscoped enum → integer

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 updated this revision to Diff 100670. rogfer01 added a comment. Thanks @aaron.ballman for the review. I have extended the test with your suggestions. https://reviews.llvm.org/D33398 Files: lib/AST/ItaniumMangle.cpp test/CodeGenCXX/pr33080.cpp test/CodeGenCXX/unaligned-duplicated

[PATCH] D33412: Add support for #pragma clang section

rogfer01 added a comment. This clang change looks sensible to me. Can you add documentation in `LanguageExtensions.rst` describing this new pragma and its semantics? Thanks! https://reviews.llvm.org/D33412 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. I wonder what should we do in C99 for cases like void foo(void) { { extern void g(int(*a)[call_to_undeclared()]); int (*p_ok)() = call_to_undeclared; } int (*p_err)() = call_to_undeclared; } I understand that the scope `S` in this case

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. I think what happens is that the implicit declaration is done in the prototype scope which is not visible later. Doing the same as GCC in the handling of this extension is probably the best: note that in C90 a function call should not happen inside an array expression

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 added inline comments. Comment at: include/clang-c/Index.h:3015 CXType_Half = 31, + CXType_Float16 = 30, CXType_FirstBuiltin = CXType_Void, This enumerator is the same as `CXType_Float128` above, is that intended? https://reviews.llvm.org/D33719

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 updated this revision to Diff 100868. rogfer01 added a comment. Fix formatting of tests. Thanks for the review @aaron.ballman ! https://reviews.llvm.org/D33398 Files: lib/AST/ItaniumMangle.cpp test/CodeGenCXX/pr33080.cpp test/CodeGenCXX/unaligned-duplicated-mangle-name.cpp tes

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 updated this revision to Diff 100974. rogfer01 added a comment. Changelog: - Fix formatting. - Emit `__unaligned` in the right order (as defined by the Itanium ABI) when there are Objective-C++ ARC vendor qualifiers. - New test for `__unaligned` and ARC's `__weak`, `__strong` and `__aut

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2210 + if (Quals.hasUnaligned()) + mangleVendorQualifier("__unaligned"); + rsmith wrote: > Too much indentation here. Also, the ABI requires the "unordered" vendor > qualifiers to be emi

[PATCH] D33412: Add support for #pragma clang section

rogfer01 added a comment. After the docs update this looks good to me. @rnk @jroelofs what do you think? Thanks! https://reviews.llvm.org/D33412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D33398: Mangle __unaligned in Itanium ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL304523: Mangle __unaligned in Itanium ABI (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D33398?vs=100974&id=101171#toc Repository: rL LLVM https://reviews.llvm.org/D33398

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. Given that we are already considering extensions, maybe you want to add a test for compound statements in expressions. void foo(void) { ({ bar(); }); int (*p)() = bar; /* expected-error {{use of undeclared identifier 'bar'}} */ } This already works with

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 added inline comments. Comment at: include/clang/AST/Type.h:1669 bool isHalfType() const; // OpenCL 6.1.1.1, NEON (IEEE 754-2008 half) + bool isFloat16Type() const; // FIXME bool isRealType() const; // C99 6.2.5p17 (real floating + integer) --

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. Thanks Momchil, this looks sensible to me. What do you think @aaron.ballman @rsmith ? https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D43572: [Sema] Improve test coverage of narrowing conversion diagnostics

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks! https://reviews.llvm.org/D43572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 created this revision. rogfer01 added a reviewer: asb. Herald added subscribers: mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. We were calculating twice ilp32/lp64. Do this just in one place instead. https://reviews.llvm.org/

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:381 + // FIXME: currently defaults to the soft-float ABIs. Will need to be + // expanded to select ilp32f, ilp32d, lp64f, lp64d when appropriate. When 64-bit is upstreamed and `l

[PATCH] D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand

rogfer01 abandoned this revision. rogfer01 added a comment. Upstream recently amended the ABI spec so it looks to me this is not going to be needed. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D59298: [RISCV] Pass -target-abi to -cc1as

rogfer01 created this revision. rogfer01 added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Herald added a project: clang

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Herald added subscribers: jocewei, PkmX, rkruppe. @asb in D59298 I call `riscv::getRISCVABI` for `ClangAs`, does it make sense to make the same change for `Clang` here? Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D59298: [RISCV] Pass -target-abi to -cc1as

rogfer01 added a comment. Thanks Alex. I will commit it shortly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59298/new/ https://reviews.llvm.org/D59298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D59298: [RISCV] Pass -target-abi to -cc1as

This revision was automatically updated to reflect the committed changes. Closed by commit rL356981: [RISCV] Pass -target-abi to -cc1as (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D57450: [RISCV] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for RV32/RV64 targets with atomics

rogfer01 added a comment. Looks sensible to me. I'm just curious why we want to prevent emission of atomic LLVM instructions at this point. Won't LLVM's AtomicExpand perform a similar lowering already? Perhaps the goal is to save that pass some work? Repository: rC Clang CHANGES SINCE LAST

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 added a comment. There are a few tests checking the precise interaction between `__fp16` and `_Float16` values but I don't see tests interacting `_Float16` and the other standard floating types `float`, `double` and `long double`. Do you reckon it is worth adding them as well? =

[PATCH] D33719: Add _Float16 as a C/C++ source language type

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Thanks @SjoerdMeijer This LGTM now. Wait a couple of days in case @rsmith has more comments. https://reviews.llvm.org/D33719 ___ cfe-commits

[PATCH] D34695: _Float16 preprocessor macro definitions

rogfer01 added inline comments. Comment at: lib/Headers/float.h:137 +#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__ +# define FLT16_MANT_DIG __FLT16_MANT_DIG__ My understanding is that, given that we support TS18661-2 by default, this macro should be predefined by

[PATCH] D34695: _Float16 preprocessor macro definitions

rogfer01 added inline comments. Comment at: lib/Headers/float.h:137 +#ifdef __STDC_WANT_IEC_60559_TYPES_EXT__ +# define FLT16_MANT_DIG __FLT16_MANT_DIG__ scanon wrote: > rogfer01 wrote: > > My understanding is that, given that we support TS18661-2 by default,

[PATCH] D34695: _Float16 preprocessor macro definitions

rogfer01 accepted this revision. rogfer01 added a subscriber: rsmith. rogfer01 added a comment. This revision is now accepted and ready to land. This LGTM, but wait a couple of days before comitting in case @rsmith or @scanon (or others!) have further comments. https://reviews.llvm.org/D34695

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Hi @lenary, sure I can rebase this. However, I think it may be better to do the `lp64d` change in another phab so we can keep this one NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 updated this revision to Diff 212970. rogfer01 added a comment. ChangeLog - Rebase change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/lib/Driver/ToolChains/Clang.cpp Ind

[PATCH] D65635: Sidestep false positive due to a matching git repository name

rogfer01 created this revision. rogfer01 added reviewers: eli.friedman, ddunbar. Herald added a project: clang. Herald added a subscriber: cfe-commits. rogfer01 edited reviewers, added: efriedma; removed: eli.friedman. I have failures in this test because the `grep @b` gets confused by the `clang

[PATCH] D65634: [RISCV] Default to lp64d in 64-bit RISC-V Linux

rogfer01 created this revision. rogfer01 added reviewers: asb, lenary. Herald added subscribers: cfe-commits, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook,

[PATCH] D65635: Sidestep false positive due to a matching git repository name

rogfer01 added a comment. Thanks @efriedma. I will commit this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65635/new/ https://reviews.llvm.org/D65635 ___ cfe-commits mailing list cfe-commits

[PATCH] D65635: Sidestep false positive due to a matching git repository name

This revision was automatically updated to reflect the committed changes. Closed by commit rL367826: Sidestep false positive due to a matching git repository name (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Thanks @lenary ! I will commit this shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48357/new/ https://reviews.llvm.org/D48357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL368128: [RISCV] Remove duplicated logic when determining the target ABI (authored by rogfer01, committed by ). Herald added subscribers: llvm-commits, jrtc27. Herald added a project: LLVM. Changed prior t

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks @asb @lenary for the review! I understand that, after this change, we will also want to make `-march=rv{32,64}gc` the default in Linux as well. Otherwise there will be an ABI mismatch with the default `-march=rv{32.64}i` in a default invocation. Does this make

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 updated this revision to Diff 213812. rogfer01 retitled this revision from "[RISCV] Default to lp64d in 64-bit RISC-V Linux" to "[RISCV] Default to ilp32d/lp64d in RISC-V Linux". rogfer01 edited the summary of this revision. rogfer01 added a comment. ChangeLog: - Make `ilp32d` also the

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks for the clarification @asb. I've posted D66003 (depending on D66002 ) for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65634/new/ https://reviews.llvm.org/D65634 _

[PATCH] D66002: [RISCV] Move architecture parsing code into its own function

rogfer01 created this revision. rogfer01 added reviewers: asb, lenary. Herald added subscribers: cfe-commits, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook,

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

rogfer01 created this revision. rogfer01 added reviewers: asb, lenary. Herald added subscribers: cfe-commits, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook,

[PATCH] D60456: [RISCV] Hard float ABI support

rogfer01 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9352 +return false; + // As a quirk of the ABI, zero-width bitfields aren't ignored for fp+fp + // or int+fp structs, but are ignored for a struct with an fp field and

[PATCH] D60456: [RISCV] Hard float ABI support

rogfer01 added a comment. > As noted in another comment, it's not entirely clear what zero-width bitfield > behaviour to match (see here > ) > as GCC seems buggy and the ABI is under-specified. Ideally I'd like to la

[PATCH] D66002: [RISCV] Move architecture parsing code into its own function

rogfer01 added a comment. Herald added a subscriber: pzheng. Thanks for the review @luismarques I plan to commit this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66002/new/ https://reviews.llvm.org/D66002

[PATCH] D66002: [RISCV] Move architecture parsing code into its own function

This revision was automatically updated to reflect the committed changes. Closed by commit rL371492: [RISCV] Move architecture parsing code into its own function (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

rogfer01 added a comment. Thanks for the review @lenary @luismarques We can indeed look at what defaults we want for baremetal in a later change. I plan to commit this shortly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65634/new/ https://reviews.llvm.org/D65634

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

rogfer01 added a comment. Herald added a subscriber: pzheng. Thanks for the review @luismarques I plan to commit this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66003/new/ https://reviews.llvm.org/D66003

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL371494: [RISCV] Default to ilp32d/lp64d in RISC-V Linux (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D66003: [RISCV] Make -march=rv{32, 64}gc the default in RISC-V Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL371496: [RISCV] Make -march=rv{32,64}gc the default in RISC-V Linux (authored by rogfer01, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

rogfer01 added a comment. There is a flag `-fno-ident` that has the same effect in GCC https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fno-ident although it involves also ignoring the `#ident`. A quick look seems to suggest that #ident is just ignored in the usual PP callbacks u

[PATCH] D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand

rogfer01 added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:475 +static_assert(std::is_trivially_copyable::value, +"ABIArgInfo must be trivially copyable as it is embedded as trailing " I think this is the right trait here. I spent to

[PATCH] D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand

rogfer01 created this revision. rogfer01 added a reviewer: rjmccall. This is WIP and it is motivated by the suggestions in http://lists.llvm.org/pipermail/cfe-dev/2018-June/058263.html First attempt, piggybacking the extend information in a structure where the bit-width of the integer represent

[PATCH] D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand

rogfer01 added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:90 union { -unsigned DirectOffset; // isDirect() || isExtend() -unsigned IndirectAlign;// isIndirect() -unsigned AllocaFieldIndex; // isInAlloca() +llvm::StructType *Exte

[PATCH] D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand

rogfer01 updated this revision to Diff 153070. rogfer01 added a comment. ChangeLog: - Use a `ConstantDataArray` instead of a struct of types. - Use `LLVM_IS_TRIVIALLY_COPYABLE` https://reviews.llvm.org/D48589 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp Index: lib

[PATCH] D48589: [WIP] [CodeGen] Allow specifying Extend to CoerceAndExpand

rogfer01 added a comment. @rjmccall because we do not want to impact the clients of `ABIArgInfo` I thought of two possible approaches 1. extend `CGFunctionInfo` with a third trailing array (now it has two), with as many elements as `ABIArgInfo` (call it `ABIArgExtraInfo`) then during the creat

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Herald added subscribers: the_o, brucehoult, MartinMosbeck. Ping? https://reviews.llvm.org/D48357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20561: Warn when taking address of packed member

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7b9f3149b76: Add missing tests (authored by rogfer01). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D20561?vs=67807&id=223564#toc Repository: rG LLVM Github Monore

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || `llvm::StringSwitch` has a method `StartsWithLower` which might help make the

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || lenary wrote: > rogfer01 wrote: > > `llvm::StringSwitch` has a method `Starts

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

rogfer01 added a comment. @HsiangKai: just to confirm and to avoid confusion for other reviewers. > Assemble/disassemble RISC-V V extension instructions according to version > 0.8-draft-20191004 in https://github.com/riscv/riscv-v-spec/. Is the patch against the spec published in https://githu

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

rogfer01 added a comment. The patch as it stands now LGTM and I think it can be committed. Is there any objection remaining? Any further comments @simoncook @asb? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69987/new/ https://reviews.llvm.org/D

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

rogfer01 added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:796 } return ""; } Minor nit that we missed in the patch of 0.8: can you replace this return with ```lang=cpp llvm_unreachable(); ``` as recommended in t

[PATCH] D40895: Ignore pointers to incomplete types when diagnosing misaligned addresses

rogfer01 created this revision. This is a fix for PR35509 in which we crash because we attempt to compute the alignment of an incomplete type. https://reviews.llvm.org/D40895 Files: lib/Sema/SemaChecking.cpp test/SemaCXX/address-packed.cpp Index: test/SemaCXX/address-packed.cpp =

[PATCH] D40895: Ignore pointers to incomplete types when diagnosing misaligned addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rL320017: Ignore pointers to incomplete types when diagnosing misaligned addresses (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D40895?vs=125718&id=125901#toc Repository: r

[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

rogfer01 added inline comments. Comment at: lib/Parse/ParseTemplate.cpp:702 +ReportStorageClass(DS.getStorageClassSpecLoc()); + if (DS.getThreadStorageClassSpec() != DeclSpec::TSCS_unspecified) +ReportStorageClass(DS.getThreadStorageClassSpecLoc()); You

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

rogfer01 added a comment. Hi @miyuki I can commit it. https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

This revision was automatically updated to reflect the committed changes. Closed by commit rL320363: [libcxx] Define istream_iterator equality comparison operators out-of-line (authored by rogfer01). Changed prior to commit: https://reviews.llvm.org/D40415?vs=124155&id=126349#toc Repository:

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

rogfer01 added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7021 + // C++ [temp]p6: + // A template, a template explicit specialization, and a class template + // partial specialization shall not have C linkage. Can you add a test for a partial s

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

rogfer01 added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7021 + // C++ [temp]p6: + // A template, a template explicit specialization, and a class template + // partial specialization shall not have C linkage. miyuki wrote: > rogfer01 wrote: >

[PATCH] D106044: [RISCV] Update to vcpop.m, vlm.v and vsm.v according to v1.0-rc1.

rogfer01 added a comment. I'm confused because the PDF at https://github.com/riscv/riscv-v-spec/releases/tag/v1.0-rc1 doesn't seem to describe `vcpop.m`. I can see this has changed in the ToT https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#changes-from-v1-0-rc1 Perhaps this wi

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

rogfer01 added inline comments. Comment at: clang/test/Driver/riscv-default-features.c:4 +// RV32: "target-features"="+a,+c,+m,+relax,-save-restore" +// RV64: "target-features"="+64bit,+a,+c,+m,+relax,-save-restore" + I think we may be missing are missing a `RUN`

[PATCH] D119688: [RISCV] Add the passthru operand for vmv.vv/vmv.vx/vfmv.vf IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119688/new/ https://reviews.llvm.org/D119688 _

[PATCH] D119686: [RISCV] Add the passthru operand for nomask vadc/vsbc/vmerge/vfmerge IR intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119686/new/ https://reviews.llvm.org/D119686 __

[PATCH] D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124186/new/ https://reviews.llvm.org/D124186 _

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

rogfer01 added a comment. Do you think you can split `vlseg` and `vlseg_ff` tests in two different files? So we (potentially) reduce the test latency by half in multicore systems. Other than this, LGTM. We're a bit split in https://github.com/riscv/rvv-intrinsic-doc/issues/95 However there are

[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

rogfer01 created this revision. rogfer01 added a reviewer: ABataev. Herald added subscribers: guansong, yaxunl. rogfer01 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. We were using an `OpaqueVa

[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

rogfer01 added a comment. Thanks for the prompt review @ABataev! I'll push this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107666/new/ https://reviews.llvm.org/D107666 ___ cfe-commits mailing

[PATCH] D107666: [OpenMP] Fix accidental reuse of VLA size

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb77364d0be: [OpenMP] Fix accidental reuse of VLA size (authored by rogfer01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107666/new/ https://reviews.ll

[PATCH] D112398: [RISCV] Add ABI testing for Float16.

rogfer01 added a comment. I'm curious about how we handle `_Float16` here. My understanding from the psabi and the Zfh draft

[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

rogfer01 added a comment. Overall LGTM. Thanks @khchen! Comment at: clang/include/clang/Basic/riscv_vector.td:175 + // builtin to C/C++. It is parameter of the unmasked version without VL + // operand. + list PermuteOperands = []; Not sure if we want to clar

[PATCH] D126740: [RISCV][Clang] Refactor and rename rvv intrinsic related stuff. (NFC)

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! (I was a bit confused by the refactoring of `computeBuiltinTypes` but it is definitely better this way) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D126741: [RISCV][Clang] Refactor RISCVVEmitter. (NFC)

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. LGTM. Thanks @khchen ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126741/new/ https://reviews.llvm.org/D126741 _

  1   2   3   >