rsmith closed this revision.
rsmith added a comment.
Committed as r267444.
I refactored it to use `CXXRecordDecl::forallBases` instead of a hand-rolled
traversal of the base classes in r267453.
http://reviews.llvm.org/D18868
___
cfe-commits mailin
Author: rsmith
Date: Mon Apr 25 14:30:37 2016
New Revision: 267454
URL: http://llvm.org/viewvc/llvm-project?rev=267454&view=rev
Log:
Implement support for conditional between xvalues of reference-compatible
types. Patch by Erik Pilkington!
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
cfe/
rsmith closed this revision.
rsmith added a comment.
Committed as r267454.
http://reviews.llvm.org/D17451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Apr 25, 2016 at 1:04 PM, Reid Kleckner wrote:
> On Fri, Apr 22, 2016 at 1:58 PM, Richard Smith
> wrote:
>>
>> This seems like a fragile thing to rely on. What about template
>> instantiation performed at end of TU? (I /think/ that case is currently
>> fine because all the kinds of templa
On Mon, Apr 25, 2016 at 1:52 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: adrian
> Date: Mon Apr 25 15:52:40 2016
> New Revision: 267464
>
> URL: http://llvm.org/viewvc/llvm-project?rev=267464&view=rev
> Log:
> Module Debugging: Fix the condition for determining
rsmith added inline comments.
Comment at: include/clang/AST/ExprCXX.h:2871-2872
@@ -2870,1 +2870,4 @@
+ // When false, it must not have side effects.
+ bool CleanupsHaveSideEffects;
+
You may as well put this in the bitfield storage on `Stmt`.
===
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:5636-5639
@@ -5634,4 +5635,6 @@
- Expr *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups);
+ auto *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups);
+ if (Cleanup.cleanupsHaveSideEffects())
+
rsmith added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2282
@@ -2281,3 +2281,3 @@
// Otherwise, if we don't consume this token, we are going to emit an
// error anyway. Try to recover from various common problems. Check
Maybe put the check her
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:1536-1537
@@ -1535,3 +1535,4 @@
/// other template arguments.
ParsedType ActOnDelayedDefaultTemplateArg(const IdentifierInfo &II,
SourceLocation NameLoc);
+ Pars
Author: rsmith
Date: Mon May 23 15:03:04 2016
New Revision: 270482
URL: http://llvm.org/viewvc/llvm-project?rev=270482&view=rev
Log:
Fix filtering of prior declarations when checking for a tag redeclaration to
map to the redecl context for both decls, not just one of them, and to properly
check th
rsmith added a comment.
It sounds like we're failing to properly inherit default template arguments
onto redeclarations generated by template instantiation, resulting in a
violation of our AST invariants. This patch will hide the problem in some
cases, but the right thing to do is to fix the ro
Author: rsmith
Date: Mon May 23 19:01:49 2016
New Revision: 270514
URL: http://llvm.org/viewvc/llvm-project?rev=270514&view=rev
Log:
Properly track the found declaration (possibly a using-declaration) when
handling an explicit member specialization.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.c
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:1534
@@ +1533,3 @@
+ /// type name has failed in a dependent context. In these situations, we
+ /// automatically form DependentTypeName that will retry lookup in a related
+ /// scope during instantiation.
---
As I recall, this was intentional. The supported way to check for these is
has_builtin. The has_feature support is provided only for backwards
compatibility.
On 24 May 2016 9:59 a.m., "David Majnemer via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Tue May 24 11:53:
On 24 May 2016 10:15 a.m., "Richard Smith" wrote:
>
> As I recall, this was intentional. The supported way to check for these
is has_builtin. The has_feature support is provided only for backwards
compatibility.
See documentation here:
http://clang.llvm.org/docs/LanguageExtensions.html#checks-for
rsmith added a comment.
Looks like this extension was added at some point between 1.1 and 2.1. It would
make sense to produce an `ExtWarn` for it if the OpenCL standard version is
less than the one that introduced it (whenever that was) -- that would match
what we do for extensions in other lan
rsmith added a comment.
In http://reviews.llvm.org/D20602#438643, @srhines wrote:
> In http://reviews.llvm.org/D20602#438528, @rsmith wrote:
>
> > Looks like this extension was added at some point between 1.1 and 2.1. It
> > would make sense to produce an `ExtWarn` for it if the OpenCL standard
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM with or without the `SpeculativeEvaluationRAII` refactor (which is
ultimately pre-existing duplication).
Please commit the rename of `keepEvaluatingAfterFailure` -> `noteFailure`
separat
On 25 May 2016 9:13 a.m., "Yaxun Liu via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> yaxunl created this revision.
> yaxunl added a reviewer: Anastasia.
> yaxunl added subscribers: pxli168, bader, tstellarAMD, cfe-commits.
>
> Fix a regression which forbids using -std=CL|CL1.1|CL1.2|CL2.0
rsmith added inline comments.
Comment at: lib/Basic/FileManager.cpp:389
@@ -383,2 +388,3 @@
UFE->File.reset();
+ UFE->IsVirtual = true;
return UFE;
Rather than adding this `IsVirtual` flag, could you just set `UFE->IsValid` to
`true` here? It looks like a
rsmith added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangStand
On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> bader added a subscriber: bader.
> bader added a comment.
>
> In http://reviews.llvm.org/D20602#438667, @rsmith wrote:
>
> > I'm not suggesting it be treated as invalid. This extension is part of
>
rsmith added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangStand
On Wed, May 25, 2016 at 2:20 PM, Aleksey Bader
wrote:
> On Wed, May 25, 2016 at 11:53 PM, Richard Smith
> wrote:
>
>> On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> bader added a subscriber: bader.
>>> bader added a comment.
>>>
>>> I
Author: rsmith
Date: Wed May 25 17:06:25 2016
New Revision: 270774
URL: http://llvm.org/viewvc/llvm-project?rev=270774&view=rev
Log:
Fix rejects-valid on constexpr function that accesses a not-yet-defined 'extern
const' variable. That variable might be defined as 'constexpr', so we cannot
prove th
rsmith added a comment.
In http://reviews.llvm.org/D18035#437715, @rengolin wrote:
> The 3.8.1 deadline is tomorrow and I'd really like to see these two patches
> (plus the related fixes) in it,
Realistically, this seems unlikely to make it in time.
> or some LTS Linux distributions will live
rsmith added a comment.
Looks good other than the recent information about the version of OpenCL that
actually specifies this.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7899
@@ +7898,3 @@
+// OpenCL v2.2 s2.1.2.3 - Vector Component Access
+def warn_opencl_ext_vecto
rsmith added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:446
@@ +445,3 @@
+ case SD_FullExpression:
+EHStack.pushCleanup(NormalEHLifetimeMarker, Object,
+ Size);
This should use pushFullExprCleanup.
Author: rsmith
Date: Thu May 26 15:23:13 2016
New Revision: 270904
URL: http://llvm.org/viewvc/llvm-project?rev=270904&view=rev
Log:
Produce better pretty stack traces from crashes in template instantiation: add
pretty stack trace entries for all cases where we instantiate the definition of
someth
rsmith added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6197
@@ +6196,3 @@
+ // but there may be a chance to merge them.
+ if (getLangOpts().CPlusPlus)
+Cleanup.setExprNeedsCleanups(false);
Why is this C++-only? We presumably would want to clean up a
rsmith added a comment.
Seems reasonable to me.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3427
@@ -3402,5 +3402,6 @@
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ SourceRange NoexceptRange(Tok.getLocation(),
+
rsmith added inline comments.
Comment at: include/clang/AST/TypeLoc.h:1251
@@ -1250,2 +1250,3 @@
SourceLocation RParenLoc;
+ SourceRange ExceptionSpecRange;
SourceLocation LocalRangeEnd;
Can you arrange things so we only store this if there is an exception
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM once the LLVM side is landed.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:278
@@ +277,3 @@
+def pp_nonportable_path : Warning<
On Fri, May 27, 2016 at 1:03 PM, Srivastava, Sunil via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
>
>
> I want to discuss the issue in PR27895,
>
>https://llvm.org/bugs/show_bug.cgi?id=27895
>
>
>
> But I will give a slightly different example for this discussion.
>
>
>
> The
Could we use __LIBCPP_PREFERRED_OVERLOAD to get this working even with
older glibc (and recent clang)?
On 27 May 2016 3:26 p.m., "Eric Fiselier via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Fri May 27 17:19:53 2016
> New Revision: 271060
>
> URL: http://llvm.org/v
On 28 May 2016 12:58 a.m., "Eric Fiselier via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> I think that would be a possibility. However IMO such a change has little
value. Unlike other uses of `_LIBCPP_PREFERRED_OVERLOAD`, which fix const
correctness issue, I don't think the int vs bool re
rsmith added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:1989
@@ +1988,3 @@
+if (Tok.is(tok::colon)) {
+ // skip constructor initializer list
+ SkipUntil(tok::l_brace, StopAtSemi | StopBeforeMatch);
Comments should start with a capital lette
rsmith accepted this revision.
rsmith added a comment.
Looks good to me, too.
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Jun 1, 2016 at 12:42 PM, Manman Ren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> manmanren added a comment.
>
> In http://reviews.llvm.org/D20844#445762, @rjmccall wrote:
>
> > Hmm. No, I think the original code is correct here — RangeEnd is a
> token range, and those are genera
rsmith added a subscriber: rsmith.
rsmith added a comment.
The summary and content of this patch are very different.
If you have an ABI variant that any language should be able to target, that
should be controlled by the triple and related flags, not by a RenderScript
language option.
If you w
Author: rsmith
Date: Fri Jun 3 19:22:31 2016
New Revision: 271754
URL: http://llvm.org/viewvc/llvm-project?rev=271754&view=rev
Log:
PR27989: only enqueue binary operators into the data recursive int expression
evaluator if they are actually int expressions.
Modified:
cfe/trunk/lib/AST/ExprCo
On Sun, Jun 5, 2016 at 10:27 PM, Srivastava, Sunil <
sunil.srivast...@sony.com> wrote:
> Hi Richard,
>
>
>
> Thanks for you analysis. I have some follow up questions though:
>
>
> First, either of these two suggestions below should fix the bug, though it
> may be better to do both. Right ?
>
Eith
On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> pgousseau created this revision.
> pgousseau added reviewers: rsmith, thakis.
> pgousseau added subscribers: cfe-commits, wristow, probinson, gbedwell,
> bruno, cameron314.
>
> On Linux, if the t
rsmith added a comment.
Yes, I definitely want us to implement this for GCC compatibility. And now that
we have a specification for this feature, we can evaluate whether this is doing
the right thing. On that basis:
I still want this refactored so that the normally-mangled part of a function
n
On Mon, Jun 6, 2016 at 3:28 PM, Eric Niebler via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 6/3/16, 4:13 PM, "tha...@google.com on behalf of Nico Weber" <
> tha...@google.com on behalf of tha...@chromium.org> wrote:
> >On Fri, Jun 3, 2016 at 7:07 PM, Eric Niebler wrote:
> >>On 6/3/16,
LGTM for branch. Please also merge r271893 to fix a test failure from this
change.
On Sun, Jun 5, 2016 at 12:29 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Tom,
> I'd like to merge this change for getting rid of the stupid '-pie is
> nont used' warnings and to
It's larger than I'd like for a merge onto the branch, but yes, it looks OK.
On 7 Jun 2016 9:20 a.m., "Tom Stellard via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
> Is this OK for the 3.8 branch?
>
> reviews.llvm.org/rL259776
>
> -Tom
>
> On Mon, May 30, 2016 at 11:35:04AM
On 7 Jun 2016 7:52 a.m., "pierre gousseau"
wrote:
>
> pgousseau added a comment.
>
> > > On Linux, if the timestamp of a header file, included in the pch, is
modified, then including the pch without regenerating it causes a fatal
error, which is reasonable.
>
> >
>
> > > On Windows the check is i
rsmith added a comment.
In http://reviews.llvm.org/D20709#446595, @srhines wrote:
> There is a coming patch that adds a single attribute (for "kernel"), that has
> error checking to ensure that it is only used by our RenderScript targets. I
> assume that the cleanest way to retain that diagnost
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/AST/Decl.cpp:2938-2948
@@ -2937,1 +2937,13 @@
+SourceRange FunctionDecl::getExceptionSpecSourceRange() const {
+ const TypeSourceInfo *TSI = getTypeSourceInfo();
+ if (!TSI)
+re
rsmith added a comment.
Looks OK to me, pending Bruno's confirmation that performance is acceptable.
Comment at: lib/Lex/PPDirectives.cpp:102
Can you use `llvm::StringSwitch` for this? I'd be interested to see how the
performance compares.
http://reviews.llv
rsmith added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:33
@@ -28,2 +32,2 @@
#include "llvm/Support/Path.h"
#include "llvm/Support/SaveAndRestore.h"
eric_niebler wrote:
> You mean, instead of the `StringSet` below? Looks like `StringSwitch` just
> tu
Author: rsmith
Date: Wed Jun 8 19:53:41 2016
New Revision: 272233
URL: http://llvm.org/viewvc/llvm-project?rev=272233&view=rev
Log:
Update to match LLVM r272232.
Modified:
cfe/trunk/tools/arcmt-test/arcmt-test.cpp
cfe/trunk/tools/c-index-test/c-index-test.c
cfe/trunk/tools/c-index-te
Author: rsmith
Date: Wed Jun 8 19:54:42 2016
New Revision: 272235
URL: http://llvm.org/viewvc/llvm-project?rev=272235&view=rev
Log:
Update to match LLVM r272232.
Modified:
clang-tools-extra/trunk/clang-query/tool/ClangQuery.cpp
clang-tools-extra/trunk/tool-template/ToolTemplate.cpp
Modi
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith added inline comments.
Comment at: lib/Parse/ParseExpr.cpp:450-452
@@ -449,1 +449,5 @@
+
+// In this case, ActOnBinOp performed the CorrectDelayedTyposInExpr
check.
+if (!getLangOpts().CPlusPlus)
+ continue;
} else {
The inc
rsmith added a subscriber: rsmith.
Comment at: lib/Sema/SemaExpr.cpp:12825
@@ -12824,1 +12824,3 @@
+ // BlockContext.
+ } else if (!Rec.IsArrayBound) {
// C++1y [expr.const]p2:
This isn't correct; you still need to produce the diagnostic even if
rsmith added a comment.
Please call `Parser::ConsumeAndStoreFunctionPrologue` rather than trying to
reinvent it. You're still getting a number of cases wrong that it handles
properly.
You also need to handle the case where the code completion token appears within
the constructor *mem-initializ
rsmith added inline comments.
Comment at: lib/Basic/FileManager.cpp:389
@@ -383,2 +388,3 @@
UFE->File.reset();
+ UFE->IsVirtual = true;
return UFE;
Yes. The `IsValid` flag is just supposed to mean that this file has actually
been added to the `UniqueRealFi
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please make sure that any relevant parts of our documentation are also updated.
Given how small and self-contained this is, that we have a reasonable
expectation of good support and maintainer
rsmith added a comment.
Thanks for the updates, LGTM (@bruno, did you get the performance numbers you
wanted?)
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: rsmith
Date: Thu Jun 9 19:58:19 2016
New Revision: 272357
URL: http://llvm.org/viewvc/llvm-project?rev=272357&view=rev
Log:
Remove CXXConstructExpr::getFoundDecl(); it turned out to not be useful.
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/include/clang/Sema/Sema.h
Author: rsmith
Date: Thu Jun 9 21:01:28 2016
New Revision: 272361
URL: http://llvm.org/viewvc/llvm-project?rev=272361&view=rev
Log:
Reduce sizeof(CXXConstructorDecl) by 4-8 bytes.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
Modified: cfe/trunk/include/clang/AST/DeclCXX.h
URL:
http://ll
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900
@@ -7897,1 +7899,3 @@
+def err_opencl_ext_vector_type_rgba_selector: Error<
+ "vector component name '%0' cannot be used earlier than OpenCL version 2.2">;
} // end of sema category
---
Author: rsmith
Date: Mon Jun 13 14:04:44 2016
New Revision: 272575
URL: http://llvm.org/viewvc/llvm-project?rev=272575&view=rev
Log:
Add test for DR1359.
Modified:
cfe/trunk/test/CXX/drs/dr13xx.cpp
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/test/CXX/drs/dr13xx.cpp
URL:
http://
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Let's go ahead with this for now and figure out the proper way to handle this
as a follow-up change.
http://reviews.llvm.org/D20490
___
cfe-comm
Author: rsmith
Date: Mon Jun 13 19:48:35 2016
New Revision: 272605
URL: http://llvm.org/viewvc/llvm-project?rev=272605&view=rev
Log:
Add a test to ensure that pass_object_size is handled properly by a delegate
constructor.
Modified:
cfe/trunk/test/CodeGenCXX/pass-object-size.cpp
Modified: c
Author: rsmith
Date: Mon Jun 13 20:13:21 2016
New Revision: 272609
URL: http://llvm.org/viewvc/llvm-project?rev=272609&view=rev
Log:
Remove nonsense and simplify. To forward a reference, we always just load the
pointer-to-pointer representing the parameter. An aggregate rvalue representing
a point
rsmith added a comment.
This still looks like it will have has lots of false positives for cases like:
struct __attribute__((packed)) A {
char c;
int n;
} a;
void *p = &a.n;
It also looks like it will now have false negatives for cases like:
memcpy(x, y, *&a.n);
I think whiteli
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
Adding `-cl-opt-disable` to the tests seems fine as an alternative short-term
approach; LGTM with that approach (either as part of this change or a separate
ch
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
Repository:
rL LLVM
http://reviews.llvm.org/D21390
___
cfe-commits mailing list
cfe-commit
rsmith added inline comments.
Comment at: include/llvm/module.modulemap:121-126
@@ -106,8 +120,8 @@
// FIXME: Is this the right place for these?
module Pass { header "Pass.h" export * }
module PassSupport { header "PassSupport.h" export * }
module PassAnalysisSupport
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaLookup.cpp:1091
@@ -1091,2 +1091,2 @@
bool Found = false;
for (; I != IEnd && S->isDeclScope(*I); ++I) {
Please rename this to something like `Search
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:57-58
@@ -56,2 +56,4 @@
const FunctionProtoType *FPT = MD->getType()->castAs();
- RequiredArgs required = RequiredArgs::forPrototypePlus(FPT, Args.size());
+ // Don't pass in the MethodDecl, because we should
rsmith added a comment.
I agree, that looks like correct behavior for the warning. Thanks!
Comment at: lib/Sema/SemaCast.cpp:259-260
@@ -258,2 +258,4 @@
return ExprError();
+ if (DestType->isVoidPointerType())
+DiscardMisalignedMemberAddress(E);
}
LGTM
On 16 Jun 2016 3:07 p.m., "Pirama Arumuga Nainar via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> pirama created this revision.
> pirama added a reviewer: rsmith.
> pirama added subscribers: srhines, cfe-commits.
>
> If the RenderScript LangOpt is set, either via '-x renderscript' or
rsmith added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2073-2079
@@ +2072,9 @@
+ let Content = [{
+Use ``overallocated`` to indicate a struct or union is over-allocated. For
example,
+
+.. code-block:: c++
+
+struct S {
+ char a[4], char b[4];
+} __attribute_
Author: rsmith
Date: Tue Jun 21 15:10:11 2016
New Revision: 273309
URL: http://llvm.org/viewvc/llvm-project?rev=273309&view=rev
Log:
Refactor scope building in JumpDiagnostics for simplicity. This fixes a
(currently theoretical) bug where recursive calls to BuildScopeInformation
would do the wrong
Author: rsmith
Date: Thu Jun 23 03:41:20 2016
New Revision: 273548
URL: http://llvm.org/viewvc/llvm-project?rev=273548&view=rev
Log:
Rearrange condition handling so that semantic checks on a condition variable
are performed before the other substatements of the construct are parsed,
rather than de
Author: rsmith
Date: Thu Jun 23 14:02:52 2016
New Revision: 273600
URL: http://llvm.org/viewvc/llvm-project?rev=273600&view=rev
Log:
Re-commit r273548, reverted in r273589, with a fix to not produce
-Wfor-loop-analysis warnings for a for-loop with a condition variable. In such
a case, the loop con
Author: rsmith
Date: Thu Jun 23 14:16:49 2016
New Revision: 273602
URL: http://llvm.org/viewvc/llvm-project?rev=273602&view=rev
Log:
Implement p0292r2 (constexpr if), a likely C++1z feature.
Added:
cfe/trunk/test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.spec.auto/p2-1z.cpp
cfe/trunk/test/CXX/stm
On Thu, Jun 23, 2016 at 12:26 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Jun 23, 2016 at 3:16 PM, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Thu Jun 23 14:16:49 2016
> > New Revision: 273602
> >
Author: rsmith
Date: Fri Jun 24 06:20:31 2016
New Revision: 273662
URL: http://llvm.org/viewvc/llvm-project?rev=273662&view=rev
Log:
Add (commented out) status entries for the upcoming WG21 motions.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://
Author: rsmith
Date: Fri Jun 24 07:15:12 2016
New Revision: 273666
URL: http://llvm.org/viewvc/llvm-project?rev=273666&view=rev
Log:
Using for attributes voted into C++17.
Added:
cfe/trunk/test/CXX/dcl.dcl/dcl.attr/dcl.attr.grammar/p2-1z.cpp
Modified:
cfe/trunk/include/clang/Basic/Diagnos
Author: rsmith
Date: Fri Jun 24 07:16:11 2016
New Revision: 273667
URL: http://llvm.org/viewvc/llvm-project?rev=273667&view=rev
Log:
Dynamic memory allocation with alignment has been approved for C++17.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
htt
Author: rsmith
Date: Fri Jun 24 07:21:30 2016
New Revision: 273668
URL: http://llvm.org/viewvc/llvm-project?rev=273668&view=rev
Log:
More approved features for C++17.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/cfe
rsmith added a comment.
Ah right, we were (intentionally, but unfortunately) making an assumption that
the `TypeLoc` data layout doesn't change when the exception spec of a function
is updated. You'd need to make yourself a `TypeLocBuilder`, copy the relevant
data, and update the exception spec
Author: rsmith
Date: Fri Jun 24 08:25:08 2016
New Revision: 273676
URL: http://llvm.org/viewvc/llvm-project?rev=273676&view=rev
Log:
Updates from further motions.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
Author: rsmith
Date: Fri Jun 24 09:04:07 2016
New Revision: 273680
URL: http://llvm.org/viewvc/llvm-project?rev=273680&view=rev
Log:
Inline variables tentatively approved for C++17.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/l
Author: rsmith
Date: Fri Jun 24 09:10:58 2016
New Revision: 273681
URL: http://llvm.org/viewvc/llvm-project?rev=273681&view=rev
Log:
Remaining motions pass.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/www
Author: rsmith
Date: Fri Jun 24 09:23:32 2016
New Revision: 273683
URL: http://llvm.org/viewvc/llvm-project?rev=273683&view=rev
Log:
Correct error in change description.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/
Author: rsmith
Date: Fri Jun 24 19:15:56 2016
New Revision: 273754
URL: http://llvm.org/viewvc/llvm-project?rev=273754&view=rev
Log:
Implement C++17 P0386R2, inline variables. (The 'inline' specifier gives a
variable weak discardable linkage and partially-ordered initialization, and is
implied for
rsmith added inline comments.
Comment at: include/clang/AST/RecursiveASTVisitor.h:630-635
@@ -593,1 +629,8 @@
+ if (getDerived().shouldTraversePostOrder()) {
+for (auto Iter = ReverseLocalQueue.rbegin();
+ Iter != ReverseLocalQueue.rend(); ++Iter) {
+ TRY_TO(Po
Author: rsmith
Date: Mon Jun 27 14:43:46 2016
New Revision: 273913
URL: http://llvm.org/viewvc/llvm-project?rev=273913&view=rev
Log:
Add simple, stupid, pattern-based fuzzer / reducer for modules bugs. I've
already used this to find and reduce quite a few bugs, and it works pretty well
if you can
rsmith requested changes to this revision.
Comment at: include/clang/Basic/AttrDocs.td:2073-2079
@@ +2072,9 @@
+ let Content = [{
+Use ``overallocated`` to indicate a class or union can have extra memory
+allocated at its end. This attribute is primarily used when we want
+__buil
Author: rsmith
Date: Tue Jun 28 14:09:30 2016
New Revision: 274050
URL: http://llvm.org/viewvc/llvm-project?rev=274050&view=rev
Log:
Fix unreasonably-precise CHECK.
Modified:
cfe/trunk/test/CodeGenCXX/inheriting-constructor.cpp
Modified: cfe/trunk/test/CodeGenCXX/inheriting-constructor.cpp
U
Author: rsmith
Date: Tue Jun 28 15:35:53 2016
New Revision: 274058
URL: http://llvm.org/viewvc/llvm-project?rev=274058&view=rev
Log:
Update cxx_dr_status from test/CXX/drs.
Modified:
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/www/cxx_dr_status.html
URL:
http://llvm.org/viewvc/llvm
Author: rsmith
Date: Tue Jun 28 15:37:00 2016
New Revision: 274059
URL: http://llvm.org/viewvc/llvm-project?rev=274059&view=rev
Log:
cxx_status: fix footnote for p0136.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/c
Author: rsmith
Date: Tue Jun 28 15:37:43 2016
New Revision: 274060
URL: http://llvm.org/viewvc/llvm-project?rev=274060&view=rev
Log:
cxx_status: make c++17 footnote list formatting consistent with other footnote
lists.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_stat
3401 - 3500 of 4285 matches
Mail list logo
