rsmith added inline comments.
================
Comment at: include/clang/Sema/Sema.h:1534
@@ +1533,3 @@
+ /// type name has failed in a dependent context. In these situations, we
+ /// automatically form DependentTypeName that will retry lookup in a related
+ /// scope during instantiation.
----------------
form -> form a
================
Comment at: lib/Sema/SemaDecl.cpp:500
@@ +499,3 @@
+ // until instantiation time by making a non-dependent DependentTypeName. We
+ // pretend we saw a NestedNameSpecifier refering to the current scope, and
+ // lookup is retried.
----------------
refering -> referring
================
Comment at: lib/Sema/SemaDecl.cpp:520-522
@@ +519,5 @@
+
+ // This is not a situation that we need to recover from.
+ if (!NNS)
+ return ParsedType();
+
----------------
Maybe make this an `else` for the above `if`.
================
Comment at: lib/Sema/SemaDecl.cpp:559-562
@@ -521,6 +558,6 @@
}
}
return DeclSpec::TST_unspecified;
}
----------------
Doesn't seem to be done? I can easily believe there's a good reason why we want
two different paths for building a recovery nested name specifier, but I'd like
to know what it is at least.
http://reviews.llvm.org/D20500
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
