On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva wrote:
> On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rsmith
>> Date: Fri Oct 16 18:20:19 2015
>> New Revision: 250577
>>
>> URL: http:/
On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva wrote:
> On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith
> wrote:
>
>> On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva
>> wrote:
>>
>>> On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits <
>>> cf
On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva wrote:
> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith
> wrote:
>
>> On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva
>> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith
>>> wrote:
>>
On Mon, Oct 19, 2015 at 1:28 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> On Oct 16, 2015, at 5:47 PM, Richard Smith wrote:
>
> Great, looks like progress. Next you need a correct module map for libc++
> that actually covers all of its header
Ugh, looks like I missed a submodule for stdio.h :(
On Oct 19, 2015 11:34 AM, "Adrian Prantl" wrote:
> While building module 'std' imported from
> /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/cassert:20:
> While building module 'Darwin' imported from
> /Volumes/Data/llvm/_build.n
Author: rsmith
Date: Wed Oct 21 02:13:52 2015
New Revision: 250884
URL: http://llvm.org/viewvc/llvm-project?rev=250884&view=rev
Log:
[modules] libstdc++ defines some static inline functions in its internal
headers. If those headers end up being textually included twice into the same
module, we get
Author: rsmith
Date: Wed Oct 21 22:52:15 2015
New Revision: 250980
URL: http://llvm.org/viewvc/llvm-project?rev=250980&view=rev
Log:
[coroutines] Add lexer support for co_await, co_yield, and co_return keywords.
Add -fcoroutines flag (just for -cc1 for now) to enable the feature. Early
indications
Author: rsmith
Date: Wed Oct 21 23:27:47 2015
New Revision: 250982
URL: http://llvm.org/viewvc/llvm-project?rev=250982&view=rev
Log:
[coroutines] Add feature-test macro for coroutines, defined to 1 to indicate
the implementation is incomplete.
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor
Author: rsmith
Date: Wed Oct 21 23:42:51 2015
New Revision: 250984
URL: http://llvm.org/viewvc/llvm-project?rev=250984&view=rev
Log:
[coroutines] Fix description of LangOption for coroutines.
Modified:
cfe/trunk/include/clang/Basic/LangOptions.def
Modified: cfe/trunk/include/clang/Basic/Lang
Author: rsmith
Date: Wed Oct 21 23:46:14 2015
New Revision: 250985
URL: http://llvm.org/viewvc/llvm-project?rev=250985&view=rev
Log:
[coroutines] Add parsing support for co_await expression, co_yield expression,
co_await modifier on range-based for loop, co_return statement.
Added:
cfe/trunk/
Author: rsmith
Date: Thu Oct 22 00:12:22 2015
New Revision: 250991
URL: http://llvm.org/viewvc/llvm-project?rev=250991&view=rev
Log:
[coroutines] Add overloaded unary 'operator co_await'.
Modified:
cfe/trunk/include/clang/Basic/OperatorKinds.def
cfe/trunk/lib/AST/ItaniumMangle.cpp
cfe
Author: rsmith
Date: Thu Oct 22 00:21:12 2015
New Revision: 250992
URL: http://llvm.org/viewvc/llvm-project?rev=250992&view=rev
Log:
[coroutines] Add forgotten test for lexing coroutines keywords.
Added:
cfe/trunk/test/Lexer/coroutines.cpp
Added: cfe/trunk/test/Lexer/coroutines.cpp
URL:
htt
Author: rsmith
Date: Thu Oct 22 01:13:50 2015
New Revision: 250993
URL: http://llvm.org/viewvc/llvm-project?rev=250993&view=rev
Log:
[coroutines] Initial stub Sema functionality for handling coroutine await /
yield / return.
Added:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
cfe/trunk/test/Sema
Author: rsmith
Date: Tue Oct 27 01:02:45 2015
New Revision: 251387
URL: http://llvm.org/viewvc/llvm-project?rev=251387&view=rev
Log:
[coroutines] Creation of promise object, lookup of operator co_await, building
of await_* calls, and AST representation for same.
Modified:
cfe/trunk/include/cl
Author: rsmith
Date: Tue Oct 27 02:25:29 2015
New Revision: 251391
URL: http://llvm.org/viewvc/llvm-project?rev=251391&view=rev
Log:
Work around incomplete list initialization support in older MSVC.
Modified:
cfe/trunk/include/clang/AST/ExprCXX.h
cfe/trunk/include/clang/AST/StmtCXX.h
Mod
Author: rsmith
Date: Tue Oct 27 02:47:45 2015
New Revision: 251397
URL: http://llvm.org/viewvc/llvm-project?rev=251397&view=rev
Log:
Properly clear current coroutine promise on FunctionScopeInfo reuse. Should
hopefully make bots happy again.
Modified:
cfe/trunk/lib/Sema/ScopeInfo.cpp
Modifie
Author: rsmith
Date: Thu Oct 29 18:32:29 2015
New Revision: 251665
URL: http://llvm.org/viewvc/llvm-project?rev=251665&view=rev
Log:
Revert r249929 ("Split out of ").
This change caused problems when building code like povray that:
a) uses 'using namespace std;'
b) is built on an environment whe
Hi,
The attached patch undoes the revert of r249929, and adds an extension to
allow (and ) to work properly even in environments such
as iOS where the underlying libc does not provide C++'s const-correct
overloads of strchr and friends.
This works as follows:
* The macro _LIBCPP_PREFERRED_OVER
h ready for commit, or were you just checking an idea? Our
> bots are still failing to build povray, so we’re really looking forward for
> some fix:)
>
> Thanks,
> Michael
>
> On Oct 15, 2015, at 6:21 PM, Manman Ren via cfe-commits <
> cfe-commits@lists.llvm.org>
On Oct 30, 2015 6:39 AM, "NAKAMURA Takumi via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: chapuni
> Date: Fri Oct 30 11:37:27 2015
> New Revision: 251713
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251713&view=rev
> Log:
> CGExprConstant.cpp: Appease Modules.
Why? Please don
rsmith added inline comments.
Comment at: lib/AST/ASTDumper.cpp:1340-1344
@@ +1339,7 @@
+ dumpName(D);
+ switch (D->getBuiltinTemplateKind()) {
+ case BTK__make_integer_seq:
+OS << " __make_integer_seq";
+break;
+ }
+ dumpTemplateParameters(D->getTemplateParameters())
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:2125
@@ +2124,3 @@
+
+def InternalLinkage : InheritableAttr {
+ let Spellings = [GNU<"internal_linkage">, CXX11<"clang",
"internal_linkage">];
`InheritableAttr` doesn't seem right for the case
Author: rsmith
Date: Mon Nov 2 19:19:56 2015
New Revision: 251875
URL: http://llvm.org/viewvc/llvm-project?rev=251875&view=rev
Log:
Switch to using an explicit scope object to ensure we don't forget to pop ObjC
type parameters off the scope, and fix the cases where we failed to do so.
Modified:
This is awesome, thank you both!
On Mon, Nov 2, 2015 at 5:22 PM, Douglas Gregor via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> … and I forgot the most important part, which is that this is based on the
> good work of Mr. Kyrtzidis that I failed to acknowledge in the commit
> message.
>
>
Author: rsmith
Date: Mon Nov 2 21:13:11 2015
New Revision: 251898
URL: http://llvm.org/viewvc/llvm-project?rev=251898&view=rev
Log:
[modules] Rationalize the behavior of Decl::declarationReplaces, and in
particular don't assume that two declarations of the same kind in the same
context are declar
rsmith added a comment.
I am not convinced that it's reasonable to put inlining heuristics into clang's
IR generation. This will cause maintenance problems for the inliner in the
future (anyone tuning the inlining heuristics and thresholds will need to be
aware of this, and clang will behave di
rsmith added inline comments.
Comment at: lib/Basic/Targets.cpp:2516-2517
@@ -2515,1 +2515,4 @@
+ // X86 always has X87.
+ setFeatureEnabledImpl(Features, "x87", true);
+
i386 doesn't necessarily have x87, does it? IIRC the floating point
co-processor is only
rsmith added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1628
@@ +1627,3 @@
+The ``internal_linkage`` attribute changes the linkage type of the declaration
to internal.
+This is similar to C-style ``static``, but can be used on classes and class
methods
+This ca
On Tue, Nov 3, 2015 at 4:37 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Nov 3, 2015 at 7:23 PM, Richard Smith
> wrote:
> > rsmith added inline comments.
> >
> >
> > Comment at: include/clang/Basic/AttrDoc
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please add a test for serialization/deserialization of this declaration.
Otherwise, this looks fine.
Comment at: include/clang/Serialization/ASTBitCodes.h:994
@@ -990,3 +993,
rsmith accepted this commit.
Users:
ismailp (Author)
rsmith (Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
http://reviews.llvm.org/rL251335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rsmith accepted this commit.
Users:
dim (Author)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
joerg (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL250657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith accepted this commit.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rsmith added a subscriber: rsmith.
rsmith raised a concern with this commit.
/cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 According to the GCC documentation
for libatomic:
> for i = __atomic_add_fetch (ptr, j, model) the code generated will be
>
>tmp = __atomic_fetch_add (ptr, j, model);
rsmith added inline comments.
Comment at: test/CodeGenCXX/attribute_internal_linkage.cpp:34-35
@@ +33,4 @@
+
+__attribute__((internal_linkage)) void A::f3() {
+}
+
We should reject this. We're just causing problems for ourselves if we allow
the linkage to change
Author: rsmith
Date: Wed Nov 4 13:26:32 2015
New Revision: 252063
URL: http://llvm.org/viewvc/llvm-project?rev=252063&view=rev
Log:
[modules] Generalize the workaround for multiple ambiguous definitions of
internal linkage entities in different modules from r250884 to apply to all
names, not just
On Wed, Nov 4, 2015 at 11:36 AM, James Y Knight via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jyknight added inline comments.
>
> /cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 Looks like GCC's behavior does
> actually follow that spec.
>
> I'm not sure why the library exposes these entry-po
t;>> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek
>>>> wrote:
>>>>
>>>>> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva
>>>>> wrote:
>>>>>
>>>>>> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek
>>>>>>
It'd be simpler and would more directly match the C specification (and
would handle a few other cases better, such as placeholder types and atomic
types) if you instead passed the operand through DefaultLvalueConversion
rather than matching against the decayed form of the type.
On Wed, Nov 4, 2015
On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith wrote:
> It'd be simpler and would more directly match the C specification (and
> would handle a few other cases better, such as placeholder types and atomic
> types) if you instead passed the operand through DefaultLvalueConversio
LGTM, thanks!
On Wed, Nov 4, 2015 at 4:00 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Nov 4, 2015 at 5:46 PM, Richard Smith
> wrote:
> > On Wed, Nov 4, 2015 at 2:45 PM, Richard Smith
> wrote:
> >>
> >> It'd be
rsmith added inline comments.
Comment at: lib/Lex/ModuleMap.cpp:235-237
@@ -234,5 +234,1 @@
return IsPrivateRole &&
- // FIXME: Should we map RequestingModule to its top-level module here
- //too? This check is redundant with the isSubModuleOf check in
-
Author: rsmith
Date: Wed Nov 4 18:54:55 2015
New Revision: 252114
URL: http://llvm.org/viewvc/llvm-project?rev=252114&view=rev
Log:
[modules] If we're given a module file, via -fmodule-file=, for a module, but
we can't load that file due to a configuration mismatch, and implicit module
building i
Author: rsmith
Date: Wed Nov 4 19:30:19 2015
New Revision: 252125
URL: http://llvm.org/viewvc/llvm-project?rev=252125&view=rev
Log:
[modules] Don't merge an anonymous enum definition into a named enum definition.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/test/Modules/merge-enum
Author: rsmith
Date: Thu Nov 5 14:55:14 2015
New Revision: 252206
URL: http://llvm.org/viewvc/llvm-project?rev=252206&view=rev
Log:
Improve macro dumping to preserve semantically-relevant spelling information.
Modified:
cfe/trunk/lib/Lex/MacroInfo.cpp
Modified: cfe/trunk/lib/Lex/MacroInfo.c
On Wed, Nov 4, 2015 at 7:14 PM, Sean Silva via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Nov 4, 2015 at 1:07 PM, Richard Smith
> wrote:
>
>> On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote:
>>
>>> On Fri, Oct 23, 2015 at 9:31 PM Sean Si
Author: rsmith
Date: Thu Nov 5 15:16:22 2015
New Revision: 252211
URL: http://llvm.org/viewvc/llvm-project?rev=252211&view=rev
Log:
PR25368: Replace workaround for build failure with modules enabled with a fix
for the root cause. The 'using llvm::isa;' declaration in Basic/LLVM.h only
pulls the d
Author: rsmith
Date: Thu Nov 5 15:41:06 2015
New Revision: 252214
URL: http://llvm.org/viewvc/llvm-project?rev=252214&view=rev
Log:
Update C++ status page to match motions from Kona.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc
Author: rsmith
Date: Thu Nov 5 15:42:07 2015
New Revision: 252215
URL: http://llvm.org/viewvc/llvm-project?rev=252215&view=rev
Log:
Fix CSS style name.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/www/cxx
Author: rsmith
Date: Thu Nov 5 15:42:32 2015
New Revision: 252216
URL: http://llvm.org/viewvc/llvm-project?rev=252216&view=rev
Log:
Fix incorrect status for P0012R1.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-project/cfe
Author: rsmith
Date: Thu Nov 5 16:21:52 2015
New Revision: 252223
URL: http://llvm.org/viewvc/llvm-project?rev=252223&view=rev
Log:
Better link for Library Fundamentals TS.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/viewvc/llvm-proj
rsmith added a comment.
As discussed off-line:
1. Can we avoid tracking the `pass_object_size` attributes in the canonical
function type? As the only permitted use of a function with this attribute is
as a direct callee in a function call, it seems like we'll always have the
parameters to hand
Ping.
On Thu, Oct 29, 2015 at 5:21 PM, Richard Smith
wrote:
> Hi,
>
> The attached patch undoes the revert of r249929, and adds an extension to
> allow (and ) to work properly even in environments such
> as iOS where the underlying libc does not provide C++'s const-co
rsmith added a comment.
Sorry for the long delay. This looks to be in good shape.
Comment at: include/clang/AST/Type.h:1210
@@ +1209,3 @@
+/// Which keyword(s) were used to create an AutoType.
+enum class AutoTypeKeyword : unsigned char {
+ /// \brief auto
The
rsmith added inline comments.
Comment at: lib/Sema/SemaType.cpp:2621
@@ -2620,3 +2620,3 @@
// C++14 In generic lambdas allow 'auto' in their parameters.
- if (ContainsPlaceholderType &&
+ if (D.getDeclSpec().containsPlaceholderType() &&
(!SemaRef.getLangOpts().CPlusPlu
rsmith added inline comments.
Comment at: lib/Sema/SemaCXXScopeSpec.cpp:775-787
@@ +774,15 @@
+if (ClassTemplateDecl *CTD = Found.getAsSingle()) {
+ TemplateParameterList *TPL = CTD->getTemplateParameters();
+ assert(TPL && "NULL template parameter list");
+ std
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
This LGTM, do you have SVN access or would you like someone to commit for you?
Comment at: lib/Sema/SemaType.cpp:2616-2618
@@ -2616,5 +2615,5
You use this pattern in a few places:
+#if (__cplusplus <= 199711L) // C or C++03 or earlier modes
Please remove the "C or" from the tests that are not actually run in C mode
(most or all of these tests make no sense in C, so the comment is
confusing). Also remove the parens.
Otherwise, this loo
Author: rsmith
Date: Tue Nov 10 19:36:17 2015
New Revision: 252688
URL: http://llvm.org/viewvc/llvm-project?rev=252688&view=rev
Log:
N3922: direct-list-initialization of an auto-typed variable no longer deduces a
std::initializer_list type. Instead, the list must contain a single element
and the t
Author: rsmith
Date: Tue Nov 10 20:02:15 2015
New Revision: 252690
URL: http://llvm.org/viewvc/llvm-project?rev=252690&view=rev
Log:
Add support for GCC's '__auto_type' extension, per the GCC manual:
https://gcc.gnu.org/onlinedocs/gcc/Typeof.html
Differences from the GCC extension:
* __auto_type
Committed as r252690.
Could I tempt you to put together a documentation patch for this, and a
change for the release notes?
On Tue, Nov 10, 2015 at 3:06 PM, Nicholas Allegra wrote:
> comex added a comment.
>
> I don't have SVN access. If you want to commit it, feel free to remove
> that commen
rsmith added a comment.
Why does this construct justify the compiler emitting a warning? It seems to be
reporting a fact about the code rather than a bug, and as there are many coding
styles where variables are not routinely marked as const whenever possible,
this appears to be checking that th
On Wed, Nov 11, 2015 at 3:53 PM, Nathan Wilson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nwilson
> Date: Wed Nov 11 17:53:35 2015
> New Revision: 252827
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252827&view=rev
> Log:
> Add diagnostics which fall under [dcl.spec.concept
On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Nov 11 18:44:12 2015
> New Revision: 252834
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252834&view=rev
> Log:
> Provide a frontend based error for always_inli
On Wed, Nov 11, 2015 at 5:25 PM, Eric Christopher
wrote:
> On Wed, Nov 11, 2015 at 5:03 PM Richard Smith
> wrote:
>
>> On Wed, Nov 11, 2015 at 4:44 PM, Eric Christopher via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: echristo
Author: rsmith
Date: Thu Aug 6 17:14:12 2015
New Revision: 244288
URL: http://llvm.org/viewvc/llvm-project?rev=244288&view=rev
Log:
[modules] Fix use-after-iterator-invalidation bug.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
URL:
Author: rsmith
Date: Thu Aug 6 17:14:35 2015
New Revision: 244289
URL: http://llvm.org/viewvc/llvm-project?rev=244289&view=rev
Log:
[modules] Remove unused ModuleManager::visitDepthFirst function.
Modified:
cfe/trunk/include/clang/Serialization/ModuleManager.h
cfe/trunk/lib/Serialization
rsmith added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1262
@@ +1261,3 @@
+
+/// \brief The end location of the keyword introducing the spec, if any.
+unsigned ExceptionSpecLocEnd;
Drop bogus "keyword introducing the" here, and drop either
On Thu, Aug 6, 2015 at 4:49 PM, Ben Langmuir wrote:
> benlangmuir added inline comments.
>
>
> Comment at: lib/Basic/Targets.cpp:4552
> @@ -4551,2 +4551,3 @@
> .Case("arm", true)
> +.Case("aarch32", true)
> .Case("softfloat", SoftFloat)
> ---
rsmith added a subscriber: rsmith.
rsmith added a comment.
This doesn't recover from the errors properly any more (leaving junk behind in
the 'current module' stack), and somewhat breaks the original purpose of these
checks, which is to detect and diagnose missing close braces. Here's what I
su
rsmith added a subscriber: rsmith.
Comment at: lib/AST/ItaniumMangle.cpp:2060-2062
@@ -2058,2 +2059,5 @@
void CXXNameMangler::mangleType(const FunctionNoProtoType *T) {
- llvm_unreachable("Can't mangle K&R function prototypes");
+ // Function types without prototypes can arise
rsmith added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:2060-2062
@@ -2058,2 +2059,5 @@
void CXXNameMangler::mangleType(const FunctionNoProtoType *T) {
- llvm_unreachable("Can't mangle K&R function prototypes");
+ // Function types without prototypes can arise when
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
rsmith added a comment.
This seems to have a lot of overlap with the function sanitizer. The
documentation would probably benefit from some advice about when to use each
and how they compare.
Comment at: lib/AST/ItaniumMangle.cpp:4119-4126
@@ +4118,10 @@
+
Author: rsmith
Date: Sat Aug 8 20:05:31 2015
New Revision: 244409
URL: http://llvm.org/viewvc/llvm-project?rev=244409&view=rev
Log:
[modules] When loading a template specialization, re-canonicalize its template
arguments because the reloaded form might have become non-canonical across the
seriali
Author: rsmith
Date: Sat Aug 8 20:50:14 2015
New Revision: 244410
URL: http://llvm.org/viewvc/llvm-project?rev=244410&view=rev
Log:
Add file missed from r244409.
Added:
cfe/trunk/test/Modules/Inputs/stress1/merge_no_reexport.h
Added: cfe/trunk/test/Modules/Inputs/stress1/merge_no_reexport.h
Author: rsmith
Date: Sat Aug 8 21:28:42 2015
New Revision: 244411
URL: http://llvm.org/viewvc/llvm-project?rev=244411&view=rev
Log:
[modules] Attach dependency listeners to the module manager once when it's
created, rather than creating and attaching a new listener each time we load a
module file
Author: rsmith
Date: Sat Aug 8 21:44:20 2015
New Revision: 244412
URL: http://llvm.org/viewvc/llvm-project?rev=244412&view=rev
Log:
[modules] Don't leak -M flags for dependency file generation into the module
build process when we implicitly build a module. Previously, we'd create the
specified .
Author: rsmith
Date: Sun Aug 9 03:48:41 2015
New Revision: 244416
URL: http://llvm.org/viewvc/llvm-project?rev=244416&view=rev
Log:
[modules] PR22534: Load files specified by -fmodule-file= eagerly. In
particular, this avoids the need to re-parse module map files when using such a
module.
Adde
On Aug 9, 2015 3:56 PM, "NAKAMURA Takumi via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: chapuni
> Date: Sun Aug 9 17:55:50 2015
> New Revision: 244427
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244427&view=rev
> Log:
> clang/test/Modules: Satisfy win32 hosts due to dospath
rsmith added inline comments.
Comment at: include/clang/AST/VTableBuilder.h:387-391
@@ -386,7 +386,3 @@
- // Copy constructor.
- // FIXME: Uncomment when we've moved to C++11.
- // VPtrInfo(const VPtrInfo &) = default;
-
/// The vtable will hold all of the virtual bases or
rsmith added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:2098
@@ -2063,3 +2097,3 @@
// Initialize the vtable pointer for this base.
-InitializeVTablePointer(Base, NearestVBase, OffsetFromNearestVBase,
-VTableClass);
+VPtr vptr{Base
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
rsmith added inline comments.
Comment at: lib/AST/Expr.cpp:1425
@@ +1424,3 @@
+
+ if (E->isTypeDependent() && isa(base)) {
+bool MemberOfCurrentInstantiation = true;
The language rule for this says nothing about the base being a `this`
expression; there are
rsmith added a comment.
Interested reviewers, see also discussion here of whether we want this feature:
http://lists.llvm.org/pipermail/cfe-dev/2016-July/050040.html
https://reviews.llvm.org/D22474
___
cfe-commits mailing list
cfe-commits@lists.llv
On Wed, Mar 9, 2016 at 7:46 AM, Samuel Antao via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sfantao
> Date: Wed Mar 9 09:46:05 2016
> New Revision: 263019
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263019&view=rev
> Log:
> [OpenMP] Add support for multidimensional array sect
On Wed, Feb 26, 2014 at 4:25 PM, Ben Langmuir wrote:
> Author: benlangmuir
> Date: Wed Feb 26 18:25:12 2014
> New Revision: 202329
>
> URL: http://llvm.org/viewvc/llvm-project?rev=202329&view=rev
> Log:
> Add a 'use-external-names' option to VFS overlay files
>
> When true, sets the name of the f
Author: rsmith
Date: Mon Jul 18 17:37:35 2016
New Revision: 275925
URL: http://llvm.org/viewvc/llvm-project?rev=275925&view=rev
Log:
Fix some minor issues found by Coverity.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/lib/AST/ItaniumMan
On Mon, Jul 18, 2016 at 5:01 PM, Samuel Antao via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sfantao
> Date: Mon Jul 18 19:01:12 2016
> New Revision: 275931
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275931&view=rev
> Log:
> Append clang system include path for offloading too
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1602
@@ -1601,2 +1601,3 @@
unsigned IsConstexpr : 1;
+ unsigned IsMarkedForPendingInstantiation : 1;
Drop the `MarkedFor` here. This flag *is* the mark from the point of view of a
user of th
rsmith created this revision.
rsmith added reviewers: EricWF, mclow.lists.
rsmith added a subscriber: cfe-commits.
rsmith set the repository for this revision to rL LLVM.
This fixes a bug where throwing an exception of type nullptr_t and catching it
as a pointer-to-member would not guarantee to p
rsmith added inline comments.
Comment at: src/CMakeLists.txt:94
@@ -93,3 +93,3 @@
PROPERTIES
-COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS}"
+COMPILE_FLAGS "${LIBCXXABI_COMPILE_FLAGS} -fno-modules"
)
Err, ignore this :)
Repository:
rL LLVM
https://r
Author: rsmith
Date: Tue Jul 19 15:19:37 2016
New Revision: 276016
URL: http://llvm.org/viewvc/llvm-project?rev=276016&view=rev
Log:
[libcxxabi] When catching an exception of type nullptr_t with a handler of
pointer-to-member type, produce a null value of the right type.
This fixes a bug where th
rsmith closed this revision.
rsmith added a comment.
Committed as r276016.
Repository:
rL LLVM
https://reviews.llvm.org/D22528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Jul 19 15:35:09 2016
New Revision: 276022
URL: http://llvm.org/viewvc/llvm-project?rev=276022&view=rev
Log:
Attempt to bring peace to -Werror buildbots.
Modified:
libcxxabi/trunk/test/catch_reference_nullptr.pass.cpp
Modified: libcxxabi/trunk/test/catch_reference_nul
Author: rsmith
Date: Wed Jul 20 13:28:19 2016
New Revision: 276152
URL: http://llvm.org/viewvc/llvm-project?rev=276152&view=rev
Log:
Fix modules self-host: add missing include and forward-decl.
Modified:
cfe/trunk/include/clang/Lex/PTHManager.h
Modified: cfe/trunk/include/clang/Lex/PTHManage
Author: rsmith
Date: Wed Jul 20 14:10:16 2016
New Revision: 276159
URL: http://llvm.org/viewvc/llvm-project?rev=276159&view=rev
Log:
[modules] Don't emit initializers for VarDecls within a module eagerly whenever
we first touch any part of that module. Instead, defer them until the first
time that
rsmith added a comment.
ManagedStatic.h already includes , so the additional includes of
don't seem appropriate to me. Looks like this may have hit a bug in
enum merging?
https://reviews.llvm.org/D22439
___
cfe-commits mailing list
cfe-commits@li
2901 - 3000 of 6740 matches
Mail list logo
