Author: rnk
Date: Fri Sep 11 12:50:14 2015
New Revision: 247438
URL: http://llvm.org/viewvc/llvm-project?rev=247438&view=rev
Log:
Use Itanium C++ ABI triple for new modules+debug test
Modified:
cfe/trunk/test/Modules/ExtDebugInfo.cpp
Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp
URL:
ht
rnk added inline comments.
Comment at: lib/Sema/SemaType.cpp:5876
@@ +5875,3 @@
+
+if (!IsCtorOrDtor) {
+ if (CurCC != DefaultCC || DefaultCC == ToCC)
andreybokhanko wrote:
> rnk wrote:
> > This looks like the !IsCtorOrDtor check that affects Itanium. Isn
Author: rnk
Date: Wed Sep 16 15:15:55 2015
New Revision: 247843
URL: http://llvm.org/viewvc/llvm-project?rev=247843&view=rev
Log:
[WinEH] Pass the catch adjectives to catchpad directly
This avoids building a fake LLVM IR global variable just to ferry an i32
down into LLVM codegen. It also puts a
Author: rnk
Date: Wed Sep 16 16:06:09 2015
New Revision: 247851
URL: http://llvm.org/viewvc/llvm-project?rev=247851&view=rev
Log:
[WinEH] Fix a build issue in CGException.cpp
I was constructing an object without filling in all the fields.
Modified:
cfe/trunk/lib/CodeGen/CGException.cpp
Modi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks like I forgot to submit the comments I wrote. Anyway, looks good.
Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:238
@@ +237,3 @@
+ continue;
+const StringRef Can
Author: rnk
Date: Thu Sep 17 12:04:13 2015
New Revision: 247902
URL: http://llvm.org/viewvc/llvm-project?rev=247902&view=rev
Log:
Use the MSVC SEH personalities on Mingw
Mingw generally wraps an old copy of msvcrt.dll which has these
personalities, so things should work out, or so I hear. I haven
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
I think this is ready.
http://reviews.llvm.org/D1623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
I think you need to address the feedback about avoiding dynamic
initialization on stock non-Mac systems.
Sent from phone
On Sep 21, 2015 8:33 AM, "Evgeny Astigeevich"
wrote:
> eastig added a comment.
>
> Ping.
>
>
> http://reviews.llvm.org/D12689
>
>
>
>
_
rnk added a subscriber: rnk.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: rnk
Date: Wed Sep 30 12:30:48 2015
New Revision: 248925
URL: http://llvm.org/viewvc/llvm-project?rev=248925&view=rev
Log:
[Sema] Avoid crashing during this-> insertion recovery
We get into this bad state when someone defines a new member function
for a class but forgets to add the declara
rnk added a comment.
I think fundamentally we are doing too much declspec property lowering in Sema.
We might want to back up and figure out how to do it in IRGen. Right now we
have bugs like this, which are probably more important than new functionality:
https://llvm.org/bugs/show_bug.cgi?id=24
rnk added a subscriber: rnk.
Comment at: include/CMakeLists.txt:31
@@ +30,3 @@
+# by prepending __config_site to the current __config header.
+# TODO(EricWF) Is it portable to use "cat" and ">>"?
+add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config
-
Author: rnk
Date: Tue Oct 6 20:07:13 2015
New Revision: 249497
URL: http://llvm.org/viewvc/llvm-project?rev=249497&view=rev
Log:
[SEH] Fix x64 __exception_code in __except blocks
Use llvm.eh.exceptioncode to get the code out of EAX for x64. For
32-bit, the filter is responsible for storing it to
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
In http://reviews.llvm.org/D11921#221136, @dschuff wrote:
> Should this test be renamed to x86_longdouble.c or some such instead of fp128?
Yeah, x86_64-longdouble.c is probably better.
http
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Feel free to commit more test coverage like this with just post-commit review.
http://reviews.llvm.org/D11922
___
cfe-commits mailing list
cfe-co
rnk added a comment.
In http://reviews.llvm.org/D11922#221185, @dschuff wrote:
> I'm not an expert in mangling, and I'm not 100% sure if this is right. The
> Itanium ABI's spec lists "long double" as the same as __float80. Should we
> use "double" in mangling instead?
If you can have differen
On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith
wrote:
> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Mon Aug 10 14:39:01 2015
>> New Revision: 244488
>>
>> URL: http:/
On Mon, Aug 10, 2015 at 6:40 PM, Richard Smith
wrote:
> On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner wrote:
>
>> On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith
>> wrote:
>>
>>> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits <
&
Yeah, let's do that.
On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
> wrote:
> > Author: rnk
> > Date: Mon Aug 10 14:39:01 2015
> > New Revision: 244488
> >
> > URL: http://llvm.or
rnk added a comment.
I added this code before C++11 migration. I wanted to explicitly default the
copy ctor to document that it's a value type, rather than defaulting it
implicitly. You can nuke both comments and uncomment the definition.
http://reviews.llvm.org/D11928
_
rnk added inline comments.
Comment at: include/clang/AST/VTableBuilder.h:54
@@ -53,3 +53,3 @@
- VTableComponent() { }
+ VTableComponent() = default;
Is this ctor used? It leaves Value uninitialized. Maybe we should delete it to
ensure that it isn't called,
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D11928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Thu Aug 13 12:56:49 2015
New Revision: 244922
URL: http://llvm.org/viewvc/llvm-project?rev=244922&view=rev
Log:
Turn off __has_feature(cxx_rtti) when -fno-rtti-data is present
-fno-rtti-data makes it so that vtables emitted in the current TU lack
RTTI data. This means that dynam
Author: rnk
Date: Thu Aug 13 13:10:34 2015
New Revision: 244926
URL: http://llvm.org/viewvc/llvm-project?rev=244926&view=rev
Log:
Try to fix the build after r244923
Modified:
cfe/trunk/lib/Frontend/DependencyFile.cpp
Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp
URL:
http://llvm.org/v
Author: rnk
Date: Thu Aug 13 13:10:32 2015
New Revision: 244925
URL: http://llvm.org/viewvc/llvm-project?rev=244925&view=rev
Log:
Try to fix new.cpp after r244920 to make it pass
Modified:
cfe/trunk/test/CodeGenCXX/new.cpp
Modified: cfe/trunk/test/CodeGenCXX/new.cpp
URL:
http://llvm.org/vie
We could support that by allowing the MSVC version in the triple to be
different from the -fms-compatibility-version on the command line. Today,
this might even with with --target.
That said, I don't imagine many people are doing this. Microsoft makes it
hard for you to do this, and lots of code a
rnk added inline comments.
Comment at: test/Parser/arm-windows-calling-convention-handling.c:2
@@ -1,3 @@
-// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only
-verify %s
-
-int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling
conv
rnk added inline comments.
Comment at: test/Parser/arm-windows-calling-convention-handling.c:2
@@ -1,3 @@
-// RUN: %clang_cc1 -triple thumbv7-windows -fms-compatibility -fsyntax-only
-verify %s
-
-int __cdecl cdecl(int a, int b, int c, int d) { // expected-warning {{calling
conv
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D12037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Fri Aug 14 14:03:02 2015
New Revision: 245083
URL: http://llvm.org/viewvc/llvm-project?rev=245083&view=rev
Log:
Don't run explicit-modules-missing-files.cpp on Windows
It is flaky due to inability to remove files with open handles. We
could paper over it with rm -f, but then th
rnk accepted this revision.
rnk added a comment.
lgtm
http://reviews.llvm.org/D11932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Aug 18, 2015 at 11:26 AM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> I don’t have access to gcc to test removing the flag there. I see no
> reason not to remove it for gcc, but I haven’t and can’t test it. Someone
> else will need to test it before committing.
On Tue, Aug 18, 2015 at 3:00 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 14, 2015 at 11:27 AM, Hans Wennborg via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote:
>> > On Thu, Aug 6, 2015 at 1:56
I merged both of them and tweaked the test case to make it work.
On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote:
> On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
> > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
> > wrote:
> >> Author: r
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
lgtm
http://reviews.llvm.org/D12164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D12109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
This looks good.
As a larger issue, LLVM fast isel definitely won't pattern match this series of
shifts and selects to rotl at -O0. There are some users who want branchless
constant time rotates re
rnk closed this revision.
rnk added a comment.
Looks like this landed as r245817.
http://reviews.llvm.org/D12137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Wed Aug 26 16:57:20 2015
New Revision: 246088
URL: http://llvm.org/viewvc/llvm-project?rev=246088&view=rev
Log:
[ms-inline-asm] Add field access to MS inline asm identifier lookup
Now we can parse code like this:
struct A {
int field;
};
int f(A o) {
__asm mov eax,
rnk added a comment.
MSVC appears to ignore __stdcall on virtual destructors, and I think the
correct fix is for us to do the same.
See this test case:
$ cat t.cpp
struct A { virtual __stdcall ~A(); };
A::~A() {}
$ cl -c t.cpp
Microsoft (R) C/C++ Optimizing Compiler Version 18.00.3110
rnk added inline comments.
Comment at: lib/Headers/Intrin.h:961
@@ +960,3 @@
+static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) {
+ __builtin_ia32_lgdt(__ptr);
+}
compnerd wrote:
> mkuper wrote:
> > compnerd wrote:
> > > Why does this need a builtin?
rnk added a subscriber: rnk.
Comment at: lib/CodeGen/CodeGenModule.cpp:469-470
@@ +468,4 @@
+ llvm::LLVMContext &Ctx = getModule().getContext();
+ llvm::Function *StubFn =
+ llvm::Function::Create(FT, Fn->getLinkage(), Name, &getModule());
+ assert(StubFn->getName() == Nam
rnk added inline comments.
Comment at: lib/Sema/SemaType.cpp:2272
@@ -2271,1 +2271,3 @@
// calling convention.
+ bool is_ctor_or_dtor =
+ (Entity.getNameKind() == DeclarationName::CXXConstructorName) ||
s/is_ctor_or_dtor/IsCtorOrDtor/, it's the local vari
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/CodeGen/CodeGenModule.cpp:463
@@ +462,3 @@
+
+// if (U.getUser() == GV) continue;
+
Commented out code?
===
rnk added inline comments.
Comment at: lib/Sema/SemaType.cpp:5855-5856
@@ -5854,3 +5854,4 @@
CallingConv CurCC = FT->getCallConv();
- CallingConv FromCC =
+ CallingConv DefaultCC =
Context.getDefaultCallingConvention(IsVariadic, IsStatic);
+ CallingConv ToCC;
rnk added inline comments.
Comment at: lib/AST/Mangle.cpp:142
@@ +141,3 @@
+ // language).
+ if (MCXX || (CC == CM_Other && TI.getCXXABI() == TargetCXXABI::Microsoft))
+return mangleCXXName(D, Out);
TI.getCXXABI().isMicrosoft() is better than the == check.
LGTM, but I would expand on the comment a bit:
// The ABI says: "It is suggested that it be emitted in the same
COMDAT group
// as the associated data object." In practice, this doesn't work for
non-ELF object formats, so only do it for ELF.
On Thu, Sep 3, 2015 at 11:31 AM, Rafael Espínd
rnk added a subscriber: rnk.
rnk added a comment.
I think a better fix would be to insert a non-terminator placeholder that
doesn't confuse EmitBlock.
http://reviews.llvm.org/D12412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Author: rnk
Date: Fri Sep 4 16:39:15 2015
New Revision: 246880
URL: http://llvm.org/viewvc/llvm-project?rev=246880&view=rev
Log:
Don't use unreachable as a placeholder, it confuses EmitBlock
This fixes an issue raised in D12412, where we generated invalid IR.
Thanks to Vedant Kumar for coming u
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246880: Don't use unreachable as a placeholder, it confuses
EmitBlock (authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D12412?vs=33347&id=34080#toc
Repository:
rL LLVM
http://revi
Author: rnk
Date: Fri Sep 4 17:32:51 2015
New Revision: 246889
URL: http://llvm.org/viewvc/llvm-project?rev=246889&view=rev
Log:
Relax partial-init test case for ARM
Modified:
cfe/trunk/test/CodeGenCXX/partial-init.cpp
Modified: cfe/trunk/test/CodeGenCXX/partial-init.cpp
URL:
http://llvm.o
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
This looks fine, just make sure the indentation is right. Phab seems confused.
Repository:
rL LLVM
http://reviews.llvm.org/D12466
___
cfe-commits ma
Author: rnk
Date: Wed Oct 7 16:03:41 2015
New Revision: 249616
URL: http://llvm.org/viewvc/llvm-project?rev=249616&view=rev
Log:
[WinEH] Don't use lifetime markers for MS catch parameters
We don't have a good place to put them. Our previous spot was causing us
to optimize loads from the exceptio
Author: rnk
Date: Wed Oct 7 19:17:45 2015
New Revision: 249640
URL: http://llvm.org/viewvc/llvm-project?rev=249640&view=rev
Log:
Don't emit exceptional stackrestore cleanups around inalloca functions
The backend restores the stack pointer after recovering from an
exception. This is similar to r
Author: rnk
Date: Wed Oct 7 20:13:52 2015
New Revision: 249647
URL: http://llvm.org/viewvc/llvm-project?rev=249647&view=rev
Log:
[WinEH] Remove NewMSEH and enable its behavior by default
Testing has shown that it is at least as reliable as the old landingpad
pattern matching code.
Removed:
rnk added a comment.
Looks like this got committed. Sorry for the delay, I was travelling.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Thu Oct 8 12:29:07 2015
New Revision: 249704
URL: http://llvm.org/viewvc/llvm-project?rev=249704&view=rev
Log:
[clang-cl] Make /EHs turn on C++ EH once again
C++ exceptions are still off by default, which is similar to how C++
cleanups are off by default in MSVC.
If you use cl
rnk added a comment.
I added this conditional check in r221415, with this message:
cmake: Only export targets in the standalone build
Trying to fix bots that didn't like the fact that I exported targets
that depended on LLVM without exporting targets from LLVM.
I assume this has already
Author: rnk
Date: Thu Oct 8 16:14:56 2015
New Revision: 249748
URL: http://llvm.org/viewvc/llvm-project?rev=249748&view=rev
Log:
[WinEH] Push cleanupendpad scopes around exceptional cleanups
We were only doing this for SEH as a special case. Generalize it to all
cleanups.
Modified:
cfe/trun
Author: rnk
Date: Fri Oct 9 11:48:52 2015
New Revision: 249846
URL: http://llvm.org/viewvc/llvm-project?rev=249846&view=rev
Log:
Fix VFS GCC unittest on Windows
Modified:
cfe/trunk/unittests/Driver/ToolChainTest.cpp
Modified: cfe/trunk/unittests/Driver/ToolChainTest.cpp
URL:
http://llvm.or
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Thanks, sorry for the delay, EH was keeping me busy. =/
http://reviews.llvm.org/D13375
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
rnk added a comment.
Richard suggested that maybe we formed the wrong AST while parsing the
template. I'm not sure that's the case. We have this very explicit logic that
controls what AST nodes we form in SemaExprMember.cpp
ClassifyImplicitMemberAccess:
bool isStaticContext = SemaRef.CXXThis
rnk updated this revision to Diff 37283.
rnk added a comment.
- Rebase
http://reviews.llvm.org/D6700
Files:
lib/Sema/TreeTransform.h
test/SemaTemplate/instantiate-using-decl.cpp
Index: test/SemaTemplate/instantiate-using-decl.cpp
rnk added inline comments.
Comment at: lib/Sema/TreeTransform.h:9138
@@ +9137,3 @@
+ isa(D))
+return getSema().BuildPossibleImplicitMemberExpr(
+SS, SourceLocation(), R, /*TemplateArgs=*/nullptr,
I believe this will always fail, so one
rnk updated this revision to Diff 37302.
rnk added a comment.
- Diagnose instance members rather than pretending to build an expr
http://reviews.llvm.org/D6700
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprMember.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/using-decl-1.cpp
test/Sema
rnk updated this revision to Diff 37303.
rnk added a comment.
- Remove duplicate tests, beef them up
http://reviews.llvm.org/D6700
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExprMember.cpp
lib/Sema/TreeTransform.h
test/SemaCXX/using-decl-1.cpp
test/SemaTemplate/instantiate-using-de
rnk added a comment.
In http://reviews.llvm.org/D13549#267790, @klimek wrote:
> We're waiting for Reid to find somebody who is good at reviewing this in
> detail.
> Sorry it takes a while, so far we don't have enough trusted Windows experts
> in the community :(
Oops, I didn't know that. Zac
This revision was automatically updated to reflect the committed changes.
rnk marked an inline comment as done.
Closed by commit rL250592: Diagnose UnresolvedLookupExprs that resolve to
instance members in static… (authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D6700?vs=3730
Author: rnk
Date: Fri Oct 16 19:19:04 2015
New Revision: 250592
URL: http://llvm.org/viewvc/llvm-project?rev=250592&view=rev
Log:
Diagnose UnresolvedLookupExprs that resolve to instance members in static
methods
During the initial template parse for this code, 'member' is unresolved
and we don't
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm Sorry, took me a while to read the document and understand why you want
`float inreg`.
I think we overload LLVM inreg to mean "put this float / double in an SSE
register", but I think it's rea
rnk added a subscriber: rnk.
rnk added a comment.
I spent some time reading through the pseudo-object implementation in clang,
but I still don't understand it. We should ask John if he can review this.
My gut feeling is that we shouldn't have a global DenseMap in Sema just for
this. Should we h
Author: rnk
Date: Mon Oct 19 19:31:42 2015
New Revision: 250774
URL: http://llvm.org/viewvc/llvm-project?rev=250774&view=rev
Log:
Revert "Diagnose UnresolvedLookupExprs that resolve to instance members in
static methods"
This reverts commit r250592.
It has issues around unevaluated contexts, li
Author: rnk
Date: Tue Oct 20 13:12:08 2015
New Revision: 250839
URL: http://llvm.org/viewvc/llvm-project?rev=250839&view=rev
Log:
Look through using decls when classifying implicit member access
Clang will now accept this valid C++11 code:
struct A { int field; };
struct B : A {
using A::
Author: rnk
Date: Tue Oct 20 13:45:57 2015
New Revision: 250844
URL: http://llvm.org/viewvc/llvm-project?rev=250844&view=rev
Log:
Add back null check removed accidentally in r250554
Fixes PR25262
Added:
cfe/trunk/test/Frontend/force-include-not-found.c
Modified:
cfe/trunk/lib/Lex/HeaderS
Author: rnk
Date: Tue Oct 20 16:04:13 2015
New Revision: 250856
URL: http://llvm.org/viewvc/llvm-project?rev=250856&view=rev
Log:
Re-land r250592 without rejecting field refs in unevaluated contexts
This time, I went with the first approach from
http://reviews.llvm.org/D6700, where clang actually
Author: rnk
Date: Wed Oct 21 17:01:02 2015
New Revision: 250954
URL: http://llvm.org/viewvc/llvm-project?rev=250954&view=rev
Log:
[Driver] Alias -fvisibility=internal to -fvisibility=hidden
The ELF symbol visibilities are:
- internal: Not visibile across DSOs, cannot pass address across DSOs
- hi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm with the suggested simplification.
Comment at: lib/CodeGen/TargetInfo.cpp:857
@@ -854,3 +856,3 @@
IsWin32StructABI(Win32StructABI),
- IsSoftFloatABI(SoftFloatABI),
On Mon, Oct 26, 2015 at 11:02 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ScopeInfo.h?rev=251387&r1=251386&r2=251387&view=diff
>
> =
Author: rnk
Date: Tue Oct 27 11:24:03 2015
New Revision: 251412
URL: http://llvm.org/viewvc/llvm-project?rev=251412&view=rev
Log:
Widen this enum bitfield by one bit to prevent sign extension in MSVC
Modified:
cfe/trunk/include/clang/Sema/ScopeInfo.h
Modified: cfe/trunk/include/clang/Sema/Sc
Author: rnk
Date: Tue Oct 27 12:34:29 2015
New Revision: 251419
URL: http://llvm.org/viewvc/llvm-project?rev=251419&view=rev
Log:
[ms-inline-asm] Test case for alignment directive change in LLVM r251418
Added:
cfe/trunk/test/CodeGen/ms-inline-asm-align.c
Added: cfe/trunk/test/CodeGen/ms-inli
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, I don't feel strongly about whether -fms-compatibility matters, but I'd
prefer that it didn't.
Comment at: lib/Sema/SemaStmt.cpp:224
@@ +223,3 @@
+ // but its implementation
Author: rnk
Date: Wed Oct 28 17:29:52 2015
New Revision: 251567
URL: http://llvm.org/viewvc/llvm-project?rev=251567&view=rev
Log:
Fix the calling convention of Mingw64 long double values
GCC uses the x87DoubleExtended model for long doubles, and passes them
indirectly by address through function
Author: rnk
Date: Wed Oct 28 18:06:42 2015
New Revision: 251576
URL: http://llvm.org/viewvc/llvm-project?rev=251576&view=rev
Log:
[WinEH] Mark calls inside cleanups as noinline
This works around PR25162. The MSVC tables make it very difficult to
correctly inline a C++ destructor that contains try
rnk added a comment.
Rafael, we don't support pre GCC 4.7 mingw right? They switched to thiscall on
32bit, right? I think we can take a break for x64.
http://reviews.llvm.org/D14179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Author: rnk
Date: Mon Nov 2 11:53:55 2015
New Revision: 251810
URL: http://llvm.org/viewvc/llvm-project?rev=251810&view=rev
Log:
Sink some PTHManager includes out of Preprocessor.h
This reduces the number of .cpp files needed to be rebuilt after
touching OnDiskHashTable from 120 to 21 for me.
M
Author: rnk
Date: Mon Nov 2 14:47:31 2015
New Revision: 251828
URL: http://llvm.org/viewvc/llvm-project?rev=251828&view=rev
Log:
[PTH] Fix data length used for stat cache entries
This came up in a boost build, which apparently uses PTH. This was
broken in r187619 when we migrated it to uses llvm
rnk created this revision.
rnk added reviewers: danalbert, mclow.lists.
rnk added a subscriber: cfe-commits.
According to Clang's sources, the maximum supported storage alignment is a
property of the COFF object file format. Fixes building libc++
with Clang on Windows.
http://reviews.llvm.org/D1
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
I'm happy with this. Richard, what do you think?
Repository:
rL LLVM
http://reviews.llvm.org/D13925
___
cfe-commits maili
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Yeah, lgtm.
http://reviews.llvm.org/D14179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rnk added a comment.
Will Clang be able to compile the last few stable mingw-w64 releases with this
change? I'd like that to keep working.
http://reviews.llvm.org/D14180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D14285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
In http://reviews.llvm.org/D14180#279962, @martell wrote:
> In http://reviews.llvm.org/D14180#279651, @rnk wrote:
>
> > Will Clang be able to compile the last few stable mingw-w64 releases with
> > this change? I'd like that to keep working.
>
>
> Clang has not been able to
rnk added a comment.
I'd like clang to work out of the box with mingw-w64 releases from at least the
past year. You're mostly interested in the non-builtin parts of
-fms-extensions, like declspec and UUID, right? One way we could do this is to
enable -fms-extensions in mingw but then suppress t
rnk added a comment.
This is an interesting test case, though:
inline int foo() {
static int __attribute__((internal_linkage)) x;
return x++;
}
If foo gets inlined, those call sites will use and update 'x'. If foo is not
inlined, one definition of foo will win, and every caller will
rnk added a comment.
> ! In http://reviews.llvm.org/D14180#280193, @martell wrote:
>
> > You can then change the mingw headers to use
> > `__has_builtin(_InterlockedCompareExchange)` to provide compatibility with
> > either mode.
>
>
> Yes I could do this but this still won't work with t
Author: rnk
Date: Wed Nov 4 18:24:01 2015
New Revision: 252107
URL: http://llvm.org/viewvc/llvm-project?rev=252107&view=rev
Log:
Fix nullptr crash in -Wthread-safety-beta
Modified:
cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyCommon.h
cfe/trunk/test/SemaCXX/warn-thread-safety-an
Author: rnk
Date: Tue Nov 10 16:23:58 2015
New Revision: 252659
URL: http://llvm.org/viewvc/llvm-project?rev=252659&view=rev
Log:
[COFF] Don't try to emit weak aliases on COFF
This comes up when a derived class destructor is equivalent to a base
class destructor defined in the same TU, and we try
rnk added a comment.
In http://reviews.llvm.org/D11437#211165, @chh wrote:
> I tried to make X86_64ABIInfo::classify to return (Lo=SSE, Hi=NoClass) for
> fp128 long double type, or (Lo=SSE, Hi=SSEUp). That is not enough, although
> making fp128 Complex type to "Memory" worked.
>
> X86_64ABIInfo
rnk commandeered this revision.
rnk added a reviewer: chh.
rnk added a comment.
Comandeering so I can upload my diff.
http://reviews.llvm.org/D11437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
rnk updated this revision to Diff 31457.
rnk updated the summary for this revision.
rnk added a comment.
- Update classify and GetByteVectorType
http://reviews.llvm.org/D11437
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/x86_64-fp128.c
Index: test/CodeGen/x86_64-fp128.c
=
801 - 900 of 1562 matches
Mail list logo
