LGTM, but I would expand on the comment a bit: // The ABI says: "It is suggested that it be emitted in the same COMDAT group // as the associated data object." In practice, this doesn't work for non-ELF object formats, so only do it for ELF.
On Thu, Sep 3, 2015 at 11:31 AM, Rafael EspĂndola < rafael.espind...@gmail.com> wrote: > I fully trust Reid review on this, so OK with me. > > On 3 September 2015 at 14:04, Yaron Keren <yaron.ke...@gmail.com> wrote: > > http://llvm.org/pr23472 > > > > As suggested by Reid, OK to commit? > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits