NP, I forgot to follow up mentioning that I tweaked the test to fix the
failure in https://reviews.llvm.org/rC365557. It would be good to
eventually mangle whatever OpenCL thing is being mangled here in the MS
ABI, but that can be future work.
On Wed, Jul 10, 2019 at 2:45 AM Marco Antognini
wrote
Author: rnk
Date: Tue May 14 11:51:07 2019
New Revision: 360699
URL: http://llvm.org/viewvc/llvm-project?rev=360699&view=rev
Log:
Restore test files accidentally deleted in r354839
I think there must be a bug in git-llvm causing parent directories to be
deleted when the diff deletes files in a su
Author: rnk
Date: Tue May 14 12:02:39 2019
New Revision: 360701
URL: http://llvm.org/viewvc/llvm-project?rev=360701&view=rev
Log:
Update ASTMerge FileCheck test expectations
I belive many of these diagnostics changed from errors to warnings in
r357394. I've simply mechanically updated the tests,
Author: rnk
Date: Tue May 14 13:01:03 2019
New Revision: 360705
URL: http://llvm.org/viewvc/llvm-project?rev=360705&view=rev
Log:
Fix ASTMerge/namespace/test.cpp after r360701
Modified:
cfe/trunk/test/ASTMerge/namespace/test.cpp
Modified: cfe/trunk/test/ASTMerge/namespace/test.cpp
URL:
http
*From: *Hans Wennborg
*Date: *Wed, May 15, 2019 at 1:22 AM
> On Tue, May 14, 2019 at 6:35 PM Richard Smith
> wrote:
> > Yep, I'm not at all surprised. Perhaps we should stop claiming to
> support this extension, given that it fundamentally violates assumptions
> made by clang (that linkage doesn
*From: *Richard Smith
*Date: *Wed, May 15, 2019 at 5:43 PM
> On Wed, 15 May 2019 at 15:54, Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> We could probably re-land Richard's change (although it's quite a lot of
>> code...), but...
Author: rnk
Date: Wed May 22 14:52:12 2019
New Revision: 361438
URL: http://llvm.org/viewvc/llvm-project?rev=361438&view=rev
Log:
Fix new enum-codegen.cpp test
Modified:
cfe/trunk/test/Modules/enum-codegen.cpp
Modified: cfe/trunk/test/Modules/enum-codegen.cpp
URL:
http://llvm.org/viewvc/llv
Author: rnk
Date: Thu May 23 11:35:43 2019
New Revision: 361530
URL: http://llvm.org/viewvc/llvm-project?rev=361530&view=rev
Log:
[Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1
New -cc1 arguments, such as -faddrsig, have started appearing after the
input name. I personally find
Author: rnk
Date: Wed Dec 12 15:46:06 2018
New Revision: 348991
URL: http://llvm.org/viewvc/llvm-project?rev=348991&view=rev
Log:
Emit a proper diagnostic when attempting to forward inalloca arguments
The previous assertion was relatively easy to trigger, and likely will
be easy to trigger going
Author: rnk
Date: Wed Dec 12 17:33:20 2018
New Revision: 349001
URL: http://llvm.org/viewvc/llvm-project?rev=349001&view=rev
Log:
Remove unused Args parameter from EmitFunctionBody, NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
cfe/trunk/lib/CodeGen/CodeGenFunction.h
Modified:
On Thu, Dec 13, 2018 at 9:56 AM Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> +// RUN: cd %t/UNIQUEISH_SENTINEL
> +// RUN: %clang_cc1 -debug-info-kind=limited -triple %itanium_abi_triple \
> +// RUN: debug-info-abspath.c -emit-obj -o /tmp/t.o
>
Do you need to create thi
Author: rnk
Date: Thu Dec 13 13:18:16 2018
New Revision: 349083
URL: http://llvm.org/viewvc/llvm-project?rev=349083&view=rev
Log:
Fix debug-info-abspath.c on Windows by removing /tmp/t.o line
This object seemed unused, so I believe we can just remove this compiler
invocation without losing any te
Author: rnk
Date: Thu Dec 13 13:24:08 2018
New Revision: 349085
URL: http://llvm.org/viewvc/llvm-project?rev=349085&view=rev
Log:
Fix test after -Wstring-plus-int warning was enabled
Use array indexing instead of addition.
Modified:
cfe/trunk/test/SemaCXX/constant-expression-cxx1y.cpp
Modif
This new test doesn't pass on Windows. I think it's an LLP64-ness bug based
on the output:
Note: Google Test filter = PreferredTypeTest.Binar*
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from PreferredTypeTest
[ RUN ] Preferred
Author: rnk
Date: Thu Dec 13 13:41:07 2018
New Revision: 349086
URL: http://llvm.org/viewvc/llvm-project?rev=349086&view=rev
Log:
Attempt to fix code completion test to handle LLP64 platforms
Modified:
cfe/trunk/unittests/Sema/CodeCompleteTest.cpp
Modified: cfe/trunk/unittests/Sema/CodeCompl
r349086 should take care of it, but you may want to tweak it.
On Thu, Dec 13, 2018 at 1:30 PM Reid Kleckner wrote:
> This new test doesn't pass on Windows. I think it's an LLP64-ness bug
> based on the output:
> Note: Google Test filter = PreferredTypeTest.Binar*
> [==] Running 1 test fr
Author: rnk
Date: Fri Dec 14 15:42:59 2018
New Revision: 349212
URL: http://llvm.org/viewvc/llvm-project?rev=349212&view=rev
Log:
Mangle calling conventions into function pointer types where GCC does
Summary:
GCC 5.1 began mangling these Windows calling conventions into function
types, since they
I sent https://reviews.llvm.org/D55781 and cc'd the original reviewers so
we can decide if it's worth the cost.
On Fri, Dec 14, 2018 at 5:17 PM Richard Smith wrote:
> Should this change be disableable by -fclang-abi-compat=7 or below?
>
> On Fri, 14 Dec 2018, 15:46 Reid Kleck
Author: rnk
Date: Mon Dec 17 15:10:43 2018
New Revision: 349414
URL: http://llvm.org/viewvc/llvm-project?rev=349414&view=rev
Log:
Update Microsoft name mangling scheme for exception specifiers in the type
system
Summary:
The msvc exception specifier for noexcept function types has changed
from t
Author: rnk
Date: Mon Dec 17 15:16:43 2018
New Revision: 349415
URL: http://llvm.org/viewvc/llvm-project?rev=349415&view=rev
Log:
Fix ms-layout_version declspec test and add missing new test
Now that MSVC compatibility versions are stored as a four digit number
(1912) instead of a two digit numbe
Author: rnk
Date: Thu Dec 20 17:40:29 2018
New Revision: 349872
URL: http://llvm.org/viewvc/llvm-project?rev=349872&view=rev
Log:
[mingw] Don't mangle thiscall like fastcall etc
GCC does not mangle it when it is not explicit in the source. The
mangler as currently written cannot differentiate be
Author: rnk
Date: Wed Dec 26 09:44:40 2018
New Revision: 350068
URL: http://llvm.org/viewvc/llvm-project?rev=350068&view=rev
Log:
Ignore ConstantExpr in IgnoreParens
Summary:
This moves it up from IgnoreParenImpCasts to IgnoreParens, so that more
helpers ignore it. For most clients, this ensures
Author: rnk
Date: Wed Dec 26 12:07:52 2018
New Revision: 350071
URL: http://llvm.org/viewvc/llvm-project?rev=350071&view=rev
Log:
[MS] Mangle return adjusting thunks with the public access specifier
MSVC does this, so we should too.
Fixes PR40138
Added:
cfe/trunk/test/CodeGenCXX/mangle-ms-t
Author: rnk
Date: Wed Dec 26 13:04:08 2018
New Revision: 350072
URL: http://llvm.org/viewvc/llvm-project?rev=350072&view=rev
Log:
[clang-cl] Treat inputs as C++ with /E, like MSVC
midl invokes the compiler on .idl files with /E. Before this change, we
would treat unrecognized inputs as object fil
Author: rnk
Date: Mon Sep 9 17:50:32 2019
New Revision: 371478
URL: http://llvm.org/viewvc/llvm-project?rev=371478&view=rev
Log:
Remove REQUIRES:shell from tests that pass for me on Windows
I see in the history for some of these tests REQUIRES:shell was used as
a way to disable tests on Windows
Author: rnk
Date: Tue Sep 10 13:15:45 2019
New Revision: 371552
URL: http://llvm.org/viewvc/llvm-project?rev=371552&view=rev
Log:
Re-land Remove REQUIRES:shell from tests that pass for me on Windows
This reverts r371497 (git commit 3d7e9ab7b9f8c53aa41420c54970f0fb421004a2)
Reorder `not` with `en
Author: rnk
Date: Tue Sep 10 14:54:16 2019
New Revision: 371559
URL: http://llvm.org/viewvc/llvm-project?rev=371559&view=rev
Log:
Actually reorder not and env in crash-recovery-modules.m
Modified:
cfe/trunk/test/Index/crash-recovery-modules.m
Modified: cfe/trunk/test/Index/crash-recovery-mod
Author: rnk
Date: Tue Sep 10 18:01:06 2019
New Revision: 371581
URL: http://llvm.org/viewvc/llvm-project?rev=371581&view=rev
Log:
Emit -Wmicrosoft-enum-value warning instead of error in MS ABI
Summary:
The first NFC change is to replace a getCXXABI().isMicrosoft() check
with getTriple().isWindows
Author: rnk
Date: Wed Sep 11 11:09:10 2019
New Revision: 371642
URL: http://llvm.org/viewvc/llvm-project?rev=371642&view=rev
Log:
[MS] Consder constexpr globals to be inline, as in C++17
Summary:
Microsoft seems to do this regardless of the language mode, so we must
also do it in order to be ABI
Author: rnk
Date: Wed Sep 11 13:56:25 2019
New Revision: 371663
URL: http://llvm.org/viewvc/llvm-project?rev=371663&view=rev
Log:
Start porting ivfsoverlay tests to Windows
Part of PR43272, the changes are:
1. Use @ as the sed pattern delimiter instead of : so that the drive
letter in lit substi
Author: rnk
Date: Thu Sep 12 10:55:48 2019
New Revision: 371749
URL: http://llvm.org/viewvc/llvm-project?rev=371749&view=rev
Log:
Don't warn about selectany on implicitly inline variables
Summary:
This avoids a -Wignored-attribute warning on the code pattern Microsoft
recommends for integral cons
Thanks, that seems like the correct fix. The property that makes them fail
is the native system path style, not the default target.
On Thu, Sep 12, 2019 at 5:03 AM Jeremy Morse
wrote:
> On Thu, Sep 12, 2019 at 11:24 AM Jeremy Morse
> wrote:
> > Assuming no-one else is looking at this, I'll comm
Author: rnk
Date: Thu Sep 12 11:26:34 2019
New Revision: 371753
URL: http://llvm.org/viewvc/llvm-project?rev=371753&view=rev
Log:
[MS] Warn when shadowing template parameters under -fms-compatibility
Summary:
C++ does not allow shadowing template parameters, but previously we
allowed it under -fm
Author: rnk
Date: Tue Sep 17 13:29:10 2019
New Revision: 372178
URL: http://llvm.org/viewvc/llvm-project?rev=372178&view=rev
Log:
Ignore exception specifier mismatch when merging redeclarations
Exception specifiers are now part of the function type in C++17.
Normally, it is illegal to redeclare t
Author: rnk
Date: Wed Sep 25 15:50:50 2019
New Revision: 372926
URL: http://llvm.org/viewvc/llvm-project?rev=372926&view=rev
Log:
Simplify -fms-compatibility include lookup logic, NFC
This include search logic has an extra parameter to deal with Windows
includes with backslashes, which get normal
Author: rnk
Date: Thu Sep 26 09:56:25 2019
New Revision: 372994
URL: http://llvm.org/viewvc/llvm-project?rev=372994&view=rev
Log:
Un-XFAIL coverage_no_integrated_as.c test on Windows
You can't use -fno-integrated-as for *-msvc triples because no usable
standalone assembler exists. Perhaps we coul
Author: rnk
Date: Thu Sep 26 10:19:22 2019
New Revision: 372999
URL: http://llvm.org/viewvc/llvm-project?rev=372999&view=rev
Log:
Move normalization of `\` in #includes from -fms-compatibility to
-fms-extensions
Handling backslashes in include paths in the implementation isn't
non-conforming.
M
Author: rnk
Date: Thu Sep 26 11:13:19 2019
New Revision: 373004
URL: http://llvm.org/viewvc/llvm-project?rev=373004&view=rev
Log:
Only pass -coverage-notes-file when emitting coverage
The only functional change here is that -coverage-notes-file is not
passed to -cc1 in some situations.
This code
Author: rnk
Date: Wed Apr 18 16:21:32 2018
New Revision: 330303
URL: http://llvm.org/viewvc/llvm-project?rev=330303&view=rev
Log:
[MS] Fix unprototyped thunk emission for incomplete return types
Fixes PR37161
Modified:
cfe/trunk/lib/CodeGen/CGVTables.cpp
cfe/trunk/test/CodeGenCXX/ms-thun
Author: rnk
Date: Thu Apr 19 12:40:12 2018
New Revision: 330360
URL: http://llvm.org/viewvc/llvm-project?rev=330360&view=rev
Log:
Remove impossible _MSC_VER check
Summary:
It is immediately preceded by this check:
#if _MSC_VER < 1900
#error "MSVC versions prior to Visual Studio 2015 are not s
Author: rnk
Date: Thu Apr 19 15:12:10 2018
New Revision: 330372
URL: http://llvm.org/viewvc/llvm-project?rev=330372&view=rev
Log:
Don't do aligned allocations on MSVCRT before 19.12 (update 15.3)
Reviewers: EricWF, pcc
Subscribers: christof, cfe-commits
Differential Revision: https://reviews.ll
Author: rnk
Date: Wed Apr 25 16:38:54 2018
New Revision: 330886
URL: http://llvm.org/viewvc/llvm-project?rev=330886&view=rev
Log:
Include to get std::isdigit, fixes MSVC STL build
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/RISCV.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Arch/RISCV.c
Author: rnk
Date: Fri Apr 27 15:32:21 2018
New Revision: 331093
URL: http://llvm.org/viewvc/llvm-project?rev=331093&view=rev
Log:
Fix diag-format test to not care about what cl.exe is on path
Modified:
cfe/trunk/test/Misc/diag-format.c
Modified: cfe/trunk/test/Misc/diag-format.c
URL:
http:/
Author: rnk
Date: Fri Oct 4 11:57:01 2019
New Revision: 373771
URL: http://llvm.org/viewvc/llvm-project?rev=373771&view=rev
Log:
Add missing null pointer check in -ftime-trace code
createOutputFile diagnoses the error for the caller already, so recover
by not writing the output.
Fixes PR43555
Author: rnk
Date: Wed Oct 9 17:54:33 2019
New Revision: 374266
URL: http://llvm.org/viewvc/llvm-project?rev=374266&view=rev
Log:
Use -fdebug-compilation-dir to form absolute paths in coverage mappings
This allows users to explicitly request relative paths with
`-fdebug-compilation-dir .`.
Fixes
Author: rnk
Date: Wed Oct 9 18:10:01 2019
New Revision: 374268
URL: http://llvm.org/viewvc/llvm-project?rev=374268&view=rev
Log:
Revert [mangle] Fix mangling where an extra mangle context is required.
This reverts r374200 (git commit fd18e94697c987d5f24e25aa4e27ada3cce4)
Causes crashes just
Author: rnk
Date: Wed Oct 9 18:14:22 2019
New Revision: 374269
URL: http://llvm.org/viewvc/llvm-project?rev=374269&view=rev
Log:
Re-land [mangle] Fix mangling where an extra mangle context is required.
This reverts r374268 (git commit c34385d07c7d59447bf836b740f032235391d121)
I think I reverted
Author: rnk
Date: Thu Oct 10 11:01:20 2019
New Revision: 374403
URL: http://llvm.org/viewvc/llvm-project?rev=374403&view=rev
Log:
Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage
mappings"
This reverts r374324 (git commit 62808631acceaa8b78f8ab9b407eb6b943ff5f77)
I change
Author: rnk
Date: Thu Oct 10 11:36:41 2019
New Revision: 374416
URL: http://llvm.org/viewvc/llvm-project?rev=374416&view=rev
Log:
Update clang tests for new LLVM IR backslash printing in r374415
Modified:
cfe/trunk/test/CodeGen/debug-prefix-map.c
cfe/trunk/test/CodeGen/string-literal.c
Author: rnk
Date: Thu Oct 10 11:42:06 2019
New Revision: 374418
URL: http://llvm.org/viewvc/llvm-project?rev=374418&view=rev
Log:
Fix one more clang test which didn't have \5C in it
Modified:
cfe/trunk/test/CoverageMapping/abspath.cpp
Modified: cfe/trunk/test/CoverageMapping/abspath.cpp
URL:
Author: rnk
Date: Thu Oct 10 14:04:25 2019
New Revision: 374449
URL: http://llvm.org/viewvc/llvm-project?rev=374449&view=rev
Log:
Add -fgnuc-version= to control __GNUC__ and other GCC macros
I noticed that compiling on Windows with -fno-ms-compatibility had the
side effect of defining __GNUC__, a
ould have a
> separate -fno-gnu-extensions for that part instead?
>
> On Thu, Oct 10, 2019 at 5:02 PM Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Thu Oct 10 14:04:25 2019
>> New Revision: 374449
>>
>
Author: rnk
Date: Tue Oct 15 11:39:41 2019
New Revision: 374936
URL: http://llvm.org/viewvc/llvm-project?rev=374936&view=rev
Log:
Fix as-w-option.c on Windows where no assembler exists
Modified:
cfe/trunk/test/Driver/as-w-option.c
Modified: cfe/trunk/test/Driver/as-w-option.c
URL:
http://ll
Author: rnk
Date: Fri Oct 18 17:48:11 2019
New Revision: 375316
URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev
Log:
Move endian constant from Host.h to SwapByteOrder.h, prune include
Works on this dependency chain:
ArrayRef.h ->
Hashing.h -> --CUT--
Host.h ->
StringMap.h / S
Author: rnk
Date: Fri Oct 18 17:48:11 2019
New Revision: 375316
URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev
Log:
Move endian constant from Host.h to SwapByteOrder.h, prune include
Works on this dependency chain:
ArrayRef.h ->
Hashing.h -> --CUT--
Host.h ->
StringMap.h / S
Author: Reid Kleckner
Date: 2019-10-28T14:40:17-07:00
New Revision: 7cd595df96d5929488063d8ff5cc3b5d800386da
URL:
https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da
DIFF:
https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da.diff
Author: Reid Kleckner
Date: 2019-10-28T17:12:43-07:00
New Revision: 9ecd3225d134541bdfde18a6648edb8b9e048035
URL:
https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035
DIFF:
https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035.diff
Author: Reid Kleckner
Date: 2020-04-03T13:27:52-07:00
New Revision: ba1ffd25c1f7a3564136b13e49fb1a7185561613
URL:
https://github.com/llvm/llvm-project/commit/ba1ffd25c1f7a3564136b13e49fb1a7185561613
DIFF:
https://github.com/llvm/llvm-project/commit/ba1ffd25c1f7a3564136b13e49fb1a7185561613.diff
Author: Reid Kleckner
Date: 2020-04-03T16:46:07-07:00
New Revision: e62dc1f6252c1dcdcc2a64e8e3b07a32412e9d89
URL:
https://github.com/llvm/llvm-project/commit/e62dc1f6252c1dcdcc2a64e8e3b07a32412e9d89
DIFF:
https://github.com/llvm/llvm-project/commit/e62dc1f6252c1dcdcc2a64e8e3b07a32412e9d89.diff
Author: Reid Kleckner
Date: 2020-04-06T10:09:01-07:00
New Revision: b36c19bc4f2110a8e33f8d93751ef28b6dcd0292
URL:
https://github.com/llvm/llvm-project/commit/b36c19bc4f2110a8e33f8d93751ef28b6dcd0292
DIFF:
https://github.com/llvm/llvm-project/commit/b36c19bc4f2110a8e33f8d93751ef28b6dcd0292.diff
Author: Reid Kleckner
Date: 2020-04-06T10:42:17-07:00
New Revision: 76221c734eac81387f772aca9299f10a7c921bda
URL:
https://github.com/llvm/llvm-project/commit/76221c734eac81387f772aca9299f10a7c921bda
DIFF:
https://github.com/llvm/llvm-project/commit/76221c734eac81387f772aca9299f10a7c921bda.diff
Author: Reid Kleckner
Date: 2020-04-09T14:19:36-07:00
New Revision: 55efb68c19b4911f780ec4d074f8ff2f8529883f
URL:
https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f
DIFF:
https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f.diff
Author: Reid Kleckner
Date: 2020-04-13T13:14:06-07:00
New Revision: eac56724fd955af0f8521557cacc57a83f371649
URL:
https://github.com/llvm/llvm-project/commit/eac56724fd955af0f8521557cacc57a83f371649
DIFF:
https://github.com/llvm/llvm-project/commit/eac56724fd955af0f8521557cacc57a83f371649.diff
Author: Reid Kleckner
Date: 2020-04-14T18:34:52-07:00
New Revision: 8da5b9083691b557f50f72ab099598bb291aec5f
URL:
https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f
DIFF:
https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f.diff
Author: Reid Kleckner
Date: 2020-06-05T12:52:38-07:00
New Revision: 672ed5386024ba5cee53e19d637b7920a4889837
URL:
https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837
DIFF:
https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837.diff
Author: Reid Kleckner
Date: 2020-04-23T16:22:01-07:00
New Revision: bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581
URL:
https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581
DIFF:
https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581.diff
Author: Reid Kleckner
Date: 2020-04-28T11:36:21-07:00
New Revision: b8000c0ce84541c5b5535419234fb65ce77d6756
URL:
https://github.com/llvm/llvm-project/commit/b8000c0ce84541c5b5535419234fb65ce77d6756
DIFF:
https://github.com/llvm/llvm-project/commit/b8000c0ce84541c5b5535419234fb65ce77d6756.diff
On Mon, Sep 12, 2016 at 5:20 PM, David Blaikie wrote:
> On Mon, Sep 12, 2016 at 5:09 PM Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Mon Sep 12 19:01:23 2016
>> New Revision: 281278
>>
>> URL: http:/
rnk added a comment.
I'm pretty sure GCCRegNames is used to parse constraint lists, not to parse
inline asm text. Your test should try using kN as a constraint.
Repository:
rL LLVM
https://reviews.llvm.org/D25011
___
cfe-commits mailing list
cfe
rnk added inline comments.
> x86_inlineasm_curly_bracket_escape.c:1
> +// RUN: %clang_cc1 %s -target-cpu skylake-avx512 -O0 -S -o - -Wall -Werror
> | FileCheck %s
> +// This test checks validity of inline assembly using curly brackets syntax
Please check the LLVM IR, not the assembly
Reposito
rnk added inline comments.
> ParseExprCXX.cpp:1135
> +// "[...]", even if there is no "(...)" before the lambda body.
> +MaybeParseGNUAttributes(Attr, &DeclEndLoc);
> + }
Does nvcc support __declspec style attributes? Maybe we should check for those
too?
> ParseExprCXX.cpp:1280
>
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> SemaExpr.cpp:8084
> +// type. Note that this is already done by non-compound assignments in
> +// CheckAssignmentConstraints. If it's a scalar type, only biscast for
> +// <1 x T
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> jlebar wrote in ParseExprCXX.cpp:1135
> nvcc doesn't seem to support __declspec attributes.
>
> I have no strong opinion on whether or not we should add them ourselves,
> though I guess I
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
> CGDebugInfo.cpp:47
>
> +namespace {
> +template
LLVM prefers `static` to anonymous namespaces
http://llvm.org/docs/CodingStandards.html#anonymous-namespaces
> CGDebugInfo.cpp:48
> +namespace {
> +template
> +uint64_t GetTypeAlignIfRequired(Type Ty, const ASTCon
rnk added a comment.
It feels like the right thing is to disable EH in device side compilation, but
obviously that won't work because it would reject try/throw in host code. I
think instead of doing that, we should make sure that CUDA diagnoses try /
catch / throw in device functions, and then
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> SemaOverload.cpp:1131
>
>if (getLangOpts().CUDA && ConsiderCudaAttrs) {
> CUDAFunctionTarget NewTarget = IdentifyCUDATarget(New),
I feel like we should
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
> Sema.h:9210
> + /// Emit no diagnostics.
> + NOP,
> + /// Emit the diagnostic immediately (i.e., behave like Sema::Diag()).
LLVM has a different enum naming convention:
http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enume
rnk added a comment.
In https://reviews.llvm.org/D25166#559168, @jlebar wrote:
> > Also, take a look at CodeGenFunction::getInvokeDestImpl(). I think you
> > should add some checks in there to return nullptr if we're doing a
> > device-side CUDA compilation. That's a much more direct way to ens
Author: rnk
Date: Mon Oct 3 13:34:23 2016
New Revision: 283131
URL: http://llvm.org/viewvc/llvm-project?rev=283131&view=rev
Log:
Factor out a diagnostic kind enum for use in two %select expressions
NFC
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> CGDebugInfo.cpp:54-56
> + auto TI = Ctx.getTypeInfo(Ty);
> + return TI.AlignIsRequired ? Ctx.toCharUnitsFromBits(TI.Align).getQuantity()
> +
rnk added inline comments.
> jlebar wrote in Sema.h:9258
> These diagnostics live until the end of codegen, and so are destroyed after
> the ASTContext.
>
> I am becoming increasingly displeased with emitting these errors during
> codegen. In particular, it makes it annoying to write tests.
rnk added inline comments.
> Targets.cpp:2319
> + { #ID, TYPE, ATTRS, HEADER, LANGS, FEATURE },
> +#include "clang/Basic/BuiltinsX86.def"
> +
I'd rather not duplicate this readonly data. I had this clever idea that we'd
do something like:
const Builtin::Info BuiltinInfo[] = {
...
#inclu
rnk added inline comments.
> agutowski wrote in BuiltinsX86_32.def:1
> Will we ever need that file? It seems to nicely complement the 64-bit one,
> but if it's going to be empty forever maybe it's better to remove it.
I guess we should remove it. Take a look at isX86_64Builtin in
Sema/SemaChec
rnk created this revision.
rnk added a reviewer: rsmith.
rnk added a subscriber: cfe-commits.
Other compilers accept invalid code here that we reject, and we need a
better error message to try to convince users that the code is really
incorrect. Consider:
class Foo {
typedef MyIterHelper it
Author: rnk
Date: Tue Oct 4 10:57:49 2016
New Revision: 283227
URL: http://llvm.org/viewvc/llvm-project?rev=283227&view=rev
Log:
[MS] Move hex long long sign compat hack to -fms-compatibility
Treating large 0x*LL literals as signed instead of unsigned is not a
conforming language extension, so m
rnk added inline comments.
> AttrDocs.td:1263
> +On x86 targets, this attribute changes the calling convention to
> +__regcall convention. This convention aimes to pass as many arguments
> +as possible in registers. It also tries to utilize registers for the
"aims"
> TargetInfo.cpp:3306
> + //
rnk added inline comments.
> erichkeane wrote in TargetInfo.cpp:3742-3743
> That was my intent, this should allow return values to be in registers as
> well if I'm reading the spec correctly. The idea is that register use is
> 'greedy'.
But, if the return value is returned directly, it doesn'
rnk added inline comments.
> erichkeane wrote in ItaniumMangle.cpp:1236-1237
> Right, good catch. I looked at Mangle.cpp which does something very similar,
> and assumes that FunctionType is a valid cast here, so I've switched this
> here too, please let me know if that is a wrong assumption.
rnk added a comment.
Let's avoid the duplicate enum, otherwise looks good
> TargetBuiltins.h:100
> + /// \brief X86-64 builtins
> + namespace X86_64 {
> + enum {
I think this would be better with just one enum to reduce compilation time:
/// \brief X86 builtins
namespace X86 {
Author: rnk
Date: Tue Oct 4 13:10:23 2016
New Revision: 283235
URL: http://llvm.org/viewvc/llvm-project?rev=283235&view=rev
Log:
Test what happens when tag lookup and redeclaration lookup disagree
Clang has a diagnostic for the what happens when an elaborated type
implicitly creates a tag declar
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
> CodeGenModule.cpp:512-513
>}
> + // Clear the deferred diags so they don't outlive the ASTContext from
> whence
> + // they're allocated.
> + DeferredDiags.clear();
The ASTContext outlives CodeGenModule, but the diagnostic allocator in the
ASTContext does no
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> nothrow.cu:16
> +// DEVICE: define void @_Z3foov() [[DEVICE_ATTR:#[0-9]+]]
> +__device__ void foo() { f(); }
> +
I would check for `call void @_Z1fv` here, and ma
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
Nice, probably ready to land with one revision.
> majnemer wrote in CGBuiltin.cpp:2640-2647
> This should be in an anonymous namespace. Also, consider using an `enum
> class` instead of an `enum` nested inside a namespace.
Let's also use a more specific name than MSVC, ma
201 - 300 of 1562 matches
Mail list logo
