[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

[Reid Kleckner via cfe-commits]

rnk added inline comments.


> Targets.cpp:2319
> +  { #ID, TYPE, ATTRS, HEADER, LANGS, FEATURE },
> +#include "clang/Basic/BuiltinsX86.def"
> +

I'd rather not duplicate this readonly data. I had this clever idea that we'd 
do something like:

  const Builtin::Info BuiltinInfo[] = {
  ...
  #include "BuiltinsX86_32.def"
  #include "BuiltinsX86.def"
  #include "BuiltinsX86_64.def"
  };

And then our makeArrayRef call would take the appropriate parts.

https://reviews.llvm.org/D24598



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits