[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

teemperor added a comment. I reverted in adf0b8cc70325f027d202139e3ff984c41896b57 to get the bots green again . Feel free to ping if you need someone to test the patch on macOS. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

teemperor accepted this revision. teemperor added a comment. Sorry, just got around to check this out. With the new workaround this seems to work on macOS (the initial patch did produce the same error). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4c3ed42ba56: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347) (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Somehow this ended up failing on Fuchsia with a plain "Exit code 1", but not sure what's the fault. I'll revert until I figured that out. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

This revision was automatically updated to reflect the committed changes. Closed by commit rGada2e8ea6739: Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)" (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D84013?vs=287017&id=287318#toc Reposi

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

teemperor added a comment. In D84013#2233242 , @davezarzycki wrote: > I have an auto-bisecting cron job that has identified the "reland" as > breaking the test suite on Fedora 32 (x86). Is there a quick fix or can we > revert the reland? > > FAIL: Cla

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

This revision was automatically updated to reflect the committed changes. Closed by commit rG105151ca5669: Reland "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)" (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D84013?vs=287318&id=287358#toc Reposi

[PATCH] D86308: [CMake][compiler-rt][libunwind] Compile assembly files as ASM not C, unify workarounds

teemperor added a comment. In D86308#2229936 , @tambre wrote: > In D86308#2229901 , @teemperor wrote: > >> Sorry, just got around to check this out. With the new workaround this seems >> to work on macOS (the initi

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

teemperor added a comment. Just to also jump in on the thread: This broke the modules builds. I fixed that in https://reviews.llvm.org/rGe0e7eb2e2648aee83caf2ecfe2972ce2f653d306 so please recommit that patch or merge it into this revision before relanding. Thanks! Repository: rG LLVM Github

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0478720157f6: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. In D80878#2258942 , @riccibruno wrote: > And what if deserialization is forced? That's a good point. That should indeed continue to work with the

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. There are several LLDB tests failing with this change. The TestImportBaseClassWhenClassHasDerivedMember.py is probably the only relevant one. The others are probably failing for the same

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

teemperor added a comment. I believe rsmith is in GMT-8, so I assume this won't get a fix soon and I went ahead and reverted in 22ccdb787024e954318e35fcf904fd4fa36f5679 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D83038: [clang] Add an option for hiding line numbers in diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG659f4bd87efc: [clang] Add an option for hiding line numbers in diagnostics (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mono

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Shouldn't this compare the actual width expressions? In other words, this patch wouldn't pass the test below: TEST_F(StructuralEquivalenceTemplateTest, DependentFieldDeclDiff

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88665/new/ https://reviews.llvm.org/D88665 __

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

teemperor added a comment. > I am not sure how much do you guys value these diags in LLDB I think we don't even display them most of the time (IIUC they go to the diagnostic engine which is not always hooked up for the ASTs in LLDB as only a few actually come from Clang). Repository: rG LLV

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

teemperor added a comment. On macOS, LLDB's tests pass `-isysroot /path/to/SDK` to Clang but expect that Clang always prefers the the libc++ headers that are in the Clang build directory. So if we change this behaviour then we should have a way to keep the old behaviour around. Repository:

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

teemperor added a comment. I think we could at least have a unittest that just calls these functions with an invalid SourceLocation. `unittests/Basic/SourceManagerTest.cpp` already takes care of creating a valid SourceManager object, so the unit test would just be a single call to each method.

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

teemperor added a comment. From the LLDB side we can just change our test setup to explicitly add an include the libc++ in our build tree (and have -nostdinc to avoid the libc++ in the SDK). So it wouldn't be a problem for us. I can make a review for that once this gets accepted. Repository:

[PATCH] D89319: [ASTImporter] Fix crash caused by unimported type of FromatAttr

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/ASTMerge/attr/Inputs/FormatAttr.cpp:2 +int foo(const char * fmt, ...) +__attribute__ ((__format__ (__scanf__, 1, 2)));

[PATCH] D92016: [ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c926e6d245b: [ASTImporter] Make the Import() return value consistent with the map of… (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. You think it's worth it to have a test for a user-specified deduction guide? I think this is missing an 'explicit' deduction guide test, so maybe we could test both things in a

[PATCH] D92119: [ASTImporter] Import the default argument of TemplateTemplateParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG39a5dd164ca8: [ASTImporter] Import the default argument of TemplateTemplateParmDecl (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think the test could be made a bit stricter (see inline comment), but otherwise this LGTM. Thanks! Comment at: clang/unittests/AST/ASTImporterTest.cpp:5900 + ASSERT

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6c856bb5ae: [ASTImporter] Import the default argument of TemplateTypeParmDecl (authored by teemperor). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed pr

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/ASTImporter.cpp:5161 - // FIXME: Import default argument and constraint expression. + // FIXME: Import constraint expression. martong wrote: > I wonder whet

[PATCH] D92106: [ASTImporter] Import the default argument of NonTypeTemplateParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG89c1a7a67d69: [ASTImporter] Import the default argument of NonTypeTemplateParmDecl (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. @gamesh411 I recreated the setup you listed (thanks for that btw) but for me this works just fine. I assume the crash happens in a class template from one of the external libraries. It probably works for me because I don't have the same library version as you have, bu

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. In D92103#2428139 , @martong wrote: > Hey Raphael, thanks for looking into the CTU crash! > > I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC > 7. I think the discrepancy stems from GCC's libstdc++ an

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

teemperor added a comment. Having the comparison code would be nice. The custom types in the associated types aren't compared by the generic code, so an overload like this in the `StmtComparer` class should be enough: bool IsStmtEquivalent(const GenericSelectionExpr *E1, const GenericSelecti

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

teemperor added a comment. In D92209#2437416 , @martong wrote: > Ping. > @teemperor please take a look if you have some time. This is a really > important patch which may influence some future directions regarding the > ASTImporter. Apologies, last week

[PATCH] D89748: SourceManager: Use the same fake SLocEntry whenever it fails to load

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89748/new/ https://reviews.llvm.org/D89748 ___ cfe-commits mailing list cfe-comm

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

teemperor added a subscriber: v.g.vassilev. teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Maybe arc didn't correctly apply the patch, but this causes a few LLDB tests to fail on my machine: lldb-api :: commands/expressi

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

teemperor added a comment. >> The tests are just loading a Clang module and then trying to import some >> Decls into another ASTContext, so I don't think the error here is specific >> to LLDB. We just don't have any ASTImporter tests that exercise modules. > > I'll add one. I'm actually not eve

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor updated this revision to Diff 301577. teemperor added a comment. - Respect forced deserialisation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 Files: clang/include/clang/AST/TextNodeDumper.h clang/lib/AST/ASTDumper.cpp clang/

[PATCH] D99946: [DebugInfo] Fix DWARF expressions for __block vars that are not on the heap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG888ce70af288: [DebugInfo] Fix DWARF expressions for __block vars that are not on the heap (authored by teemperor). Herald added a subscriber: cfe-com

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. In D96033#2766502 , @phosek wrote: > In D96033#2766372 , @v.g.vassilev > wrote: > >> In D96033#2766332 , @phosek wrote: >> >>> We've started seein

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. In D96033#2768940 , @phosek wrote: > In D96033#2767884 , @teemperor wrote: > >> In D96033#2766502 , @phosek wrote: >> >>> In D96033#2766372

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. (Tabbed on the Submit button instead of finishing that quote block...) So I assume the stage2- targets are just invoking some ninja invocations in sequence? Anyway, what I think it would be helpful to see what link jobs were in progress. But I guess even with 32 jobs

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

teemperor added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:243 + // If b is a get() expression, then we can return a note + if (auto Report = bugReportOnGet(Node, BRC, RHS)) { +return Report;

[PATCH] D102903: [clang] Fix Wnested-anon-types in ABIArgInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebd25fde5e04: [clang] Fix Wnested-anon-types in ABIArgInfo (authored by teemperor). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. A more general comment: You have to `std::move` your `llvm::Error` variables when the result is `llvm::Expected` (otherwise this won't compile). Comment at: clang/include/clang/Interpreter/Transaction.h:1 +//===--- Transaction.h - Incremental Compila

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a reviewer: sgraenitz. teemperor added a comment. Another round of comments. Also a general note that applies to a bunch of places, if you specify the function names in comments when calling a function, you have to add a trailing `=` so that clang-tidy can actually check this fo

[PATCH] D96049: [Timer] On macOS count number of executed instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e3b9aba609f: [Timer] On macOS count number of executed instructions (authored by ahoppen, committed by teemperor). Repository: rG LLVM Github Mon

[PATCH] D96427: Support multi-configuration generators correctly in several config files

teemperor added a comment. In D96427#2555251 , @JDevlieghere wrote: > LGTM. I'm surprised the `dsymutil` one slipped through the cracks, we have a > bot that should (?) be testing this configuration: > http://green.lab.llvm.org/green/view/LLDB/job/lldb-

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

teemperor added a comment. LGTM. Regarding the LLDB example: Given that the LLDB API is in theory not bound to the semantics a specific language, I think one can argue that `IsAnonymousType` could also return true for unnamed classes. The use case that triggered this whole discussion was someo

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:184 + SourceLocation NewLoc = SM.getLocForStartOfFile(SM.getMainFileID()) + .getLocWithOffset(InputCount + 2); + The `+ 2` here is probably not

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

This revision was automatically updated to reflect the committed changes. Closed by commit rGa54f160b3a98: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk (authored by haampie, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

teemperor added a comment. In D103750#2812613 , @RedDocMD wrote: > How do I set the C++ standard while running a test? If I understand your language correctly, then see my inline comment. Comment at: clang/test/Analysis/smart-ptr-text

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

teemperor added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:164 + const auto *MethodDecl = dyn_cast_or_null(Call.getDecl()); + if (!MethodDecl || !MethodDecl->getParent()) +return {}; `getParent()` will assert when th

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor added a comment. This is technically in the "Waiting on Review" queue, that's why I also added another reviewer :). The original revision got accepted and then I reverted and updated the patch/test to honor the `Deserialize` value (which was broken in the first version). I guess the f

[PATCH] D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.

teemperor updated this revision to Diff 364385. teemperor added a comment. - Make setter propagate 'deserialize' to the node dumper (thanks Volodymyr!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80878/new/ https://reviews.llvm.org/D80878 Files: clang/include/clang/AST/ASTNodeTrave

[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

teemperor created this revision. teemperor added reviewers: dblaikie, rjmccall, rsmith, v.g.vassilev. teemperor added a project: clang. Herald added a subscriber: dexonsmith. teemperor requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Herald added a project: LL

[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

teemperor added a comment. I'm mostly putting this up to get some early feedback if anyone sees a problem with using opaque types here (e.g. it breaks some optimizations, etc.). If it does, it would still be nice if we could at least make this happen on some opt-in bases as it would be very ben

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

teemperor added a comment. @v.g.vassilev For LLDB you need to change the `TypeSystemClang::SetExternalSource` function to this (it just moves the `setHasExternalLexicalStorage` one line up. You can just add that change and the compilation fix to this commit. void TypeSystemClang::SetExternal

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think this looks good, thanks for fixing this! I believe there should be a few more tests for all the corner cases we can run into here (those tests can all be just Python AP

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I guess Phabricator just sent this back to review automatically when you updated the diff? Just mark this as 'needs review' again when this is ready for review. I'll send this

[PATCH] D112796: [ASTImporter] Remove redundant IsStructuralMatch overloads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96808c69a13c: [ASTImporter] Remove redundant IsStructuralMatch overloads (authored by teemperor). Herald added a subscriber: cfe-commits. Repository

[PATCH] D112804: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for EnumConstantDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01b3bd3992b4: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for… (authored by teemperor). Herald added a subscriber: cfe-commits.

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

teemperor added a comment. We can (and do) run LIT tests under valgrind, so if you have a test that triggers this valgrind error then that seems like the way to go. I don't think the test has to deterministically fail outside valgrind to be a valid test. Repository: rG LLVM Github Monorepo

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

teemperor added a comment. If I understand this correctly, then the inode caching logic in FileManager isn't just breaking PCMs but all file operations: TEST_F(FileManagerTest, InodeReuse) { { std::ofstream myfile; myfile.open("a.cpp"); myfile << "content\n"; } ll

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

teemperor added a comment. Sorry for the delay. Yes, I meant the `--vg` flag which is I think the only valid way to test this from your description. That it can't be deterministically tested without this (or in configurations that don't run valgrind) is fine IMHO. Repository: rG LLVM Github

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

teemperor added a comment. It seems we already hit this issue before and decided to add a workaround: https://reviews.llvm.org/D86823 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97850/new/ https://reviews.llvm.org/D97850 ___

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor added a comment. Can you link what code is actually requiring this change? I just went over the patch series and it's not obvious to me what exactly this is used for. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75561/new/ https://reviews.llvm.org/D75561 _

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor added a comment. I am fine with this if we *really* need it for D75488 . So far the only direct place where we do need the module to be non-const was some redundant assignment for Name (I added a comment in D75488 ), bu

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I seems quite a lot of APIs in Clang are already requiring non-const Modules so I think this is fine to make D75488 possible. Let's ship it CHANGES SI

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

teemperor added a comment. My only problem is the reimplementation of the default visit methods with (from what I can tell) the same behavior as the default. If you delete all of these then that would also fix Shafik's point that all the custom dispatch code is technically untested in the unit

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

teemperor added a comment. Could we have the `clang/test/Driver/flang/flang.F90` and `clang/test/Driver/flang/flang.f90` files in different directories please? As macOS's FS is case-insensitive, those two files have the same path from macOS perspective which is causing a whole bunch of issues (

[PATCH] D69566: [ASTImporter] Add support for BuiltinTemplateDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7bde65dcff: [ASTImporter] Add support for BuiltinTemplateDecl (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69566/new/ https://re

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

teemperor added a comment. 6c0a160c2d33e54aecf1538bf7c85d8da92051be renamed the file (thanks Jeremy). In D63607#1726978 , @peterwaller-arm wrote: > In D63607#1726895

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. FYI, this doesn't compile, see: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/10890 (and probably all other build bots that are starting to break). FAILED: tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ https://reviews.llvm.org/D70440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor created this revision. teemperor added a reviewer: martong. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When Sema encounters a ObjCMethodDecl definition it declares the implicit para

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232541. teemperor added a comment. - Put code in raw string (Thanks Gabor!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: clang/unittests/AST/Language.cpp:44 + case Lang_OpenCL: +llvm_unreachable("-std=objc++"); } martong wrote: > I think, we should keep the "Not implemented yet!" messag

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232547. teemperor added a comment. - Reverted unintentional change to unreachable error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG164e0fc5c7f7: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. With DWARF5 it is no longer possible to distinguish normal methods and methods with `__attribute__((objc_direct))` by just look

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor created this revision. teemperor added reviewers: aprantl, dblaikie, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently have some very basic LLVM-style RTTI support in the ExternalASTSource class hierarchy based on the `SemaSource` bool( to dis

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor added a comment. I didn't add specific ID's to all of the subclasses in clang/clang-tools-extra because we never actually check for these specific classes anywhere from what I can see. But if anyone thinks that would be useful to have then I can update the patch. Repository: rC Cl

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor added a comment. See D71398 for the LLDB removal of our own RTTI workaround. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71397/new/ https://reviews.llvm.org/D71397 ___ c

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. I wonder if we have a way to fix this from with LLDB. Having Clang code that is only tested in LLDB is always a bit weird. Otherwise the idea itself LGTM, thanks for working on this (and reducing the test case to that!) Comment at: clang/lib/AST/AS

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor updated this revision to Diff 233756. teemperor added a comment. - Removed Objective-C metadata from LLVM test. - Removed quoted attributes. - Update DebugInfoFlags.def to be compatible with D68117 assuming probinson are applied there. CHANGES SINCE

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor marked an inline comment as done. teemperor added a comment. In D71397#1782537 , @lhames wrote: > Side note: This https://reviews.llvm.org/D39111 seems related. The patch has > languished as I have been busy with other work, but if it would be u

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor updated this revision to Diff 233968. teemperor added a comment. - Addressed Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71397/new/ https://reviews.llvm.org/D71397 Files: clang/include/clang/AST/ExternalASTSource.h clang/include/clang/Sema/ExternalSem

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4558497ff6: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor updated this revision to Diff 233998. teemperor added a comment. - Further reduced test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71201/new/ https://reviews.llvm.org/D71201 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenObjC/debug-info-direct-method.

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

This revision was automatically updated to reflect the committed changes. Closed by commit rGccfab8e4596e: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. Another bug report for this: https://bugs.llvm.org/show_bug.cgi?id=44331 Please close when landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71378/new/ https://reviews.llvm.org/D71378 ___ cfe-commits ma

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

teemperor added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:196 +@implementation Foo (Cat) +// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"( +- (int)directMethodInCategory { MadCoder wrote: > aprantl wrote: > > M

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

teemperor added a comment. This patch broke the Clang build with enabled modules (which is used by the LLDB bot, but every other bot is also dead: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

teemperor added a comment. I ran the patch on macOS and Linux through check-lldb and there were no regressions, so this is LGTM. The libc++ failures should go away when you add `libcxx;libcxxabi` to LLVM_ENABLE_PROJECTS (the tests are using libc++). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor created this revision. teemperor added reviewers: martong, a_sidorin. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When importing the main FileID the ASTImporter currently gives it no

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1874201 , @martong wrote: > Looks good to me! Thanks! > Adding @balazske as another reviewer though. He worked on something related > to this, where we also experienced an assert in `isBeforeInTranslationUnit`. IIRC

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. @balazske Do you see any problems with this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74542/new/ https://reviews.llvm.org/D74542 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

teemperor added a comment. This broke the LLVM_ENABLE_MODULES build because it introduces a cyclic dependency between LLVM_IR and LLVM_intrinsic_gen: FAILED: tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o /Applications/Xcode.app/Contents/De

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1878732 , @balazske wrote: > In D74542#1878576 , @teemperor wrote: > > > @balazske Do you see any problems with this patch? > > > I have no opinion against the change. Probably s

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37734f643fb: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69933: [ASTImporter] Limit imports of structs

teemperor added a comment. I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should f

<    1   2   3   4   >